[GitHub] drill issue #729: Drill 1328: Support table statistics for Parquet

2017-06-23 Thread gparai
Github user gparai commented on the issue:

https://github.com/apache/drill/pull/729
  
Thanks for the reminder @paul-rogers. Based on the last discussion with the 
reviewers and Drill community members, we would hold off on the PR because it 
also causes regressions in queries in TPC-H, TPC-DS benchmarks. We identified 
that we need histograms and other enhancements to fully address the 
regressions. I will post a new PR once these issues are addressed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill issue #729: Drill 1328: Support table statistics for Parquet

2017-06-22 Thread paul-rogers
Github user paul-rogers commented on the issue:

https://github.com/apache/drill/pull/729
  
This PR has been sitting idle for a while. Does it still make sense to 
continue with the reviews to get this into master? If so, @gparai, can you 
rebase onto the latest master and update with any fixes made since the last 
update?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill issue #729: Drill 1328: Support table statistics for Parquet

2017-03-01 Thread gparai
Github user gparai commented on the issue:

https://github.com/apache/drill/pull/729
  
I have addressed the second set of comments. @amansinha100 @paul-rogers 
could you please review and/or approve? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill issue #729: Drill 1328: Support table statistics for Parquet

2017-02-21 Thread gparai
Github user gparai commented on the issue:

https://github.com/apache/drill/pull/729
  
I have addressed the comments from the earlier pull request. Please take a 
look


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---