[GitHub] drill issue #876: DRILL-5659: Fix error code checking in reading from socket

2017-07-14 Thread parthchandra
Github user parthchandra commented on the issue:

https://github.com/apache/drill/pull/876
  
Still haven't been able to confirm the SASL encryption case, but there is 
no reason why this fix would affect that. Merging it in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill issue #876: DRILL-5659: Fix error code checking in reading from socket

2017-07-13 Thread laurentgo
Github user laurentgo commented on the issue:

https://github.com/apache/drill/pull/876
  
I tested non-SASL case and confirm it fixes the issue. Unfortunately I 
don't have any handy SASL-ready setup for now.

Thanks @parthchandra 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill issue #876: DRILL-5659: Fix error code checking in reading from socket

2017-07-13 Thread superbstreak
Github user superbstreak commented on the issue:

https://github.com/apache/drill/pull/876
  
Thanks, @parthchandra!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill issue #876: DRILL-5659: Fix error code checking in reading from socket

2017-07-13 Thread sohami
Github user sohami commented on the issue:

https://github.com/apache/drill/pull/876
  
+1 LGTM
Thanks a lot for catching and fixing this!. I will test it with SASL 
encryption case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---