[GitHub] drill issue #890: Escape version number period separator, this captures vers...

2017-08-07 Thread paul-rogers
Github user paul-rogers commented on the issue:

https://github.com/apache/drill/pull/890
  
Please put the JIRA ticket number in the title so that the system will 
automagically send comments & close notices to the JIRA ticket. Example:

DRILL-5698: Escape version number period separator, this captures version 
numbers


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill issue #890: Escape version number period separator, this captures vers...

2017-08-02 Thread josefloreschura
Github user josefloreschura commented on the issue:

https://github.com/apache/drill/pull/890
  
I have the same issue and got here when I was about to create an issue.
It's can also be reproduced this way:

- Current behaviour

bash-3.2# echo "version 1.8.0_66" | grep "version" | egrep -e "1.4|1.5|1.6"
(no output)

bash-3.2# echo "version 1.8.0_144" | grep "version" | egrep -e "1.4|1.5|1.6"
version 1.8.0_144

- With the proposal fix

bash-3.2# echo "version 1.8.0_144" | grep "version" | egrep -e 
"1\.4|1\.5|1\.6"
(no output)

bash-3.2# echo "version 1.6" | grep "version" | egrep -e "1\.4|1\.5|1\.6"
version 1.6

Workaround (for now): install java version not containing 14, 15 16 in the 
version (revision)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill issue #890: Escape version number period separator, this captures vers...

2017-08-02 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/890
  
+1, LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill issue #890: Escape version number period separator, this captures vers...

2017-08-01 Thread darrenbrien
Github user darrenbrien commented on the issue:

https://github.com/apache/drill/pull/890
  
Jira https://issues.apache.org/jira/browse/DRILL-5698 created


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill issue #890: Escape version number period separator, this captures vers...

2017-07-31 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/890
  
@darrenbrien thanks for the pull request but could please also create Jira 
for the fix [1], [2].

[1] 
https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=185=DRILL
[2] https://drill.apache.org/docs/apache-drill-contribution-guidelines/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---