[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/913 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build
Github user ilooner commented on the issue: https://github.com/apache/drill/pull/913 @parthchandra I think the PR still needs a +1 from a committer. If Vlad's review is sufficient, could you give this a +1? Thanks, Tim --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build
Github user ilooner-mapr commented on the issue: https://github.com/apache/drill/pull/913 @vrozov I've fixed the source.skip switch to be maven.source.skip as you pointed out. For now I also made the **script** tag a noop since as you said the mvn package command is redundant at this point. The **script** tag can't be completely removed because then travis runs its own default command for **script** which causes failures. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/913 @parthchandra LGTM. There are questions that I have related to how travis-ci build is configured, but they are for pre-existing settings and can be addressed in a follow up PR if necessary. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/913 @ilooner-mapr I tested it on my branch and it works with the default jdk and without *sudo*. Add `MAVEN_OPTS="-Xms1G -Xmx1G"` before `mvn`. Can you remove leading dash from the commit message as part of rebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build
Github user ilooner-mapr commented on the issue: https://github.com/apache/drill/pull/913 @vrozov I got it working with Trusty and explicitly configuring openjdk7. One thing to note is that Trusty was running out of memory doing the build with the default 4gb container size. So I had to add the **sudo: required** option in order to increase the vm size https://docs.travis-ci.com/user/reference/overview/ . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build
Github user ilooner-mapr commented on the issue: https://github.com/apache/drill/pull/913 @vrozov It looks like the default jdk for Trusty on travis is jdk8. I'll check to see if explicitly telling travis to use jdk7 with Trusty is also a possible fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build
Github user vrozov commented on the issue: https://github.com/apache/drill/pull/913 @ilooner-mapr Do you know why it fails on the Trusty (new default)? Going back to using Precise is OK for a while, but my guess that it will eventually become obsolete. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build
Github user ilooner-mapr commented on the issue: https://github.com/apache/drill/pull/913 @vrozov Spoke with Parth. Could you take a look at this PR? There are other issues with the travis build. For example it doesn't even run the unit tests right now. But this is a first step to fix what is currently in the travis build from failing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill issue #913: - DRILL-5729 Fix Travis Build
Github user ilooner-mapr commented on the issue: https://github.com/apache/drill/pull/913 @parthchandra --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
