[GitHub] drill issue #950: DRILL-5431: SSL Support
Github user paul-rogers commented on the issue: https://github.com/apache/drill/pull/950 Go for it. I won't do any more commits until you give the all-clear. ---
[GitHub] drill issue #950: DRILL-5431: SSL Support
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/950 Squashed and rebased on master again. ---
[GitHub] drill issue #950: DRILL-5431: SSL Support
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/950 @laurentgo are you good with this? I'll open a new JIRA for the enhancements to the C++ client. ---
[GitHub] drill issue #950: DRILL-5431: SSL Support
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/950 @arina-ielchiieva The `TestSSLConfig.testMissingKeystorePassword` test will fail if the exception is not thrown. The test is checking that the exception is in fact being thrown. Anyway, I added back the assertTrue check as well. It doesn't hurt to have it there. Re the failing `TestUserBitSSL.testClientConfigHostnameVerification`. The test generates a self signed certificate with the local machine host name ``` String fqdn = InetAddress.getLocalHost().getHostName(); SelfSignedCertificate certificate = new SelfSignedCertificate(fqdn); ``` It then connects to the Drillbit which, one assumes, should have the same hostname so we can test that the certificate's hostname is being validated. I really don't know why this would fail unless you have your test machine hostname not set or set incorrectly. It should work for all cases where the hostname is the default localhost. It does appear that this test might cause angst down the road and it might be best to disable it for the general case. ---
[GitHub] drill issue #950: DRILL-5431: SSL Support
Github user parthchandra commented on the issue: https://github.com/apache/drill/pull/950 Squashed the review changes and rebased on master. ---
[GitHub] drill issue #950: DRILL-5431: SSL Support
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/950 @parthchandra could you please resolve the conflicts? ---