[GitHub] drill pull request #634: DRILL-4974: NPE in FindPartitionConditions.analyzeC...

2016-10-30 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/634


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill pull request #634: DRILL-4974: NPE in FindPartitionConditions.analyzeC...

2016-10-27 Thread bitblender
GitHub user bitblender opened a pull request:

https://github.com/apache/drill/pull/634

DRILL-4974: NPE in FindPartitionConditions.analyzeCall() for 'holistic' 
expressions

Changes: Added a missing null check in 
FindPartitionConditions.analyzeCall(), to ensure that opStack.peek() value is 
dereferenced only after a null-check. Without this check, if the expression is 
holistic, opStack can be null, so using the value of opStack.peek() without a 
check can cause an NPE.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bitblender/drill DRILL-4974

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/634.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #634


commit a519a0987280abeb00e33a8088d2f7d6c9809eed
Author: karthik 
Date:   2016-10-20T20:43:17Z

DRILL-4974: Add missing null check in FindPartitionConditions.analyzeCall()




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---