[GitHub] drill pull request #675: DRILL-5094: Comparator should guarantee transitive ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/675


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #675: DRILL-5094: Comparator should guarantee transitive ...

[laurentgo]

Github user laurentgo commented on a diff in the pull request:

https://github.com/apache/drill/pull/675#discussion_r90688989
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/schedule/AssignmentCreator.java
 ---
@@ -50,7 +50,8 @@
   private static Comparator> comparator = new 
Comparator>() {
 @Override
 public int compare(Entry o1, 
Entry o2) {
-  return (int) (o1.getValue() - o2.getValue());
+  long ret = o1.getValue() - o2.getValue();
--- End diff --

Alternatively: 
`
return o1.getValue().compareTo(o2.getValue());
`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #675: DRILL-5094: Comparator should guarantee transitive ...

[chunhui-shi]

GitHub user chunhui-shi opened a pull request:

https://github.com/apache/drill/pull/675

DRILL-5094: Comparator should guarantee transitive attribute.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/chunhui-shi/drill DRILL-5094

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/675.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #675


commit 90e874a3e38cdfdac9067d55e6829c048bcb459b
Author: chunhui-shi 
Date:   2016-12-02T01:55:12Z

DRILL-5094: Comparator should guarantee transitive attribute.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---