[GitHub] drill pull request #683: DRILL-5114: Rationalize use of Logback logging in u...

[paul-rogers]

Github user paul-rogers closed the pull request at:

https://github.com/apache/drill/pull/683


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #683: DRILL-5114: Rationalize use of Logback logging in u...

[chunhui-shi]

Github user chunhui-shi commented on a diff in the pull request:

https://github.com/apache/drill/pull/683#discussion_r92451306
  
--- Diff: logical/src/test/resources/logback-test.xml ---
@@ -0,0 +1,42 @@
+

[GitHub] drill pull request #683: DRILL-5114: Rationalize use of Logback logging in u...

[chunhui-shi]

Github user chunhui-shi commented on a diff in the pull request:

https://github.com/apache/drill/pull/683#discussion_r92451193
  
--- Diff: exec/memory/base/src/test/resources/logback-test.xml ---
@@ -0,0 +1,42 @@
+
--- End diff --

Why could not the test here use existing logback-test.xml?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #683: DRILL-5114: Rationalize use of Logback logging in u...

[paul-rogers]

GitHub user paul-rogers opened a pull request:

https://github.com/apache/drill/pull/683

DRILL-5114: Rationalize use of Logback logging in unit tests

Cleans up the Drill test Logback config files to reduce unnecessary
logging in tests and avoid Logback complaints about missing or
duplicate log config files.

Does not affect production logging.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/paul-rogers/drill DRILL-5114

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/683.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #683


commit bbd5ceb4f1c61bfa844701d18220cbd019e1b700
Author: Paul Rogers 
Date:   2016-12-07T18:33:48Z

DRILL-5114: Rationalize use of Logback logging in unit tests

Cleans up the Drill test Logback config files to reduce unnecessary
logging in tests and avoid Logback complaints about missing or
duplicate log config files.

Does not affect production logging.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---