[GitHub] drill pull request #876: DRILL-5659: Fix error code checking in reading from...

2017-07-17 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/876


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill pull request #876: DRILL-5659: Fix error code checking in reading from...

2017-07-13 Thread parthchandra
GitHub user parthchandra opened a pull request:

https://github.com/apache/drill/pull/876

DRILL-5659: Fix error code checking in reading from socket

Check if errorcode is set before checking if the error code is EINTR. Also, 
check for error first thing after making the read_some or write_some calls.
This fixes the case when we read (or write) only a part of the data in a 
call to read from or write to the socket.
Tested for the issue on Mac/Centos. Not tested on Windows. Not tested for 
the case with SASL encryption.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/parthchandra/drill DRILL-5659

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/876.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #876


commit 0a29ced81dc935b926e734ea169eb884a2cbe40f
Author: Parth Chandra 
Date:   2017-07-12T21:39:17Z

DRILL-5659: Fix error code checking in reading from socket




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---