[GitHub] drill pull request #891: DRILL-5699: Drill Web UI Page Source Has Links To E...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/891


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #891: DRILL-5699: Drill Web UI Page Source Has Links To E...

[arina-ielchiieva]

Github user arina-ielchiieva commented on a diff in the pull request:

https://github.com/apache/drill/pull/891#discussion_r131677320
  
--- Diff: exec/java-exec/src/main/resources/rest/generic.ftl ---
@@ -27,7 +27,9 @@
 
   
 
-  
+  
--- End diff --

Oh, if this valid, please don't change. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #891: DRILL-5699: Drill Web UI Page Source Has Links To E...

[sindhurirayavaram]

Github user sindhurirayavaram commented on a diff in the pull request:

https://github.com/apache/drill/pull/891#discussion_r131671757
  
--- Diff: exec/java-exec/src/main/resources/rest/generic.ftl ---
@@ -27,7 +27,9 @@
 
   
 
-  
+  
--- End diff --

According to this 
[reference](https://stackoverflow.com/questions/550038/is-it-valid-to-replace-http-with-in-a-script-src-http),
 it shouldn't be a problem. I will change it though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #891: DRILL-5699: Drill Web UI Page Source Has Links To E...

[arina-ielchiieva]

Github user arina-ielchiieva commented on a diff in the pull request:

https://github.com/apache/drill/pull/891#discussion_r131650994
  
--- Diff: exec/java-exec/src/main/resources/rest/generic.ftl ---
@@ -27,7 +27,9 @@
 
   
 
-  
+  
--- End diff --

`https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #891: DRILL-5699: Drill Web UI Page Source Has Links To E...

[sindhurirayavaram]

GitHub user sindhurirayavaram opened a pull request:

https://github.com/apache/drill/pull/891

DRILL-5699: Drill Web UI Page Source Has Links To External Sites

When there is no internet, Drill Web UI fails to load the external CDNs and 
will not load the result page. This change, uses the maven download plugin to 
download the javascript and css files during build time. First this tries to 
load the CDNs from the internet. If a failure occurs, it uses the local 
downloaded Javascript and css files. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sindhurirayavaram/drill DRILL-5699

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/891.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #891


commit 61b874e2e17e44666cea9c7626767651ce7e4c70
Author: Sindhuri Rayavaram 
Date:   2017-07-31T18:45:53Z

DRILL-5699: Drill Web UI Page Source Has Links To External Sites




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---