[GitHub] drill pull request #894: DRILL-5701: drill.connections.rpc.

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/894


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #894: DRILL-5701: drill.connections.rpc.

[sohami]

Github user sohami commented on a diff in the pull request:

https://github.com/apache/drill/pull/894#discussion_r134616629
  
--- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/security/TestUserBitKerberos.java
 ---
@@ -137,6 +142,41 @@ public Void run() throws Exception {
 test("SELECT * FROM cp.`region.json` LIMIT 5");
   }
 
+  @Test
+  public void testUnecryptedConnectionCounter() throws Exception {
+final Properties connectionProps = new Properties();
+connectionProps.setProperty(DrillProperties.SERVICE_PRINCIPAL, 
krbHelper.SERVER_PRINCIPAL);
+connectionProps.setProperty(DrillProperties.KERBEROS_FROM_SUBJECT, 
"true");
+final Subject clientSubject = 
JaasKrbUtil.loginUsingKeytab(krbHelper.CLIENT_PRINCIPAL,
+krbHelper.clientKeytab.getAbsoluteFile());
+
+Subject.doAs(clientSubject, new PrivilegedExceptionAction() {
+  @Override
+  public Void run() throws Exception {
+updateClient(connectionProps);
+return null;
+  }
+});
+
+// Run few queries using the new client
+testBuilder()
+.sqlQuery("SELECT session_user FROM (SELECT * FROM sys.drillbits 
LIMIT 1)")
+.unOrdered()
+.baselineColumns("session_user")
+.baselineValues(krbHelper.CLIENT_SHORT_NAME)
+.go();
+
+// Check encrypted counters value
--- End diff --

Updated the test description for explaining the logic behind different 
count values. Also rebase PR on latest apache master. This test will change 
based on the [PR for DRILL-5721](https://github.com/apache/drill/pull/919) 
since for local fragment's on Foreman node status update will happen locally 
and hence there won't be any Control Connection created from a Drillbit to 
itself. I will update the test based on which commit makes in first.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #894: DRILL-5701: drill.connections.rpc.

[bitblender]

Github user bitblender commented on a diff in the pull request:

https://github.com/apache/drill/pull/894#discussion_r134553446
  
--- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/security/TestUserBitKerberos.java
 ---
@@ -137,6 +142,41 @@ public Void run() throws Exception {
 test("SELECT * FROM cp.`region.json` LIMIT 5");
   }
 
+  @Test
+  public void testUnecryptedConnectionCounter() throws Exception {
+final Properties connectionProps = new Properties();
+connectionProps.setProperty(DrillProperties.SERVICE_PRINCIPAL, 
krbHelper.SERVER_PRINCIPAL);
+connectionProps.setProperty(DrillProperties.KERBEROS_FROM_SUBJECT, 
"true");
+final Subject clientSubject = 
JaasKrbUtil.loginUsingKeytab(krbHelper.CLIENT_PRINCIPAL,
+krbHelper.clientKeytab.getAbsoluteFile());
+
+Subject.doAs(clientSubject, new PrivilegedExceptionAction() {
+  @Override
+  public Void run() throws Exception {
+updateClient(connectionProps);
+return null;
+  }
+});
+
+// Run few queries using the new client
+testBuilder()
+.sqlQuery("SELECT session_user FROM (SELECT * FROM sys.drillbits 
LIMIT 1)")
+.unOrdered()
+.baselineColumns("session_user")
+.baselineValues(krbHelper.CLIENT_SHORT_NAME)
+.go();
+
+// Check encrypted counters value
--- End diff --

Please explain the logic behind the different count values in the 
assertion. Same for other tests as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #894: DRILL-5701: drill.connections.rpc.

[sohami]

GitHub user sohami opened a pull request:

https://github.com/apache/drill/pull/894

DRILL-5701: drill.connections.rpc.. metric not behaving correctly

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sohami/drill DRILL-5701

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/894.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #894


commit e4d84d1f555a8abb383c72bf947c6787ecea055d
Author: Sorabh Hamirwasia 
Date:   2017-08-02T21:25:21Z

DRILL-5701: 
drill.connections.rpc.. metric not 
behaving correctly




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---