[GitHub] drill pull request #913: - DRILL-5729 Fix Travis Build

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/913


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #913: - DRILL-5729 Fix Travis Build

[ilooner-mapr]

Github user ilooner-mapr commented on a diff in the pull request:

https://github.com/apache/drill/pull/913#discussion_r135312783
  
--- Diff: .travis.yml ---
@@ -13,8 +13,9 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-sudo: false
 before_install: git fetch --unshallow
 language: java
-install: mvn install --batch-mode -DskipTests=true 
-Dmaven.javadoc.skip=true -Dsource.skip=true > mvn_install.log || (cat 
mvn_install.log && false)
-script: mvn package -DskipTests=true
+jdk:
+  - openjdk7
--- End diff --

Hmm good to know.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #913: - DRILL-5729 Fix Travis Build

[vrozov]

Github user vrozov commented on a diff in the pull request:

https://github.com/apache/drill/pull/913#discussion_r135291374
  
--- Diff: .travis.yml ---
@@ -13,8 +13,9 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-sudo: false
 before_install: git fetch --unshallow
 language: java
-install: mvn install --batch-mode -DskipTests=true 
-Dmaven.javadoc.skip=true -Dsource.skip=true > mvn_install.log || (cat 
mvn_install.log && false)
-script: mvn package -DskipTests=true
+jdk:
+  - openjdk7
--- End diff --

@ilooner-mapr Switch to jdk7 is not required, it works with jdk8 as well, 
but enforcing jdk7 helps with validating that the project is java 1.7 
compliant, so I am OK with the change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #913: - DRILL-5729 Fix Travis Build

[vrozov]

Github user vrozov commented on a diff in the pull request:

https://github.com/apache/drill/pull/913#discussion_r135148431
  
--- Diff: .travis.yml ---
@@ -13,8 +13,10 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-sudo: false
+sudo: required
 before_install: git fetch --unshallow
 language: java
+jdk:
+  - openjdk7
 install: mvn install --batch-mode -DskipTests=true 
-Dmaven.javadoc.skip=true -Dsource.skip=true > mvn_install.log || (cat 
mvn_install.log && false)
 script: mvn package -DskipTests=true
--- End diff --

`install` includes `package` goal and I don't think that javadoc or source 
plugin are enabled in the default profile, so `script` just repeats the 
`install`. Also, if the goal is to skip source jar generation, the proper 
property is maven.source.skip, I believe. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #913: - DRILL-5729 Fix Travis Build

[vrozov]

Github user vrozov commented on a diff in the pull request:

https://github.com/apache/drill/pull/913#discussion_r135143313
  
--- Diff: .travis.yml ---
@@ -13,8 +13,10 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-sudo: false
+sudo: required
 before_install: git fetch --unshallow
 language: java
+jdk:
+  - openjdk7
 install: mvn install --batch-mode -DskipTests=true 
-Dmaven.javadoc.skip=true -Dsource.skip=true > mvn_install.log || (cat 
mvn_install.log && false)
--- End diff --

@ilooner-mapr can you remove redirection to mvn_install.log as part of the 
same PR. It is not necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request #913: - DRILL-5729 Fix Travis Build

[ilooner-mapr]

GitHub user ilooner-mapr opened a pull request:

https://github.com/apache/drill/pull/913

 - DRILL-5729 Fix Travis Build



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ilooner-mapr/drill DRILL-5729

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/913.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #913


commit b52188f8091a3b22021cb1efaa42f7ebb1b2792d
Author: Timothy Farkas 
Date:   2017-08-17T23:37:24Z

 - DRILL-5729 explicitly made the travis container ubuntu precise to fix 
build errors caused by ubuntu trusty.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---