[GitHub] drill pull request #936: DRILL-5772: Enable UTF-8 support in query string by...
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/936 ---
[GitHub] drill pull request #936: DRILL-5772: Enable UTF-8 support in query string by...
Github user arina-ielchiieva commented on a diff in the pull request: https://github.com/apache/drill/pull/936#discussion_r147552950 --- Diff: exec/java-exec/src/test/resources/saffron.properties --- @@ -0,0 +1,23 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to you under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# This properties file is used by Apache Calcite to define allowed charset in string literals, +# which is by default ISO-8859-1. +# Current configuration allows parsing UTF-8 by default, i.e. queries that contain utf-8 string literal. +# To take affect this file should be present in classpath. + +saffron.default.charset=UTF-16LE +saffron.default.nationalcharset=UTF-16LE +saffron.default.collation.name=UTF-16LE$en_US --- End diff -- We need separate test properties file to be included into classpath during tests execution. Tests run in exec module, while production properties reside in distribution module. ---
[GitHub] drill pull request #936: DRILL-5772: Enable UTF-8 support in query string by...
Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/936#discussion_r147515235 --- Diff: exec/java-exec/src/test/resources/saffron.properties --- @@ -0,0 +1,23 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to you under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# This properties file is used by Apache Calcite to define allowed charset in string literals, +# which is by default ISO-8859-1. +# Current configuration allows parsing UTF-8 by default, i.e. queries that contain utf-8 string literal. +# To take affect this file should be present in classpath. + +saffron.default.charset=UTF-16LE +saffron.default.nationalcharset=UTF-16LE +saffron.default.collation.name=UTF-16LE$en_US --- End diff -- Do we need a separate test properties file if it is identical with the main one? ---
