[GitHub] sohami commented on a change in pull request #1611: DRILL-6971: Display query state in query result page
sohami commented on a change in pull request #1611: DRILL-6971: Display query state in query result page URL: https://github.com/apache/drill/pull/1611#discussion_r248102321 ## File path: exec/java-exec/src/main/resources/rest/query/result.ftl ## @@ -33,11 +33,21 @@ - Query Profile: ${model.getQueryId()} + Query Profile: ${model.getQueryId()} <#switch model.getQueryState()> +<#case "COMPLETED"> + + <#break> +<#case "CANCELED"> + + <#break> Review comment: LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sohami commented on a change in pull request #1611: DRILL-6971: Display query state in query result page
sohami commented on a change in pull request #1611: DRILL-6971: Display query state in query result page URL: https://github.com/apache/drill/pull/1611#discussion_r248102188 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/AbstractDisposableUserClientConnection.java ## @@ -73,6 +75,7 @@ public void sendResult(RpcOutcomeListener listener, QueryResult result) { // Release the wait latch if the query is terminated. final QueryState state = result.getQueryState(); +queryState = state.toString(); Review comment: Not required as type of variable is reflecting that it's a string. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sohami commented on a change in pull request #1611: DRILL-6971: Display query state in query result page
sohami commented on a change in pull request #1611: DRILL-6971: Display query state in query result page URL: https://github.com/apache/drill/pull/1611#discussion_r248102275 ## File path: exec/java-exec/src/main/resources/rest/query/result.ftl ## @@ -34,6 +34,9 @@ Query Profile: ${model.getQueryId()} + + + Query State: ${model.getQueryState()} Review comment: Thanks for sharing the change for this. Added commit in this PR This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services