[GitHub] [drill] jnturton commented on pull request #2495: DRILL-8168: Do not duplicate attempts to impersonate a user in the REST API
jnturton commented on pull request #2495: URL: https://github.com/apache/drill/pull/2495#issuecomment-1068003565 @cgivre I updated the docs to describe the `userName` property supported by /query.json (even though this PR did not introduce it, just fixes a bug relating to it). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [drill] cgivre merged pull request #2494: DRILL-8167: Add JSON Config Options to Format Config
cgivre merged pull request #2494: URL: https://github.com/apache/drill/pull/2494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [drill] jnturton opened a new pull request #2495: DRILL-8168: Do not duplicate attempts to impersonate a user in the REST API
jnturton opened a new pull request #2495: URL: https://github.com/apache/drill/pull/2495 # [DRILL-8168](https://issues.apache.org/jira/browse/DRILL-8168): Do not duplicate attempts to impersonate a user in the REST API ## Description When authentication is enabled, the Drill UserSession is persistent and it is only appropriate to modify it for impersonation once. This adds a check for whether the UserSession needs modifying and avoids any uneeded attempt to do so, thereby fixing the broken scenario Request 1: UserSession user alice modified to impersonated user bob Request 2: UserSession user bob fails to be modified to bob because bob is not authorised to impersonate bob. ## Documentation N/A ## Testing New test for this scenario? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org