[GitHub] [drill] luocooong commented on pull request #2596: DRILL-8259: Supports advanced HBase persistence storage options

2022-07-26 Thread GitBox 


luocooong commented on PR #2596:
URL: https://github.com/apache/drill/pull/2596#issuecomment-1195301013

   @cgivre @Z0ltrix I added two new options. If `namespace` is used, the 
`namespace:table` semantics are applied. And we can also use the `table` 
configuration only. The `family` is also an optional.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [drill] jnturton commented on a diff in pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

2022-07-26 Thread GitBox 


jnturton commented on code in PR #2610:
URL: https://github.com/apache/drill/pull/2610#discussion_r930036634


##
pom.xml:
##
@@ -3965,6 +3977,46 @@
   
 
   
+  

Review Comment:
   My audit of jars that were not present in 1.20.1-hadoop2
   
    Comes from Google Sheets plugin
   Only in /opt/apache-drill/jars/3rdparty: opencensus-api-0.31.1.jar
   Only in /opt/apache-drill/jars/3rdparty: 
opencensus-contrib-http-util-0.31.1.jar
   Only in /opt/apache-drill/jars/3rdparty: grpc-context-1.27.2.jar
   Only in /opt/apache-drill/jars/3rdparty: google-api-client-1.35.2.jar
   Only in /opt/apache-drill/jars/3rdparty: 
google-api-client-jackson2-1.35.2.jar
   Only in /opt/apache-drill/jars/3rdparty: 
google-api-services-sheets-v4-rev20220606-1.32.1.jar
   Only in /opt/apache-drill/jars/3rdparty: 
google-auth-library-credentials-1.8.0.jar
   Only in /opt/apache-drill/jars/3rdparty: 
google-auth-library-oauth2-http-1.8.0.jar
   Only in /opt/apache-drill/jars/3rdparty: google-http-client-1.42.0.jar
   Only in /opt/apache-drill/jars/3rdparty: 
google-http-client-apache-v2-1.42.0.jar
   Only in /opt/apache-drill/jars/3rdparty: google-http-client-gson-1.42.0.jar
   Only in /opt/apache-drill/jars/3rdparty: google-oauth-client-1.34.1.jar
   Only in /opt/apache-drill/jars/3rdparty: google-oauth-client-java6-1.34.1.jar
   Only in /opt/apache-drill/jars/3rdparty: google-oauth-client-jetty-1.34.1.jar
   
    Comes from Swagger
   Only in /opt/apache-drill/jars/3rdparty: narcissus-1.0.1.jar
   Only in /opt/apache-drill/jars/3rdparty: jvm-driver-4.0.0.jar
   Only in /opt/apache-drill/jars/3rdparty: classgraph-4.8.117.jar
   Only in /opt/apache-drill/jars/3rdparty: swagger-annotations-2.1.12.jar
   Only in /opt/apache-drill/jars/3rdparty: swagger-core-2.1.12.jar
   Only in /opt/apache-drill/jars/3rdparty: swagger-integration-2.1.12.jar
   Only in /opt/apache-drill/jars/3rdparty: swagger-jaxrs2-2.1.12.jar
   Only in /opt/apache-drill/jars/3rdparty: 
swagger-jaxrs2-servlet-initializer-v2-2.1.12.jar
   Only in /opt/apache-drill/jars/3rdparty: swagger-models-2.1.12.jar
   
    Looks like nimbus-jose-jwt was downgraded in Hadoop 2, causing this 
downgrade
   Only in /opt/apache-drill/jars/3rdparty: accessors-smart-1.2.jar
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [drill] vvysotskyi commented on pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

2022-07-26 Thread GitBox 


vvysotskyi commented on PR #2610:
URL: https://github.com/apache/drill/pull/2610#issuecomment-1195743563

   @jnturton, looks like this PR causes extra warnings:
   ```
   2022-07-26T14:35:28.5702064Z [WARNING] 
   2022-07-26T14:35:28.5703626Z [WARNING] Some problems were encountered while 
building the effective model for 
org.apache.drill.tools:tools-parent:pom:2.0.0-SNAPSHOT
   2022-07-26T14:35:28.5706084Z [WARNING] 
'profiles.profile[default-hadoop].dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)'
 must be unique: org.apache.hadoop:hadoop-common:jar -> duplicate declaration 
of version ${hadoop.version} @ org.apache.drill:drill-root:2.0.0-SNAPSHOT, 
/home/runner/work/drill/drill/pom.xml, line 2246, column 23
   2022-07-26T14:35:28.5707420Z [WARNING] 
   2022-07-26T14:35:28.5708538Z [WARNING] Some problems were encountered while 
building the effective model for org.apache.drill:drill-root:pom:2.0.0-SNAPSHOT
   2022-07-26T14:35:28.5709650Z [WARNING] 
'profiles.profile[default-hadoop].dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)'
 must be unique: org.apache.hadoop:hadoop-common:jar -> duplicate declaration 
of version ${hadoop.version} @ line 2246, column 23
   2022-07-26T14:35:28.5710552Z [WARNING] 
   2022-07-26T14:35:28.5711039Z [WARNING] It is highly recommended to fix these 
problems because they threaten the stability of your build.
   2022-07-26T14:35:28.5711458Z [WARNING] 
   2022-07-26T14:35:28.5711917Z [WARNING] For this reason, future Maven 
versions might no longer support building such malformed projects.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [drill] ankane opened a new issue, #2614: Missing 1.20.1 Release

2022-07-26 Thread GitBox 


ankane opened a new issue, #2614:
URL: https://github.com/apache/drill/issues/2614

   **Describe the bug**
   
   Hi, it looks like Drill 1.20.1 was released on May 16 according to [this 
post](https://drill.apache.org/blog/2022/05/16/drill-1.20.1-released/) and the 
[release 
notes](https://drill.apache.org/docs/apache-drill-1-20-1-release-notes/), and 
Homebrew picked up a release on that date 
(https://github.com/Homebrew/homebrew-core/pull/101694).
   
   However:
   
   - the [download page](https://drill.apache.org/download/) points to 1.20.0
   - it's not available on 
[mirrors](https://www.apache.org/dyn/closer.lua?path=drill/drill-1.20.1/apache-drill-1.20.1.tar.gz)
   - it's not available in [the archive](https://archive.apache.org/dist/drill/)
   - it's not listed under "Releases" on GitHub (but is tagged)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [drill] jnturton commented on issue #2614: Missing 1.20.1 Release

2022-07-26 Thread GitBox 


jnturton commented on issue #2614:
URL: https://github.com/apache/drill/issues/2614#issuecomment-1196284912

   Thank you for opening this. You're right that we're currently missing our 
1.20.1 build due to some technical reasons but the good news is that we're just 
about to put up a 1.20.2 build. If you'd like to play with the first release 
candidate (which won't be promoted to a release, but only due to some issues 
relating to legacy Hadoop 2 support) then have a look here.
   
   https://dist.apache.org/repos/dist/dev/drill/1.20.2-rc0/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [drill] jnturton closed issue #2614: Missing 1.20.1 Release

2022-07-26 Thread GitBox 


jnturton closed issue #2614: Missing 1.20.1 Release
URL: https://github.com/apache/drill/issues/2614


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [drill] jnturton commented on pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

2022-07-26 Thread GitBox 


jnturton commented on PR #2610:
URL: https://github.com/apache/drill/pull/2610#issuecomment-1195642829

   > @luocooong See https://stackoverflow.com/a/61267496/497381 ` 
java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer;` is not available in JDK 
1.8. It is available since Java 11. In 1.8 the return type is 
`Ljava/nio/Buffer;`. I am not sure why `Github CI / Main Build (8)` passes. 
Maybe it does not cover this code path ?!
   
   @martin-g thanks for looking into it, we've progressed to a successful build 
now. I was dragging in bad dependencies and somehow, specifically for aarch64, 
that seems to have caused a jar compiled with a >8 JDK, probably Netty, to have 
been pulled in to the Travis JDK 8 environment. That's my suspicion, anyway.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [drill] martin-g commented on pull request #2610: DRILL-8268: Fix Hadoop 2 and Netty lib exclusions, REST mem limiter disabled by default

2022-07-26 Thread GitBox 


martin-g commented on PR #2610:
URL: https://github.com/apache/drill/pull/2610#issuecomment-1195684710

   Good job, James!
   
   On Tue, Jul 26, 2022, 18:37 James Turton ***@***.***> wrote:
   
   > @luocooong  See
   > https://stackoverflow.com/a/61267496/497381
   > java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer; is not available in
   > JDK 1.8. It is available since Java 11. In 1.8 the return type is
   > Ljava/nio/Buffer;. I am not sure why Github CI / Main Build (8) passes.
   > Maybe it does not cover this code path ?!
   >
   > @martin-g  thanks for looking into it, we've
   > progressed to a successful build now. I was dragging in bad dependencies
   > and somehow, specifically for aarch64, that seems to have caused a jar
   > compiled with a >8 JDK, probably Netty, to have been pulled in to the
   > Travis JDK 8 environment. That's my suspicion, anyway.
   >
   > —
   > Reply to this email directly, view it on GitHub
   > , or
   > unsubscribe
   > 

   > .
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org