[GitHub] anyway-whatever commented on issue #50: 2.5.4-SNAPSHOT dubbo admin error

[GitBox]

anyway-whatever commented on issue #50: 2.5.4-SNAPSHOT dubbo admin error
URL: https://github.com/apache/incubator-dubbo/issues/50#issuecomment-380312284
 
 
   INFO interceptor.AuthorizationValve -  
   [DUBBO] AuthorizationValve of uri: /, dubbo version: 2.5.3, current host: 
192.168.189.1
   为什么我搜索这个错误会来到这里？搞了一天，身份拒绝原来是浏览器兼容的问题，谷歌浏览器不行，其他的就可以。。。
   为什么？？？


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mercyblitz commented on issue #101: Better use the newest dubbo 2.6.x version and only depend on necessary modules.

[GitBox]

mercyblitz commented on issue #101: Better use the newest dubbo 2.6.x version 
and only depend on necessary modules.
URL: 
https://github.com/apache/incubator-dubbo-spring-boot-project/issues/101#issuecomment-380309004
 
 
   Ok , NP


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] chickenlj commented on issue #1534: Spring Framework / Spring Boot supports

[GitBox]

chickenlj commented on issue #1534: Spring Framework / Spring Boot supports
URL: https://github.com/apache/incubator-dubbo/pull/1534#issuecomment-380305266
 
 
   Please don't merge this PR to 2.5.x，@mercyblitz  will create a new one with 
master as the target branch.
   2.5.x is a maintain branch now, only fix urgent bugs, i think we should 
focus on 2.6.x branch for enhancements or features.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] neesonqk commented on issue #93: Is it incompatible with Spring Boot 2.0？

[GitBox]

neesonqk commented on issue #93: Is it incompatible with Spring Boot 2.0？
URL: 
https://github.com/apache/incubator-dubbo-spring-boot-project/issues/93#issuecomment-380304762
 
 
   
[provider_and_consumer.zip](https://github.com/apache/incubator-dubbo-spring-boot-project/files/1897027/provider_and_consumer.zip)

   @suclogger I've modified your official example, just created a new interface 
and it's implementation, then comment out your DefaultDemoService, then it 
stopped to work anymore, please help to take a look, thank you!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] shinestarwang opened a new issue #1586: 新增provider后负载均衡问题

[GitBox]

shinestarwang opened a new issue #1586: 新增provider后负载均衡问题
URL: https://github.com/apache/incubator-dubbo/issues/1586
 
 
   遇到的情况是这样的：
   新增8台服务器(provider)，旧的8台服务器的被请求次数明显比新增的服务器被调用次数多很多
   策略使用的roundrobin
   dubbo version：2.5.3
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: DubboX papers donate to Dubbo

[Ian Luo]

wow, that's great, would you mind to integrate the doc into
https://github.com/apache/incubator-dubbo-docs, even though we could do it
ourselves if you don't have time :)

Thanks,
-Ian.

On Tue, Apr 10, 2018 at 5:05 PM, 林嘉琦  wrote:

> Hello,
>  I decided to donate DubboX to Dubbo,including the papers of
> DubboX. Besides, I have changed the license of papers to Apache 2.0.
> The papers are in here:https://dangdangdotcom.github.io/dubbox/
>
> Github account : chidaodezhongsheng
>
>
>

[GitHub] lixiaguang opened a new issue #1585: How to use standard cxf client to invoke Dubbo Webservice?

[GitBox]

lixiaguang opened a new issue #1585: How to use standard cxf client to invoke 
Dubbo Webservice?
URL: https://github.com/apache/incubator-dubbo/issues/1585
 
 
   I got a  Dubbo Webservice WSDL Address. I want to use cxf client 
toinvoke.But when i run my code,I got some error "NullPointerException".
   here is my client code:
   -
   import javax.xml.namespace.QName;
   import javax.xml.ws.WebServiceClient;
   
   import org.apache.cxf.endpoint.Client;
   import org.apache.cxf.jaxws.endpoint.dynamic.JaxWsDynamicClientFactory;
   import org.apache.log4j.Logger;
   
   import cn.com.shenhuagroup.xxgs.bigdata.test.builddata.BuildTestData;
   
   public class Test1 {
Logger log = Logger.getLogger(Test1.class);
   
public Object[] callWebService(String wsdl, String targetNamespace, 
String methodName, Object args[]) {
Object[] res = null;
try {
log.info("动态调用webservice开始，wsdl:" + wsdl + 
",methodName:" + methodName + ",args:" + args);
JaxWsDynamicClientFactory dcf = 
JaxWsDynamicClientFactory.newInstance();
Client client = dcf.createClient(wsdl);
if (targetNamespace == null) {
res = client.invoke(methodName, args);
} else {
res = client.invoke(new QName(targetNamespace, 
methodName), args);
}
   
} catch (Exception e) {
log.error("动态调用webservice 失败,wsdl:" + wsdl + 
",targetNamespace:" + targetNamespace + ",methodName:"
+ methodName + ",args:" + args, e);
}
return res;
}
   
public static void main(String[] args) {
String wsdl = "http://xx:8080/TestService?wsdl;; // WSDL
String targetNamespace = "http://xx.com/;; // WSDL
String methodName = "getUserInfo";
Object params[] = {"id","1" };
Test1 client = new Test1();
Object[] res = client.callWebService(wsdl, targetNamespace, 
methodName, params);
System.out.println(res.toString());
}
   }
   
   Here is error:
   ---
   java.lang.NullPointerException
at 
org.apache.cxf.transport.http.URLConnectionHTTPConduit.createConnection(URLConnectionHTTPConduit.java:109)
at 
org.apache.cxf.transport.http.URLConnectionHTTPConduit.setupConnection(URLConnectionHTTPConduit.java:122)
at 
org.apache.cxf.transport.http.HTTPConduit.prepare(HTTPConduit.java:499)
at 
org.apache.cxf.interceptor.MessageSenderInterceptor.handleMessage(MessageSenderInterceptor.java:46)
at 
org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:308)
at org.apache.cxf.endpoint.ClientImpl.doInvoke(ClientImpl.java:514)
at org.apache.cxf.endpoint.ClientImpl.invoke(ClientImpl.java:423)
at org.apache.cxf.endpoint.ClientImpl.invoke(ClientImpl.java:324)
at org.apache.cxf.endpoint.ClientImpl.invoke(ClientImpl.java:277)
at org.apache.cxf.endpoint.ClientImpl.invoke(ClientImpl.java:297)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] alphatan commented on issue #100: dubbo status is UNKOWN

[GitBox]

alphatan commented on issue #100: dubbo status is UNKOWN
URL: 
https://github.com/apache/incubator-dubbo-spring-boot-project/issues/100#issuecomment-380283176
 
 
   @mercyblitz Hi, thanks for your response. But what does it mean? How could I 
find the info of the `load` item?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mercyblitz commented on issue #100: dubbo status is UNKOWN

[GitBox]

mercyblitz commented on issue #100: dubbo status is UNKOWN
URL: 
https://github.com/apache/incubator-dubbo-spring-boot-project/issues/100#issuecomment-380169806
 
 
   Please take a look at `load` item in this endpoint


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] gMan1990 opened a new issue #25: file://${user.home}/dubbo.properties 引入有什么用？

[GitBox]

gMan1990 opened a new issue #25: file://${user.home}/dubbo.properties 引入有什么用？
URL: https://github.com/apache/incubator-dubbo-ops/issues/25
 
 
   
https://github.com/apache/incubator-dubbo-ops/blob/53136c2003285a1f25d9dc08064aeac9d2be30f7/dubbo-admin/src/main/resources/META-INF/spring/dubbo-admin.xml#L15


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kimmking commented on issue #1583: provider report failed monitor

[GitBox]

kimmking commented on issue #1583: provider  report failed monitor
URL: 
https://github.com/apache/incubator-dubbo/issues/1583#issuecomment-380147999
 
 
   you can use the latest version.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kimmking commented on issue #1581: 注册中心怎么通知consumer端知道provider发布了和断开了

[GitBox]

kimmking commented on issue #1581: 注册中心怎么通知consumer端知道provider发布了和断开了
URL: 
https://github.com/apache/incubator-dubbo/issues/1581#issuecomment-380118573
 
 
   the notification mechanism is based on zookeeper


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] beiwei30 closed pull request #13: New thread model: eager

[GitBox]

beiwei30 closed pull request #13: New thread model: eager
URL: https://github.com/apache/incubator-dubbo-docs/pull/13
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/dubbo-user-book/demos/thread-model.md 
b/dubbo-user-book/demos/thread-model.md
index a1c7cfa..ef662e2 100644
--- a/dubbo-user-book/demos/thread-model.md
+++ b/dubbo-user-book/demos/thread-model.md
@@ -27,4 +27,5 @@ ThreadPool
 
 * `fixed` 固定大小线程池，启动时建立线程，不关闭，一直持有。(缺省)
 * `cached` 缓存线程池，空闲一分钟自动删除，需要时重建。
-* `limited` 可伸缩线程池，但池中的线程数只会增长不会收缩。只增长不收缩的目的是为了避免收缩时突然来了大流量引起的性能问题。
\ No newline at end of file
+* `limited` 可伸缩线程池，但池中的线程数只会增长不会收缩。只增长不收缩的目的是为了避免收缩时突然来了大流量引起的性能问题。
+* `eager` 
优先创建`Worker`线程池。在任务数量大于`corePoolSize`但是小于`maximumPoolSize`时，优先创建`Worker`来处理任务。当任务数量大于`maximumPoolSize`时，将任务放入阻塞队列中。阻塞队列充满时抛出`RejectedExecutionException`。(相比于`cached`:`cached`在任务数量超过`maximumPoolSize`时直接抛出异常而不是将任务放入阻塞队列)
\ No newline at end of file


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carryxyh opened a new pull request #13: New thread model: eager

[GitBox]

carryxyh opened a new pull request #13: New thread model: eager
URL: https://github.com/apache/incubator-dubbo-docs/pull/13
 
 
   Introduce a new thread model named eager.
   EagerThreadPoolExecutor has been merged into master.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wangyq07 opened a new issue #1581: 注册中心怎么通知consumer端知道provider发布了和断开了

[GitBox]

wangyq07 opened a new issue #1581: 注册中心怎么通知consumer端知道provider发布了和断开了
URL: https://github.com/apache/incubator-dubbo/issues/1581
 
 
   
我现在有个应用，就是在consumer端需要知道目前provider的地址列表，并且provider如果停止了，consumer能够捕捉到相关信息，注册了也可以捕捉到相关信息，谢谢


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cvictory commented on issue #1497: when using simpleregistry, provider throwed a exception

[GitBox]

cvictory commented on issue #1497: when using simpleregistry, provider throwed 
a exception
URL: https://github.com/apache/incubator-dubbo/pull/1497#issuecomment-380037530
 
 
   The issue is fixed on https://github.com/apache/incubator-dubbo/issues/1289 .
   
   The merge request can be closed.  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cvictory commented on issue #1497: when using simpleregistry, provider throwed a exception

[GitBox]

cvictory commented on issue #1497: when using simpleregistry, provider throwed 
a exception
URL: https://github.com/apache/incubator-dubbo/pull/1497#issuecomment-380037530
 
 
   The issue is fixed on https://github.com/apache/incubator-dubbo/issues/1289 .
   
   The merge request can be closed.  Refer to: 
https://github.com/apache/incubator-dubbo/issues/1289


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cvictory commented on issue #1528: dubbo monitor?

[GitBox]

cvictory commented on issue #1528: dubbo monitor?
URL: 
https://github.com/apache/incubator-dubbo/issues/1528#issuecomment-380028629
 
 
   It is usage question. Please close it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cvictory commented on issue #1524: The version report to registry is 2.0.1 after dubbo 2.5.9

[GitBox]

cvictory commented on issue #1524: The version report to registry is 2.0.1 
after dubbo 2.5.9
URL: 
https://github.com/apache/incubator-dubbo/issues/1524#issuecomment-380025302
 
 
   I found Implementation-verison and Specification-version in dubbo 
jar(version:2.6.1 ) is right.
   
   As @diecui1202 said, We will not change the value in register url. such as : 
registry://224.5.6.7:1234/com.alibaba.dubbo.registry.RegistryService?application=demo-provider=2.0.0=9796=2=multicast=1523350418885
 .
   The value `dubbo=2.0.0` will be kept.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cvictory commented on issue #1524: The version report to registry is 2.0.1 after dubbo 2.5.9

[GitBox]

cvictory commented on issue #1524: The version report to registry is 2.0.1 
after dubbo 2.5.9
URL: 
https://github.com/apache/incubator-dubbo/issues/1524#issuecomment-380025302
 
 
   I found Implementation-verison and Specification-version in dubbo 
jar(version:2.6.1 ) is right now.
   
   As @diecui1202 said, We will not change the value in register url. such as : 
registry://224.5.6.7:1234/com.alibaba.dubbo.registry.RegistryService?application=demo-provider=2.0.0=9796=2=multicast=1523350418885
 .
   The value `dubbo=2.0.0` will be kept.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cvictory commented on issue #1524: The version report to registry is 2.0.1 after dubbo 2.5.9

[GitBox]

cvictory commented on issue #1524: The version report to registry is 2.0.1 
after dubbo 2.5.9
URL: 
https://github.com/apache/incubator-dubbo/issues/1524#issuecomment-380025302
 
 
   I found Implementation-verison and Specification-version in dubbo 
jar(version:2.6.1 ) is right.
   
   And as @diecui1202 said, We will not change the value in register url. such 
as : 
registry://224.5.6.7:1234/com.alibaba.dubbo.registry.RegistryService?application=demo-provider=2.0.0=9796=2=multicast=1523350418885
 .
   The value `dubbo=2.0.0` will be kept.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cvictory commented on issue #1523: dubbo多分支api依赖版本管理问题

[GitBox]

cvictory commented on issue #1523: dubbo多分支api依赖版本管理问题
URL: 
https://github.com/apache/incubator-dubbo/issues/1523#issuecomment-380016838
 
 
   It is usage question.  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mercyblitz closed pull request #1578: Fix #1539, change log method

[GitBox]

mercyblitz closed pull request #1578: Fix #1539, change log method
URL: https://github.com/apache/incubator-dubbo/pull/1578
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/support/wrapper/MockClusterInvoker.java
 
b/dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/support/wrapper/MockClusterInvoker.java
index 0a038c7433..0269c2b73f 100644
--- 
a/dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/support/wrapper/MockClusterInvoker.java
+++ 
b/dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/support/wrapper/MockClusterInvoker.java
@@ -83,7 +83,7 @@ public Result invoke(Invocation invocation) throws 
RpcException {
 throw e;
 } else {
 if (logger.isWarnEnabled()) {
-logger.info("fail-mock: " + invocation.getMethodName() 
+ " fail-mock enabled , url : " + directory.getUrl(), e);
+logger.warn("fail-mock: " + invocation.getMethodName() 
+ " fail-mock enabled , url : " + directory.getUrl(), e);
 }
 result = doMockInvoke(invocation, e);
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #1578: Fix #1539, change log method

[GitBox]

codecov-io commented on issue #1578: Fix #1539, change log method
URL: https://github.com/apache/incubator-dubbo/pull/1578#issuecomment-380011618
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1578?src=pr=h1) 
Report
   > Merging 
[#1578](https://codecov.io/gh/apache/incubator-dubbo/pull/1578?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/c25d462ff48c725440393da801e8c614df600248?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1578/graphs/tree.svg?width=650=150=VnEIkiFQT0=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/1578?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#1578  +/-   ##
   
   + Coverage 34.52%   34.53%   +<.01% 
   - Complexity 3684 3685   +1 
   
 Files   621  621  
 Lines 3087530875  
 Branches   5448 5448  
   
   + Hits  1066110663   +2 
 Misses1837618376  
   + Partials   1838 1836   -2
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1578?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...pc/cluster/support/wrapper/MockClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1578/diff?src=pr=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3N1cHBvcnQvd3JhcHBlci9Nb2NrQ2x1c3Rlckludm9rZXIuamF2YQ==)
 | `62.5% <100%> (ø)` | `10 <0> (ø)` | :arrow_down: |
   | 
[...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1578/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=)
 | `62.5% <0%> (-3.75%)` | `20% <0%> (-1%)` | |
   | 
[...ba/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1578/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlTZXJ2ZXIuamF2YQ==)
 | `70.9% <0%> (+3.63%)` | `9% <0%> (+1%)` | :arrow_up: |
   | 
[...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1578/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh)
 | `55.69% <0%> (+3.79%)` | `13% <0%> (+2%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1578?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1578?src=pr=footer).
 Last update 
[c25d462...50f72c0](https://codecov.io/gh/apache/incubator-dubbo/pull/1578?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] huangxincheng opened a new issue #1579: Could you tell me why no dubbo admin and dubbo monitoring on source

[GitBox]

huangxincheng opened a new issue #1579: Could you tell me why no dubbo admin 
and dubbo monitoring on source
URL: https://github.com/apache/incubator-dubbo/issues/1579
 
 
   Could you tell me why no dubbo admin and dubbo monitoring on source


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] diecui1202 opened a new pull request #1578: Fix #1539, change log method

[GitBox]

diecui1202 opened a new pull request #1578: Fix #1539, change log method
URL: https://github.com/apache/incubator-dubbo/pull/1578
 
 
   ## What is the purpose of the change
   
   Just fix hand-writing error for warn log
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   All unit test are pass.
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
   - [x] Make sure there is a 
[GITHUB_issue](https://github.com/alibaba/dubbo/issues) filed for the change 
(usually before you start working on it). Trivial changes like typos do not 
require a GITHUB issue. Your pull request should address just this issue, 
without pulling in other changes - one PR resolves one issue. 
   - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [ ] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [ ] Write necessary unit-test to verify your logic correction, more mock a 
little better when cross module dependency exist. If the new feature or 
significant change is committed, please remember to add integration-test in 
[test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test).
   - [ ] Run `mvn clean install -DskipITs` to make sure unit-test pass. Run 
`mvn clean test-compile failsafe:integration-test`  to make sure 
integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nzomkxia commented on issue #1442: [Dubbo-889-Attachments] support implicit delivery of attachments from provider to consumer

[GitBox]

nzomkxia commented on issue #1442: [Dubbo-889-Attachments] support implicit 
delivery of attachments from provider to consumer
URL: https://github.com/apache/incubator-dubbo/pull/1442#issuecomment-380005817
 
 
   can you commit a test case for the change?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

[GitBox]

zonghaishang commented on a change in pull request #1550: [Dubbo-Fix 
EnableDubbo annotation bug]
URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179936669
 
 

 ##
 File path: 
dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/ServiceAnnotationBeanPostProcessor.java
 ##
 @@ -98,13 +110,88 @@ public void 
postProcessBeanDefinitionRegistry(BeanDefinitionRegistry registry) t
 Set resolvedPackagesToScan = 
resolvePackagesToScan(packagesToScan);
 
 if (!CollectionUtils.isEmpty(resolvedPackagesToScan)) {
+
+// register @Service
 registerServiceBeans(resolvedPackagesToScan, registry);
+
+// register @Component
+registerComponentBeans(resolvedPackagesToScan, registry);
 } else {
 if (logger.isWarnEnabled()) {
 logger.warn("packagesToScan is empty , ServiceBean registry 
will be ignored!");
 }
 }
 
+/**
+ * The solution to consumers early references to unexposed services.
+ */
+deferConfiguationBeans();
+
+}
+
+/**
+ * Registers Beans whose classes was annotated {@link Component}
+ *
+ * @param packagesToScan The base packages to scan
+ * @param registry   {@link BeanDefinitionRegistry}
+ */
+private void registerComponentBeans(Set packagesToScan, 
BeanDefinitionRegistry registry) {
+
+DubboClassPathBeanDefinitionScanner scanner =
+new DubboClassPathBeanDefinitionScanner(registry, environment, 
resourceLoader);
+
+BeanNameGenerator beanNameGenerator = 
resolveBeanNameGenerator(registry);
+
+scanner.setBeanNameGenerator(beanNameGenerator);
+
+scanner.addExcludeFilter(new AnnotationTypeFilter(Controller.class, 
false));
 
 Review comment:
   Process discovery and `@Component` under the same service package.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

[GitBox]

zonghaishang commented on a change in pull request #1550: [Dubbo-Fix 
EnableDubbo annotation bug]
URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179554995
 
 

 ##
 File path: 
dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/context/annotation/DubboClassPathBeanDefinitionScanner.java
 ##
 @@ -53,7 +53,7 @@ public 
DubboClassPathBeanDefinitionScanner(BeanDefinitionRegistry registry, bool
 public DubboClassPathBeanDefinitionScanner(BeanDefinitionRegistry 
registry, Environment environment,
ResourceLoader resourceLoader) {
 
-this(registry, false, environment, resourceLoader);
+this(registry, true, environment, resourceLoader);
 
 Review comment:
   Supports `@Service` to automatically discover Component annotations


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

[GitBox]

zonghaishang commented on a change in pull request #1550: [Dubbo-Fix 
EnableDubbo annotation bug]
URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179936906
 
 

 ##
 File path: 
dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/ReferenceAnnotationBeanPostProcessor.java
 ##
 @@ -60,7 +65,7 @@
  */
 public class ReferenceAnnotationBeanPostProcessor extends 
InstantiationAwareBeanPostProcessorAdapter
 implements MergedBeanDefinitionPostProcessor, PriorityOrdered, 
ApplicationContextAware, BeanClassLoaderAware,
-DisposableBean {
+DisposableBean, ApplicationListener {
 
 Review comment:
   I always think that @EnableDubbo (basepackage="com.xxx") since it supports 
packet scanning, should avoid having the user repeatedly configure the same 
`@ComponentScan(basepackage="com.xxx")`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lovepoem commented on issue #1546: multiple registry centers or one registry center cluster?

[GitBox]

lovepoem commented on issue #1546: multiple registry centers or one registry 
center cluster?
URL: 
https://github.com/apache/incubator-dubbo/issues/1546#issuecomment-380003750
 
 
   Agree with @zonghaishang zong


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lovepoem closed issue #1546: multiple registry centers or one registry center cluster?

[GitBox]

lovepoem closed issue #1546: multiple registry centers or one registry center 
cluster?
URL: https://github.com/apache/incubator-dubbo/issues/1546
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lovepoem commented on issue #1546: multiple registry centers or one registry center cluster?

[GitBox]

lovepoem commented on issue #1546: multiple registry centers or one registry 
center cluster?
URL: 
https://github.com/apache/incubator-dubbo/issues/1546#issuecomment-380003750
 
 
   Agree with @johnament 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] takeseem commented on issue #1516: 请求解决序列化问题

[GitBox]

takeseem commented on issue #1516: 请求解决序列化问题
URL: 
https://github.com/apache/incubator-dubbo/issues/1516#issuecomment-37842
 
 
   其实这个需求不应该由dubbo实现，本身就是[null]，为什么经过dubbo rpc后，变成了[]，这本身就是问题！
   
   你完全可以直接写一个工具方法，在return时处理list：return ltrim(list);
   ```java
   public static ltrim(List list) {
 if (list != null && !list.isEmpty() && list.get(0) == null) list.remove(0);
   }
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hank-whu commented on issue #1500: not support java 10

[GitBox]

hank-whu commented on issue #1500: not support java 10
URL: 
https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-379998472
 
 
   应该是我电脑 maven 的问题，删掉 maven 的 repository 后问题解决。
   浪费大家时间了，多谢各位。


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[Suggestion] PR failing if test coverage went down

[htynkn]

hey team,


In pull request 
template(https://github.com/apache/incubator-dubbo/blob/master/PULL_REQUEST_TEMPLATE.md),
 this is one item to ask all pr to 


   "Write necessary unit-test to verify your logic correction"


Codecov has feature to fail PR if test coverage went down. Which means for any 
pull request, if it add some code without any unit test, the PR will fail
This can help to increase test coverage.


Any thoughts?


Relate links: 
1.https://docs.codecov.io/docs/commit-status
2.https://github.com/codecov/support/issues/351