Re: [ANN] Welcome new committer Jinkai Ma

2018-10-29 Thread YunKun Huang
Congratulations !

On 2018/10/30 03:20:58, yuhang xiu  wrote: 
> Hi, jinkai
> Congratulations on your joining!
> 
> Jun Liu  于2018年10月30日周二 上午11:15写道:
> 
> >
> >
> > > On Oct 30, 2018, at 11:12 AM, Jun Liu  wrote:
> > >
> > > Hi, Community,
> > >
> > > On behalf of the Dubbo PPMC, I am pleased to announce that Jinkai Ma,
> > whose github id is majinkai, has been voted in as a new Dubbo committer.
> > >
> > > Please join me to say congratulations to him!
> > >
> > > Jinkai, would you please briefly introduce yourself to the community?
> > >
> > > Best regards,
> > > Jun
> >
> >
> 


Re: [ANN] Welcome new committer Jinkai Ma

2018-10-29 Thread Xin Wang
Congratulations,Jinkai

马金凯  于2018年10月30日周二 上午11:29写道:

> Hi, all,
> It's my great honor to join the dubbo family, my name Jinkai Ma, and
> work at Handuyishe.
> I started using dubbo five years ago, and i like to participate in the
> open source community, it's very helpful to me.
> Hope the dubbo and apache communities gets better, best wish for
> everyone.
>
>
> --
> 发件人:Jun Liu 
> 发送时间:2018年10月30日(星期二) 11:12
> 收件人:dev 
> 主 题:[ANN] Welcome new committer Jinkai Ma
>
> Hi, Community,
>
> On behalf of the Dubbo PPMC, I am pleased to announce that Jinkai Ma,
> whose github id is majinkai, has been voted in as a new Dubbo committer.
>
> Please join me to say congratulations to him!
>
> Jinkai, would you please briefly introduce yourself to the community?
>
> Best regards,
> Jun
>
>


回复:[ANN] Welcome new committer Jinkai Ma

2018-10-29 Thread 马金凯
Hi, all,
It's my great honor to join the dubbo family, my name Jinkai Ma, and work 
at Handuyishe.
I started using dubbo five years ago, and i like to participate in the open 
source community, it's very helpful to me.
Hope the dubbo and apache communities gets better, best wish for everyone.


--
发件人:Jun Liu 
发送时间:2018年10月30日(星期二) 11:12
收件人:dev 
主 题:[ANN] Welcome new committer Jinkai Ma

Hi, Community,

On behalf of the Dubbo PPMC, I am pleased to announce that Jinkai Ma, whose 
github id is majinkai, has been voted in as a new Dubbo committer.

Please join me to say congratulations to him!

Jinkai, would you please briefly introduce yourself to the community?

Best regards,
Jun



Re: [ANN] Welcome new committer Jinkai Ma

2018-10-29 Thread Jerrick Zhu
congrats, majinkai.


On Tue, Oct 30, 2018 at 11:17 AM Ian Luo  wrote:

> Congratulations! welcome to the community :)
>
> On Tue, Oct 30, 2018 at 11:15 AM Jun Liu  wrote:
>
> >
> >
> > > On Oct 30, 2018, at 11:12 AM, Jun Liu  wrote:
> > >
> > > Hi, Community,
> > >
> > > On behalf of the Dubbo PPMC, I am pleased to announce that Jinkai Ma,
> > whose github id is majinkai, has been voted in as a new Dubbo committer.
> > >
> > > Please join me to say congratulations to him!
> > >
> > > Jinkai, would you please briefly introduce yourself to the community?
> > >
> > > Best regards,
> > > Jun
> >
> >
>


Re: [ANN] Welcome new committer Jinkai Ma

2018-10-29 Thread yuhang xiu
Hi, jinkai
Congratulations on your joining!

Jun Liu  于2018年10月30日周二 上午11:15写道:

>
>
> > On Oct 30, 2018, at 11:12 AM, Jun Liu  wrote:
> >
> > Hi, Community,
> >
> > On behalf of the Dubbo PPMC, I am pleased to announce that Jinkai Ma,
> whose github id is majinkai, has been voted in as a new Dubbo committer.
> >
> > Please join me to say congratulations to him!
> >
> > Jinkai, would you please briefly introduce yourself to the community?
> >
> > Best regards,
> > Jun
>
>


pull request 2686

2018-10-29 Thread Ian Luo
Xiaobo,

Would you mind to take a look at the comments I dropped on pull request
2686 [1] you proposed? Basically I think we could completely remove isDelay
method, if you agree with this idea, pls. follow up to enhance your pull
request.

Thanks,
-Ian.

1. https://github.com/apache/incubator-dubbo/pull/2686


Re: [ANN] Welcome new committer Jinkai Ma

2018-10-29 Thread Ian Luo
Congratulations! welcome to the community :)

On Tue, Oct 30, 2018 at 11:15 AM Jun Liu  wrote:

>
>
> > On Oct 30, 2018, at 11:12 AM, Jun Liu  wrote:
> >
> > Hi, Community,
> >
> > On behalf of the Dubbo PPMC, I am pleased to announce that Jinkai Ma,
> whose github id is majinkai, has been voted in as a new Dubbo committer.
> >
> > Please join me to say congratulations to him!
> >
> > Jinkai, would you please briefly introduce yourself to the community?
> >
> > Best regards,
> > Jun
>
>


Re: [ANN] Welcome new committer Jinkai Ma

2018-10-29 Thread Jun Liu



> On Oct 30, 2018, at 11:12 AM, Jun Liu  wrote:
> 
> Hi, Community,
> 
> On behalf of the Dubbo PPMC, I am pleased to announce that Jinkai Ma, whose 
> github id is majinkai, has been voted in as a new Dubbo committer.
> 
> Please join me to say congratulations to him!
> 
> Jinkai, would you please briefly introduce yourself to the community?
> 
> Best regards,
> Jun



Re: [Discuss] Prepare for release of dubbo-2.6.5

2018-10-29 Thread Ian Luo
+1, we should mention this. Victory, would you mind to iterate all changes
since release 2.6.4 to make sure nothing is missing in the release note?

Thanks,
-Ian.


On Mon, Oct 29, 2018 at 11:04 PM 秦金卫  wrote:

> there is an important enhancement:
> https://github.com/apache/incubator-dubbo/pull/2647  ?
> At 2018-10-29 19:47:30, "victory"  wrote:
> >Hello Community,
> >
> >
> >As 2.6.4 has been released, I think we are ready for the next maintenance
> >release 2.6.5 now. In this release, we plan to solve the issues and
> >requirements reported by the community recently:
> >
> >
> >Enhancements / Features:
> >
> >- [#2655](https://github.com/apache/incubator-dubbo/issues/2655) @Service
> >and @Reference Optimization
> >
> >- [#1641](https://github.com/apache/incubator-dubbo/issues/1641)
> >[Enhancement] the algorithm of load issue on Windows good first issue help
> >wanted
> >
> >- [#2600](https://github.com/apache/incubator-dubbo/issues/2600) add
> >javadoc to dubbo-all module good first issue help wanted
> >
> >- [#2519](https://github.com/apache/incubator-dubbo/issues/2519) Can we
> >make the bom and all module become the child module of dubbo-parent?
> >
> >- [#2235](https://github.com/apache/incubator-dubbo/issues/2235)
> >[Enhancement] Reactor the generation rule for @Service Bean name
> >type/enhancement
> >
> >
> >Bugfixes:
> >
> >- [#2063](https://github.com/apache/incubator-dubbo/issues/2063)
> >@Service(register=false) is not work
> >
> >- [#1903](https://github.com/apache/incubator-dubbo/issues/1903) Our
> >customized serialization id exceeds the maximum limit, now it cannot work
> >on 2.6.2 anymore.
> >
> >- [#2194](https://github.com/apache/incubator-dubbo/issues/2194)
> Annotation
> >@Reference can't support to export a service with a sync one and an async
> >one
> >
> >- [#2522](https://github.com/apache/incubator-dubbo/issues/2522)
>
> >`org.apache.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor#generateReferenceBeanCacheKey`
> >has a bug
> >
> >- [#2256](https://github.com/apache/incubator-dubbo/issues/2256) 2.6.x
> >Spring Event & Bugfix
> >
> >- [#2621](https://github.com/apache/incubator-dubbo/issues/2621) fix
> #1641,
> >support get system load on windows.
> >
> >- [pr#2624](https://github.com/apache/incubator-dubbo/pull/2624) Fix
> >incorrect descriptions for dubbo-serialization module
> >
> >- [#2560](https://github.com/apache/incubator-dubbo/issues/2560) A empty
> >directory dubbo-config/dubbo-config-spring/src/test/resources/work after
> >package source tgz
> >
> >
> >Issues and Pull Requests, check [milestone-2.6.5](
> >https://github.com/apache/incubator-dubbo/milestone/21)
> >
> >
> >Check the link below for more detailed release candidates:
> >
> >https://github.com/apache/incubator-dubbo/blob/2.6.5-release/CHANGES.md
> >
> >
> >I’d like to be the PM of this release, I suggest we start this release
> cycle
> >as soon as possible. If you are ok to that, let's start the official
> release
> >vote in community at this week late or next week.
> >
> >
> >We kindly ask for your suggestions on the release candidates, and you can
> also
> >help verify all the commits on the release branch:
> >
> >https://github.com/apache/incubator-dubbo/tree/2.6.5-release
> >
> >
> >Best Regard!
> >
> >cvictory
>


Re: [Discuss] Prepare for release of dubbo-2.6.5

2018-10-29 Thread Jerrick Zhu
You could use git log on 2.6.x branch, and check all the commits after
2.6.4.

On Tue, Oct 30, 2018 at 10:02 AM victory  wrote:

> Ok, I left out some issues in the one week.  All issues are from
> https://github.com/apache/incubator-dubbo/issues/2663
> I will check again, and all of you can let me know if I left out something.
>
> 秦金卫  于2018年10月29日周一 下午11:04写道:
>
> > there is an important enhancement:
> > https://github.com/apache/incubator-dubbo/pull/2647  ?
> > At 2018-10-29 19:47:30, "victory"  wrote:
> > >Hello Community,
> > >
> > >
> > >As 2.6.4 has been released, I think we are ready for the next
> maintenance
> > >release 2.6.5 now. In this release, we plan to solve the issues and
> > >requirements reported by the community recently:
> > >
> > >
> > >Enhancements / Features:
> > >
> > >- [#2655](https://github.com/apache/incubator-dubbo/issues/2655)
> @Service
> > >and @Reference Optimization
> > >
> > >- [#1641](https://github.com/apache/incubator-dubbo/issues/1641)
> > >[Enhancement] the algorithm of load issue on Windows good first issue
> help
> > >wanted
> > >
> > >- [#2600](https://github.com/apache/incubator-dubbo/issues/2600) add
> > >javadoc to dubbo-all module good first issue help wanted
> > >
> > >- [#2519](https://github.com/apache/incubator-dubbo/issues/2519) Can we
> > >make the bom and all module become the child module of dubbo-parent?
> > >
> > >- [#2235](https://github.com/apache/incubator-dubbo/issues/2235)
> > >[Enhancement] Reactor the generation rule for @Service Bean name
> > >type/enhancement
> > >
> > >
> > >Bugfixes:
> > >
> > >- [#2063](https://github.com/apache/incubator-dubbo/issues/2063)
> > >@Service(register=false) is not work
> > >
> > >- [#1903](https://github.com/apache/incubator-dubbo/issues/1903) Our
> > >customized serialization id exceeds the maximum limit, now it cannot
> work
> > >on 2.6.2 anymore.
> > >
> > >- [#2194](https://github.com/apache/incubator-dubbo/issues/2194)
> > Annotation
> > >@Reference can't support to export a service with a sync one and an
> async
> > >one
> > >
> > >- [#2522](https://github.com/apache/incubator-dubbo/issues/2522)
> >
> >
> >`org.apache.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor#generateReferenceBeanCacheKey`
> > >has a bug
> > >
> > >- [#2256](https://github.com/apache/incubator-dubbo/issues/2256) 2.6.x
> > >Spring Event & Bugfix
> > >
> > >- [#2621](https://github.com/apache/incubator-dubbo/issues/2621) fix
> > #1641,
> > >support get system load on windows.
> > >
> > >- [pr#2624](https://github.com/apache/incubator-dubbo/pull/2624) Fix
> > >incorrect descriptions for dubbo-serialization module
> > >
> > >- [#2560](https://github.com/apache/incubator-dubbo/issues/2560) A
> empty
> > >directory dubbo-config/dubbo-config-spring/src/test/resources/work after
> > >package source tgz
> > >
> > >
> > >Issues and Pull Requests, check [milestone-2.6.5](
> > >https://github.com/apache/incubator-dubbo/milestone/21)
> > >
> > >
> > >Check the link below for more detailed release candidates:
> > >
> > >https://github.com/apache/incubator-dubbo/blob/2.6.5-release/CHANGES.md
> > >
> > >
> > >I’d like to be the PM of this release, I suggest we start this release
> > cycle
> > >as soon as possible. If you are ok to that, let's start the official
> > release
> > >vote in community at this week late or next week.
> > >
> > >
> > >We kindly ask for your suggestions on the release candidates, and you
> can
> > also
> > >help verify all the commits on the release branch:
> > >
> > >https://github.com/apache/incubator-dubbo/tree/2.6.5-release
> > >
> > >
> > >Best Regard!
> > >
> > >cvictory
> >
>
>
> --
>
> Best Regard!
> cvitory
>


Re: [Discuss] Prepare for release of dubbo-2.6.5

2018-10-29 Thread victory
Ok, I left out some issues in the one week.  All issues are from
https://github.com/apache/incubator-dubbo/issues/2663
I will check again, and all of you can let me know if I left out something.

秦金卫  于2018年10月29日周一 下午11:04写道:

> there is an important enhancement:
> https://github.com/apache/incubator-dubbo/pull/2647  ?
> At 2018-10-29 19:47:30, "victory"  wrote:
> >Hello Community,
> >
> >
> >As 2.6.4 has been released, I think we are ready for the next maintenance
> >release 2.6.5 now. In this release, we plan to solve the issues and
> >requirements reported by the community recently:
> >
> >
> >Enhancements / Features:
> >
> >- [#2655](https://github.com/apache/incubator-dubbo/issues/2655) @Service
> >and @Reference Optimization
> >
> >- [#1641](https://github.com/apache/incubator-dubbo/issues/1641)
> >[Enhancement] the algorithm of load issue on Windows good first issue help
> >wanted
> >
> >- [#2600](https://github.com/apache/incubator-dubbo/issues/2600) add
> >javadoc to dubbo-all module good first issue help wanted
> >
> >- [#2519](https://github.com/apache/incubator-dubbo/issues/2519) Can we
> >make the bom and all module become the child module of dubbo-parent?
> >
> >- [#2235](https://github.com/apache/incubator-dubbo/issues/2235)
> >[Enhancement] Reactor the generation rule for @Service Bean name
> >type/enhancement
> >
> >
> >Bugfixes:
> >
> >- [#2063](https://github.com/apache/incubator-dubbo/issues/2063)
> >@Service(register=false) is not work
> >
> >- [#1903](https://github.com/apache/incubator-dubbo/issues/1903) Our
> >customized serialization id exceeds the maximum limit, now it cannot work
> >on 2.6.2 anymore.
> >
> >- [#2194](https://github.com/apache/incubator-dubbo/issues/2194)
> Annotation
> >@Reference can't support to export a service with a sync one and an async
> >one
> >
> >- [#2522](https://github.com/apache/incubator-dubbo/issues/2522)
>
> >`org.apache.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor#generateReferenceBeanCacheKey`
> >has a bug
> >
> >- [#2256](https://github.com/apache/incubator-dubbo/issues/2256) 2.6.x
> >Spring Event & Bugfix
> >
> >- [#2621](https://github.com/apache/incubator-dubbo/issues/2621) fix
> #1641,
> >support get system load on windows.
> >
> >- [pr#2624](https://github.com/apache/incubator-dubbo/pull/2624) Fix
> >incorrect descriptions for dubbo-serialization module
> >
> >- [#2560](https://github.com/apache/incubator-dubbo/issues/2560) A empty
> >directory dubbo-config/dubbo-config-spring/src/test/resources/work after
> >package source tgz
> >
> >
> >Issues and Pull Requests, check [milestone-2.6.5](
> >https://github.com/apache/incubator-dubbo/milestone/21)
> >
> >
> >Check the link below for more detailed release candidates:
> >
> >https://github.com/apache/incubator-dubbo/blob/2.6.5-release/CHANGES.md
> >
> >
> >I’d like to be the PM of this release, I suggest we start this release
> cycle
> >as soon as possible. If you are ok to that, let's start the official
> release
> >vote in community at this week late or next week.
> >
> >
> >We kindly ask for your suggestions on the release candidates, and you can
> also
> >help verify all the commits on the release branch:
> >
> >https://github.com/apache/incubator-dubbo/tree/2.6.5-release
> >
> >
> >Best Regard!
> >
> >cvictory
>


-- 

Best Regard!
cvitory


Re:[Discuss] Prepare for release of dubbo-2.6.5

2018-10-29 Thread 秦金卫
there is an important enhancement: 
https://github.com/apache/incubator-dubbo/pull/2647  ?
At 2018-10-29 19:47:30, "victory"  wrote:
>Hello Community,
>
>
>As 2.6.4 has been released, I think we are ready for the next maintenance
>release 2.6.5 now. In this release, we plan to solve the issues and
>requirements reported by the community recently:
>
>
>Enhancements / Features:
>
>- [#2655](https://github.com/apache/incubator-dubbo/issues/2655) @Service
>and @Reference Optimization
>
>- [#1641](https://github.com/apache/incubator-dubbo/issues/1641)
>[Enhancement] the algorithm of load issue on Windows good first issue help
>wanted
>
>- [#2600](https://github.com/apache/incubator-dubbo/issues/2600) add
>javadoc to dubbo-all module good first issue help wanted
>
>- [#2519](https://github.com/apache/incubator-dubbo/issues/2519) Can we
>make the bom and all module become the child module of dubbo-parent?
>
>- [#2235](https://github.com/apache/incubator-dubbo/issues/2235)
>[Enhancement] Reactor the generation rule for @Service Bean name
>type/enhancement
>
>
>Bugfixes:
>
>- [#2063](https://github.com/apache/incubator-dubbo/issues/2063)
>@Service(register=false) is not work
>
>- [#1903](https://github.com/apache/incubator-dubbo/issues/1903) Our
>customized serialization id exceeds the maximum limit, now it cannot work
>on 2.6.2 anymore.
>
>- [#2194](https://github.com/apache/incubator-dubbo/issues/2194) Annotation
>@Reference can't support to export a service with a sync one and an async
>one
>
>- [#2522](https://github.com/apache/incubator-dubbo/issues/2522)
>`org.apache.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor#generateReferenceBeanCacheKey`
>has a bug
>
>- [#2256](https://github.com/apache/incubator-dubbo/issues/2256) 2.6.x
>Spring Event & Bugfix
>
>- [#2621](https://github.com/apache/incubator-dubbo/issues/2621) fix #1641,
>support get system load on windows.
>
>- [pr#2624](https://github.com/apache/incubator-dubbo/pull/2624) Fix
>incorrect descriptions for dubbo-serialization module
>
>- [#2560](https://github.com/apache/incubator-dubbo/issues/2560) A empty
>directory dubbo-config/dubbo-config-spring/src/test/resources/work after
>package source tgz
>
>
>Issues and Pull Requests, check [milestone-2.6.5](
>https://github.com/apache/incubator-dubbo/milestone/21)
>
>
>Check the link below for more detailed release candidates:
>
>https://github.com/apache/incubator-dubbo/blob/2.6.5-release/CHANGES.md
>
>
>I’d like to be the PM of this release, I suggest we start this release cycle
>as soon as possible. If you are ok to that, let's start the official release
>vote in community at this week late or next week.
>
>
>We kindly ask for your suggestions on the release candidates, and you can also
>help verify all the commits on the release branch:
>
>https://github.com/apache/incubator-dubbo/tree/2.6.5-release
>
>
>Best Regard!
>
>cvictory


[Discuss] Prepare for release of dubbo-2.6.5

2018-10-29 Thread victory
Hello Community,


As 2.6.4 has been released, I think we are ready for the next maintenance
release 2.6.5 now. In this release, we plan to solve the issues and
requirements reported by the community recently:


Enhancements / Features:

- [#2655](https://github.com/apache/incubator-dubbo/issues/2655) @Service
and @Reference Optimization

- [#1641](https://github.com/apache/incubator-dubbo/issues/1641)
[Enhancement] the algorithm of load issue on Windows good first issue help
wanted

- [#2600](https://github.com/apache/incubator-dubbo/issues/2600) add
javadoc to dubbo-all module good first issue help wanted

- [#2519](https://github.com/apache/incubator-dubbo/issues/2519) Can we
make the bom and all module become the child module of dubbo-parent?

- [#2235](https://github.com/apache/incubator-dubbo/issues/2235)
[Enhancement] Reactor the generation rule for @Service Bean name
type/enhancement


Bugfixes:

- [#2063](https://github.com/apache/incubator-dubbo/issues/2063)
@Service(register=false) is not work

- [#1903](https://github.com/apache/incubator-dubbo/issues/1903) Our
customized serialization id exceeds the maximum limit, now it cannot work
on 2.6.2 anymore.

- [#2194](https://github.com/apache/incubator-dubbo/issues/2194) Annotation
@Reference can't support to export a service with a sync one and an async
one

- [#2522](https://github.com/apache/incubator-dubbo/issues/2522)
`org.apache.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor#generateReferenceBeanCacheKey`
has a bug

- [#2256](https://github.com/apache/incubator-dubbo/issues/2256) 2.6.x
Spring Event & Bugfix

- [#2621](https://github.com/apache/incubator-dubbo/issues/2621) fix #1641,
support get system load on windows.

- [pr#2624](https://github.com/apache/incubator-dubbo/pull/2624) Fix
incorrect descriptions for dubbo-serialization module

- [#2560](https://github.com/apache/incubator-dubbo/issues/2560) A empty
directory dubbo-config/dubbo-config-spring/src/test/resources/work after
package source tgz


Issues and Pull Requests, check [milestone-2.6.5](
https://github.com/apache/incubator-dubbo/milestone/21)


Check the link below for more detailed release candidates:

https://github.com/apache/incubator-dubbo/blob/2.6.5-release/CHANGES.md


I’d like to be the PM of this release, I suggest we start this release cycle
as soon as possible. If you are ok to that, let's start the official release
vote in community at this week late or next week.


We kindly ask for your suggestions on the release candidates, and you can also
help verify all the commits on the release branch:

https://github.com/apache/incubator-dubbo/tree/2.6.5-release


Best Regard!

cvictory


[DISCUSS] should we include gson support in main trunk

2018-10-29 Thread Ian Luo
Hi folks,

Today I noticed there's one pull request 2699 (dubbo Add a new
serialization -gson) [1] pending for review. I'm hesitate to move it in
since we've already had fastjson serialization support which serves the
same purpose.

I'd like to hear your opinion on this.

Thanks,
-Ian.


1. https://github.com/apache/incubator-dubbo/pull/2699