Re: [VOTE] Release Apache Dubbo API Docs 2.7.8.3 RC3

[victory]

+1 (binding)

I have checked the following items:

[v] Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] LICENSE and NOTICE exists and contents are good
[v] Download the source, compile, and run unit test successfully.


YunKun Huang  于2021年5月6日周四 上午11:56写道：

> +1
>
> + Release note looks ok
> + Can compile from source files
> + LICENSE NOTICE file exists
> + Hash for release tag is correct
>
> On Thu, May 6, 2021 at 11:02 AM ranke  wrote:
> >
> > Hello Community,
> >
> > This is a call for vote to release Apache Dubbo API Docs version 2.7.8.3.
> > Dubbo API Docs is currently existing as a submodule of the
> > apache/dubbo-spi-extensions[1] project, the Apache release package
> contains
> > only the API Docs source code.
> >
> > The release candidates:
> > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-api-docs/2.7.8.3/
> >
> > The staging repo:
> > https://repository.apache.org/content/repositories/orgapachedubbo-1167
> >
> > Git tag for the release:
> > https://github.com/apache/dubbo-spi-extensions/tree/v2.7.8.3
> >
> > Hash for the release tag:
> > d3b1b0292b164b638be28dfcee2eae6a617d1267
> >
> > Release Notes:
> > https://github.com/apache/dubbo-spi-extensions/releases/tag/v2.7.8.3
> >
> > The artifacts have been signed with Key 21C12FEAC580F98D, which can be
> > found in the keys file:
> > https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> >
> > The vote will be open for at least 72 hours or until necessary number of
> > votes are reached.
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > 1.
> >
> https://github.com/apache/dubbo-spi-extensions/tree/v2.7.8.3/dubbo-api-docs
> >
> > Thanks,
> > The Apache Dubbo Team
>


-- 

Best Regard!
cvitory

Re: [VOTE] Accept the donation of dubbo-go-pixiu

[victory]

+1 Accept

Xin Wang  于2021年3月15日周一 上午9:15写道：

> +1 Accept
>
> joezou  于2021年3月14日周日 下午10:44写道：
>
> > +1 Accept
> >
> > stocks alex  于2021年3月13日周六 下午9:20写道：
> >
> > > +1 Accept
> > >
> > > wongoo  于2021年3月13日周六 下午7:24写道：
> > >
> > > > Hi All,
> > > >
> > > > This is a formal vote to donate dubbogo/dubbo-go-pixiu[1] to apache.
> > > >
> > > > dubbo-go-pixiu is a gateway based on dubbo-go. It provides a general
> > > > solution that supports calling dubbo services through other
> protocols.
> > At
> > > > present, it supports HTTP and gRPC[developing].
> > > >
> > > > All contributors[3] agree to donate it to the Dubbo community, and
> have
> > > > already signed the ICLA. In the discussion[2], the community also
> > > supports
> > > > the donation.
> > > >
> > > >
> > > > Please vote:
> > > > [ ] +1 Accept
> > > > [ ] +0 No Opinion
> > > > [ ] -1 Reject because...
> > > >
> > > >
> > > > [1] https://github.com/dubbogo/dubbo-go-pixiu/
> > > > [2]
> > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/r765a243e534ff36f524227776a8ab7c067678d1952141a4cf461200c%40%3Cdev.dubbo.apache.org%3E
> > > > [3] pixiu contributors:
> > > > - williamfeng323, ICLA signed
> > > > - mark4z, ICLA signed
> > > > - xiaoliu10, ICLA signed
> > > > - oaoit, ICLA signed
> > > > - xianlezheng, ICLA signed
> > > > - ztelur, ICLA signed
> > > > - zhangshen023, ICLA signed
> > > > - cityiron/IronCity, dubbo commiter
> > > > - zouyx, dubbo PMC
> > > > - pantianying, dubbo commiter
> > > > - AlexStocks, dubbo PMC
> > > >
> > > > --
> > > > Regards,
> > > > Wongoo
> > > >
> > >
> >
>


-- 

Best Regard!
cvitory

Re: [VOTE]: Release Apache dubbo-go v1.5.1

[victory]

+1 binding.

I checked:
  - Signatures and hashes are good
  - All files no binary
  - LICENSE and NOTICE exist and looks good.
  - All unit tests can be passed

>

Re: [VOTE]: Accept dubbogo/getty donation

[victory]

+1

The getty is the core component in dubbo-go.  I look forward to it joining
Apache soon.

stocks alex  于2020年7月22日周三 下午10:07写道：

> to Mr Justin,
>
> IMO we have completed all the agreements. I will show the vote result this
> weekend.
>
> stocks alex  于2020年7月22日周三 下午10:01写道：
>
> > To Mr Justin, the contributors info is as follows,
> >
> > Github IDChinese NameApache Committer(y/n)ICLA Sign Date
> > alexstocks Zhao Xin y March 29, 2019
> > fangyincheng Fang Yincheng y March 29, 2019
> > pantianying Pan Tianying y Sep, 2019
> > wongoo Yang Liu y March 29, 2019
> > zouyx Zou Yixian y Feb, 2020
> > gaoxinge Gao Xinge y March 29, 2019
> > watermelo He Qun n May 21, 2020
> > u0x01 Zhou Ziqing n March 29, 2019
> > wenxuwan Wang Wenxue n May 21, 2020
> >
> > Justin Mclean  于2020年7月22日周三 上午7:56写道：
> >
> >> Hi,
> >>
> >> > all contributors as follows except [JerryZhou343](
> >> > https://github.com/JerryZhou343) has signed the ICLA.
> >>
> >> That seems fine. It would be best to list their names as the ICLA don’t
> >> list GitHub accounts.
> >>
> >> > I can not contact with JerryZhou343 who just has one commit
> >> >
> >>
> https://github.com/dubbogo/getty/commit/0c47783532dd2dc9995d8ebd850dcda09856e939
> >>
> >> I don’t think that is a concern.
> >>
> >> Thanks,
> >> Justin
> >
> >
>


-- 

Best Regard!
cvitory

Re: [VOTE] Release Apache Dubbo-Hessian-Lite 3.2.9 RC1

[victory]

+1 (binding)

- signatures and hashes are fine
- LICENSE and NOTICE good
- compile and unit test fine
- the hash of release tag is 8acc674e9572e51aed2b75ae186536025e3c9d0f.

Jun Liu  于2020年7月22日周三 下午3:27写道：

> This vote has already lasted for 72+ hours, I just self checked the
> following parts:
> * Hashes and signatures are good
> * Can compile from source
> * All files no binaries
> * All files has standard LICENSE headers
> * NOTICE and LICENSE exist
>
> So I vote +1
>
> We still need two more +1 votes.
>
> Jun
>
> > On Jul 17, 2020, at 11:37 AM, Jun Liu  wrote:
> >
> > Hello Dubbo Community,
> >
> > This is a call for a vote to release Apache Dubbo-hessian-lite version
> 3.2.9
> >
> > The release candidates:
> > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-hessian-lite/
> >
> > Git tag for the release:
> > https://github.com/apache/dubbo-hessian-lite/tree/v3.2.9
> >
> > The hash for the release tag:
> > 6ebfa92ecad6bb6c4ab412c26382596e7b2bbada
> >
> > Release Notes:
> > https://github.com/apache/dubbo-hessian-lite/releases/tag/v3.2.9
> >
> > The artifacts have been signed with Key: 28681CB1, which can be found in
> > the keys file:
> > https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> >
> > The vote will be open for at least 72 hours or until the necessary
> number of
> > votes are reached.
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > The Apache Dubbo Team
>
>

-- 

Best Regard!
cvitory

Re: [VOTE] Release Apache Dubbo-Hessian-Lite 3.2.8 RC1

[victory]

+1 binding,

I checked:
* signatures and hashes are good
* compile and unit test is fine
* LICENSE and NOTICE exist.

Best Regards!
cvictory

Re: [VOTE]: Release Apache Dubbo Spring Boot 2.7.7 [RC1]

[victory]

+1 binding,

I checked:
* signatures and hashes are good
* compile and unit test is fine
* LICENSE and NOTICE exist.  In NOTICE file, the sentence "Copyright
2018-2019 The Apache Software Foundation" contains 2019, it would be 2020.
* release tag and release note are fine.

Jun Liu  于2020年6月2日周二 上午11:33写道：

> +1 binding,
>
> I checked:
> * signatures and hashes are good
> * unit tests pass on my Mac with jdk1.8
> * LICENSE and NOTICE exist
> * all files have ASF header (mvn clean test -Drat.skip=true
> -Dcheckstyle.skip=true)
> * tag and release note are fine
>
> Jun
>
> > On May 29, 2020, at 3:01 PM, Mercy Ma  wrote:
> >
> > Hi, All
> >
> > This is a call for a vote to release Apache Dubbo Spring Boot version
> 2.7.7.
> >
> > The release candidates (there will be only source release in this
> version):
> > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-spring-boot/2.7.7/ <
> > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-spring-boot/2.7.7/>
> >
> > Git tag for the release:
> > https://github.com/apache/dubbo-spring-boot-project/tree/2.7.7 <
> > https://github.com/apache/dubbo-spring-boot-project/tree/2.7.7>
> >
> > Hash for the release tag:
> > 2dc6e372b921019d40be713152f76c14b81bfdb8
> >
> > Release Notes:
> > https://github.com/apache/dubbo-spring-boot-project/releases/tag/2.7.7 <
> > https://github.com/apache/dubbo-spring-boot-project/releases/tag/2.7.7>
> >
> > The artifacts have been signed with Key: 28681CB1, which can be
> > found in the keys file:
> > https://dist.apache.org/repos/dist/dev/dubbo/KEYS <
> > https://dist.apache.org/repos/dist/dev/dubbo/KEYS>
> >
> > The vote will be open for at least 72 hours or until the necessary
> number of
> > votes are reached.
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > The Apache Dubbo Team
>
>

-- 

Best Regard!
cvitory

Re: [VOTE]: Release Apache Dubbo Spring Boot 2.7.6 [RC1]

[victory]

+1 binding

 I checked:
- signatures and hashes fine
- no unexpected binary files
- can compile from source
- unit test success
- LICENSE and NOTICE exists

And I found there is a sentence  'Copyright 2018-*2019*'  in the NOTICE .
I think we should fix it in next release.


Best Regard!
victory

Re: [VOTE] Release Apache Dubbo-Hessian-Lite 3.2.7 RC3

[victory]

+1 binding

 I checked:
- signatures and hashes fine
- no unexpected binary files
- can compile from source
- unit test success
- LICENSE and NOTICE exists


Best Regard!
cvictory

Re: [VOTE]: Release Apache dubbo-go v1.3.0 RC1

[victory]

+1 binding

I checked:
- signatures and hashes are OK
- all source files have ASF headers
- run go test, and all tests passed.

Ian Luo  于2020年1月22日周三 上午11:48写道：

> I checked the following items. I vote +1 (binding) to this release.
>
> [v]  Are release files in correct location?
> [v] Are the digital signature and hashes correct?
> [v] Do LICENSE and NOTICE files exists?
> [v] Is the LICENSE and NOTICE text correct?
> [v] Is the NOTICE year correct?
> [x] Un-included software dependencies are not mentioned in LICENSE or
> NOTICE?
> [x] License information is not mentioned in NOTICE?
> [x] Is there any 3rd party code contained inside the release? If so:
>   [ ] Does the software have a compatible license?
>   [ ] Are all software licenses mentioned in LICENSE?
>   [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
>   Is any of this code Apache licensed? Do they have NOTICE files? If so:
> [ ] Have relevant parts of those NOTICE files been added to this NOTICE
> file?
> [ ] Do all source files have ASF headers?
> [v] Do the contents of the release match with what's tagged in version
> control?
> [x] Are there any unexpected binary files in the release?
> [v] Can you compile from source? Are the instruction clear?
>
> The year in NOTICE should be 2020.
>
> Is the issue minor?
> [v] Yes [] No [] Unsure
>
>
> Could it possibly be fixed in the next release?
> [v] Yes [ ] No [ ] Unsure
>
> I vote with:
> [v] +1 release the software
> [ ] +0 not sure if it should be released
> [ ] -1 don’t release the software because..
>
> Regards,
> -Ian.
>
> On Sat, Jan 18, 2020 at 11:52 PM 方银城  wrote:
>
> > Hello Dubbo/Dubbogo Community,
> >
> >   This is a call for vote to release Apache dubbo-go version v1.3.0 RC1.
> >
> >   The release candidates:
> > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.3.0-rc1/
> >
> >   Git tag for the release: https://github.com/apache/dubbo-go/tree/1.3.0
> >
> >   Hash for the release tag: 1147a82c2f62d92764a98ef998ad2ad2b17928eb
> >
> >   Release Notes: https://github.com/apache/dubbo-go/blob/1.3/CHANGE.md
> >
> >   The artifacts have been signed with Key :5862908F9A627BAA, which can be
> > found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> >
> >   The vote will be open for at least 72 hours or until necessary number
> of
> > votes are reached.
> >
> >  Please vote accordingly:
> >  [ ] +1 approve
> >  [ ] +0 no opinion
> >  [ ] -1 disapprove with the reason
> >
> >  Thanks,
> >  The Apache Dubbo-go Team
> >
>


-- 

Best Regard!
cvitory

Re: [VOTE] Release Apache Dubbo 2.7.5 RC3

[victory]

I have checked the following items. I vote +1 (binding) to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Download the source and run unit test successfully.


zhenya Sun  于2019年12月27日周五 上午8:57写道：

> +1
>
>
> from my iphone！
> On 12/26/2019 17:01, Mercy Ma wrote:
> +1, however, is it dependent on the Docker environment for test cases？
>
> Kind regards,
> Mercy Ma
>
> On Tue, Dec 24, 2019 at 11:06 AM Jun Liu  wrote:
>
> > Hello Dubbo Community,
> >
> > This is a call for vote to release Apache Dubbo version 2.7.5.
> >
> > The release candidates:
> > https://dist.apache.org/repos/dist/dev/dubbo/dubbo/2.7.5/RC3
> >
> > The staging repo:
> > https://repository.apache.org/content/repositories/orgapachedubbo-1053
> > https://repository.apache.org/content/repositories/orgapachedubbo-1054
> >
> > Git tag for the release:
> > https://github.com/apache/dubbo/tree/dubbo-2.7.5
> >
> > Hash for the release tag:
> > 5ae160ad7b6b1ec67dad14bce819e5d27353cf21
> >
> > Release Notes:
> > https://github.com/apache/dubbo/blob/2.7.5-release/CHANGES.md#275
> >
> > The artifacts have been signed with Key: 28681CB1, which can be
> > found in the keys file:
> > https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> >
> > The vote will be open for at least 72 hours or until necessary number of
> > votes are reached.
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > The Apache Dubbo Team
> >
> >
>
> --
>
> *Mercy Ma*
> GMail:mercybl...@gmail.com
> Yahoo: mercy.bl...@yahoo.com
> Wetchat: mercyblitz-1985
> Twitter : @mercyblitz 
> Blog: https://mercyblitz.github.io/
>


-- 

Best Regard!
cvitory

Re: [VOTE]: Release Apache Dubbo 2.7.4.1 [RC1]

[victory]

Hi,

+1 binding

I checked:
- signatures and hashes fine
- no unexpected binary files
- can compile from source
- unit test success


From: victory
Official Account: GeekVictory

Ian Luo  于2019年10月25日周五 上午11:31写道：

> I checked the following items. I vote +1 to this release.
>
> [v]  Are release files in correct location?
> [v] Are the digital signature and hashes correct?
> [v] Do LICENSE and NOTICE files exists?
> [v] Is the LICENSE and NOTICE text correct?
> [v] Is the NOTICE year correct?
> [x] Un-included software dependencies are not mentioned in LICENSE or
> NOTICE?
> [x] License information is not mentioned in NOTICE?
> [v] Is there any 3rd party code contained inside the release? If so:
>   [v] Does the software have a compatible license?
>   [v] Are all software licenses mentioned in LICENSE?
>   [v] Is the full text of the licenses (or pointers to it) in LICENSE?
>   Is any of this code Apache licensed? Do they have NOTICE files? If so:
> [v] Have relevant parts of those NOTICE files been added to this NOTICE
> file?
> [v] Do all source files have ASF headers?
> [v] Do the contents of the release match with what's tagged in version
> control?
> [x] Are there any unexpected binary files in the release?
> [v] Can you compile from source? Are the instruction clear?
>
> Is the issue minor?
> [ ] Yes [ ] No [ ] Unsure
>
> Could it possibly be fixed in the next release?
> [ ] Yes [ ] No [ ] Unsure
>
> I vote with:
> [v] +1 release the software
> [ ] +0 not sure if it should be released
> [ ] -1 don’t release the software because...
>
> Thanks,
> -Ian.
>
> On Tue, Oct 22, 2019 at 8:54 PM Jun Liu  wrote:
>
> > Hello Dubbo Community,
> >
> > This is a call for vote to release Apache Dubbo version 2.7.4.1.
> >
> > The release candidates:
> > https://dist.apache.org/repos/dist/dev/dubbo/2.7.4.1/
> >
> > The staging repo:
> > https://repository.apache.org/content/repositories/orgapachedubbo-1046
> >
> > Git tag for the release:
> > https://github.com/apache/dubbo/tree/dubbo-2.7.4.1
> >
> > Hash for the release tag:
> > 7957e268fbdf8cb214c8205f57f778e388366f48
> >
> > Release Notes:
> > https://github.com/apache/dubbo/blob/dubbo-2.7.4.1/CHANGES.md#2741
> >
> > The artifacts have been signed with Key: 28681CB1, which can be
> > found in the keys file:
> > https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> >
> > The vote will be open for at least 72 hours or until necessary number of
> > votes are reached.
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > The Apache Dubbo Team
> >
>


-- 

Best Regard!
cvitory

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC2]

[victory]

I have found the problem, and I think it should be fixed as soon as
possible.
We will release dubbo-2.7.4.1 in this week

victory  于2019年10月21日周一 下午4:15写道：

> I will check this problem, and I will give you reply.
> If this problem is  servere and urgent,  I will try to fix it in a fix
> version on this week.
>
> Jason Joo  于2019年10月21日周一 下午3:26写道：
>
>> And I'm ok to file a NEW issue but will anyone to discuss and follow
>> together?
>>
>> It seems that most guys are busy currently. Maybe for the event of 11.11?
>> This issue would affect quite a large amount of upgraded users.
>>
>> An active issue needs our following up in time so we can do it better.
>>
>> And I also spend quite a lot of time in debugging and analyzing related
>> codes to implement a multiple registries configuration. This is also
>> undocumented and I feel a little buggy after trying all possible ways.
>> Thank god finally we got one correct way to achieve that.
>> And is this also necessary to file an issue for discussing if anyone
>> liked involving in?
>>
>> best regards,
>>
>> Jason
>>
>> > On Oct 21, 2019, at 15:04, bailei  wrote:
>> >
>> > IMO, it is quite serve.
>> >
>> > Step 1: Upgrade dubbo to 2.7.4 in dubbo-samples-api.
>> > Step 2: Start `org.apache.dubbo.samples.provider.Application`. Will
>> report an NPE problem.
>> >
>> >> 在 2019年10月21日，下午2:30，victory  写道：
>> >>
>> >> I have released dubbo-2.7.4 two days ago.
>> >> If you have some problem, please file an issue on
>> >> https://github.com/apache/dubbo/issues
>> >> If your problem is very severe,  we will try to fix in next release as
>> soon
>> >> as possible.
>> >>
>> >> Jason Joo  于2019年10月21日周一 上午8:49写道：
>> >>
>> >>> -1.
>> >>>
>> >>> So will it be included in 2.7.4 or 2.7.5?
>> >>>
>> >>> One of our project using annotations came to introduce multiple
>> >>> registries. But we found that there was a bug on subscribing same
>> interface
>> >>> from different registries before 2.7.3(inclusive) util #5033(
>> >>> https://github.com/apache/dubbo/pull/5033) had been merged.
>> >>>
>> >>> But after updating to branch of 2.7.4 we continue to suffer the NPE
>> issue
>> >>> (Location AbstractInterfaceConfig.useRegistryForConfigIfNecessary
>> which is
>> >>> mentioned by @bailei).
>> >>>
>> >>> We will make a temporary build first in our private repository and I
>> >>> suggest it is necessary being included in 2.7.4. Btw, `sonymoon` has
>> >>> already given a fix in his repo (
>> >>>
>> https://github.com/sonymoon/dubbo/commit/7b73f52349d7a37572bb724b28ec62e08d3a29fd
>> >>> ).
>> >>>
>> >>> And more pls consider that how to solve the scanning problem
>> mentioned in
>> >>> issue #4895 (https://github.com/apache/dubbo/pull/4895) because it is
>> >>> long time no response. It is not as urgent as the NPE issue.
>> >>>
>> >>> And I will close #4199 now and I think we'd better to describe it in
>> >>> document for those which have mixed versions deployed in environment
>> and
>> >>> also have implemented MonitorService. (The simple solution is just
>> copying
>> >>> the legacy interface into project and public them together).
>> >>>
>> >>> best regards,
>> >>>
>> >>> Jason
>> >>>
>> >>>> On Oct 20, 2019, at 15:00, bailei  wrote:
>> >>>>
>> >>>> -1.
>> >>>> I don’t know if I am qualified from voting.
>> >>>> Is 2.7.4 released?
>> >>>> I think there is a issue need to be checked (
>> >>> https://github.com/apache/dubbo/issues/5186 <
>> >>> https://github.com/apache/dubbo/issues/5186>). Fix me if I was wrong.
>> >>>>
>> >>>>
>> >>>>> 在 2019年10月18日，上午9:46，victory  写道：
>> >>>>>
>> >>>>> We’ve received 3 +1 binding votes and 2 +1 non-binding vote: +1
>> binding,
>> >>>>> Mercy Ma +1 binding, Justin Mclean +1 binding, Jun Liu +1
>> non-binding,
>> >>> Lonre
>> >>>>> Wang
>> >>>>> +1 non-binding ,  郑泽超
>> >>>>>
>> >>>>> I will release dubbo-2.7.4 today. Best regards, The Apache Dubbo
>> >>>>> (Incubating) Team
>> >>>>>
>> >>>>> Justin Mclean  于2019年10月16日周三 上午10:58写道：
>> >>>>>
>> >>>>>> Hi,
>> >>>>>>
>> >>>>>> +1 (binding)
>> >>>>>>
>> >>>>>> I checked:
>> >>>>>> - signatures and hashes fine
>> >>>>>> - LICENSE and NOTICE OK
>> >>>>>> - no unexpected binary files
>> >>>>>> - source files have ASF headers
>> >>>>>> - can compile from source
>> >>>>>>
>> >>>>>> RE the software grant normally when a copyright is removed and the
>> >>> headers
>> >>>>>> replaced you need to put something in NOTICE saying this was done.
>> If
>> >>>>>> original headers are left in there then this should be mentioned in
>> >>>>>> LICENSE. I suggest you fix this in the next release
>> >>>>>>
>> >>>>>> Thanks,
>> >>>>>> Justin
>> >>>>>
>> >>>>>
>> >>>>>
>> >>>>> --
>> >>>>>
>> >>>>> Best Regard!
>> >>>>> cvitory
>> >>>>
>> >>>
>> >>>
>> >>
>> >> --
>> >>
>> >> Best Regard!
>> >> cvitory
>>
>>
>
> --
>
> Best Regard!
> cvitory
>


-- 

Best Regard!
cvitory

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC2]

[victory]

I will check this problem, and I will give you reply.
If this problem is  servere and urgent,  I will try to fix it in a fix
version on this week.

Jason Joo  于2019年10月21日周一 下午3:26写道：

> And I'm ok to file a NEW issue but will anyone to discuss and follow
> together?
>
> It seems that most guys are busy currently. Maybe for the event of 11.11?
> This issue would affect quite a large amount of upgraded users.
>
> An active issue needs our following up in time so we can do it better.
>
> And I also spend quite a lot of time in debugging and analyzing related
> codes to implement a multiple registries configuration. This is also
> undocumented and I feel a little buggy after trying all possible ways.
> Thank god finally we got one correct way to achieve that.
> And is this also necessary to file an issue for discussing if anyone liked
> involving in?
>
> best regards,
>
> Jason
>
> > On Oct 21, 2019, at 15:04, bailei  wrote:
> >
> > IMO, it is quite serve.
> >
> > Step 1: Upgrade dubbo to 2.7.4 in dubbo-samples-api.
> > Step 2: Start `org.apache.dubbo.samples.provider.Application`. Will
> report an NPE problem.
> >
> >> 在 2019年10月21日，下午2:30，victory  写道：
> >>
> >> I have released dubbo-2.7.4 two days ago.
> >> If you have some problem, please file an issue on
> >> https://github.com/apache/dubbo/issues
> >> If your problem is very severe,  we will try to fix in next release as
> soon
> >> as possible.
> >>
> >> Jason Joo  于2019年10月21日周一 上午8:49写道：
> >>
> >>> -1.
> >>>
> >>> So will it be included in 2.7.4 or 2.7.5?
> >>>
> >>> One of our project using annotations came to introduce multiple
> >>> registries. But we found that there was a bug on subscribing same
> interface
> >>> from different registries before 2.7.3(inclusive) util #5033(
> >>> https://github.com/apache/dubbo/pull/5033) had been merged.
> >>>
> >>> But after updating to branch of 2.7.4 we continue to suffer the NPE
> issue
> >>> (Location AbstractInterfaceConfig.useRegistryForConfigIfNecessary
> which is
> >>> mentioned by @bailei).
> >>>
> >>> We will make a temporary build first in our private repository and I
> >>> suggest it is necessary being included in 2.7.4. Btw, `sonymoon` has
> >>> already given a fix in his repo (
> >>>
> https://github.com/sonymoon/dubbo/commit/7b73f52349d7a37572bb724b28ec62e08d3a29fd
> >>> ).
> >>>
> >>> And more pls consider that how to solve the scanning problem mentioned
> in
> >>> issue #4895 (https://github.com/apache/dubbo/pull/4895) because it is
> >>> long time no response. It is not as urgent as the NPE issue.
> >>>
> >>> And I will close #4199 now and I think we'd better to describe it in
> >>> document for those which have mixed versions deployed in environment
> and
> >>> also have implemented MonitorService. (The simple solution is just
> copying
> >>> the legacy interface into project and public them together).
> >>>
> >>> best regards,
> >>>
> >>> Jason
> >>>
> >>>> On Oct 20, 2019, at 15:00, bailei  wrote:
> >>>>
> >>>> -1.
> >>>> I don’t know if I am qualified from voting.
> >>>> Is 2.7.4 released?
> >>>> I think there is a issue need to be checked (
> >>> https://github.com/apache/dubbo/issues/5186 <
> >>> https://github.com/apache/dubbo/issues/5186>). Fix me if I was wrong.
> >>>>
> >>>>
> >>>>> 在 2019年10月18日，上午9:46，victory  写道：
> >>>>>
> >>>>> We’ve received 3 +1 binding votes and 2 +1 non-binding vote: +1
> binding,
> >>>>> Mercy Ma +1 binding, Justin Mclean +1 binding, Jun Liu +1
> non-binding,
> >>> Lonre
> >>>>> Wang
> >>>>> +1 non-binding ,  郑泽超
> >>>>>
> >>>>> I will release dubbo-2.7.4 today. Best regards, The Apache Dubbo
> >>>>> (Incubating) Team
> >>>>>
> >>>>> Justin Mclean  于2019年10月16日周三 上午10:58写道：
> >>>>>
> >>>>>> Hi,
> >>>>>>
> >>>>>> +1 (binding)
> >>>>>>
> >>>>>> I checked:
> >>>>>> - signatures and hashes fine
> >>>>>> - LICENSE and NOTICE OK
> >>>>>> - no unexpected binary files
> >>>>>> - source files have ASF headers
> >>>>>> - can compile from source
> >>>>>>
> >>>>>> RE the software grant normally when a copyright is removed and the
> >>> headers
> >>>>>> replaced you need to put something in NOTICE saying this was done.
> If
> >>>>>> original headers are left in there then this should be mentioned in
> >>>>>> LICENSE. I suggest you fix this in the next release
> >>>>>>
> >>>>>> Thanks,
> >>>>>> Justin
> >>>>>
> >>>>>
> >>>>>
> >>>>> --
> >>>>>
> >>>>> Best Regard!
> >>>>> cvitory
> >>>>
> >>>
> >>>
> >>
> >> --
> >>
> >> Best Regard!
> >> cvitory
>
>

-- 

Best Regard!
cvitory

[ANNOUNCE] Apache Dubbo version 2.7.4 Released

[victory]

Hello Community,

The Apache Dubbo team is pleased to announce that the 2.7.4 has been
released.

Apache Dubbo™  is a high-performance, java based, open source
RPC framework. Dubbo offers three key functionalities, which include
interface based remote call, fault tolerance & load balancing, and
automatic service registration & discovery.

Both the source release[1] and the maven binary release[2] are available
now, you can also find the detailed release notes in here[3].


If you have any usage questions, or have problems when upgrading or find
any problems about enhancements included in this release, please don’t
hesitate to let us know by sending feedback to this mailing list or filing
an issue on GitHub[4].



[1] http://dubbo.apache.org/en-us/blog/download.html
[2] http://central.maven.org/maven2/org/apache/dubbo
[3] https://github.com/apache/dubbo/releases
[4] https://github.com/apache/dubbo/issues

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC2]

[victory]

I have released dubbo-2.7.4 two days ago.
If you have some problem, please file an issue on
https://github.com/apache/dubbo/issues
If your problem is very severe,  we will try to fix in next release as soon
as possible.

Jason Joo  于2019年10月21日周一 上午8:49写道：

> -1.
>
> So will it be included in 2.7.4 or 2.7.5?
>
> One of our project using annotations came to introduce multiple
> registries. But we found that there was a bug on subscribing same interface
> from different registries before 2.7.3(inclusive) util #5033(
> https://github.com/apache/dubbo/pull/5033) had been merged.
>
> But after updating to branch of 2.7.4 we continue to suffer the NPE issue
> (Location AbstractInterfaceConfig.useRegistryForConfigIfNecessary which is
> mentioned by @bailei).
>
> We will make a temporary build first in our private repository and I
> suggest it is necessary being included in 2.7.4. Btw, `sonymoon` has
> already given a fix in his repo (
> https://github.com/sonymoon/dubbo/commit/7b73f52349d7a37572bb724b28ec62e08d3a29fd
> ).
>
> And more pls consider that how to solve the scanning problem mentioned in
> issue #4895 (https://github.com/apache/dubbo/pull/4895) because it is
> long time no response. It is not as urgent as the NPE issue.
>
> And I will close #4199 now and I think we'd better to describe it in
> document for those which have mixed versions deployed in environment and
> also have implemented MonitorService. (The simple solution is just copying
> the legacy interface into project and public them together).
>
> best regards,
>
> Jason
>
> > On Oct 20, 2019, at 15:00, bailei  wrote:
> >
> > -1.
> > I don’t know if I am qualified from voting.
> > Is 2.7.4 released?
> > I think there is a issue need to be checked (
> https://github.com/apache/dubbo/issues/5186 <
> https://github.com/apache/dubbo/issues/5186>). Fix me if I was wrong.
> >
> >
> >> 在 2019年10月18日，上午9:46，victory  写道：
> >>
> >> We’ve received 3 +1 binding votes and 2 +1 non-binding vote: +1 binding,
> >> Mercy Ma +1 binding, Justin Mclean +1 binding, Jun Liu +1 non-binding,
> Lonre
> >> Wang
> >> +1 non-binding ,  郑泽超
> >>
> >> I will release dubbo-2.7.4 today. Best regards, The Apache Dubbo
> >> (Incubating) Team
> >>
> >> Justin Mclean  于2019年10月16日周三 上午10:58写道：
> >>
> >>> Hi,
> >>>
> >>> +1 (binding)
> >>>
> >>> I checked:
> >>> - signatures and hashes fine
> >>> - LICENSE and NOTICE OK
> >>> - no unexpected binary files
> >>> - source files have ASF headers
> >>> - can compile from source
> >>>
> >>> RE the software grant normally when a copyright is removed and the
> headers
> >>> replaced you need to put something in NOTICE saying this was done. If
> >>> original headers are left in there then this should be mentioned in
> >>> LICENSE. I suggest you fix this in the next release
> >>>
> >>> Thanks,
> >>> Justin
> >>
> >>
> >>
> >> --
> >>
> >> Best Regard!
> >> cvitory
> >
>
>

-- 

Best Regard!
cvitory

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC2]

[victory]

We’ve received 3 +1 binding votes and 2 +1 non-binding vote: +1 binding,
Mercy Ma +1 binding, Justin Mclean +1 binding, Jun Liu +1 non-binding, Lonre
Wang
+1 non-binding ,  郑泽超

I will release dubbo-2.7.4 today. Best regards, The Apache Dubbo
(Incubating) Team

Justin Mclean  于2019年10月16日周三 上午10:58写道：

> Hi,
>
> +1 (binding)
>
> I checked:
> - signatures and hashes fine
> - LICENSE and NOTICE OK
> - no unexpected binary files
> - source files have ASF headers
> - can compile from source
>
> RE the software grant normally when a copyright is removed and the headers
> replaced you need to put something in NOTICE saying this was done. If
> original headers are left in there then this should be mentioned in
> LICENSE. I suggest you fix this in the next release
>
> Thanks,
> Justin



-- 

Best Regard!
cvitory

[VOTE]: Release Apache Dubbo 2.7.4 [RC2]

[victory]

Hello Dubbo Community,

This is a call for vote to release Apache Dubbo version 2.7.4.

The release candidates:
https://dist.apache.org/repos/dist/dev/dubbo/2.7.4/

The staging repo:
https://repository.apache.org/content/repositories/orgapachedubbo-1045

Git tag for the release:
https://github.com/apache/dubbo/tree/dubbo-2.7.4

Hash for the release tag:
1d7e8fac4523d7482d5f2d8f25dd024807e3d3d5

Release Notes:
https://github.com/apache/dubbo/releases/tag/dubbo-2.7.4

The artifacts have been signed with Key : 35D071D458D03BB4, which can be
found in the keys file:
https://dist.apache.org/repos/dist/dev/dubbo/KEYS

The vote will be open for at least 72 hours or until necessary number of
votes are reached.

Please vote accordingly:

[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason

Thanks,
The Apache Dubbo Team

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC1]

[victory]

Thanks guys，

I will repost a new vote for 2.7.4 release today.

Jun Liu  于2019年10月12日周六 下午2:18写道：

> Hey, Cvictory
>
> Since we have submitted the SGA, could you please help to start a new vote?
>
> Jun
>
> On Sep 25, 2019, at 4:27 PM, victory  wrote:
>
> Hello Dubbo Community,
>
> This is a call for vote to release Apache Dubbo version 2.7.4.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/2.7.4/
>
> The staging repo:
> https://repository.apache.org/content/repositories/orgapachedubbo-1041
>
> Git tag for the release:
> https://github.com/apache/dubbo/tree/dubbo-2.7.4
>
> Hash for the release tag:
> 4ec4b244902b753d3aa3fffc490d77f4b326667b
>
> Release Notes:
> https://github.com/apache/dubbo/releases/tag/dubbo-2.7.4
>
> The artifacts have been signed with Key : A3A1CA7A5D4A3981, which can be
> found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo Team
>
>
>

-- 

Best Regard!
cvitory

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC1]

[victory]

As noted above, the license of
https://github.com/alibaba/spring-context-support is changed to 'Apache
License 2.0'.
There are some files copied from spring-context-support to apache dubbo.

How about we add some declaration about this util java files in *LICENSE*
file.  For some code referenced from netty(Apache License 2.0),  we add
some declaration in https://github.com/apache/dubbo/blob/master/LICENSE like
this :









*This product contains a modified portion of 'Netty', an event-driven
asynchronous network application framework also under a "Apache
License 2.0" license, see
https://github.com/netty/netty/blob/4.1/LICENSE.txt
: *
io.netty.util.concurrent.FastThreadLocal *
io.netty.util.internal.InternalThreadLocalMap * io.netty.util.Timer *
io.netty.util.TimerTask * io.netty.util.Timeout *
io.netty.util.HashedWheelTimer*


What do you think?






Jun Liu  于2019年10月4日周五 下午2:55写道：

> Hi,
>
> I just went back and carefully checked the previous discussion on this
> thread and the classes in the ‘util’ package, there do still have some
> classes having the same problem. @Mercy, could you pease help to check this
> issue again?
>
> Personally, I think we have two ways to solve:
> 1. Rewrite the code completely.
> 2. Ask the owner for a software grant
>
> > If they do then we’ll get permission from them to be able to use it.
> Normally external code needs a software grant before it can be accepted
> into an Apache project.
>
> If we prefer the second way, what kind of permission should we ask from
> them?
>
> Jun
>
> > On Sep 30, 2019, at 8:41 PM, Justin Mclean 
> wrote:
> >
> > HI,
> >
> >> I checked the commit[1], several methods were removed from the file. I
> think it’s ok to proceed now if the other codes were originally written by
> yourself. I can help to cancel this vote and start a new one with the
> latest codes.
> >>
> >> Before we doing that, let’s see what other people more familiar and
> sensitive with IP Clearance will say, especially opinions from Justin.
> >
> > I only see one file changed by that PR, there are several files that
> were copied from that repo (please correct me if that not the case), so I
> think we still have an issue here.
> >
> > Thanks,
> > Justin
>
>

-- 

Best Regard!
cvitory

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC1]

[victory]

Looking through the code I found a few other minor things that may need to
be updated:
- References to internal JIRA
http://code.alibabatech.com/jira/browse/DUBBO-XXX that I cannot access.
- Reference to this URL [2]
- Reference to this URL [3] in tests. This gives a 404 so I’m not sure if
those test pass. there are also there reference to http://dubbo.io.

All of above problem exist for a long time and it is used for testcase.  So
I think the problem can be optimized in next release.
I have posted two new issues for new release :
https://github.com/apache/dubbo/issues/5118
https://github.com/apache/dubbo/issues/511
9




Mercy  于2019年9月26日周四 下午3:37写道：

>
> > If you are the only contributor (which seems to be the case) that would
> be one way of dealing with it. The Dubbo LICENSE file would need to change
> if that was done.
>
> Yes, I'm the only one contriubtor of this project and its LICENSE file
> has been changed to be "Apache License 2.0" :
>
> https://github.com/alibaba/spring-context-support/blob/master/LICENSE
>
>
> Is it fine?
>
>
> Kind regards,
>
> Mercy
>
>

-- 

Best Regard!
cvitory

Re: [VOTE]: Release Apache dubbo-go v1.1.0 RC2

[victory]

+1

I checked the following items:

[√] Do LICENSE and NOTICE files exists?
[√] Is the LICENSE and NOTICE text correct?
[√] Is the NOTICE year correct?
[√] Do all source files have ASF headers?
[√] Do the contents of the release match with what's tagged in version
control?
[√] Can you compile from source?
I could compile successfully but there's failed units test.  I run the unit
test refer to :https://github.com/apache/dubbo-go#running-unit-tests .
But I think it is not matter, the test can be fixed in next release.


I vote with:
[√] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because...

[VOTE]: Release Apache Dubbo 2.7.4 [RC1]

[victory]

Hello Dubbo Community,

This is a call for vote to release Apache Dubbo version 2.7.4.

The release candidates:
https://dist.apache.org/repos/dist/dev/dubbo/2.7.4/

The staging repo:
https://repository.apache.org/content/repositories/orgapachedubbo-1041

Git tag for the release:
https://github.com/apache/dubbo/tree/dubbo-2.7.4

Hash for the release tag:
4ec4b244902b753d3aa3fffc490d77f4b326667b

Release Notes:
https://github.com/apache/dubbo/releases/tag/dubbo-2.7.4

The artifacts have been signed with Key : A3A1CA7A5D4A3981, which can be
found in the keys file:
https://dist.apache.org/repos/dist/dev/dubbo/KEYS

The vote will be open for at least 72 hours or until necessary number of
votes are reached.

Please vote accordingly:

[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason

Thanks,
The Apache Dubbo Team

2.7.4 release plan

[victory]

Hello everyone,

 I volunteer to take release manager role for 2.7.4 release. The main
feature of 2.7.4 is to fix some bug and optimize the feature so that we can
make 2.7.x more stable.

Besides, we also have a quite long list [1] of issues targeted to 2.7.4,
which apparently need to triage to be short enough to meet to code freeze
date, Sep. 17th. Hopefully we can release 2.7.4 by Sep. 21th.


Pls. take a look at milestone 2.7.4 [1], and let me know which issues are
must have for this release. We will triage the list soon :)
https://github.com/apache/incubator-dubbo/milestone/2
7

-- 

Best Regard!
cvictory

Re: [VOTE]: Release Apache Dubbo Spring Boot 2.7.3 [RC2]

[victory]

+1 (binding)

I checked:
- signatures and hashes are good
- LICENSE and NOTICE exists and contents are good
- All files and no binary files exist
- All files has standard ASF License header
- Can compile from source
- All unit tests can pass

Mercy Ma  于2019年8月6日周二 上午11:37写道：

> Hi, All
>
> This is a call for a vote to release Apache Dubbo Spring Boot version
> 2.7.3.
>
> The release candidates (there will be only source release in this version):
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-spring-boot/2.7.3/ <
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-spring-boot/2.7.3/>
>
> Git tag for the release:
> https://github.com/apache/dubbo-spring-boot-project/tree/2.7.3 <
> https://github.com/apache/dubbo-spring-boot-project/tree/2.7.3>
>
> Hash for the release tag:
> e21ceff509337d8434abcdfe315b553d7b33afe5
>
> Release Notes:
> https://github.com/apache/dubbo-spring-boot-project/releases/tag/2.7.3 <
> https://github.com/apache/dubbo-spring-boot-project/releases/tag/2.7.3>
>
> The artifacts have been signed with Key: 28681CB1, which can be
> found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS <
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS>
>
> The vote will be open for at least 72 hours or until the necessary number
> of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo Team
>


-- 

Best Regard!
cvitory

[ANNOUNCE] Apache Dubbo version 2.7.2 Released

[victory]

Hello Community,

The Apache Dubbo team is pleased to announce that the 2.7.2 has just been
released.

Apache Dubbo™  is a high-performance, java based, open source
RPC framework. Dubbo offers three key functionalities, which include
interface based remote call, fault tolerance & load balancing, and
automatic service registration & discovery.

Both the source release[1] and the maven binary release[2] are available
now, you can also find the detailed release notes in here[3].


If you have any usage questions, or have problems when upgrading or find
any problems about enhancements included in this release, please don’t
hesitate to let us know by sending feedback to this mailing list or filing
an issue on GitHub[4].



[1] http://dubbo.apache.org/en-us/blog/download.html
[2] http://central.maven.org/maven2/org/apache/dubbo
[3] https://github.com/apache/dubbo/releases
[4] https://github.com/apache/dubbo/issues

Re: [VOTE]: Release Apache Dubbo 2.7.2 [RC1]

[victory]

We’ve received 3 +1 binding votes and one +1 non-binding vote: +1 binding,
Ian Luo +1 binding, Huxing Zhang +1 binding, Jun Liu +1 non-binding, Shunyu
Lei

I will release dubbo-2.7.2 today. Best regards, The Apache Dubbo
(Incubating) Team

Jun Liu  于2019年6月6日周四 上午10:45写道：

> +1 to release.
>
> I checked:
> * Source package has a good name, ‘incubating' removed.
> * DISCLAIMER LICENSE and NOTICE exist
> * No binary files exist in source package
> * Can compile and all UT pass in my local machine with 'mvn clean test’
> except for a few ones in the following file   -
> org.apache.dubbo.metadata.store.etcd.EtcdMetadataReportTest, I think it’s
> not a functional issue, the reason is my machine does not match this UT's
> it’s docker requirement.
> * All files have License header and meet checkstyle requirements: mvn
> clean compile -Drat.skip=false -Dcheckstyle.skip=false
> * Release notes are good
>
> Question:
> - Are we still releasing the binary package for this version? I saw the
> binary package ‘apache-dubbo-2.7.2-bin.zip’ in
> https://dist.apache.org/repos/dist/dev/dubbo/2.7.2/, if we are not
> releasing, should we remove it now?
>
> Suggestion:
> - I think we should refine the release notes in here
> https://github.com/apache/dubbo/releases/tag/dubbo-2.7.2, only highlight
> the most important and cared features. Guide people who want to see details
> to https://github.com/apache/dubbo/blob/dubbo-2.7.2/CHANGES.md for more
> info.
>
> Jun
>
>
> > On May 31, 2019, at 7:16 PM, victory  wrote:
> >
> > Hello Dubbo Community,
> >
> > This is a call for vote to release Apache Dubbo version 2.7.2.
> >
> > The release candidates:
> > https://dist.apache.org/repos/dist/dev/dubbo/2.7.2/
> >
> > Git tag for the release:
> > https://github.com/apache/dubbo/tree/dubbo-2.7.2
> >
> > Hash for the release tag:
> > 0ab26b170b40f146707cdab0b4436e32df4f5e9a
> >
> > Release Notes:
> > https://github.com/apache/dubbo/blob/dubbo-2.7.2/CHANGES.md
> >
> > The artifacts have been signed with Key : A3A1CA7A5D4A3981, which can be
> > found in the keys file:
> > https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> >
> > The vote will be open for at least 72 hours or until necessary number of
> > votes are reached.
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > The Apache Dubbo Team
>
>

-- 

Best Regard!
cvitory

Re: [VOTE]: Release Apache Dubbo 2.7.2 [RC1]

[victory]

staging repository:
https://repository.apache.org/content/repositories/orgapachedubbo-1026/

Huxing Zhang  于2019年6月3日周一 上午11:01写道：

> Hi,
>
> Could you please attach the link to staging repository?
>
> On Fri, May 31, 2019 at 7:16 PM victory  wrote:
> >
> > Hello Dubbo Community,
> >
> > This is a call for vote to release Apache Dubbo version 2.7.2.
> >
> > The release candidates:
> > https://dist.apache.org/repos/dist/dev/dubbo/2.7.2/
> >
> > Git tag for the release:
> > https://github.com/apache/dubbo/tree/dubbo-2.7.2
> >
> > Hash for the release tag:
> > 0ab26b170b40f146707cdab0b4436e32df4f5e9a
> >
> > Release Notes:
> > https://github.com/apache/dubbo/blob/dubbo-2.7.2/CHANGES.md
> >
> > The artifacts have been signed with Key : A3A1CA7A5D4A3981, which can be
> > found in the keys file:
> > https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> >
> > The vote will be open for at least 72 hours or until necessary number of
> > votes are reached.
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > The Apache Dubbo Team
>
>
>
> --
> Best Regards！
> Huxing
>

[VOTE]: Release Apache Dubbo 2.7.2 [RC1]

[victory]

Hello Dubbo Community,

This is a call for vote to release Apache Dubbo version 2.7.2.

The release candidates:
https://dist.apache.org/repos/dist/dev/dubbo/2.7.2/

Git tag for the release:
https://github.com/apache/dubbo/tree/dubbo-2.7.2

Hash for the release tag:
0ab26b170b40f146707cdab0b4436e32df4f5e9a

Release Notes:
https://github.com/apache/dubbo/blob/dubbo-2.7.2/CHANGES.md

The artifacts have been signed with Key : A3A1CA7A5D4A3981, which can be
found in the keys file:
https://dist.apache.org/repos/dist/dev/dubbo/KEYS

The vote will be open for at least 72 hours or until necessary number of
votes are reached.

Please vote accordingly:

[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason

Thanks,
The Apache Dubbo Team

Re: 2.7.2 release plan

[victory]

I have fire a pr, please review it.

Huxing Zhang  于2019年5月28日周二 下午1:55写道：

> Hi,
>
> I check the license compatibility with the script recently introduced,
> there are 2 issues which need to be addressed:
>
>  (BEA licensed) "Java Concurrency in Practice" book annotations
> (net.jcip:jcip-annotations:1.0 - http://jcip.net/)
>
> For example, in dubbo-registry/dubbo-registry-sofa:
>
> [INFO] +- org.jboss.resteasy:resteasy-jaxrs:jar:3.0.19.Final:test
> [INFO] |  +- org.jboss.spec.javax.ws.rs:
> jboss-jaxrs-api_2.0_spec:jar:1.0.0.Final:test
> [INFO] |  +-
> org.jboss.spec.javax.annotation:jboss-annotations-api_1.2_spec:jar:1.0.0.Final:test
> [INFO] |  +- javax.activation:activation:jar:1.1.1:test
> [INFO] |  +- org.apache.httpcomponents:httpclient:jar:4.5.3:test
> [INFO] |  |  +- org.apache.httpcomponents:httpcore:jar:4.4.6:test
> [INFO] |  |  \- commons-codec:commons-codec:jar:1.9:test
> [INFO] |  +- commons-io:commons-io:jar:2.1:test
> [INFO] |  +- net.jcip:jcip-annotations:jar:1.0:test
> [INFO] |  \- org.jboss.logging:jboss-logging:jar:3.1.4.GA:test
>
>  (GNU LESSER GENERAL PUBLIC LICENSE, Version 2.1) SpotBugs
> Annotations (com.github.spotbugs:spotbugs-annotations:3.1.10 -
> https://spotbugs.github.io/)
>
> For example, in dubbo-configcenter-etcd:
>
> [INFO] +- io.etcd:jetcd-launcher:jar:0.3.0:test
> [INFO] |  +- com.github.spotbugs:spotbugs-annotations:jar:3.1.10:test
> [INFO] |  \- org.slf4j:slf4j-api:jar:1.7.25:compile
>
> Looks like all are test dependency, so it should be safe to exclude them?
>
> On Tue, May 28, 2019 at 10:17 AM victory  wrote:
> >
> > I have renew a branch named 2.7.2-release for freeze the code.
> >  If you have some issue or bugs that must be fixed, please let me know.
> > Otherwise you can post pull request to master and publish this feature in
> > the next version.
> >
> > victory  于2019年5月23日周四 上午11:13写道：
> >
> > > Hello,
> > > I am coming again. I find there are so many issues is in progress and
> the
> > > release plan was postponed.
> > > I think it's time to freeze the code this weekend and I will deploy one
> > > SNAPSHOT version.  If you have some very important feature or some bugs
> > > that you mush finish, please let me know.
> > >
> > > If normal,  I think I will start to vote in the next week.
> > >
> > > victory  于2019年4月18日周四 下午7:37写道：
> > >
> > >> Hello everyone,
> > >>
> > >>  I volunteer to take release manager role for 2.7.2 release. This main
> > >> feature of 2.7.2 is as follow:
> > >>
> > >>- Support nacos as register center and config center.
> > >>- Integrate other metrics.
> > >>- Optimize registration way, support to register data by
> application
> > >>but not single service.
> > >>- Fix some compatible issues with dubbo 2.6.x.
> > >>
> > >> Besides, we also have a quite long list [1] of issues targeted to
> 2.7.2,
> > >> which apparently need to triage to be short enough to meet to code
> freeze
> > >> date, May. 17th. Hopefully we can release 2.7.2 by May. 27th.
> > >>
> > >>
> > >> Pls. take a look at milestone 2.7.2 [1], and let me know which issues
> are
> > >> must have for this release. We will triage the list soon :)
> > >> https://github.com/apache/incubator-dubbo/milestone/25
> > >>
> > >> --
> > >>
> > >> Best Regard!
> > >> cvictory
> > >>
> > >
> > >
> > > --
> > >
> > > Best Regard!
> > > cvitory
> > >
> >
> >
> > --
> >
> > Best Regard!
> > cvitory
>
>
>
> --
> Best Regards！
> Huxing
>


-- 

Best Regard!
cvitory

Re: 2.7.2 release plan

[victory]

I have renew a branch named 2.7.2-release for freeze the code.
 If you have some issue or bugs that must be fixed, please let me know.
Otherwise you can post pull request to master and publish this feature in
the next version.

victory  于2019年5月23日周四 上午11:13写道：

> Hello,
> I am coming again. I find there are so many issues is in progress and the
> release plan was postponed.
> I think it's time to freeze the code this weekend and I will deploy one
> SNAPSHOT version.  If you have some very important feature or some bugs
> that you mush finish, please let me know.
>
> If normal,  I think I will start to vote in the next week.
>
> victory  于2019年4月18日周四 下午7:37写道：
>
>> Hello everyone,
>>
>>  I volunteer to take release manager role for 2.7.2 release. This main
>> feature of 2.7.2 is as follow:
>>
>>- Support nacos as register center and config center.
>>- Integrate other metrics.
>>- Optimize registration way, support to register data by application
>>but not single service.
>>- Fix some compatible issues with dubbo 2.6.x.
>>
>> Besides, we also have a quite long list [1] of issues targeted to 2.7.2,
>> which apparently need to triage to be short enough to meet to code freeze
>> date, May. 17th. Hopefully we can release 2.7.2 by May. 27th.
>>
>>
>> Pls. take a look at milestone 2.7.2 [1], and let me know which issues are
>> must have for this release. We will triage the list soon :)
>> https://github.com/apache/incubator-dubbo/milestone/25
>>
>> --
>>
>> Best Regard!
>> cvictory
>>
>
>
> --
>
> Best Regard!
> cvitory
>


-- 

Best Regard!
cvitory

Re: 2.7.2 release plan

[victory]

Hello,
I am coming again. I find there are so many issues is in progress and the
release plan was postponed.
I think it's time to freeze the code this weekend and I will deploy one
SNAPSHOT version.  If you have some very important feature or some bugs
that you mush finish, please let me know.

If normal,  I think I will start to vote in the next week.

victory  于2019年4月18日周四 下午7:37写道：

> Hello everyone,
>
>  I volunteer to take release manager role for 2.7.2 release. This main
> feature of 2.7.2 is as follow:
>
>- Support nacos as register center and config center.
>- Integrate other metrics.
>- Optimize registration way, support to register data by application
>but not single service.
>- Fix some compatible issues with dubbo 2.6.x.
>
> Besides, we also have a quite long list [1] of issues targeted to 2.7.2,
> which apparently need to triage to be short enough to meet to code freeze
> date, May. 17th. Hopefully we can release 2.7.2 by May. 27th.
>
>
> Pls. take a look at milestone 2.7.2 [1], and let me know which issues are
> must have for this release. We will triage the list soon :)
> https://github.com/apache/incubator-dubbo/milestone/25
>
> --
>
> Best Regard!
> cvictory
>


-- 

Best Regard!
cvitory

2.7.2 release plan

[victory]

Hello everyone,

 I volunteer to take release manager role for 2.7.2 release. This main
feature of 2.7.2 is as follow:

   - Support nacos as register center and config center.
   - Integrate other metrics.
   - Optimize registration way, support to register data by application but
   not single service.
   - Fix some compatible issues with dubbo 2.6.x.

Besides, we also have a quite long list [1] of issues targeted to 2.7.2,
which apparently need to triage to be short enough to meet to code freeze
date, May. 17th. Hopefully we can release 2.7.2 by May. 27th.


Pls. take a look at milestone 2.7.2 [1], and let me know which issues are
must have for this release. We will triage the list soon :)
https://github.com/apache/incubator-dubbo/milestone/25

-- 

Best Regard!
cvictory

Re: [DISCUSS] Graduate Apache Dubbo(incubating) as a Top Level Project

[victory]

Dubbo community is very active and growing well in apache way.

It is time to discuss the graduation.

Conguratulation !

Jerrick Zhu  于2019年4月3日周三 下午1:20写道：

> Glad to see graduation discussion.
>
> +1 for Ian Luo to be PMC Chair.
>
> Huxing Zhang  于2019年4月3日周三 下午1:04写道：
>
> > Hi,
> >
> >
> > On Wed, Apr 3, 2019 at 11:55 AM Huxing Zhang  wrote:
> > >
> > > Hi Mark,
> > >
> > > On Tue, Apr 2, 2019 at 11:39 PM Mark Thomas  wrote:
> > > >
> > > > On 30/03/2019 11:00, Huxing Zhang wrote:
> > > > > Hi All,
> > > > >
> > > > > It has been more than 1 year since Dubbo joins the ASF
> > > > > incubator(2018-02-16). During incubation I think Dubbo community
> has
> > > > > been growing in a fast and healthy way, and also learned a lot
> about
> > how
> > > > > to collaborate in Apache way.
> > > >
> > > > Agreed.
> > > >
> > > > > I think it is time to discuss the graduation as a Top level project
> > for Dubbo.
> > > >
> > > > Agreed.
> > > >
> > > > > Until now, what we've achieved:
> > > >
> > > > Different people will focus on different things when it comes to
> > judging
> > > > a podling's readiness for graduation. Concentrating of the points I
> > > > consider key...
> > > >
> > > > > ### Releases
> > > > > Totally 10 release since incubation
> > > >
> > > > 
> > > >
> > > > > The release process has been well-documented and there are 6
> > different
> > > > > release managers: Jun Liu, Yong Zhu, Victory Cao, Huxing Zhang,
> Mercy
> > > > > Ma, Ian Luo.
> > > >
> > > > This is very positive.
> > > >
> > > > > ### Community building:
> > > > > - PPMC 19(+8 since incubation, excluding mentors)
> > > > > - committers 35(+18 since incubation)
> > > > > The committers varies from Alibaba, Weidian, Jingdong, Qunar,
> Youzan,
> > > > > Netease, Meituan-Dianping, Rongguan, Handuyishe, Didi, NetsUnion,
> > > > > Caocaokeji, Huawei, GomeFinance, Asiainfo-sec, iFlytek, Keep and
> etc.
> > > >
> > > > Great increase in both numbers and diversity of committers.
> > > >
> > > > > - The number of contributors has grown from 70+ to 186
> > > >
> > > > Another positive sign.
> > > >
> > > > > - Discussion are happening on the mailing list
> > > >
> > > > This has really improved over the last 6 months.
> > > >
> > > > > Based on the data above, I think Dubbo is ready for graduation.
> > > > > How do you folks think?
> > > >
> > > > +1
> > > >
> > > > One quick check. Dubbo has not been registered anywhere as a
> trademark
> > > > by Alibaba has it?
> > >
> > > I think so, I will contact the legal department of Alibaba to make
> > > sure about it.
> >
> > I just confirmed with the legal department of Alibaba, they do not
> > registered Dubbo as a trademark.
> > I also checked it publicly[1], no trademark regarding Dubbo has been
> > registered.
> >
> > [1]
> >
> http://searchsaic.saic.gov.cn/was5/web/search?searchword=Dubbo=13=11=32.1349860449837.41===IR_URLTITLE=272901=-IR_URLTIME=saic_type=yes
> >
> >
> > >
> > > >
> > > > Mark
> > >
> > >
> > >
> > > --
> > > Best Regards！
> > > Huxing
> >
> >
> >
> > --
> > Best Regards！
> >
> > Huxing
> >
>


-- 

Best Regard!
cvitory

Re: [VOTE] End of Life for 2.5.x

[victory]

[x ] 2019-9-15 (half year later)

I think we should half a year is better.

Huxing Zhang  于2019年3月19日周二 下午1:54写道：

> Hi,
>
> [x] 2019-6-15 (3 month later)
>
> On Fri, Mar 15, 2019 at 5:37 PM Huxing Zhang  wrote:
> >
> > Hi All,
> >
> > Based on the discussion before[1], I am calling a vote to decide end
> > of life date for 2.5.x.
> >
> > Please vote accordingly:
> > [ ] immediately if the vote get passed
>
> > [ ] 2019-9-15 (half year later)
> > [ ] 2019-12-31 (end of this year)
> >
> > [1]
> https://lists.apache.org/thread.html/7b2873a0e6df957f62e62fad51fc87b72629a56fd8a1e633dd8252f5@%3Cdev.dubbo.apache.org%3E
> >
> > --
> > Best Regards！
> > Huxing
>
>
>
> --
> Best Regards！
> Huxing
>


-- 

Best Regard!
cvitory

Re: [DISCUSS] Archive incubator-dubbo-docs project

[victory]

+1
we could focus on the website and make the website better.

Huxing Zhang  于2019年3月13日周三 上午9:57写道：

> Hi,
>
>
> On Wed, Mar 13, 2019 at 8:21 AM kezhenxu94  wrote:
> >
> > > I see there are remaining issues, shall they be migrated?
> >
> > I notice that GitHub recently released a new feature called "Transfer
> Issue" that can transfer issue from one repo to another, can we use this
> feature to migrate?
>
> I didn't know that before, looks like a cool feature. It worth to try
> it out (after the decision is made)!
> >
> >
> > 在 2019-03-13 00:11:08，"Huxing Zhang"  写道：
> > >Hi All,
> > >
> > >The community has already deprecated incubator-dubbo-docs, with the
> > >following effort:
> > >- all the documentation in incubator-dubbo-docs[1] has been migrated
> > >to incubator-dubbo-website, - the last commit of this project was 7
> > >months ago
> > >- deprecated the project in README
> > >
> > >However, I am still seeing issues/pull request were raised. To avoid
> > >this, I am proposing to archive the incubator-dubbo-docs project (make
> > >it read only).
> > >
> > >Do you think it is necessary?
> > >
> > >I see there are remaining issues, shall they be migrated?
> > >
> > >[1] https://github.com/apache/incubator-dubbo-docs
> > >
> > >--
> > >Best Regards！
> > >Huxing
>
>
>
> --
> Best Regards！
> Huxing
>


-- 

Best Regard!
cvitory

Re: [DISCUSS] Next Dubbo meetup

[victory]

+1 for Nanjing
And any weekend is fine for me.

Minxuan Zhuang  于2019年2月18日周一 下午5:49写道：

> +1 for March 23rd
> +1 for Nanjing
>
> On Thu, Feb 14, 2019 at 2:41 PM jun liu  wrote:
>
> > > Can we make it Mar 23rd? As our venue is available on that day.
> >
> > +1 for Mar. 23th, any time is ok for me.
> >
> > +1 for hosting in Nanjing.
> >
> > Jun
> >
> > > On Feb 12, 2019, at 12:20 PM, 王蓉(涂南)  wrote:
> > >
> > > Mar 15th is Friday.
> > >
> > > Can we make it Mar 23rd? As our venue is available on that day.
> > >
> > >
> > > --
> > > 发件人：Ian Luo 
> > > 发送时间：2019年2月1日(星期五) 17:12
> > > 收件人：dev 
> > > 抄 送：王蓉(涂南) 
> > > 主 题：Re: 回复：[DISCUSS] Next Dubbo meetup
> > >
> > > +1 Mar. 15th looks better.
> > >
> > > On Thu, Jan 31, 2019 at 10:49 AM Huxing Zhang 
> wrote:
> > >
> > >> Hi,
> > >>
> > >> Consider the Chinese New Year vacation, how about move one week later?
> > >>
> > >> Location: Nanjing
> > >> Call for talks close:  Feb. 22nd (Friday)
> > >> Meetup: March 15th (Saturday)
> > >>
> > >> On Mon, Jan 28, 2019 at 10:47 PM Ian Luo  wrote:
> > >>
> > >>> +1 for Nanjing. I think any weekend in March sounds fine to me.
> > >>>
> > >>> Thanks,
> > >>> -Ian.
> > >>>
> > >>> On Mon, Jan 28, 2019 at 5:12 PM Huxing Zhang 
> > wrote:
> > >>>
> >  Hi,
> > 
> >  On Mon, Jan 28, 2019 at 11:19 AM 王蓉(涂南) 
> > >>> wrote:
> > 
> > > Hi guys,
> > >
> > > Last week meetup in Guangzhou was so much fun.
> > > We have total 400+ registrations and more than 200 attendees,
> another
> > >>> 4k
> > > people watched our live streaming!
> > >
> > > I think we should start to prepare next meetup in Nanjing ASAP. As
> > >> the
> > > Chinese New Year is approaching.
> > >
> > 
> >  We need to first discuss with the community about:
> >  - where should next meetup be held?
> >  - when should it be held?
> > 
> >  As discussed in the previous threads, based on the vote result, I
> > think
> >  Nanjing is a good candidate for the next meetup.
> >  +1 for Nanjing!
> > 
> > 
> > 
> > >
> > > What about March 9th?If March 9th is OK, the Call for Talks will be
> >  closed
> > > on Feb 15th. That will give us plenty of time to prepare.
> > >
> > 
> >  March 9th is a Saturday, which looks good to me.
> >  Feb 15th looks too early to me, because the Chinese new year
> festival
> > >> is
> >  Feb 4th to Feb 10th. There is only one week after the vacation, and
> it
> > >> is
> >  possible some of us would have extra days-off after the vacation.
> >  Is is possible to close the Call for talks one week later? say Feb
> > >> 22nd.
> > 
> > 
> > >
> > > Amber
> > > BR
> > >
> > >
> > > --
> > > 发件人：Huxing Zhang 
> > > 发送时间：2018年12月11日(星期二) 15:15
> > > 收件人：dev 
> > > 主 题：Re: 回复：[DISCUSS] Next Dubbo meetup
> > >
> > > Hi,
> > >
> > > I think Guangzhou and Nanjing are the cities we all should go to.
> It
> > >> is
> > > just about who is the first.
> > >
> > > On Tue, Dec 11, 2018 at 2:07 PM Mercy 
> wrote:
> > >
> > >> I vote twice, one is Nanjing, another is Guangzhou :D
> > >>
> > >>
> > >> Kind regards,
> > >>
> > >> Mercy Ma
> > >>
> > >>
> > >> 在 2018/12/11 下午1:47, 王蓉(涂南) 写道:
> > >>> Folks, so far we have received 40 votes.
> > >>>
> > >>> Looks like Guangzhou is where we're gonna meet on Jan 19th.
> > >>>
> > >>>
> > >>>  广州  12
> > >>>  南京  10
> > >>>  北京  4
> > >>>  深圳  4
> > >>>  上海  4
> > >>>  厦门  2
> > >>>  武汉  1
> > >>>  西安  1
> > >>>  重庆  1
> > >>>  大连  1
> > >>>
> > >>>
> > >>>
> > >> --
> > >>> 发件人：jun liu 
> > >>> 发送时间：2018年12月7日(星期五) 23:52
> > >>> 收件人：dev 
> > >>> 主 题：Re: [DISCUSS] Next Dubbo meetup
> > >>>
> > >>> I prefer Nanjing for the next Meetup city.
> > >>>
> > >>> Jun
> > >>>
> >  On Dec 4, 2018, at 10:06 PM, Huxing Zhang 
> >  wrote:
> > 
> >  In the link[1] provided, there are 3 options:
> > 
> >  * Nanjing
> >  * Guangzhou
> >  * Other
> > 
> >  I prefer to a new city where we haven't been there before.
> >  According to a survey, the number of users who is using Dubbo in
> > >> Guangzhou
> >  ranks 5th in China, only secondary to Beijing, Shanghai,
> > >> Shenzhen,
> > >> Hangzhou.
> >  So I am going to vote +1 for Guangzhou. :)
> > 
> >  [1] http://sc-meetup.mikecrm.com/7hZFeTl <
> > >> http://sc-meetup.mikecrm.com/7hZFeTl>
> > 
> >  On Tue, Dec 4, 2018 at 4:08 

Re: [Notification of V2.7.0] Status, TODOs, Possible Release Schedules.

[victory]

I have check the file , it is the same as pull request #3263.


Huxing Zhang  于2019年1月17日周四 下午5:34写道：

> Hi Victory,
>
> I've mistakenly reverted your recent pull request[1].
> Luckily I have restored it via the commit email message.
> I've push it to 2.7.0-release branch already.
> Would you please help to check it?
>
>
> [1] https://github.com/apache/incubator-dubbo/pull/3263
>
> On Thu, Jan 17, 2019 at 5:08 PM victory  wrote:
> >
> > I have review the code and it work well in
> >
> https://github.com/apache/incubator-dubbo-samples/tree/samples-for-2.7.0-SNAPSHOT/dubbo-samples-configcenter/dubbo-samples-configcenter-apollo
> >
> > I have merged this pull request into 2.7.0-release.
> >
> > Huxing Zhang  于2019年1月17日周四 下午2:59写道：
> >
> > > Hi,
> > >
> > > This looks like a blocking issue, I've already tagged 2.7.0, I will
> > > wait for it and re-do the tagging.
> > >
> > > On Thu, Jan 17, 2019 at 2:49 PM jun liu  wrote:
> > > >
> > > > > I am seeing that all the issue has been cleaned for the 2.7.0
> > > milestone.
> > > > > It looks like all the things have been settled, I am planning to
> tag
> > > > > the 2.7.0 release today.
> > > >
> > > > One more issue to be solved before vote.
> > > > Thanks to the suggestions from the Apollo[1] community, I submitted a
> > > PR[2] to polish the Apollo extension. Please help to review.
> > > >
> > > > 1. https://github.com/ctripcorp/apollo
> > > > 2. https://github.com/apache/incubator-dubbo/pull/3263
> > > >
> > > > Jun
> > > >
> > > > > On Jan 17, 2019, at 10:41 AM, Huxing Zhang 
> wrote:
> > > > >
> > > > > Hi All,
> > > > >
> > > > > I am seeing that all the issue has been cleaned for the 2.7.0
> > > milestone.
> > > > > It looks like all the things have been settled, I am planning to
> tag
> > > > > the 2.7.0 release today.
> > > > >
> > > > > dubbo-ops and dubbo-spring-boot-project should be released after
> Dubbo
> > > > > 2.7.0 release.
> > > > >
> > > > > On Wed, Jan 16, 2019 at 5:02 PM jun liu   > > ken.lj...@gmail.com>> wrote:
> > > > >>
> > > > >>> There is no need to shade gson into dubbo.jar, just need depency
> gson
> > > > >>> library.
> > > > >>>
> > > > >>> I have fixed it .
> > > https://github.com/apache/incubator-dubbo/pull/3246 <
> > > https://github.com/apache/incubator-dubbo/pull/3246> <
> > > https://github.com/apache/incubator-dubbo/pull/3246 <
> > > https://github.com/apache/incubator-dubbo/pull/3246>>
> > > > >> Agree.
> > > > >>
> > > > >> Well done,  merged.
> > > > >>
> > > > >> Jun
> > > > >>
> > > > >>> On Jan 16, 2019, at 4:15 PM, victory 
> wrote:
> > > > >>>
> > > > >>> There is no need to shade gson into dubbo.jar, just need depency
> gson
> > > > >>> library.
> > > > >>>
> > > > >>> I have fixed it .
> > > https://github.com/apache/incubator-dubbo/pull/3246
> > > > >>>
> > > > >>> Ian Luo  于2019年1月16日周三 下午2:34写道：
> > > > >>>
> > > > >>>> We should not shade gson binaries into dubbo all in one jar
> file,
> > > even
> > > > >>>> though there's no license issue. It is simply we should not do
> this,
> > > > >>>> instead, we should make sure dubbo all in one jar should have a
> > > transitive
> > > > >>>> dependency to gson library.
> > > > >>>>
> > > > >>>> I noticed it's caused
> > > by'com.google.code.gson:gson' in
> > > > >>>> dubbo-all/pom.xml. We should fix it.
> > > > >>>>
> > > > >>>> Thanks,
> > > > >>>> -Ian.
> > > > >>>>
> > > > >>>>
> > > > >>>> On Tue, Jan 15, 2019 at 5:16 PM jun liu 
> > > wrote:
> > > > >>>>
> > > > >>>>> I noticed that a third-party source code ‘com.google <
> > > http://com.google/
> > &

Re: [Notification of V2.7.0] Status, TODOs, Possible Release Schedules.

[victory]

I have review the code and it work well in
https://github.com/apache/incubator-dubbo-samples/tree/samples-for-2.7.0-SNAPSHOT/dubbo-samples-configcenter/dubbo-samples-configcenter-apollo

I have merged this pull request into 2.7.0-release.

Huxing Zhang  于2019年1月17日周四 下午2:59写道：

> Hi,
>
> This looks like a blocking issue, I've already tagged 2.7.0, I will
> wait for it and re-do the tagging.
>
> On Thu, Jan 17, 2019 at 2:49 PM jun liu  wrote:
> >
> > > I am seeing that all the issue has been cleaned for the 2.7.0
> milestone.
> > > It looks like all the things have been settled, I am planning to tag
> > > the 2.7.0 release today.
> >
> > One more issue to be solved before vote.
> > Thanks to the suggestions from the Apollo[1] community, I submitted a
> PR[2] to polish the Apollo extension. Please help to review.
> >
> > 1. https://github.com/ctripcorp/apollo
> > 2. https://github.com/apache/incubator-dubbo/pull/3263
> >
> > Jun
> >
> > > On Jan 17, 2019, at 10:41 AM, Huxing Zhang  wrote:
> > >
> > > Hi All,
> > >
> > > I am seeing that all the issue has been cleaned for the 2.7.0
> milestone.
> > > It looks like all the things have been settled, I am planning to tag
> > > the 2.7.0 release today.
> > >
> > > dubbo-ops and dubbo-spring-boot-project should be released after Dubbo
> > > 2.7.0 release.
> > >
> > > On Wed, Jan 16, 2019 at 5:02 PM jun liu  ken.lj...@gmail.com>> wrote:
> > >>
> > >>> There is no need to shade gson into dubbo.jar, just need depency gson
> > >>> library.
> > >>>
> > >>> I have fixed it .
> https://github.com/apache/incubator-dubbo/pull/3246 <
> https://github.com/apache/incubator-dubbo/pull/3246> <
> https://github.com/apache/incubator-dubbo/pull/3246 <
> https://github.com/apache/incubator-dubbo/pull/3246>>
> > >> Agree.
> > >>
> > >> Well done,  merged.
> > >>
> > >> Jun
> > >>
> > >>> On Jan 16, 2019, at 4:15 PM, victory  wrote:
> > >>>
> > >>> There is no need to shade gson into dubbo.jar, just need depency gson
> > >>> library.
> > >>>
> > >>> I have fixed it .
> https://github.com/apache/incubator-dubbo/pull/3246
> > >>>
> > >>> Ian Luo  于2019年1月16日周三 下午2:34写道：
> > >>>
> > >>>> We should not shade gson binaries into dubbo all in one jar file,
> even
> > >>>> though there's no license issue. It is simply we should not do this,
> > >>>> instead, we should make sure dubbo all in one jar should have a
> transitive
> > >>>> dependency to gson library.
> > >>>>
> > >>>> I noticed it's caused
> by'com.google.code.gson:gson' in
> > >>>> dubbo-all/pom.xml. We should fix it.
> > >>>>
> > >>>> Thanks,
> > >>>> -Ian.
> > >>>>
> > >>>>
> > >>>> On Tue, Jan 15, 2019 at 5:16 PM jun liu 
> wrote:
> > >>>>
> > >>>>> I noticed that a third-party source code ‘com.google <
> http://com.google/
> > >>>>> .gson.*’
> > >>>>> has been compiled into the convenient maven binary jar of 2.7.0 -
> > >>>>> dubbo-2.7.0.jar :
> > >>>>>>>>>
> > >>>>> .
> > >>>>> ├── META-INF
> > >>>>> │   ├── DEPENDENCIES
> > >>>>> │   ├── LICENSE
> > >>>>> │   ├── MANIFEST.MF
> > >>>>> │   ├── NOTICE
> > >>>>> │   ├── assembly
> > >>>>> │   │   └── bin
> > >>>>> │   ├── compat
> > >>>>> │   │   └── dubbo.xsd
> > >>>>> │   ├── dubbo
> > >>>>> │   │   └── internal
> > >>>>> │   ├── dubbo.xsd
> > >>>>> │   ├── maven
> > >>>>> │   │   ├── com.alibaba
> > >>>>> │   │   ├── com.google.code.gson
> > >>>>> │   │   └── org.apache.dubbo
> > >>>>> │   ├── spring.handlers
> > >>>>> │   └── spring.schemas
> > >>>>> ├── com
> > >>>>> │   ├── alibaba
> > >>>>> │   │   ├── com
> > >>>>> │   │   └── dubbo
> > >>>>> │   └── goo

Re: [Notification of V2.7.0] Status, TODOs, Possible Release Schedules.

[victory]

There is no need to shade gson into dubbo.jar, just need depency gson
library.

I have fixed it . https://github.com/apache/incubator-dubbo/pull/3246

Ian Luo  于2019年1月16日周三 下午2:34写道：

> We should not shade gson binaries into dubbo all in one jar file, even
> though there's no license issue. It is simply we should not do this,
> instead, we should make sure dubbo all in one jar should have a transitive
> dependency to gson library.
>
> I noticed it's caused by'com.google.code.gson:gson' in
> dubbo-all/pom.xml. We should fix it.
>
> Thanks,
> -Ian.
>
>
> On Tue, Jan 15, 2019 at 5:16 PM jun liu  wrote:
>
> > I noticed that a third-party source code ‘com.google  >.gson.*’
> > has been compiled into the convenient maven binary jar of 2.7.0 -
> > dubbo-2.7.0.jar :
> > 
> > .
> > ├── META-INF
> > │   ├── DEPENDENCIES
> > │   ├── LICENSE
> > │   ├── MANIFEST.MF
> > │   ├── NOTICE
> > │   ├── assembly
> > │   │   └── bin
> > │   ├── compat
> > │   │   └── dubbo.xsd
> > │   ├── dubbo
> > │   │   └── internal
> > │   ├── dubbo.xsd
> > │   ├── maven
> > │   │   ├── com.alibaba
> > │   │   ├── com.google.code.gson
> > │   │   └── org.apache.dubbo
> > │   ├── spring.handlers
> > │   └── spring.schemas
> > ├── com
> > │   ├── alibaba
> > │   │   ├── com
> > │   │   └── dubbo
> > │   └── google
> > │   └── gson
> > └── org
> > └── apache
> > └── dubbo
> >
> >
> > Since this binary jar (dubbo-2.7.0.jar) will be included in the Apache
> > Binary Release, should we update the LICENSE or NOTICE file in the Binary
> > Release to announce the existence of these binary files?
> >
> > BTW, ‘com.google .gson’ is declared to be unde
> Apache
> > License 2.0.
> >
> > You can directly download the latest SNAPSHOT release of 2.7.0-SNAPSHOT
> in
> > here[1] and unzip and check the contents to better understand what I am
> > trying to describe here.
> >
> > 1.
> >
> https://repository.apache.org/content/repositories/snapshots/org/apache/dubbo/dubbo/2.7.0-SNAPSHOT/
> >
> > Jun
> >
> > > On Jan 13, 2019, at 5:58 PM, Huxing Zhang  wrote:
> > >
> > > Hi Jun,
> > >
> > > Could you summarize the current status of the 2.7-release branch?
> > > I see there are still several enhancement on this branch.
> > >
> > > As this is the first time to prepare for a release for me, I am trying
> > > to walk through the release steps[1].
> > > I might try to deploy snapshot to maven repository.
> > >
> > > Once we feel it is ready to do the release, I will start the formal
> > > release process.
> > >
> > >
> > > [1] http://dubbo.apache.org/en-us/blog/prepare-an-apache-release.html
> > >
> > >
> > > --
> > > Best Regards！
> > > Huxing
> > >
> > > On Mon, Jan 7, 2019 at 1:48 PM jun liu  wrote:
> > >>
> > 
> >  Nice work!
> > 
> >  I think we should let the community to participate more in the
> release
> >  process, for example,
> >  1. check out a release branch called 2.7.0-release
> >  2. encourage people to check it out, test it and report if there is
> >  any regressions, bugs or issues.
> >  3. while we are doing the test, we can start going through the ASF
> >  release process locally, once we think it is ready to start a formal
> >  release note, it can be done very quickly.
> > 
> >  By the way, we need decide the release manager of 2.7.0 release. Is
> >  there anyone who volunteer to do that?
> > >>
> > >> Sorry, I missed this mail.
> > >> * 2.7.0-release has been created
> > >> * we've froze the codebase, test is underway.
> > >>
> > >>> I'd like to be the release manager if no one is claiming it.
> > >>
> > >> Great, I can help you with the source/binary packaging and tagging
> > things.
> > >>
> > >> Jun
> > >>
> > >>> On Jan 5, 2019, at 12:11 PM, Huxing Zhang  wrote:
> > >>>
> > >>> Hi,
> > >>>
> > >>> On Fri, Dec 28, 2018 at 10:45 AM Huxing Zhang 
> > wrote:
> > 
> >  Nice work!
> > 
> >  I think we should let the community to participate more in the
> release
> >  process, for example,
> >  1. check out a release branch called 2.7.0-release
> >  2. encourage people to check it out, test it and report if there is
> >  any regressions, bugs or issues.
> >  3. while we are doing the test, we can start going through the ASF
> >  release process locally, once we think it is ready to start a formal
> >  release note, it can be done very quickly.
> > 
> >  By the way, we need decide the release manager of 2.7.0 release. Is
> >  there anyone who volunteer to do that?
> > >>>
> > >>> I'd like to be the release manager if no one is claiming it.
> > 
> >  On Thu, Dec 27, 2018 at 11:53 PM jun liu 
> wrote:
> > >
> > > Hi, All
> > >
> > > I am writing this mail to
> > >
> > > * Keep you refreshed of the latest status about v2.7.0.
> > > * Call for efforts on code review and tests
> > > * Discuss possible release schedules of v2.7.0.
> > >

Re: [Notification of V2.7.0] Status, TODOs, Possible Release Schedules.

[victory]

Hi ,

 There are still some issues about dubbo-2.7 as follow:
1.  In dubbo2.7 , we modify the ZookeeperTransport to make zookeeper using
one singleton connection.
 But when the hook is invoked after closing server, it will get
zookeeper connection for many times for remove some data from zookeeper
server.  But the connection may be closed by the other hook.
 Removing the zookeeper data , it happened some error for the
connection is closed.
 https://github.com/apache/incubator-dubbo/issues/3218
2.  Http Invoke between dubbo2.6 and dubbo2.7 cannot work well.
https://github.com/apache/incubator-dubbo/issues/3226

These issue should be fixed as quickly as possible.






Huxing Zhang  于2019年1月13日周日 下午5:58写道：

> Hi Jun,
>
> Could you summarize the current status of the 2.7-release branch?
> I see there are still several enhancement on this branch.
>
> As this is the first time to prepare for a release for me, I am trying
> to walk through the release steps[1].
> I might try to deploy snapshot to maven repository.
>
> Once we feel it is ready to do the release, I will start the formal
> release process.
>
>
> [1] http://dubbo.apache.org/en-us/blog/prepare-an-apache-release.html
>
>
> --
> Best Regards！
> Huxing
>
> On Mon, Jan 7, 2019 at 1:48 PM jun liu  wrote:
> >
> > >>
> > >> Nice work!
> > >>
> > >> I think we should let the community to participate more in the release
> > >> process, for example,
> > >> 1. check out a release branch called 2.7.0-release
> > >> 2. encourage people to check it out, test it and report if there is
> > >> any regressions, bugs or issues.
> > >> 3. while we are doing the test, we can start going through the ASF
> > >> release process locally, once we think it is ready to start a formal
> > >> release note, it can be done very quickly.
> > >>
> > >> By the way, we need decide the release manager of 2.7.0 release. Is
> > >> there anyone who volunteer to do that?
> >
> > Sorry, I missed this mail.
> > * 2.7.0-release has been created
> > * we've froze the codebase, test is underway.
> >
> > > I'd like to be the release manager if no one is claiming it.
> >
> > Great, I can help you with the source/binary packaging and tagging
> things.
> >
> > Jun
> >
> > > On Jan 5, 2019, at 12:11 PM, Huxing Zhang  wrote:
> > >
> > > Hi,
> > >
> > > On Fri, Dec 28, 2018 at 10:45 AM Huxing Zhang 
> wrote:
> > >>
> > >> Nice work!
> > >>
> > >> I think we should let the community to participate more in the release
> > >> process, for example,
> > >> 1. check out a release branch called 2.7.0-release
> > >> 2. encourage people to check it out, test it and report if there is
> > >> any regressions, bugs or issues.
> > >> 3. while we are doing the test, we can start going through the ASF
> > >> release process locally, once we think it is ready to start a formal
> > >> release note, it can be done very quickly.
> > >>
> > >> By the way, we need decide the release manager of 2.7.0 release. Is
> > >> there anyone who volunteer to do that?
> > >
> > > I'd like to be the release manager if no one is claiming it.
> > >>
> > >> On Thu, Dec 27, 2018 at 11:53 PM jun liu  wrote:
> > >>>
> > >>> Hi, All
> > >>>
> > >>> I am writing this mail to
> > >>>
> > >>> * Keep you refreshed of the latest status about v2.7.0.
> > >>> * Call for efforts on code review and tests
> > >>> * Discuss possible release schedules of v2.7.0.
> > >>>
> > >>> About v2.7, it’s going to be a milestone version, in which will make
> some significant changes. Most importantly, we will complete all IP
> Clearance related works. Technically speaking, it’s from this version on
> that a Dubbo release starts fully follows the Apache rules (lawfully),
> totally independent from any other third-party organizations or companies.
> Secondly, this version will include many new features that have received
> wide attention from the community, by supporting these features, we can
> better resolve the community’s long accumulated demands. Last but not
> least, we have made some architectural changes in this version, made Dubbo
> closer to the micro-service architecture, take the newly introduced
> configuration center as an example, it can work both as the center of
> Externalized Configuration at startup and as the center of service
> management configurations at runtime.
> > >>>
> > >>> To summarize, the contents already included in the CodeBase are:
> > >>>
> > >>> * Config Center: Zookeeper, Apollo, Nacos
> > >>> * Externalized Configuration
> > >>> * Service governance enhancement: dynamic configuration & routing
> rule
> > >>> * Repackage to 'org.apache.dubbo'
> > >>> * Java 8 support
> > >>> * Async programming support
> > >>>
> > >>> Most of the candidates listed above are in the proposal list that we
> have discussed in some threads before. For a more detailed description of
> these features or how they are realized, you can refer to the draft
> development documentations within this link[1]
> > >>>
> > >>> Thanks to the efforts 

[incubator-dubbo-samples] branch samples-for-2.7.0-SNAPSHOT updated: properties configuration format from aa-bc-dd to aaBcDd

[victory]

This is an automated email from the ASF dual-hosted git repository.

victory pushed a commit to branch samples-for-2.7.0-SNAPSHOT
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo-samples.git


The following commit(s) were added to refs/heads/samples-for-2.7.0-SNAPSHOT by 
this push:
 new f8ed983  properties configuration format from aa-bc-dd to aaBcDd
f8ed983 is described below

commit f8ed98353155beaa66f9a79f63712eebf66d66b6
Author: cvictory 
AuthorDate: Wed Jan 2 19:06:10 2019 +0800

properties configuration format from aa-bc-dd to aaBcDd
---
 .../src/main/resources/dubbo.properties   | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/dubbo-samples-simplified-registry/dubbo-samples-simplified-registry-xml/src/main/resources/dubbo.properties
 
b/dubbo-samples-simplified-registry/dubbo-samples-simplified-registry-xml/src/main/resources/dubbo.properties
index 9636821..c420ab3 100644
--- 
a/dubbo-samples-simplified-registry/dubbo-samples-simplified-registry-xml/src/main/resources/dubbo.properties
+++ 
b/dubbo-samples-simplified-registry/dubbo-samples-simplified-registry-xml/src/main/resources/dubbo.properties
@@ -17,7 +17,7 @@
 #
 #
 
-dubbo.registrydata.simple-provider-config=true
-dubbo.registrydata.extra-provider-keys=retries,owner
-dubbo.registrydata.simple-consumer-config=true
-dubbo.registrydata.extra-consumer-keys=actives,owner
+dubbo.registryData.simpleProviderConfig=true
+dubbo.registryData.extraProviderKeys=retries,owner
+dubbo.registryData.simpleConsumerConfig=true
+dubbo.registryData.extraConsumerKeys=actives,owner

[incubator-dubbo-samples] branch samples-for-2.7.0-SNAPSHOT updated: resilience4j dubbo sample

[victory]

This is an automated email from the ASF dual-hosted git repository.

victory pushed a commit to branch samples-for-2.7.0-SNAPSHOT
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo-samples.git


The following commit(s) were added to refs/heads/samples-for-2.7.0-SNAPSHOT by 
this push:
 new 1b85eb6  resilience4j dubbo sample
1b85eb6 is described below

commit 1b85eb6f974dcaa9b8246600dc091cd37e34d3e9
Author: cvictory 
AuthorDate: Wed Jan 2 15:10:20 2019 +0800

resilience4j dubbo sample
---
 .../apache/dubbo/samples/api/GreetingsService.java |   6 +-
 .../dubbo/samples/governance/AsyncConsumer.java|  23 ++--
 .../governance/filter/AsyncPostprocessFilter.java  |   9 +-
 .../main/resources/spring/dubbo-demo-consumer.xml  |   2 +-
 .../main/resources/spring/dubbo-demo-provider.xml  |   4 +-
 .../Resilience4jAnnotationConsumer.java|   2 +-
 .../resilience4j/action/AnnotationAction.java  |  39 --
 .../filter/Resilience4jCircuitBreakerFilter.java   |  39 +-
 .../filter/Resilience4jRateLimiterFilter.java  |  13 +-
 .../resilience4j/impl/AnnotationServiceImpl.java   |   2 +-
 .../impl/CircuitBreakerServiceImpl.java|  14 ++-
 .../resilience4j/impl/RateLimiterServiceImpl.java  |   2 +-
 .../resources/spring/dubbo-consumer.properties |   3 +-
 .../resources/spring/dubbo-provider.properties |   2 +-
 .../dubbo-samples-resilience4j-springboot2/pom.xml |  95 ++
 .../Resilience4jBootAnnotationConsumer.java|  58 -
 .../Resilience4jBootAnnotationProvider.java|  61 -
 .../EmbeddedZooKeeper.java |   2 +-
 .../api/AnnotationService.java |   2 +-
 .../api/CircuitBreakerService.java}|  10 +-
 .../api/RateLimiterService.java}   |  10 +-
 .../Resilience4jBootConsumerApplication.java   |  57 +
 .../consumer}/action/AnnotationAction.java |  10 +-
 .../action/CircuitBreakMethodWrapper.java} |  28 ++---
 .../consumer/action/CircuitBreakTypeWrapper.java}  |  28 ++---
 .../consumer/action/CircuitBreakerAction.java  | 138 +
 .../consumer/action/RateLimiterAction.java |  75 +++
 .../consumer/controller/TestController.java| 103 +++
 .../provider/DubbConfiguration.java}   |  15 ++-
 .../Resilience4jBootProviderApplication.java   |  67 ++
 .../provider}/impl/AnnotationServiceImpl.java  |  10 +-
 .../provider}/impl/CircuitBreakerServiceImpl.java  |  18 ++-
 .../provider}/impl/RateLimiterServiceImpl.java |   8 +-
 ...onsumer.properties => application-consumer.yml} |  16 ++-
 ...onsumer.properties => application-provider.yml} |  15 ++-
 .../{log4j.properties => application.yml}  |  28 +++--
 .../src/main/resources/logback-spring.xml  |  45 +++
 .../resources/spring/dubbo-consumer.properties |  11 +-
 .../resources/spring/dubbo-provider.properties |  11 +-
 dubbo-samples-resilience4j/pom.xml |   2 +-
 dubbo-samples-spring-boot-hystrix/pom.xml  |   6 +
 41 files changed, 813 insertions(+), 276 deletions(-)

diff --git 
a/dubbo-samples-api/src/main/java/org/apache/dubbo/samples/api/GreetingsService.java
 
b/dubbo-samples-api/src/main/java/org/apache/dubbo/samples/api/GreetingsService.java
index 5d21f1d..888d6cb 100644
--- 
a/dubbo-samples-api/src/main/java/org/apache/dubbo/samples/api/GreetingsService.java
+++ 
b/dubbo-samples-api/src/main/java/org/apache/dubbo/samples/api/GreetingsService.java
@@ -18,9 +18,9 @@
 
 package org.apache.dubbo.samples.api;
 
-import com.alibaba.dubbo.config.async.DubboAsync;
-
-@DubboAsync
+//import com.alibaba.dubbo.config.async.DubboAsync;
+//
+//@DubboAsync
 public interface GreetingsService {
 String sayHi(String name);
 }
diff --git 
a/dubbo-samples-async/dubbo-samples-async-generated-future/src/main/java/org/apache/dubbo/samples/governance/AsyncConsumer.java
 
b/dubbo-samples-async/dubbo-samples-async-generated-future/src/main/java/org/apache/dubbo/samples/governance/AsyncConsumer.java
index 7198a88..c5e16b1 100644
--- 
a/dubbo-samples-async/dubbo-samples-async-generated-future/src/main/java/org/apache/dubbo/samples/governance/AsyncConsumer.java
+++ 
b/dubbo-samples-async/dubbo-samples-async-generated-future/src/main/java/org/apache/dubbo/samples/governance/AsyncConsumer.java
@@ -19,26 +19,21 @@
 
 package org.apache.dubbo.samples.governance;
 
-import org.apache.dubbo.samples.api.GreetingsServiceAsync;
-import org.springframework.context.support.ClassPathXmlApplicationContext;
-
-import java.util.concurrent.CompletableFuture;
-
 /**
  * CallbackConsumer
  */
 public class AsyncConsumer {
 
 public static void main(String[] args) throws Exception {
-ClassPathXmlApplicationContext context = new 
ClassPathXmlApplicationContext(new 
String[]{"META-INF/spring/async-consumer.xml"});
-context.start(

Re: travis ci are failing

[victory]

I check this issue.
The metadata is written asynchronously, so getting data return null .
Firstly I will add more sleep time when getting data return null.
If there are still problems， I will add some events to listen the put
action.

Ian Luo  于2018年12月28日周五 下午5:21写道：

> I think it is caused by this:
>
> Running org.apache.dubbo.metadata.store.redis.RedisMetadataReportTest
> log4j:WARN No appenders could be found for logger
> (org.apache.dubbo.common.logger.LoggerFactory).
> log4j:WARN Please initialize the log4j system properly.
> log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig
> for more info.
> Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.773
> sec <<< FAILURE! - in
> org.apache.dubbo.metadata.store.redis.RedisMetadataReportTest
>
> testStoreProvider(org.apache.dubbo.metadata.store.redis.RedisMetadataReportTest)
>  Time elapsed: 1.253 sec  <<< ERROR!
> org.apache.dubbo.rpc.RpcException: Failed to put to redis . cause: null
> at
> org.apache.dubbo.metadata.store.redis.RedisMetadataReportTest.testStoreProvider(RedisMetadataReportTest.java:80)
> Caused by: java.lang.AssertionError
> at
> org.apache.dubbo.metadata.store.redis.RedisMetadataReportTest.testStoreProvider(RedisMetadataReportTest.java:74)
>
>
> -Ian.
>
>
> On Fri, Dec 28, 2018 at 3:05 PM Imteyaz Khan 
> wrote:
>
> > In travis I am seeing ci are running successfully for jdk1.8 and same is
> > failing for jdak 11. Looking the the log found some test cases are
> failing?
> > Is any one has encountered/seen the same problem?
> >
> >
> >
> >
> https://travis-ci.org/apache/incubator-dubbo/builds/472901130?utm_source=github_status_medium=notification
> >
> > On Fri, Dec 28, 2018 at 10:24 AM Xin Wang 
> > wrote:
> >
> > > > Is this particular issue solved, without tuning JVM option?
> > >
> > > Yes now ci  of  master branch passed
> > >
> > > Ian Luo  于2018年12月28日周五 上午11:15写道：
> > >
> > > > Is this particular issue solved, without tuning JVM option?
> > > >
> > > > Thanks,
> > > > -Ian.
> > > >
> > > > On Thu, Dec 27, 2018 at 3:59 AM 徐靖峰  wrote:
> > > >
> > > > > I failed twice caused by OutOfMemery，are you the same as me？
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > -- Original --
> > > > > From: Imteyaz Khan 
> > > > > Date: Thu,Dec 27,2018 3:24 AM
> > > > > To: dev 
> > > > > Subject: Re: travis ci are failing
> > > > >
> > > > >
> > > > >
> > > > > Hi all,
> > > > >Travis CI are failing currently due to log size. Is it the same
> > > issue
> > > > > 3052 ?
> > > >
> > >
> >
>


-- 

Best Regard!
cvitory

[incubator-dubbo-samples] 01/02: fix hystrix issue, edit resilience4j project

[victory]

This is an automated email from the ASF dual-hosted git repository.

victory pushed a commit to branch samples-for-2.7.0-SNAPSHOT
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo-samples.git

commit 7e6828b2520970a093723b8db20b908461c8786f
Author: cvictory 
AuthorDate: Wed Dec 26 18:56:41 2018 +0800

fix hystrix issue, edit resilience4j project
---
 .../annotation/AnnotationConsumer.java |  8 ++--
 .../annotation/AnnotationProvider.java |  4 +-
 .../annotation/EmbeddedZooKeeper.java  |  4 +-
 .../annotation/action/AnnotationAction.java|  4 +-
 .../annotation/api/AnnotationService.java  |  2 +-
 .../annotation/impl/AnnotationServiceImpl.java |  6 +--
 .../annotation/AnnotationConsumer.java |  8 ++--
 .../annotation/AnnotationProvider.java |  4 +-
 .../annotation/EmbeddedZooKeeper.java  |  4 +-
 .../annotation/ZKTools.java|  2 +-
 .../annotation/action/AnnotationAction.java|  4 +-
 .../annotation/api/AnnotationService.java  |  2 +-
 .../annotation/impl/AnnotationServiceImpl.java |  4 +-
 .../hystrix/annotation/AnnotationConsumer.java |  4 +-
 .../hystrix/annotation/AnnotationProvider.java |  2 +-
 .../hystrix/annotation/EmbeddedZooKeeper.java  |  4 +-
 .../dubbo/samples/hystrix/annotation/ZKTools.java  |  2 +-
 .../annotation/action/AnnotationAction.java|  4 +-
 .../hystrix/annotation/api/AnnotationService.java  |  2 +-
 .../annotation/impl/AnnotationServiceImpl.java |  4 +-
 dubbo-samples-resilience4j/README.md   |  4 +-
 .../dubbo-samples-resilience4j-filter/README.md|  4 +-
 .../dubbo-samples-resilience4j-filter/pom.xml  |  5 ++
 .../samples/resilience4j/EmbeddedZooKeeper.java| 10 ++--
 .../Resilience4jAnnotationConsumer.java|  6 ++-
 .../Resilience4jAnnotationProvider.java| 20 
 .../resilience4j/action/AnnotationAction.java  | 47 ++-
 .../resilience4j/api/CircuitBreakerService.java|  4 +-
 .../resilience4j/api/RateLimiterService.java   |  4 +-
 .../filter/Resilience4jCircuitBreakerFilter.java   | 22 -
 .../filter/Resilience4jRateLimiterFilter.java  | 53 +++---
 .../resilience4j/impl/AnnotationServiceImpl.java   |  4 +-
 .../impl/CircuitBreakerServiceImpl.java| 10 +++-
 .../resilience4j/impl/RateLimiterServiceImpl.java  | 12 -
 .../META-INF/dubbo/org.apache.dubbo.rpc.Filter |  2 +
 .../resources/spring/dubbo-consumer.properties |  9 ++--
 .../resources/spring/dubbo-provider.properties | 10 ++--
 .../README.md  |  4 +-
 .../Resilience4jBootAnnotationConsumer.java|  2 +-
 .../Resilience4jBootAnnotationProvider.java|  2 +-
 40 files changed, 213 insertions(+), 99 deletions(-)

diff --git 
a/dubbo-samples-annotation/src/main/java/org/apache/dubbo/samples/hystrix/annotation/AnnotationConsumer.java
 
b/dubbo-samples-annotation/src/main/java/org/apache/dubbo/samples/simple/annotation/AnnotationConsumer.java
similarity index 86%
rename from 
dubbo-samples-annotation/src/main/java/org/apache/dubbo/samples/hystrix/annotation/AnnotationConsumer.java
rename to 
dubbo-samples-annotation/src/main/java/org/apache/dubbo/samples/simple/annotation/AnnotationConsumer.java
index ff80068..059e25d 100644
--- 
a/dubbo-samples-annotation/src/main/java/org/apache/dubbo/samples/hystrix/annotation/AnnotationConsumer.java
+++ 
b/dubbo-samples-annotation/src/main/java/org/apache/dubbo/samples/simple/annotation/AnnotationConsumer.java
@@ -17,10 +17,10 @@
  *
  */
 
-package org.apache.dubbo.samples.annotation;
+package org.apache.dubbo.samples.simple.annotation;
 
 import org.apache.dubbo.config.spring.context.annotation.EnableDubbo;
-import org.apache.dubbo.samples.annotation.action.AnnotationAction;
+import org.apache.dubbo.samples.simple.annotation.action.AnnotationAction;
 import 
org.springframework.context.annotation.AnnotationConfigApplicationContext;
 import org.springframework.context.annotation.ComponentScan;
 import org.springframework.context.annotation.Configuration;
@@ -41,9 +41,9 @@ public class AnnotationConsumer {
 }
 
 @Configuration
-@EnableDubbo(scanBasePackages = 
"org.apache.dubbo.samples.annotation.action")
+@EnableDubbo(scanBasePackages = 
"org.apache.dubbo.samples.simple.annotation.action")
 @PropertySource("classpath:/spring/dubbo-consumer.properties")
-@ComponentScan(value = {"org.apache.dubbo.samples.annotation.action"})
+@ComponentScan(value = 
{"org.apache.dubbo.samples.simple.annotation.action"})
 static public class ConsumerConfiguration {
 
 }
diff --git 
a/dubbo-samples-annotation/src/main/java/org/apache/dubbo/samples/hystrix/annotation/AnnotationProvider.java
 
b/dubbo-samples-annotation/src/main/java/org/apache/dubbo/samples/simple/annotation/A

[incubator-dubbo-samples] branch samples-for-2.7.0-SNAPSHOT updated (af4ad3a -> 9061f26)

[victory]

This is an automated email from the ASF dual-hosted git repository.

victory pushed a change to branch samples-for-2.7.0-SNAPSHOT
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo-samples.git.


from af4ad3a  refactor class name
 new 7e6828b  fix hystrix issue, edit resilience4j project
 new 9061f26  fix hystrix issue, edit resilience4j project

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../hystrix/annotation/EmbeddedZooKeeper.java  | 255 -
 .../annotation/AnnotationConsumer.java |   8 +-
 .../annotation/AnnotationProvider.java |   4 +-
 .../simple/annotation}/EmbeddedZooKeeper.java  |  12 +-
 .../annotation/action/AnnotationAction.java|   4 +-
 .../annotation/api/AnnotationService.java  |   2 +-
 .../annotation/impl/AnnotationServiceImpl.java |   6 +-
 .../annotation/AnnotationConsumer.java |   8 +-
 .../annotation/AnnotationProvider.java |   4 +-
 .../annotation/EmbeddedZooKeeper.java  |   2 +-
 .../annotation/ZKTools.java|   2 +-
 .../annotation/action/AnnotationAction.java|   4 +-
 .../annotation/api/AnnotationService.java  |   2 +-
 .../annotation/impl/AnnotationServiceImpl.java |   4 +-
 .../hystrix/annotation/EmbeddedZooKeeper.java  | 250 
 .../hystrix/annotation/AnnotationConsumer.java |   4 +-
 .../hystrix/annotation/AnnotationProvider.java |   2 +-
 .../hystrix/annotation/EmbeddedZooKeeper.java  |   4 +-
 .../dubbo/samples/hystrix/annotation/ZKTools.java  |   2 +-
 .../annotation/action/AnnotationAction.java|   4 +-
 .../hystrix/annotation/api/AnnotationService.java  |   2 +-
 .../annotation/impl/AnnotationServiceImpl.java |   4 +-
 dubbo-samples-resilience4j/README.md   |   4 +-
 .../dubbo-samples-resilience4j-filter/README.md|   4 +-
 .../dubbo-samples-resilience4j-filter/pom.xml  |   5 +
 .../samples/resilience4j/EmbeddedZooKeeper.java|  10 +-
 .../Resilience4jAnnotationConsumer.java|   4 +-
 .../Resilience4jAnnotationProvider.java|  17 +-
 .../resilience4j/action/AnnotationAction.java  |  48 +++-
 .../resilience4j/api/CircuitBreakerService.java|  22 +-
 .../resilience4j/api/RateLimiterService.java   |  22 +-
 .../filter/Resilience4jCircuitBreakerFilter.java   |  22 +-
 .../filter/Resilience4jRateLimiterFilter.java  |  52 +++--
 .../resilience4j/impl/AnnotationServiceImpl.java   |   4 +-
 .../impl/CircuitBreakerServiceImpl.java|  30 ++-
 .../resilience4j/impl/RateLimiterServiceImpl.java  |  30 ++-
 .../META-INF/dubbo/org.apache.dubbo.rpc.Filter |   2 +
 .../resources/spring/dubbo-consumer.properties |   9 +-
 .../resources/spring/dubbo-provider.properties |  10 +-
 .../README.md  |   4 +-
 .../Resilience4jBootAnnotationConsumer.java|   2 +-
 .../Resilience4jBootAnnotationProvider.java|   2 +-
 .../resilience4j/action/AnnotationAction.java  |   2 -
 dubbo-samples-resilience4j/pom.xml |   2 +-
 44 files changed, 287 insertions(+), 609 deletions(-)
 delete mode 100644 
dubbo-samples-annotation/src/main/java/org/apache/dubbo/samples/hystrix/annotation/EmbeddedZooKeeper.java
 rename 
dubbo-samples-annotation/src/main/java/org/apache/dubbo/samples/{hystrix => 
simple}/annotation/AnnotationConsumer.java (86%)
 rename 
dubbo-samples-annotation/src/main/java/org/apache/dubbo/samples/{hystrix => 
simple}/annotation/AnnotationProvider.java (93%)
 copy 
{dubbo-samples-generic-call/src/main/java/org/apache/dubbo/samples/generic/call 
=> 
dubbo-samples-annotation/src/main/java/org/apache/dubbo/samples/simple/annotation}/EmbeddedZooKeeper.java
 (99%)
 rename 
dubbo-samples-annotation/src/main/java/org/apache/dubbo/samples/{hystrix => 
simple}/annotation/action/AnnotationAction.java (90%)
 rename 
dubbo-samples-annotation/src/main/java/org/apache/dubbo/samples/{hystrix => 
simple}/annotation/api/AnnotationService.java (94%)
 rename 
dubbo-samples-annotation/src/main/java/org/apache/dubbo/samples/{hystrix => 
simple}/annotation/impl/AnnotationServiceImpl.java (89%)
 rename 
dubbo-samples-configcenter/dubbo-samples-configcenter-annotation/src/main/java/org/apache/dubbo/samples/{hystrix
 => configcenter}/annotation/AnnotationConsumer.java (84%)
 rename 
dubbo-samples-configcenter/dubbo-samples-configcenter-annotation/src/main/java/org/apache/dubbo/samples/{hystrix
 => configcenter}/annotation/AnnotationProvider.java (92%)
 copy 
{dubbo-samples-simplified-registry/dubbo-samples-simplified-registry-annotation/src/main/java/org/apache/dubbo/samples/simplified
 => 
dubbo-

[incubator-dubbo-samples] 02/02: fix hystrix issue, edit resilience4j project

[victory]

This is an automated email from the ASF dual-hosted git repository.

victory pushed a commit to branch samples-for-2.7.0-SNAPSHOT
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo-samples.git

commit 9061f26f4b40a59e30f3ded6961d9dcece1d021a
Merge: 7e6828b af4ad3a
Author: cvictory 
AuthorDate: Wed Dec 26 19:03:54 2018 +0800

fix hystrix issue, edit resilience4j project

 .../resilience4j/Resilience4jAnnotationConsumer.java |  1 +
 .../resilience4j/Resilience4jAnnotationProvider.java |  1 +
 .../resilience4j/action/AnnotationAction.java|  3 ---
 .../resilience4j/api/CircuitBreakerService.java  | 18 ++
 .../samples/resilience4j/api/RateLimiterService.java | 18 ++
 .../filter/Resilience4jCircuitBreakerFilter.java |  2 +-
 .../filter/Resilience4jRateLimiterFilter.java|  4 +++-
 .../resilience4j/impl/CircuitBreakerServiceImpl.java | 20 +++-
 .../resilience4j/impl/RateLimiterServiceImpl.java| 18 ++
 .../resilience4j/action/AnnotationAction.java|  2 --
 dubbo-samples-resilience4j/pom.xml   |  2 +-
 11 files changed, 80 insertions(+), 9 deletions(-)

diff --cc 
dubbo-samples-resilience4j/dubbo-samples-resilience4j-filter/src/main/java/org/apache/dubbo/samples/resilience4j/Resilience4jAnnotationProvider.java
index 6b213cb,4e6037b..84e725d
--- 
a/dubbo-samples-resilience4j/dubbo-samples-resilience4j-filter/src/main/java/org/apache/dubbo/samples/resilience4j/Resilience4jAnnotationProvider.java
+++ 
b/dubbo-samples-resilience4j/dubbo-samples-resilience4j-filter/src/main/java/org/apache/dubbo/samples/resilience4j/Resilience4jAnnotationProvider.java
@@@ -20,8 -20,11 +20,9 @@@
  package org.apache.dubbo.samples.resilience4j;
  
  
 -import org.apache.dubbo.config.ProviderConfig;
  import org.apache.dubbo.config.spring.context.annotation.EnableDubbo;
+ 
  import 
org.springframework.context.annotation.AnnotationConfigApplicationContext;
 -import org.springframework.context.annotation.Bean;
  import org.springframework.context.annotation.Configuration;
  import org.springframework.context.annotation.PropertySource;
  
diff --cc 
dubbo-samples-resilience4j/dubbo-samples-resilience4j-filter/src/main/java/org/apache/dubbo/samples/resilience4j/action/AnnotationAction.java
index 448454e,785c9eb..80fe535
--- 
a/dubbo-samples-resilience4j/dubbo-samples-resilience4j-filter/src/main/java/org/apache/dubbo/samples/resilience4j/action/AnnotationAction.java
+++ 
b/dubbo-samples-resilience4j/dubbo-samples-resilience4j-filter/src/main/java/org/apache/dubbo/samples/resilience4j/action/AnnotationAction.java
@@@ -20,12 -20,9 +20,9 @@@
  package org.apache.dubbo.samples.resilience4j.action;
  
  import org.apache.dubbo.config.annotation.Reference;
--
--
  import org.apache.dubbo.samples.resilience4j.api.AnnotationService;
 +import org.apache.dubbo.samples.resilience4j.api.CircuitBreakerService;
 +import org.apache.dubbo.samples.resilience4j.api.RateLimiterService;
- import org.springframework.beans.CachedIntrospectionResults;
  import org.springframework.stereotype.Component;
  
  /**
diff --cc 
dubbo-samples-resilience4j/dubbo-samples-resilience4j-filter/src/main/java/org/apache/dubbo/samples/resilience4j/api/CircuitBreakerService.java
index ae14529,8c824ff..e701713
--- 
a/dubbo-samples-resilience4j/dubbo-samples-resilience4j-filter/src/main/java/org/apache/dubbo/samples/resilience4j/api/CircuitBreakerService.java
+++ 
b/dubbo-samples-resilience4j/dubbo-samples-resilience4j-filter/src/main/java/org/apache/dubbo/samples/resilience4j/api/CircuitBreakerService.java
@@@ -1,3 -1,3 +1,21 @@@
++/*
++ *
++ *   Licensed to the Apache Software Foundation (ASF) under one or more
++ *   contributor license agreements.  See the NOTICE file distributed with
++ *   this work for additional information regarding copyright ownership.
++ *   The ASF licenses this file to You under the Apache License, Version 2.0
++ *   (the "License"); you may not use this file except in compliance with
++ *   the License.  You may obtain a copy of the License at
++ *
++ *   http://www.apache.org/licenses/LICENSE-2.0
++ *
++ *   Unless required by applicable law or agreed to in writing, software
++ *   distributed under the License is distributed on an "AS IS" BASIS,
++ *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ *   See the License for the specific language governing permissions and
++ *   limitations under the License.
++ *
++ */
  package org.apache.dubbo.samples.resilience4j.api;
  
  /**
diff --cc 
dubbo-samples-resilience4j/dubbo-samples-resilience4j-filter/src/main/java/org/apache/dubbo/samples/resilience4j/api/RateLimiterService.java
index 3c37fbf,3383625..0025d20
--- 
a/dubbo-samples-resilience4j/dubbo-samples-resilience4j-filter/src/main/java/org/apache/dubbo/samples/resilience4j/api/RateLimiterService.java
+++ 
b/dubbo-samples-resilience4j/dubbo-samples-resilience4j-filt

[incubator-dubbo-samples] branch samples-for-2.7.0-SNAPSHOT updated (e21930b -> 158bd22)

[victory]

This is an automated email from the ASF dual-hosted git repository.

victory pushed a change to branch samples-for-2.7.0-SNAPSHOT
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo-samples.git.


from e21930b  update license
 new c8ab454  fix sample issue
 new 4cc7029  init resilience4j project
 new 560b787  Merge branch 'samples-for-2.7.0-SNAPSHOT' of 
github.com:dubbo/dubbo-samples into samples-for-2.7.0-SNAPSHOT
 new 158bd22  fix hystrix sample issue; add resilience sample

The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 dubbo-samples-annotation/pom.xml   |   7 +-
 .../samples/annotation/EmbeddedZooKeeper.java  | 255 -
 .../annotation/AnnotationConsumer.java |   0
 .../hystrix}/annotation/AnnotationProvider.java|   0
 .../hystrix}/annotation/EmbeddedZooKeeper.java |   0
 .../annotation/action/AnnotationAction.java|   0
 .../annotation/api/AnnotationService.java  |   0
 .../annotation/impl/AnnotationServiceImpl.java |   0
 .../annotation/AnnotationConsumer.java |   0
 .../hystrix}/annotation/AnnotationProvider.java|   0
 .../annotation/EmbeddedZooKeeper.java  |   0
 .../samples/{ => hystrix}/annotation/ZKTools.java  |   0
 .../annotation/action/AnnotationAction.java|   0
 .../hystrix}/annotation/api/AnnotationService.java |   0
 .../annotation/impl/AnnotationServiceImpl.java |   0
 .../annotation/AnnotationConsumer.java |   0
 .../annotation/AnnotationProvider.java |   0
 .../annotation/EmbeddedZooKeeper.java  |   0
 .../samples/{ => hystrix}/annotation/ZKTools.java  |   0
 .../annotation/action/AnnotationAction.java|   0
 .../annotation/api/AnnotationService.java  |   0
 .../annotation/impl/AnnotationServiceImpl.java |   0
 .../src/main/resources/spring/merge-consumer.xml   |   4 +-
 .../README.md  |   0
 .../dubbo-samples-resilience4j-filter}/README.md   |   0
 .../dubbo-samples-resilience4j-filter}/pom.xml |  39 ++--
 .../samples/resilience4j}/EmbeddedZooKeeper.java   |  12 +-
 .../Resilience4jAnnotationConsumer.java|  20 +-
 .../Resilience4jAnnotationProvider.java|  15 +-
 .../resilience4j}/action/AnnotationAction.java |   8 +-
 .../resilience4j}/api/AnnotationService.java   |   2 +-
 .../resilience4j/api/CircuitBreakerService.java|   7 +
 .../resilience4j/api/RateLimiterService.java   |   7 +
 .../filter/Resilience4jCircuitBreakerFilter.java   |  42 
 .../filter/Resilience4jRateLimiterFilter.java  |  42 
 .../resilience4j}/impl/AnnotationServiceImpl.java  |  10 +-
 .../impl/CircuitBreakerServiceImpl.java|   7 +
 .../resilience4j/impl/RateLimiterServiceImpl.java  |   7 +
 .../META-INF/dubbo/org.apache.dubbo.rpc.Filter |   0
 .../src/main/resources/log4j.properties|   0
 .../resources/spring/dubbo-consumer.properties |   0
 .../resources/spring/dubbo-provider.properties |   0
 .../README.md  |   0
 .../pom.xml|  39 ++--
 .../samples/resilience4j}/EmbeddedZooKeeper.java   |  12 +-
 .../Resilience4jBootAnnotationConsumer.java|  20 +-
 .../Resilience4jBootAnnotationProvider.java|  13 +-
 .../resilience4j}/action/AnnotationAction.java |   8 +-
 .../resilience4j}/api/AnnotationService.java   |   2 +-
 .../resilience4j}/impl/AnnotationServiceImpl.java  |  10 +-
 .../src/main/resources/log4j.properties|   0
 .../resources/spring/dubbo-consumer.properties |   0
 .../resources/spring/dubbo-provider.properties |   0
 .../pom.xml|  11 +-
 dubbo-samples-spring-hystrix/README.md |   4 +-
 .../hystrix/annotation}/EmbeddedZooKeeper.java |  12 +-
 .../annotation/HystrixAnnotationConsumer.java} |  15 +-
 .../annotation/HystrixAnnotationProvider.java} |  13 +-
 .../annotation/action/AnnotationAction.java|   4 +-
 .../hystrix}/annotation/api/AnnotationService.java |   2 +-
 .../annotation/impl/AnnotationServiceImpl.java |   6 +-
 .../spring/hystrix-dubbo-consumer.properties   |  10 +-
 .../spring/hystrix-dubbo-provider.properties   |  10 +-
 pom.xml|   1 +
 64 files changed, 279 insertions(+), 397 deletions(-)
 delete mode 100644 
dubbo-samples-annotation/src/main/java/org/apache/dubbo/samples/annotation/EmbeddedZooKeeper.java
 rename dubbo-samples-annotation/src/main/java/org/apache/dubbo/samples/{ => 
hystrix}/annotation/AnnotationConsumer.java (100%)
 rename 
{dubbo-samples-configcenter/dubbo-samples-configce

[incubator-dubbo-samples] 01/04: fix sample issue

[victory]

This is an automated email from the ASF dual-hosted git repository.

victory pushed a commit to branch samples-for-2.7.0-SNAPSHOT
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo-samples.git

commit c8ab4546aca0d52f01b70a31420b08c07411e13a
Author: cvictory 
AuthorDate: Tue Dec 25 17:27:59 2018 +0800

fix sample issue
---
 dubbo-samples-annotation/pom.xml | 7 ++-
 dubbo-samples-merge/src/main/resources/spring/merge-consumer.xml | 4 ++--
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/dubbo-samples-annotation/pom.xml b/dubbo-samples-annotation/pom.xml
index 2382088..1c3bd48 100644
--- a/dubbo-samples-annotation/pom.xml
+++ b/dubbo-samples-annotation/pom.xml
@@ -39,5 +39,10 @@
 org.apache.dubbo
 dubbo-metadata-report-api
 
+
+com.alibaba.spring
+spring-context-support
+1.0.2
+
 
-
\ No newline at end of file
+
diff --git a/dubbo-samples-merge/src/main/resources/spring/merge-consumer.xml 
b/dubbo-samples-merge/src/main/resources/spring/merge-consumer.xml
index 2b91a72..18d04d4 100644
--- a/dubbo-samples-merge/src/main/resources/spring/merge-consumer.xml
+++ b/dubbo-samples-merge/src/main/resources/spring/merge-consumer.xml
@@ -28,6 +28,6 @@
 
 
 
-
+
 
-
\ No newline at end of file
+

[incubator-dubbo-samples] 03/04: Merge branch 'samples-for-2.7.0-SNAPSHOT' of github.com:dubbo/dubbo-samples into samples-for-2.7.0-SNAPSHOT

[victory]

This is an automated email from the ASF dual-hosted git repository.

victory pushed a commit to branch samples-for-2.7.0-SNAPSHOT
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo-samples.git

commit 560b7873ec9917bc0110a4fb55fe44eea170cf3c
Merge: 4cc7029 e21930b
Author: cvictory 
AuthorDate: Wed Dec 26 14:18:17 2018 +0800

Merge branch 'samples-for-2.7.0-SNAPSHOT' of github.com:dubbo/dubbo-samples 
into samples-for-2.7.0-SNAPSHOT

 dubbo-samples-generic-call/pom.xml | 19 +++
 1 file changed, 19 insertions(+)

[incubator-dubbo-samples] 02/04: init resilience4j project

[victory]

This is an automated email from the ASF dual-hosted git repository.

victory pushed a commit to branch samples-for-2.7.0-SNAPSHOT
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo-samples.git

commit 4cc70290677c1789fdf6222f2a0e967cc8197f2f
Author: cvictory 
AuthorDate: Wed Dec 26 14:18:04 2018 +0800

init resilience4j project
---
 dubbo-samples-resilience4j/README.md   |  17 ++
 .../dubbo-samples-resilience4j-filter/README.md|  17 ++
 .../dubbo-samples-resilience4j-filter/pom.xml  |  75 ++
 .../samples/resilience4j/AnnotationConsumer.java   |  63 +
 .../samples/resilience4j/AnnotationProvider.java   |  61 +
 .../samples/resilience4j/EmbeddedZooKeeper.java| 255 +
 .../resilience4j/action/AnnotationAction.java  |  46 
 .../resilience4j/api/AnnotationService.java|  29 +++
 .../filter/Resilience4jCircuitBreakerFilter.java   |  42 
 .../resilience4j/impl/AnnotationServiceImpl.java   |  40 
 .../src/main/resources/log4j.properties|  26 +++
 .../resources/spring/dubbo-consumer.properties |  22 ++
 .../resources/spring/dubbo-provider.properties |  23 ++
 .../README.md  |  17 ++
 .../dubbo-samples-resilience4j-springboot2/pom.xml |  75 ++
 .../samples/resilience4j/AnnotationConsumer.java   |  63 +
 .../samples/resilience4j/AnnotationProvider.java   |  61 +
 .../samples/resilience4j/EmbeddedZooKeeper.java| 255 +
 .../resilience4j/action/AnnotationAction.java  |  46 
 .../resilience4j/api/AnnotationService.java|  29 +++
 .../filter/Resilience4jCircuitBreakerFilter.java   |  42 
 .../resilience4j/impl/AnnotationServiceImpl.java   |  40 
 .../src/main/resources/log4j.properties|  26 +++
 .../resources/spring/dubbo-consumer.properties |  22 ++
 .../resources/spring/dubbo-provider.properties |  23 ++
 dubbo-samples-resilience4j/pom.xml |  43 
 .../samples/resilience4j/AnnotationConsumer.java   |  63 +
 .../samples/resilience4j/AnnotationProvider.java   |  61 +
 .../samples/resilience4j/EmbeddedZooKeeper.java| 255 +
 .../resilience4j/action/AnnotationAction.java  |  46 
 .../resilience4j/api/AnnotationService.java|  29 +++
 .../filter/Resilience4jCircuitBreakerFilter.java   |  42 
 .../resilience4j/impl/AnnotationServiceImpl.java   |  40 
 .../src/main/resources/log4j.properties|  26 +++
 .../resources/spring/dubbo-consumer.properties |  22 ++
 .../resources/spring/dubbo-provider.properties |  23 ++
 pom.xml|   1 +
 37 files changed, 2066 insertions(+)

diff --git a/dubbo-samples-resilience4j/README.md 
b/dubbo-samples-resilience4j/README.md
new file mode 100644
index 000..12c735e
--- /dev/null
+++ b/dubbo-samples-resilience4j/README.md
@@ -0,0 +1,17 @@
+## dubbo spring hystrix sample
+
+### Start Provider
+
+Run `org.apache.dubbo.samples.annotation.AnnotationProvider`
+
+
+### Start Consumer
+
+Run `org.apache.dubbo.samples.annotation.AnnotationConsumer`
+
+### Result
+
+0. Start provider
+0. Start consumer
+0. The provider print `java.lang.RuntimeException: Exception to show hystrix 
enabled`. The exception stack conatins hystrix command info.
+0. The consumer print `result :hystrix fallback value`, which means hystrix 
fallback configuration is effect.
diff --git 
a/dubbo-samples-resilience4j/dubbo-samples-resilience4j-filter/README.md 
b/dubbo-samples-resilience4j/dubbo-samples-resilience4j-filter/README.md
new file mode 100644
index 000..12c735e
--- /dev/null
+++ b/dubbo-samples-resilience4j/dubbo-samples-resilience4j-filter/README.md
@@ -0,0 +1,17 @@
+## dubbo spring hystrix sample
+
+### Start Provider
+
+Run `org.apache.dubbo.samples.annotation.AnnotationProvider`
+
+
+### Start Consumer
+
+Run `org.apache.dubbo.samples.annotation.AnnotationConsumer`
+
+### Result
+
+0. Start provider
+0. Start consumer
+0. The provider print `java.lang.RuntimeException: Exception to show hystrix 
enabled`. The exception stack conatins hystrix command info.
+0. The consumer print `result :hystrix fallback value`, which means hystrix 
fallback configuration is effect.
diff --git 
a/dubbo-samples-resilience4j/dubbo-samples-resilience4j-filter/pom.xml 
b/dubbo-samples-resilience4j/dubbo-samples-resilience4j-filter/pom.xml
new file mode 100644
index 000..f7b6552
--- /dev/null
+++ b/dubbo-samples-resilience4j/dubbo-samples-resilience4j-filter/pom.xml
@@ -0,0 +1,75 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+dubbo-samples-all
+org.apache.dubbo
+1.0-SNAPSHOT
+../../pom.xml
+
+4.0.0
+
+dubbo-samples-resili

[incubator-dubbo-samples] 01/03: update dubbo version to 2.6.5

[victory]

This is an automated email from the ASF dual-hosted git repository.

victory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo-samples.git

commit 26df37f1d2e48cdf183f9876c5ef50aee66b6b41
Author: cvictory 
AuthorDate: Wed Nov 21 11:45:13 2018 +0800

update dubbo version to 2.6.5
---
 dubbo-samples-docker/pom.xml   | 4 ++--
 dubbo-samples-echo/src/main/resources/spring/echo-provider.xml | 4 ++--
 pom.xml| 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/dubbo-samples-docker/pom.xml b/dubbo-samples-docker/pom.xml
index cd13133..add7699 100644
--- a/dubbo-samples-docker/pom.xml
+++ b/dubbo-samples-docker/pom.xml
@@ -41,7 +41,7 @@
 
 com.alibaba
 dubbo
-2.6.4
+2.6.5
 
 
 io.netty
@@ -127,4 +127,4 @@
 
 
 
-
\ No newline at end of file
+
diff --git a/dubbo-samples-echo/src/main/resources/spring/echo-provider.xml 
b/dubbo-samples-echo/src/main/resources/spring/echo-provider.xml
index b840950..30b7052 100644
--- a/dubbo-samples-echo/src/main/resources/spring/echo-provider.xml
+++ b/dubbo-samples-echo/src/main/resources/spring/echo-provider.xml
@@ -23,7 +23,7 @@
http://dubbo.apache.org/schema/dubbo 
http://dubbo.apache.org/schema/dubbo/dubbo.xsd;>
 
 
-
+
 
 
 
@@ -37,4 +37,4 @@
 
 
 
-
\ No newline at end of file
+
diff --git a/pom.xml b/pom.xml
index f6db953..4684404 100644
--- a/pom.xml
+++ b/pom.xml
@@ -61,8 +61,8 @@
 1.8
 1.8
 4.3.16.RELEASE
-2.6.4
-2.6.4
+2.6.5
+2.6.5
 2.12.0
 1.1.0.Final
 4.2.0.Final

[incubator-dubbo-samples] 03/03: fix sample issue

[victory]

This is an automated email from the ASF dual-hosted git repository.

victory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo-samples.git

commit 1eb0b9e881bde0f5fec76a893c665f547f4ae72c
Author: cvictory 
AuthorDate: Tue Dec 25 17:26:49 2018 +0800

fix sample issue
---
 dubbo-samples-annotation/pom.xml | 9 -
 dubbo-samples-merge/src/main/resources/spring/merge-consumer.xml | 4 ++--
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/dubbo-samples-annotation/pom.xml b/dubbo-samples-annotation/pom.xml
index 8383f11..1211662 100644
--- a/dubbo-samples-annotation/pom.xml
+++ b/dubbo-samples-annotation/pom.xml
@@ -27,4 +27,11 @@
 
 dubbo-samples-annotation
 
-
\ No newline at end of file
+
+
+com.alibaba.spring
+spring-context-support
+1.0.2
+
+
+
diff --git a/dubbo-samples-merge/src/main/resources/spring/merge-consumer.xml 
b/dubbo-samples-merge/src/main/resources/spring/merge-consumer.xml
index 5db3bf7..21c1401 100644
--- a/dubbo-samples-merge/src/main/resources/spring/merge-consumer.xml
+++ b/dubbo-samples-merge/src/main/resources/spring/merge-consumer.xml
@@ -26,6 +26,6 @@
 
 
 
-
+
 
-
\ No newline at end of file
+

[incubator-dubbo-samples] 02/03: Merge branch 'master' of github.com:dubbo/dubbo-samples

[victory]

This is an automated email from the ASF dual-hosted git repository.

victory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo-samples.git

commit e2a99ebd67771a76be289470e7d52e3786932160
Merge: 26df37f d4e1a15
Author: cvictory 
AuthorDate: Mon Dec 24 14:39:49 2018 +0800

Merge branch 'master' of github.com:dubbo/dubbo-samples

 README.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

[incubator-dubbo-samples] branch samples-for-2.7.0-SNAPSHOT updated: fix compile issue for refactor metadataReport

[victory]

This is an automated email from the ASF dual-hosted git repository.

victory pushed a commit to branch samples-for-2.7.0-SNAPSHOT
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo-samples.git


The following commit(s) were added to refs/heads/samples-for-2.7.0-SNAPSHOT by 
this push:
 new 4ad375e  fix compile issue for refactor metadataReport
4ad375e is described below

commit 4ad375e7d93c75b798d696183359abe8b2872a85
Author: cvictory 
AuthorDate: Mon Dec 24 15:33:02 2018 +0800

fix compile issue for refactor metadataReport
---
 .../metadatareport/configcenter/MetadataConfigcenterConsumer.java | 8 +---
 .../metadatareport/configcenter/MetadataConfigcenterProvider.java | 7 ---
 .../local/annotation/MetadataLocalAnnotationConsumer.java | 5 +++--
 .../local/annotation/MetadataLocalAnnotationProvider.java | 5 +++--
 .../metadatareport/local/xml/MetadataLocalXmlConsumer.java| 5 +++--
 .../metadatareport/local/xml/MetadataLocalXmlProvider.java| 5 +++--
 .../dubbo-samples-simplified-registry-annotation/pom.xml  | 1 +
 .../dubbo-samples-simplified-registry-nosimple/pom.xml| 1 +
 .../dubbo-samples-simplified-registry-xml/pom.xml | 1 +
 9 files changed, 24 insertions(+), 14 deletions(-)

diff --git 
a/dubbo-samples-metadata-report/dubbo-samples-metadata-report-configcenter/src/main/java/org/apache/dubbo/samples/metadatareport/configcenter/MetadataConfigcenterConsumer.java
 
b/dubbo-samples-metadata-report/dubbo-samples-metadata-report-configcenter/src/main/java/org/apache/dubbo/samples/metadatareport/configcenter/MetadataConfigcenterConsumer.java
index 3c18fb0..d95c15d 100644
--- 
a/dubbo-samples-metadata-report/dubbo-samples-metadata-report-configcenter/src/main/java/org/apache/dubbo/samples/metadatareport/configcenter/MetadataConfigcenterConsumer.java
+++ 
b/dubbo-samples-metadata-report/dubbo-samples-metadata-report-configcenter/src/main/java/org/apache/dubbo/samples/metadatareport/configcenter/MetadataConfigcenterConsumer.java
@@ -19,10 +19,11 @@
 
 package org.apache.dubbo.samples.metadatareport.configcenter;
 
+import org.apache.dubbo.common.Constants;
 import org.apache.dubbo.common.URL;
 import org.apache.dubbo.common.extension.ExtensionLoader;
 import org.apache.dubbo.config.spring.context.annotation.EnableDubbo;
-import org.apache.dubbo.metadata.identifier.ConsumerMetadataIdentifier;
+import org.apache.dubbo.metadata.identifier.MetadataIdentifier;
 import org.apache.dubbo.remoting.zookeeper.ZookeeperClient;
 import org.apache.dubbo.remoting.zookeeper.ZookeeperTransporter;
 import 
org.apache.dubbo.samples.metadatareport.configcenter.action.AnnotationAction;
@@ -57,10 +58,11 @@ public class MetadataConfigcenterConsumer {
 static public class ConsumerConfiguration {
 
 }
-private static void printServiceData(){
+
+private static void printServiceData() {
 // get service data(consumer) from zookeeper.
 ZookeeperClient zookeeperClient = 
ExtensionLoader.getExtensionLoader(ZookeeperTransporter.class).getExtension("curator").connect(new
 URL("zookeeper", "127.0.0.1", 2181));
-String data = zookeeperClient.getContent(ZkUtil.getNodePath(new 
ConsumerMetadataIdentifier(AnnotationService.class.getName(), "1.1.1", 
"d-test", "metadatareport-configcenter-consumer")));
+String data = zookeeperClient.getContent(ZkUtil.getNodePath(new 
MetadataIdentifier(AnnotationService.class.getName(), "1.1.1", "d-test", 
Constants.CONSUMER_SIDE, "metadatareport-configcenter-consumer")));
 
System.out.println("*");
 System.out.println("Dubbo store consumer param into special store(as 
zk,redis) when configcenter:");
 System.out.println(data);
diff --git 
a/dubbo-samples-metadata-report/dubbo-samples-metadata-report-configcenter/src/main/java/org/apache/dubbo/samples/metadatareport/configcenter/MetadataConfigcenterProvider.java
 
b/dubbo-samples-metadata-report/dubbo-samples-metadata-report-configcenter/src/main/java/org/apache/dubbo/samples/metadatareport/configcenter/MetadataConfigcenterProvider.java
index 3f31338..07fceb9 100644
--- 
a/dubbo-samples-metadata-report/dubbo-samples-metadata-report-configcenter/src/main/java/org/apache/dubbo/samples/metadatareport/configcenter/MetadataConfigcenterProvider.java
+++ 
b/dubbo-samples-metadata-report/dubbo-samples-metadata-report-configcenter/src/main/java/org/apache/dubbo/samples/metadatareport/configcenter/MetadataConfigcenterProvider.java
@@ -20,11 +20,12 @@
 package org.apache.dubbo.samples.metadatareport.configcenter;
 
 
+import org.apache.dubbo.common.Constants;
 import org.apache.dubbo.common.URL;
 import org.apache.dubbo.common.extension.ExtensionLoader;
 import org.apache.dubbo.config.ProviderConfig;
 import org.apache.dubbo.config.spring.co

Re: [DISCUSSION] Call for ideas and suggestions on v2.7.0 designs and implementations.

[victory]

All of this features are the biggest concert in the community.
I have some questions：
1.中心化配置的优先级
2.路由的逻辑比较复杂，和原来低版本的兼容性怎么保证
3.Tag路由改造了，和原来的兼容性怎么样？
4.Environment这个东西是怎么明确职责的？最好能有个独立的说明。
--
1. Prioritization of centralized configuration
2. The logic of the route is more complicated, and the compatibility with
the original low version is guaranteed.
3.Tag routing has been modified, how is the compatibility with the original?
4. How does the Environment clear responsibility? It is best to have an
independent description.


jun liu  于2018年12月7日周五 下午8:11写道：

> Hi, All
>
> I’ve just posted some blogs[4] on Github issues relating to the design
> principles and implementations of V2.7.0,  the content are based mainly on
> my own understanding of the 2.7.0 codebase (hosted on branch
> dev-metadata[1]) and the previous discussions[2][3].
>
> Recently, I spent plenty of my spare times on 2.7.0, mainly focusing on
> metadata refactoring, I am happy to see that v2.7.0 is on a right direction
> to meet community requirements and keeps evolving. The main changes or
> features already included in v2.7.0 branch are:
>
> * Config Center: Zookeeper, Apollo, Nacos
> * Externalized Configuration
> * Service governance enhancement: dynamic configuration & routing rule
> * Repackage to 'org.apache.dubbo'
> * Java 8 support
> * Async programming support
>
> Most of the features above have been mentioned or discussed on the mailing
> list or Github issues days or months ago. But during the design and coding
> process, more details come up that need to be further discussed and
> decided. The design principles and implementations on v2.7.0 branch now are
> far from the the final decision, they may be not the best choice or even
> turn to be unreasonable, so you can think them as a prototype
> implementation provided for your reference. Now, we need to know your
> opinions on v2.7.0, please help to review the designs and codes, whenever
> you have better ideas or suggestions, please don’t hesitate to let the
> community know.
>
> FYI: If you want to know more implementation details and try to read the
> codes or commits directly, you may find it hard to follow, because there’re
> too much file changes in there. So I would suggest you read the summaries I
> wrote in the blogs first and then dive into the code related to the part
> you interest one by one.
>
> 1. https://github.com/apache/incubator-dubbo/tree/dev-metadata
> 2. https://github.com/apache/incubator-dubbo/issues/2030
> 3. https://github.com/apache/incubator-dubbo/issues/2341
> 4. https://github.com/apache/incubator-dubbo/issues/2919
>
> Jun
>
>

-- 

Best Regard!
cvitory

[ANNOUNCE] Apache Dubbo(incubating) 2.6.5 has been released

[victory]

Hi, community,

I am pleased to announce that the 2.6.5 version has just been released.
Both the source release[1] and the maven binary release[2] are available
now, you can also find the detailed release notes in here[3] or quickly
check the important changes I list below:

Enhancements / Features：
- Reactor the generation rule for @Service Bean name
[#2235](https://github.com/apache/incubator-dubbo/issues/2235)
- Introduce a new Spring ApplicationEvent for ServiceBean exporting
[#2251](https://github.com/apache/incubator-dubbo/issues/2251)
- [Enhancement] the algorithm of load issue on Windows.
[#1641](https://github.com/apache/incubator-dubbo/issues/1641)
- add javadoc to dubbo-all module good first issue.
[#2600](https://github.com/apache/incubator-dubbo/issues/2600)
- [Enhancement] Reactor the generation rule for @Service Bean name
type/enhancement
[#2235](https://github.com/apache/incubator-dubbo/issues/2235)
- Optimize LeastActiveLoadBalance and add weight test case.
[#2540](https://github.com/apache/incubator-dubbo/issues/2540)
- Smooth Round Robin selection.
[#2578](https://github.com/apache/incubator-dubbo/issues/2578)
[#2647](https://github.com/apache/incubator-dubbo/pull/2647)
- [Enhancement] Resolve the placeholders for sub-properties.
[#2297](https://github.com/apache/incubator-dubbo/issues/2297)
- Add ability to turn off SPI auto injection, special support for
generic Object type injection.
[#2681](https://github.com/apache/incubator-dubbo/pull/2681)

Bugfixes：
- @Service(register=false) is not work.
[#2063](https://github.com/apache/incubator-dubbo/issues/2063)
- Our customized serialization id exceeds the maximum limit, now it
cannot work on 2.6.2 anymore.
[#1903](https://github.com/apache/incubator-dubbo/issues/1903)
- Consumer throws RpcException after RegistryDirectory notify in high
QPS. [#2016](https://github.com/apache/incubator-dubbo/issues/2016)
- Annotation @Reference can't support to export a service with a sync
one and an async one .
[#2194](https://github.com/apache/incubator-dubbo/issues/2194)
- 
`org.apache.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor#generateReferenceBeanCacheKey`
has a bug. [#2522](https://github.com/apache/incubator-dubbo/issues/2522)
- 2.6.x Spring Event & Bugfix.
[#2256](https://github.com/apache/incubator-dubbo/issues/2256)
- Fix incorrect descriptions for dubbo-serialization module.
[#2665](https://github.com/apache/incubator-dubbo/issues/2665)
- A empty directory
dubbo-config/dubbo-config-spring/src/test/resources/work after package
source tgz. [#2560](https://github.com/apache/incubator-dubbo/issues/2560)
- Fixed 2.6.x branch a minor issue with doConnect not using
getConnectTimeout() in NettyClient.  (*No issue*).
[#2622](https://github.com/apache/incubator-dubbo/pull/2622)
- Bean name of @service annotated class does not resolve placeholder.
[#1755](https://github.com/apache/incubator-dubbo/issues/1755)



Normally, you can smoothly upgrade to the new version from any version
before 2.6.5 without having to do too many changes to your apps and without
having to worry about any incompatible problems.
If you have any usage questions, or have problems when upgrading or find
any problems about enhancements included in this release, please don’t
hesitate to let us know by sending feedback to this mailing list or filing
an issue on github[4].

1. https://dist.apache.org/repos/dist/release/incubator/dubbo/2.6.5/

2. http://central.maven.org/maven2/com/alibaba/
3. https://github.com/apache/incubator-dubbo/releases
4. https://github.com/apache/incubator-dubbo/issues


Best Regard!
cvictory

[RESULT][VOTE]Release Apache Dubbo (Incubating) 2.6.5 [RC1]

[victory]

We’ve received 3 '+1 binding votes' and one '+1 non-binding vote':

+1 binding, Ian Luo
+1 binding, Huxing Zhang
+1 binding, Jun Liu

+1 non-binding, Yuhang Xiu

I will create a new vote thread in Apache community now.

Best regards,
The Apache Dubbo (Incubating) Team

Re: [ANN] Welcome new committer Victory Cao

[victory]

It's my honour to be part of the Dubbo family! !
My name is Victory Cao, from Hangzhou, Zhejiang, China. I had work at
alibaba for 8 years. but I am new at dubbo. Maybe I need some help from all
of you.
I will try my best to make dubbo better , and dubbo will become better
definitely.

Finally, thank you for your trust.
Happy weekend!



Huxing Zhang  于2018年11月16日周五 下午5:05写道：

> Congrats and welcome!
> On Thu, Nov 15, 2018 at 4:23 PM Jun Liu  wrote:
> >
> > Hi, Community,
> >
> > On behalf of the Dubbo PPMC, I am pleased to announce that Victory Cao,
> > whose github id is cvictory, has been voted in as a new Dubbo committer.
> >
> > Please join me to say congratulations to him!
> >
> > Victory, would you please briefly introduce yourself to the community?
> >
> > Best regards,
> > Jun
>
>
>
> --
> Best Regards！
> Huxing
>


-- 

Best Regard!
cvitory

[VOTE]: Release Apache Dubbo (Incubating) 2.6.5 [RC1]

[victory]

Hello Dubbo Community,

This is a call for vote to release Apache Dubbo (Incubating) version 2.6.5.

The release candidates (RC1):
https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.5

Git tag for the release (RC1):
https://github.com/apache/incubator-dubbo/tree/dubbo-2.6.5

Hash for the release tag:
38e0f15be33a5edb35b45d2c5d7c6be753bdd888

Release Notes:
https://github.com/apache/incubator-dubbo/blob/dubbo-2.6.5/CHANGES.md

The artifacts have been signed with Key : A3A1CA7A5D4A3981, which can be
found in the keys file:
https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS

The vote will be open for at least 72 hours or until necessary number of
votes are reached.

Please vote accordingly:

[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason

Thanks,
The Apache Dubbo (Incubating) Team

Re: [Discuss] Prepare for release of dubbo-2.6.5

[victory]

I would like to be the manager of 2.6.5 release.

I will do some prepare work for this release including collect the issue
list and package snapshot jar.
So I donot know if I have the permission to package the release jar .   I
expect to get the answer from the community.

jun liu  于2018年10月30日周二 下午5:31写道：

> Hi, Victory
>
> Well done! That’s a detailed summary of the release candidates for 2.6.5.
>
> I wonder if you'd like to be the manager of this release?
> The main responsibilities of a manager would be:
> 1. find out all changes already included in branch 2.6.x and the issues
> that need to be fixed in this version.
> 2. list all notable changes with a release note page.
> 3. verify the release candidate and make sure all changes are reasonable
> and stable enough to be released.
> 4. package the release candidate and start the vote process in community
> and count the vote.
> 5. make the final release.
>
> For steps 1~3, I believe you can do it very well with your knowledges of
> Dubbo and the efforts you have payed on 2.6.5 recently.
> For step 4, I am not sure if a contributor without a committer's right is
> allowed to do that.
> For the last step 5, it’s only limited to the committers or PMCs, but I
> think someone has the right can help you with that.
>
> Best regards,
> Jun
>
> > On Oct 30, 2018, at 2:22 PM, victory  wrote:
> >
> > I have checked again， and modify the release note here:
> > https://github.com/apache/incubator-dubbo/blob/2.6.5-release/CHANGES.md
> .
> > You can also check it as follow:
> >
> > Enhancements / Features：
> >
> >   - @Service and @Reference Optimization #2655
> >   <https://github.com/apache/incubator-dubbo/issues/2655> #2657
> >   <https://github.com/apache/incubator-dubbo/issues/2657>
> >   - [Enhancement] the algorithm of load issue on Windows good first issue
> >   help wanted. #1641
> >   <https://github.com/apache/incubator-dubbo/issues/1641>
> >   - add javadoc to dubbo-all module good first issue help wanted. #2600
> >   <https://github.com/apache/incubator-dubbo/issues/2600>
> >   - [Enhancement] Reactor the generation rule for @Service Bean name
> >   type/enhancement #2235
> >   <https://github.com/apache/incubator-dubbo/issues/2235>
> >   - Optimize LeastActiveLoadBalance and add weight test case. #2584
> >   <https://github.com/apache/incubator-dubbo/issues/2584>
> >   - Smooth Round Robin selection. #2647
> >   <https://github.com/apache/incubator-dubbo/pull/2647>
> >   - [Enhancement] Resolve the placeholders for sub-properties. #2297
> >   <https://github.com/apache/incubator-dubbo/pull/2297>
> >
> > Bugfixes：
> >
> >   - @Service(register=false) is not work. #2063
> >   <https://github.com/apache/incubator-dubbo/issues/2063>
> >   - Our customized serialization id exceeds the maximum limit, now it
> >   cannot work on 2.6.2 anymore. #1903
> >   <https://github.com/apache/incubator-dubbo/issues/1903> #2668
> >   <https://github.com/apache/incubator-dubbo/pull/2668>
> >   - Annotation @Reference can't support to export a service with a sync
> >   one and an async one . #2194
> >   <https://github.com/apache/incubator-dubbo/issues/2194>
> >   -
> >
>  
> org.apache.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor#generateReferenceBeanCacheKey
> > has
> >   a bug. #2522 <https://github.com/apache/incubator-dubbo/issues/2522>
> >   - 2.6.x Spring Event & Bugfix. #2256
> >   <https://github.com/apache/incubator-dubbo/issues/2256>
> >   - fix #1641, support get system load on windows. #2621
> >   <https://github.com/apache/incubator-dubbo/issues/2621>
> >   - Fix incorrect descriptions for dubbo-serialization module. pr#2624
> >   <https://github.com/apache/incubator-dubbo/pull/2624>
> >   - A empty directory
> >   dubbo-config/dubbo-config-spring/src/test/resources/work after package
> >   source tgz. #2560 <
> https://github.com/apache/incubator-dubbo/issues/2560>
> >   - Fixed 2.6.x branch a minor issue with doConnect not using
> >   getConnectTimeout() in NettyClient. #2622
> >   <https://github.com/apache/incubator-dubbo/issues/2622>
> >   - merge fix from 2.7.0 to 2.6.x (if invoker is destroyed due to address
> >   refresh from registry, let's allow the current invoke to proceed).
> #2680
> >   <https://github.com/apache/incubator-dubbo/pull/2680>
> >   - Bean name of @service annotated class does not resolve placeholder.
> >   #1755 <https://github.com/apache/incubato

Re: [ANN] Welcome new committer Jinkai Ma

[victory]

congratulation ！ My idol.

周吉林  于2018年10月31日周三 上午9:10写道：

> congratulations to Jinkai Ma!
>
>
> YunKun Huang  于2018年10月30日周二 上午11:54写道：
>
> > Congratulations ！
> >
> > On 2018/10/30 03:20:58, yuhang xiu  wrote:
> > > Hi, jinkai
> > > Congratulations on your joining!
> > >
> > > Jun Liu  于2018年10月30日周二 上午11:15写道：
> > >
> > > >
> > > >
> > > > > On Oct 30, 2018, at 11:12 AM, Jun Liu  wrote:
> > > > >
> > > > > Hi, Community,
> > > > >
> > > > > On behalf of the Dubbo PPMC, I am pleased to announce that Jinkai
> Ma,
> > > > whose github id is majinkai, has been voted in as a new Dubbo
> > committer.
> > > > >
> > > > > Please join me to say congratulations to him!
> > > > >
> > > > > Jinkai, would you please briefly introduce yourself to the
> community?
> > > > >
> > > > > Best regards,
> > > > > Jun
> > > >
> > > >
> > >
> >
>


-- 

Best Regard!
cvitory

Re: [Discuss] Prepare for release of dubbo-2.6.5

[victory]

I have checked again， and modify the release note here:
https://github.com/apache/incubator-dubbo/blob/2.6.5-release/CHANGES.md .
You can also check it as follow:

Enhancements / Features：

   - @Service and @Reference Optimization #2655
   <https://github.com/apache/incubator-dubbo/issues/2655> #2657
   <https://github.com/apache/incubator-dubbo/issues/2657>
   - [Enhancement] the algorithm of load issue on Windows good first issue
   help wanted. #1641
   <https://github.com/apache/incubator-dubbo/issues/1641>
   - add javadoc to dubbo-all module good first issue help wanted. #2600
   <https://github.com/apache/incubator-dubbo/issues/2600>
   - [Enhancement] Reactor the generation rule for @Service Bean name
   type/enhancement #2235
   <https://github.com/apache/incubator-dubbo/issues/2235>
   - Optimize LeastActiveLoadBalance and add weight test case. #2584
   <https://github.com/apache/incubator-dubbo/issues/2584>
   - Smooth Round Robin selection. #2647
   <https://github.com/apache/incubator-dubbo/pull/2647>
   - [Enhancement] Resolve the placeholders for sub-properties. #2297
   <https://github.com/apache/incubator-dubbo/pull/2297>

Bugfixes：

   - @Service(register=false) is not work. #2063
   <https://github.com/apache/incubator-dubbo/issues/2063>
   - Our customized serialization id exceeds the maximum limit, now it
   cannot work on 2.6.2 anymore. #1903
   <https://github.com/apache/incubator-dubbo/issues/1903> #2668
   <https://github.com/apache/incubator-dubbo/pull/2668>
   - Annotation @Reference can't support to export a service with a sync
   one and an async one . #2194
   <https://github.com/apache/incubator-dubbo/issues/2194>
   -
   
org.apache.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor#generateReferenceBeanCacheKey
has
   a bug. #2522 <https://github.com/apache/incubator-dubbo/issues/2522>
   - 2.6.x Spring Event & Bugfix. #2256
   <https://github.com/apache/incubator-dubbo/issues/2256>
   - fix #1641, support get system load on windows. #2621
   <https://github.com/apache/incubator-dubbo/issues/2621>
   - Fix incorrect descriptions for dubbo-serialization module. pr#2624
   <https://github.com/apache/incubator-dubbo/pull/2624>
   - A empty directory
   dubbo-config/dubbo-config-spring/src/test/resources/work after package
   source tgz. #2560 <https://github.com/apache/incubator-dubbo/issues/2560>
   - Fixed 2.6.x branch a minor issue with doConnect not using
   getConnectTimeout() in NettyClient. #2622
   <https://github.com/apache/incubator-dubbo/issues/2622>
   - merge fix from 2.7.0 to 2.6.x (if invoker is destroyed due to address
   refresh from registry, let's allow the current invoke to proceed). #2680
   <https://github.com/apache/incubator-dubbo/pull/2680>
   - Bean name of @service annotated class does not resolve placeholder.
   #1755 <https://github.com/apache/incubator-dubbo/issues/1755>


Ian Luo  于2018年10月30日周二 上午10:22写道：

> +1, we should mention this. Victory, would you mind to iterate all changes
> since release 2.6.4 to make sure nothing is missing in the release note?
>
> Thanks,
> -Ian.
>
>
> On Mon, Oct 29, 2018 at 11:04 PM 秦金卫  wrote:
>
> > there is an important enhancement:
> > https://github.com/apache/incubator-dubbo/pull/2647  ?
> > At 2018-10-29 19:47:30, "victory"  wrote:
> > >Hello Community,
> > >
> > >
> > >As 2.6.4 has been released, I think we are ready for the next
> maintenance
> > >release 2.6.5 now. In this release, we plan to solve the issues and
> > >requirements reported by the community recently:
> > >
> > >
> > >Enhancements / Features：
> > >
> > >- [#2655](https://github.com/apache/incubator-dubbo/issues/2655)
> @Service
> > >and @Reference Optimization
> > >
> > >- [#1641](https://github.com/apache/incubator-dubbo/issues/1641)
> > >[Enhancement] the algorithm of load issue on Windows good first issue
> help
> > >wanted
> > >
> > >- [#2600](https://github.com/apache/incubator-dubbo/issues/2600) add
> > >javadoc to dubbo-all module good first issue help wanted
> > >
> > >- [#2519](https://github.com/apache/incubator-dubbo/issues/2519) Can we
> > >make the bom and all module become the child module of dubbo-parent?
> > >
> > >- [#2235](https://github.com/apache/incubator-dubbo/issues/2235)
> > >[Enhancement] Reactor the generation rule for @Service Bean name
> > >type/enhancement
> > >
> > >
> > >Bugfixes：
> > >
> > >- [#2063](https://github.com/apache/incubator-dubbo/issues/2063)
> > >

Re: [Discuss] Prepare for release of dubbo-2.6.5

[victory]

Ok， I left out some issues in the one week.  All issues are from
https://github.com/apache/incubator-dubbo/issues/2663
I will check again, and all of you can let me know if I left out something.

秦金卫  于2018年10月29日周一 下午11:04写道：

> there is an important enhancement:
> https://github.com/apache/incubator-dubbo/pull/2647  ?
> At 2018-10-29 19:47:30, "victory"  wrote:
> >Hello Community,
> >
> >
> >As 2.6.4 has been released, I think we are ready for the next maintenance
> >release 2.6.5 now. In this release, we plan to solve the issues and
> >requirements reported by the community recently:
> >
> >
> >Enhancements / Features：
> >
> >- [#2655](https://github.com/apache/incubator-dubbo/issues/2655) @Service
> >and @Reference Optimization
> >
> >- [#1641](https://github.com/apache/incubator-dubbo/issues/1641)
> >[Enhancement] the algorithm of load issue on Windows good first issue help
> >wanted
> >
> >- [#2600](https://github.com/apache/incubator-dubbo/issues/2600) add
> >javadoc to dubbo-all module good first issue help wanted
> >
> >- [#2519](https://github.com/apache/incubator-dubbo/issues/2519) Can we
> >make the bom and all module become the child module of dubbo-parent?
> >
> >- [#2235](https://github.com/apache/incubator-dubbo/issues/2235)
> >[Enhancement] Reactor the generation rule for @Service Bean name
> >type/enhancement
> >
> >
> >Bugfixes：
> >
> >- [#2063](https://github.com/apache/incubator-dubbo/issues/2063)
> >@Service(register=false) is not work
> >
> >- [#1903](https://github.com/apache/incubator-dubbo/issues/1903) Our
> >customized serialization id exceeds the maximum limit, now it cannot work
> >on 2.6.2 anymore.
> >
> >- [#2194](https://github.com/apache/incubator-dubbo/issues/2194)
> Annotation
> >@Reference can't support to export a service with a sync one and an async
> >one
> >
> >- [#2522](https://github.com/apache/incubator-dubbo/issues/2522)
>
> >`org.apache.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor#generateReferenceBeanCacheKey`
> >has a bug
> >
> >- [#2256](https://github.com/apache/incubator-dubbo/issues/2256) 2.6.x
> >Spring Event & Bugfix
> >
> >- [#2621](https://github.com/apache/incubator-dubbo/issues/2621) fix
> #1641,
> >support get system load on windows.
> >
> >- [pr#2624](https://github.com/apache/incubator-dubbo/pull/2624) Fix
> >incorrect descriptions for dubbo-serialization module
> >
> >- [#2560](https://github.com/apache/incubator-dubbo/issues/2560) A empty
> >directory dubbo-config/dubbo-config-spring/src/test/resources/work after
> >package source tgz
> >
> >
> >Issues and Pull Requests, check [milestone-2.6.5](
> >https://github.com/apache/incubator-dubbo/milestone/21)
> >
> >
> >Check the link below for more detailed release candidates:
> >
> >https://github.com/apache/incubator-dubbo/blob/2.6.5-release/CHANGES.md
> >
> >
> >I’d like to be the PM of this release, I suggest we start this release
> cycle
> >as soon as possible. If you are ok to that, let's start the official
> release
> >vote in community at this week late or next week.
> >
> >
> >We kindly ask for your suggestions on the release candidates, and you can
> also
> >help verify all the commits on the release branch:
> >
> >https://github.com/apache/incubator-dubbo/tree/2.6.5-release
> >
> >
> >Best Regard!
> >
> >cvictory
>


-- 

Best Regard!
cvitory

[Discuss] Prepare for release of dubbo-2.6.5

[victory]

Hello Community,


As 2.6.4 has been released, I think we are ready for the next maintenance
release 2.6.5 now. In this release, we plan to solve the issues and
requirements reported by the community recently:


Enhancements / Features：

- [#2655](https://github.com/apache/incubator-dubbo/issues/2655) @Service
and @Reference Optimization

- [#1641](https://github.com/apache/incubator-dubbo/issues/1641)
[Enhancement] the algorithm of load issue on Windows good first issue help
wanted

- [#2600](https://github.com/apache/incubator-dubbo/issues/2600) add
javadoc to dubbo-all module good first issue help wanted

- [#2519](https://github.com/apache/incubator-dubbo/issues/2519) Can we
make the bom and all module become the child module of dubbo-parent?

- [#2235](https://github.com/apache/incubator-dubbo/issues/2235)
[Enhancement] Reactor the generation rule for @Service Bean name
type/enhancement


Bugfixes：

- [#2063](https://github.com/apache/incubator-dubbo/issues/2063)
@Service(register=false) is not work

- [#1903](https://github.com/apache/incubator-dubbo/issues/1903) Our
customized serialization id exceeds the maximum limit, now it cannot work
on 2.6.2 anymore.

- [#2194](https://github.com/apache/incubator-dubbo/issues/2194) Annotation
@Reference can't support to export a service with a sync one and an async
one

- [#2522](https://github.com/apache/incubator-dubbo/issues/2522)
`org.apache.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor#generateReferenceBeanCacheKey`
has a bug

- [#2256](https://github.com/apache/incubator-dubbo/issues/2256) 2.6.x
Spring Event & Bugfix

- [#2621](https://github.com/apache/incubator-dubbo/issues/2621) fix #1641,
support get system load on windows.

- [pr#2624](https://github.com/apache/incubator-dubbo/pull/2624) Fix
incorrect descriptions for dubbo-serialization module

- [#2560](https://github.com/apache/incubator-dubbo/issues/2560) A empty
directory dubbo-config/dubbo-config-spring/src/test/resources/work after
package source tgz


Issues and Pull Requests, check [milestone-2.6.5](
https://github.com/apache/incubator-dubbo/milestone/21)


Check the link below for more detailed release candidates:

https://github.com/apache/incubator-dubbo/blob/2.6.5-release/CHANGES.md


I’d like to be the PM of this release, I suggest we start this release cycle
as soon as possible. If you are ok to that, let's start the official release
vote in community at this week late or next week.


We kindly ask for your suggestions on the release candidates, and you can also
help verify all the commits on the release branch:

https://github.com/apache/incubator-dubbo/tree/2.6.5-release


Best Regard!

cvictory