Re: [VOTE] Release Apache dubbo-go v1.4.0 RC2

2020-04-19 Thread wongoo
On Sat, Apr 18, 2020 at 7:50 AM Justin Mclean 
wrote:

>
> - Couldn’t compile from source but probably my setup
>

@Justin Thanks for the vote, can you tell what's the problem for
compiling,  maybe we can improve it in next release.

-- 
Regards,
Wongoo


Re:[VOTE] Release Apache dubbo-go v1.4.0 RC2

2020-04-17 Thread KimmKing
+1 

I checked:
- signatures and hashes 
- LICENSE and NOTICE 
- No unexpected binary files
- All source file have ASF headers






At 2020-04-16 14:22:30, "wongoo"  wrote:
>Hello Dubbo/Dubbogo Community,
>
> This is a call for vote to release Apache dubbo-go version v1.4.0 RC2.
>
> The release candidates:
>https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.4.0-rc2/
> Git tag for the release: https://github.com/apache/dubbo-go/tree/1.4
> Hash for the release tag: 320e307b92edb5466ad55db10342ad3eee95c982
> Release Notes: https://github.com/apache/dubbo-go/blob/1.4/CHANGE.md
> The artifacts have been signed with Key :7DB68550D366E4C0, which can be
>found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until necessary number of
>votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo-go Team


Re: [VOTE] Release Apache dubbo-go v1.4.0 RC2

2020-04-17 Thread Justin Mclean
Hi,

+1 (binding)

I checked:
- signatures and hashes correct
- LICENSE and NOTICE good
- No unexpected binary files
- All source file have ASF headers
- Couldn’t compile from source but probably my setup

Thanks,
Justin

Re: [VOTE] Release Apache dubbo-go v1.4.0 RC2

2020-04-17 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[x] Is there any 3rd party code contained inside the release? If so:
  [ ] Does the software have a compatible license?
  [ ] Are all software licenses mentioned in LICENSE?
  [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
  Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ] Have relevant parts of those NOTICE files been added to this NOTICE
file?
[ ] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..

Regards,
-Ian.

On Thu, Apr 16, 2020 at 2:25 PM wongoo  wrote:

> Hello Dubbo/Dubbogo Community,
>
>  This is a call for vote to release Apache dubbo-go version v1.4.0 RC2.
>
>  The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.4.0-rc2/
>  Git tag for the release: https://github.com/apache/dubbo-go/tree/1.4
>  Hash for the release tag: 320e307b92edb5466ad55db10342ad3eee95c982
>  Release Notes: https://github.com/apache/dubbo-go/blob/1.4/CHANGE.md
>  The artifacts have been signed with Key :7DB68550D366E4C0, which can be
> found in the keys file:
>  https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
>  The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
>  Please vote accordingly:
>  [ ] +1 approve
>  [ ] +0 no opinion
>  [ ] -1 disapprove with the reason
>
>  Thanks,
>  The Apache Dubbo-go Team
>


Re:[VOTE] Release Apache dubbo-go v1.4.0 RC2

2020-04-16 Thread 陈龙星
+1
At 2020-04-16 14:22:30, "wongoo"  wrote:
>Hello Dubbo/Dubbogo Community,
>
> This is a call for vote to release Apache dubbo-go version v1.4.0 RC2.
>
> The release candidates:
>https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.4.0-rc2/
> Git tag for the release: https://github.com/apache/dubbo-go/tree/1.4
> Hash for the release tag: 320e307b92edb5466ad55db10342ad3eee95c982
> Release Notes: https://github.com/apache/dubbo-go/blob/1.4/CHANGE.md
> The artifacts have been signed with Key :7DB68550D366E4C0, which can be
>found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until necessary number of
>votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo-go Team