Re: commit to master branch by mistake

2019-03-18 Thread Ian Luo 
Xianjun,

Pls. always go through pull request to submit a change next time, so that
there's other eyes watching out any mistake for you :)

Thanks,
-Ian.


On Sun, Mar 17, 2019 at 11:28 AM Xianjun Ke  wrote:

> thx, I've done it
>
> Xin Wang  于2019年3月17日周日 上午10:17写道：
>
> > I  think you can rollback  to the latest -1 commit  by command:
> >
> > git reset –hard commit-id
> >
> >
> >
> > Xianjun Ke  于2019年3月16日周六 下午9:52写道：
> >
> > > Hi community,
> > > I'm sorry,When I'm trying to fix 3678[1], I commited to the master
> branch
> > > by mistake.What should I
> > > do to revert this commit[2] ?
> > >
> > >
> > > [1] https://github.com/apache/incubator-dubbo/issues/3678
> > > [2]
> > >
> > >
> >
> https://github.com/apache/incubator-dubbo/commit/affc976120356c93a44f98f612184c06e8ddf09f
> > >
> >
>

Re: commit to master branch by mistake

2019-03-16 Thread Xianjun Ke 
thx, I've done it

Xin Wang  于2019年3月17日周日 上午10:17写道：

> I  think you can rollback  to the latest -1 commit  by command:
>
> git reset –hard commit-id
>
>
>
> Xianjun Ke  于2019年3月16日周六 下午9:52写道：
>
> > Hi community,
> > I'm sorry,When I'm trying to fix 3678[1], I commited to the master branch
> > by mistake.What should I
> > do to revert this commit[2] ?
> >
> >
> > [1] https://github.com/apache/incubator-dubbo/issues/3678
> > [2]
> >
> >
> https://github.com/apache/incubator-dubbo/commit/affc976120356c93a44f98f612184c06e8ddf09f
> >
>

Re: commit to master branch by mistake

2019-03-16 Thread Xin Wang 
I  think you can rollback  to the latest -1 commit  by command:

git reset –hard commit-id



Xianjun Ke  于2019年3月16日周六 下午9:52写道：

> Hi community,
> I'm sorry,When I'm trying to fix 3678[1], I commited to the master branch
> by mistake.What should I
> do to revert this commit[2] ?
>
>
> [1] https://github.com/apache/incubator-dubbo/issues/3678
> [2]
>
> https://github.com/apache/incubator-dubbo/commit/affc976120356c93a44f98f612184c06e8ddf09f
>

commit to master branch by mistake

2019-03-16 Thread Xianjun Ke 
Hi community,
I'm sorry,When I'm trying to fix 3678[1], I commited to the master branch
by mistake.What should I
do to revert this commit[2] ?


[1] https://github.com/apache/incubator-dubbo/issues/3678
[2]
https://github.com/apache/incubator-dubbo/commit/affc976120356c93a44f98f612184c06e8ddf09f