[GitHub] incubator-eagle pull request #355: EAGLE-471: fix AlertBolt introduce un-ser...

[mizeng]

Github user mizeng closed the pull request at:

https://github.com/apache/incubator-eagle/pull/355


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #355: EAGLE-471: fix AlertBolt introduce un-ser...

[RalphSu]

Github user RalphSu commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/355#discussion_r75072462
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/utils/SingletonExecutor.java
 ---
@@ -0,0 +1,32 @@
+package org.apache.eagle.alert.engine.utils;
+
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+
+/**
+ * @author mizeng
+ * @version v1.0
+ * @description TODO
--- End diff --

Remove TODO/FIXME if unnecessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #355: EAGLE-471: fix AlertBolt introduce un-ser...

[RalphSu]

Github user RalphSu commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/355#discussion_r75072403
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/utils/SingletonExecutor.java
 ---
@@ -0,0 +1,32 @@
+package org.apache.eagle.alert.engine.utils;
--- End diff --

Need apache license. Other wise this should mvn failed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #355: EAGLE-471: fix AlertBolt introduce un-ser...

[mizeng]

GitHub user mizeng opened a pull request:

https://github.com/apache/incubator-eagle/pull/355

EAGLE-471: fix AlertBolt introduce un-serializble member



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mizeng/incubator-eagle EAGLE-471

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/355.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #355


commit 476b9930c6619a797af7b14b7480bf935b6d01f8
Author: mizeng 
Date:   2016-08-17T05:51:08Z

EAGLE-471: fix AlertBolt introduce un-serializble member




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---