[jira] [Commented] (EAGLE-439) Introduce policy enable/disable support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414606#comment-15414606
 ] 

ASF GitHub Bot commented on EAGLE-439:
--

Github user RalphSu commented on the issue:

https://github.com/apache/incubator-eagle/pull/319
  
merged, pls help to close


> Introduce policy enable/disable support
> ---
>
> Key: EAGLE-439
> URL: https://issues.apache.org/jira/browse/EAGLE-439
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Garrett Li
>Assignee: Garrett Li
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-439) Introduce policy enable/disable support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414605#comment-15414605
 ] 

ASF GitHub Bot commented on EAGLE-439:
--

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-eagle/pull/319


> Introduce policy enable/disable support
> ---
>
> Key: EAGLE-439
> URL: https://issues.apache.org/jira/browse/EAGLE-439
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Garrett Li
>Assignee: Garrett Li
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-439) Introduce policy enable/disable support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414575#comment-15414575
 ] 

ASF GitHub Bot commented on EAGLE-439:
--

GitHub user garrettlish opened a pull request:

https://github.com/apache/incubator-eagle/pull/319

[EAGLE-439] Introduce policy enable/disable support



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/garrettlish/incubator-eagle eagle439

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/319.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #319


commit 17670acae1ad64ca378e8a60676f027845528dd8
Author: Xiancheng Li 
Date:   2016-08-08T10:00:43Z

[EAGLE-439] Introduce policy enable/disable support




> Introduce policy enable/disable support
> ---
>
> Key: EAGLE-439
> URL: https://issues.apache.org/jira/browse/EAGLE-439
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Garrett Li
>Assignee: Garrett Li
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-439) Introduce policy enable/disable support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414554#comment-15414554
 ] 

ASF GitHub Bot commented on EAGLE-439:
--

Github user garrettlish closed the pull request at:

https://github.com/apache/incubator-eagle/pull/318


> Introduce policy enable/disable support
> ---
>
> Key: EAGLE-439
> URL: https://issues.apache.org/jira/browse/EAGLE-439
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Garrett Li
>Assignee: Garrett Li
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-439) Introduce policy enable/disable support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414533#comment-15414533
 ] 

ASF GitHub Bot commented on EAGLE-439:
--

Github user RalphSu commented on a diff in the pull request:

https://github.com/apache/incubator-eagle/pull/318#discussion_r74170914
  
--- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/coordinator/PolicyDefinition.java
 ---
@@ -191,6 +200,10 @@ public String toString() {
 return String.format("{type=\"%s\",value=\"%s\"",type,value);
 }
 }
+
+public static enum PolicyStatus {
+   enabled, disabled
--- End diff --

captilized enum values to follow the code style


> Introduce policy enable/disable support
> ---
>
> Key: EAGLE-439
> URL: https://issues.apache.org/jira/browse/EAGLE-439
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Garrett Li
>Assignee: Garrett Li
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EAGLE-439) Introduce policy enable/disable support

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EAGLE-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414490#comment-15414490
 ] 

ASF GitHub Bot commented on EAGLE-439:
--

GitHub user garrettlish opened a pull request:

https://github.com/apache/incubator-eagle/pull/318

[EAGLE-439] Introduce policy enable/disable support



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/garrettlish/incubator-eagle eagle439

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-eagle/pull/318.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #318


commit ccd0d0aea37e7eac0b50c6d46b6db3309b05cc37
Author: Xiancheng Li 
Date:   2016-08-08T10:00:43Z

[EAGLE-439] Introduce policy enable/disable support




> Introduce policy enable/disable support
> ---
>
> Key: EAGLE-439
> URL: https://issues.apache.org/jira/browse/EAGLE-439
> Project: Eagle
>  Issue Type: Improvement
>Reporter: Garrett Li
>Assignee: Garrett Li
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)