[GitHub] incubator-eagle pull request #330: EAGLE-450: Alert check meta confliction
GitHub user mizeng opened a pull request: https://github.com/apache/incubator-eagle/pull/330 EAGLE-450: Alert check meta confliction You can merge this pull request into a Git repository by running: $ git pull https://github.com/mizeng/incubator-eagle EAGLE-450 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/330.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #330 commit c3ad49b3ee84121d93082f65de4962f820b44621 Author: mizeng <miz...@ebaysf.com> Date: 2016-08-11T10:16:28Z EAGLE-450: Alert check meta confliction --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #330: EAGLE-450: Alert check meta confliction
Github user mizeng closed the pull request at: https://github.com/apache/incubator-eagle/pull/330 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #324: EAGLE-440: Alert mongodb storage refine
Github user mizeng closed the pull request at: https://github.com/apache/incubator-eagle/pull/324 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #328: EAGLE-440: Alert mongodb storage refine
GitHub user mizeng opened a pull request: https://github.com/apache/incubator-eagle/pull/328 EAGLE-440: Alert mongodb storage refine You can merge this pull request into a Git repository by running: $ git pull https://github.com/mizeng/incubator-eagle develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/328.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #328 commit 678437aadb5ca6e5c7256fabd40b4966e4227911 Author: mizeng <miz...@ebaysf.com> Date: 2016-08-10T08:04:16Z EAGLE-440: Alert mongodb storage refine --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #324: EAGLE-440: Alert mongodb storage refine
GitHub user mizeng opened a pull request: https://github.com/apache/incubator-eagle/pull/324 EAGLE-440: Alert mongodb storage refine You can merge this pull request into a Git repository by running: $ git pull https://github.com/mizeng/incubator-eagle develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/324.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #324 commit 1fe32803f5c8c93ef9c7f29fe68b5fdc194d5368 Author: mizeng <miz...@ebaysf.com> Date: 2016-08-10T08:04:16Z EAGLE-440: Alert mongodb storage refine --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #352: EAGLE-462: Alert Dudup
Github user mizeng commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/352#discussion_r74899209 --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/coordinator/Publishment.java --- @@ -32,6 +32,7 @@ private String type; private List policyIds; private String dedupIntervalMin; +private List customDedupFields; --- End diff -- sounds better. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #352: EAGLE-462: Alert Dudup
Github user mizeng commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/352#discussion_r74899429
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertEmailPublisher.java
---
@@ -69,6 +68,10 @@ public void onAlert(AlertStreamEvent event) throws
Exception {
if(event == null) {
return;
}
+
+if
(emailConfig.get(PublishConstants.SENDER).equals("sen...@corp.com")){
--- End diff --
mostly Yes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #352: EAGLE-462: Alert Dudup
Github user mizeng commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/352#discussion_r74903923 --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/model/AlertStreamEvent.java --- @@ -35,6 +35,7 @@ private StreamDefinition schema; private String createdBy; private long createdTime; +private boolean isDuplicate = false; --- End diff -- currently it is only for test. But should not "duplicate" be one property for StreamEvent? It sounds more naturally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #355: EAGLE-471: fix AlertBolt introduce un-ser...
GitHub user mizeng opened a pull request: https://github.com/apache/incubator-eagle/pull/355 EAGLE-471: fix AlertBolt introduce un-serializble member You can merge this pull request into a Git repository by running: $ git pull https://github.com/mizeng/incubator-eagle EAGLE-471 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/355.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #355 commit 476b9930c6619a797af7b14b7480bf935b6d01f8 Author: mizeng <miz...@ebaysf.com> Date: 2016-08-17T05:51:08Z EAGLE-471: fix AlertBolt introduce un-serializble member --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #360: add consumer shell and fix some wrong par...
Github user mizeng closed the pull request at: https://github.com/apache/incubator-eagle/pull/360 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #352: EAGLE-462: Alert Dudup
GitHub user mizeng opened a pull request: https://github.com/apache/incubator-eagle/pull/352 EAGLE-462: Alert Dudup 1. same metric generate alert should be deduped 2. user can define tags which is considered by dedup. by default will only consider about policyId and streamId. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mizeng/incubator-eagle EAGLE-462 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/352.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #352 commit c8aae06e15e86c64b8deedc7eab1c3139f0b0b4e Author: mizeng <miz...@ebaysf.com> Date: 2016-08-16T07:48:14Z EAGLE-462: Alert Dudup 1. same metric generate alert should be deduped 2. user can define tags which is considered by dedup. by default will only consider about policyId and streamId. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #467: fix spoutSpecs load met invalid FieldName...
GitHub user mizeng opened a pull request: https://github.com/apache/incubator-eagle/pull/467 fix spoutSpecs load met invalid FieldName(Dot) exception Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[EAGLE-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/mizeng/incubator-eagle master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/467.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #467 commit 64efd4297210f33300de755513f6d5f34dc1de32 Author: mizeng <miz...@ebaysf.com> Date: 2016-09-29T12:38:22Z fix spoutSpecs load met invalid FieldName(Dot) exception --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #441: EAGLE-550: Add Alert publish implementati...
GitHub user mizeng opened a pull request: https://github.com/apache/incubator-eagle/pull/441 EAGLE-550: Add Alert publish implementation for Slack Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[EAGLE-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [ ] Replace `` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- You can merge this pull request into a Git repository by running: $ git pull https://github.com/mizeng/incubator-eagle UMP-158 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/441.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #441 commit 19d6113a0419531652b1e71bed25560e4ed5bf95 Author: mizeng <miz...@ebaysf.com> Date: 2016-09-14T08:30:29Z EAGLE-550: Add Alert publish implementation for Slack --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #442: EAGLE-550: periodically clean up dedup cache
Github user mizeng commented on the issue: https://github.com/apache/incubator-eagle/pull/442 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #355: EAGLE-471: fix AlertBolt introduce un-ser...
Github user mizeng closed the pull request at: https://github.com/apache/incubator-eagle/pull/355 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #352: EAGLE-462: Alert Dudup
Github user mizeng closed the pull request at: https://github.com/apache/incubator-eagle/pull/352 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #360: add consumer shell and fix some wrong par...
GitHub user mizeng opened a pull request: https://github.com/apache/incubator-eagle/pull/360 add consumer shell and fix some wrong parameter names in alert-engine You can merge this pull request into a Git repository by running: $ git pull https://github.com/mizeng/incubator-eagle develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/360.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #360 commit 863273e70a79dadb9ecf9a7bf4c8a9ef01283545 Author: mizeng <miz...@ebaysf.com> Date: 2016-08-18T09:11:20Z add consumer shell and fix some wrong parameter names in alert-engine --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #376: EAGLE-491: AlertPublisherImpl dedup throw...
Github user mizeng closed the pull request at: https://github.com/apache/incubator-eagle/pull/376 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #376: EAGLE-491: AlertPublisherImpl dedup throw...
GitHub user mizeng opened a pull request: https://github.com/apache/incubator-eagle/pull/376 EAGLE-491: AlertPublisherImpl dedup throws exception when dedup colum⦠â¦n is not configured You can merge this pull request into a Git repository by running: $ git pull https://github.com/mizeng/incubator-eagle EAGLE-491 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/376.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #376 commit 065f1c230249555f9eb4dbdf595200da4e863831 Author: mizeng <miz...@ebaysf.com> Date: 2016-08-23T01:52:24Z EAGLE-491: AlertPublisherImpl dedup throws exception when dedup column is not configured --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #554: EAGLE-671: incorrect metric system use : ...
GitHub user mizeng opened a pull request: https://github.com/apache/incubator-eagle/pull/554 EAGLE-671: incorrect metric system use : too many metric object creat⦠Currently there're too many metric objects create and registered in AlertBolt. This will impact the performance. In AlertBolt: we should register one metric to metric system, then use the metric object to send metric. Not every-time register the metric to metric system. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mizeng/incubator-eagle master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/554.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #554 commit 5fd881a2eb7cd5750e1b1c52b12657c24491e77e Author: mizeng <miz...@ebaysf.com> Date: 2016-10-24T02:29:03Z EAGLE-671: incorrect metric system use : too many metric object create and registered --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #566: EAGLE-683: Improve metadata store performance
Github user mizeng commented on the issue: https://github.com/apache/incubator-eagle/pull/566 @RalphSu plz help to review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #486: EAGLE-602: Exception that Spec Version [xxx] of ...
Github user mizeng commented on the issue: https://github.com/apache/incubator-eagle/pull/486 @RalphSu could you help to review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #501: [EAGLE-616] AlertEngine: Reduce the connection f...
Github user mizeng commented on the issue: https://github.com/apache/incubator-eagle/pull/501 @RalphSu could you plz help to review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #486: EAGLE-602: Exception that Spec Version [x...
GitHub user mizeng opened a pull request: https://github.com/apache/incubator-eagle/pull/486 EAGLE-602: Exception that Spec Version [xxx] of AlertBolt is newer th⦠Just find exception as below: 2016-10-06 22:51:41 org.apache.eagle.alert.engine.runner.AlertBolt [WARN] Spec Version [spec_version_1475817732537] of AlertBolt is newer than Stream Event Version [null]! Seems there's an error when get meta version from stream event or initialising failed when stream event version is null. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mizeng/incubator-eagle master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/486.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #486 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle pull request #498: EAGLE-614: NPE in DynamicPolicyLoader
GitHub user mizeng opened a pull request: https://github.com/apache/incubator-eagle/pull/498 EAGLE-614: NPE in DynamicPolicyLoader Find exception as below: INFO [2016-10-13 01:15:02,965] org.apache.eagle.alert.coordinator.trigger.DynamicPolicyLoader: policies loader start. INFO [2016-10-13 01:15:02,966] org.apache.eagle.alert.service.MetadataServiceClientImpl: query URL http://localhost:8080/rest/metadata/policies ERROR [2016-10-13 01:15:02,972] org.apache.eagle.alert.coordinator.trigger.DynamicPolicyLoader: error loading policy, but continue to run ! java.lang.NullPointerException: null ! at org.apache.eagle.alert.engine.coordinator.PolicyDefinition.equals(PolicyDefinition.java:150) ~[alert-service-0.5.0-incubating-SNAPSHOT-shaded.jar :0.5.0-incubating-SNAPSHOT] ! at org.apache.eagle.alert.coordinator.trigger.DynamicPolicyLoader.run(DynamicPolicyLoader.java:69) ~[alert-service-0.5.0-incubating-SNAPSHOT-shaded. jar:0.5.0-incubating-SNAPSHOT] ! at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [na:1.8.0_102] ! at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) [na:1.8.0_102] ! at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) [na:1.8.0_102] ! at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) [na:1.8.0_102] ! at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [na:1.8.0_102] ! at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [na:1.8.0_102] ! at java.lang.Thread.run(Thread.java:745) [na:1.8.0_102] we have compare null with other object which should be avoided. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mizeng/incubator-eagle EAGLE-614 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/498.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #498 commit abe54782c2dbd840864f02bc57ea1659ec6672bc Author: mizeng <miz...@ebaysf.com> Date: 2016-10-13T01:41:15Z EAGLE-614: NPE in DynamicPolicyLoader --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-eagle issue #498: EAGLE-614: NPE in DynamicPolicyLoader
Github user mizeng commented on the issue: https://github.com/apache/incubator-eagle/pull/498 @RalphSu could you plz help to review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
