[GitHub] LJJCherry commented on issue #7080: formatter如何嵌入react组件

2018-05-04 Thread GitBox 
LJJCherry commented on issue #7080: formatter如何嵌入react组件
URL: 
https://github.com/apache/incubator-echarts/issues/7080#issuecomment-386775594
 
 
   formatter 应该是无法解析react组件的


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] LJJCherry commented on issue #7080: formatter如何嵌入react组件

2018-05-04 Thread GitBox 
LJJCherry commented on issue #7080: formatter如何嵌入react组件
URL: 
https://github.com/apache/incubator-echarts/issues/7080#issuecomment-386775090
 
 
   楼主最后解决了吗


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] chfw commented on issue #8289: 如何绑定ecxel中的数据

2018-05-04 Thread GitBox 
chfw commented on issue #8289: 如何绑定ecxel中的数据
URL: 
https://github.com/apache/incubator-echarts/issues/8289#issuecomment-386653596
 
 
   你可以参照这个 https://github.com/pyecharts/pyecharts/issues/524
   
   现在还是在起步阶段


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] shenqi139 opened a new issue #8289: 如何绑定ecxel中的数据

2018-05-04 Thread GitBox 
shenqi139 opened a new issue #8289: 如何绑定ecxel中的数据
URL: https://github.com/apache/incubator-echarts/issues/8289
 
 
   实际现在很多的数据都是放在excel中  或者csv格式的,但是现在官方貌似没有这方面的教程,并且百度也很多人问的, 
我觉得一定可以实现,只是我不知道,所以希望有人看到能教一下子,我也觉得有更多的人都有这方面的疑问,谢谢


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] Snatch-jie commented on issue #8270: 需要最新地图数据：地图下钻--全国/省/市-地图下钻--市县地图是旧的

2018-05-04 Thread GitBox 
Snatch-jie commented on issue #8270: 需要最新地图数据：地图下钻--全国/省/市-地图下钻--市县地图是旧的
URL: 
https://github.com/apache/incubator-echarts/issues/8270#issuecomment-386551991
 
 
   @hele10086@万分感谢提供方法(虽然还不会用)。感谢


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] hele10086 commented on issue #8270: 需要最新地图数据：地图下钻--全国/省/市-地图下钻--市县地图是旧的

2018-05-04 Thread GitBox 
hele10086 commented on issue #8270: 需要最新地图数据：地图下钻--全国/省/市-地图下钻--市县地图是旧的
URL: 
https://github.com/apache/incubator-echarts/issues/8270#issuecomment-386549949
 
 
   没有的话可以自己自定义，地址：http://geojson.io/
   先导入旧的再修改会快一点。


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] hele10086 opened a new issue #8287: echarts3 中如何做到 echarts2 中的水波效果？

2018-05-04 Thread GitBox 
hele10086 opened a new issue #8287: echarts3 中如何做到 echarts2 中的水波效果？
URL: https://github.com/apache/incubator-echarts/issues/8287
 
 
   
   
   
   ### One-line summary [问题简述]
   在echarts2中配置 markPoint 的 effect 的那种水波动态效果是外圈形状的，而 echarts3 的 effectScatter 
配置的 rippleEffect -> brushType: fill 是往外逐渐变淡的，请问一下 echart3 如何能做到 echart2 的那种水波效果？
   
   
   
   
   ### Version & Environment [版本及环境]
   + ECharts version [ECharts 版本]:
   + Browser version [浏览器类型和版本]:
   + OS Version [操作系统类型和版本]:
   
   
   
   
   
   ### Expected behaviour [期望结果]
   
   
   
   
   
   ### ECharts option [ECharts配置项]
   
   
   ```javascript
   option = {
   
   }
   
   ```
   
   
   
   
   ### Other comments [其他信息]
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

Re: [Discussion] Support image and SVG as the background of GEO coordinate system in echarts.

2018-05-04 Thread 沈毅 
Render SVG directly into HTML is not friendly to other platforms.
Cross-platform is always important when we choose the solution. That's also
what we considered when implementing the rich text label.

I can't get your concern about determining which shapes are needed to be
user
interactive. It's more about how we designing the interface. I don't think
it's relative to the underlying implementation.

About the complexity, we've tried it in ECharts 2. I think it's not that
complex and it works fine to me.

SHUANG SU  于2018年5月4日周五 下午3:18写道：

> But I doubt that parse an SVG file is probably a heavy workload if we
> implement a complete (not rough) parser. (?)
>
> And it probably difficult to determine which shapes are needed to be user
> interactive if the SVG is very complicated.
> (for example, highlight when hovering).
>
> So I think could we render the SVG directly into HTML document?
> Meanwhile, if user interaction is required, the designer can provide a
> separate SVG file, which including only  elements,
> to specify all of the s that are needed to be interactive.
>
> (This idea comes from Dingding, and TianYu agrees that).
>
>
>
>
> --
>  Su Shuang (100pah)
> --
>
>
> 2018-05-04 12:34 GMT+08:00 沈毅 :
>
> > Use SVG directly means parse SVG file and rendered it with Canvas? I
> think
> > it's better because it can be resolution independent. Also we can change
> > the style of each element to encode the data.
> >
> >
> > SHUANG SU  于2018年5月2日周三 下午2:29写道：
> >
> > > Shen Yi,
> > >
> > > Using image as geo background, will cause distortion when zooming.
> > > May be, it is a better way to use SVG directly on the browser (make a
> > > zrender/graphic/SVGImage) ?
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > --
> > >  Su Shuang (100pah)
> > > --
> > >
> > >
> > > 2018-04-30 2:45 GMT+08:00 SHUANG SU :
> > >
> > > >
> > > > (1)
> > > > > And if background image
> > > > > has SVG image source, will the node information in SVG been parsed
> > and
> > > > > displayed?
> > > >
> > > > Does the simple way appropriate?
> > > > ```js
> > > > var img = new Image()
> > > > img.src = 'some.svg';
> > > > // drawImage to canvas.
> > > > ```
> > > >
> > > > There might be some compatible issue for old browser (
> > > > https://caniuse.com/#feat=svg-img) in this way,
> > > > but I think it might bring complexity if imclude SVG parsing code to
> > > > echarts,
> > > > and not necessary if not need to interact with the inner shape of a
> > SVG.
> > > >
> > > >
> > > > (2)
> > > > > Are background and backgroundCoord general properties for the geo
> > > > > component? Can they be used with mapType property
> > > >
> > > > I think that both the `background` and `mapType` can be specified on
> > > > option.
> > > > The view rect can be calculated by union the `backgroundCoord: {x, y,
> > > > width, height}`
> > > > and the GeoJSON (specified by `mayType`, if the user needs it).
> > > >
> > > > But for this part, consider a scenario:
> > > > The background is a shopping mall map, and the user might need some
> > > > polygons
> > > > to describe some area (which can be interactive, like, highlight when
> > > > hovering).
> > > > If the polygons are described using GeoJSON, the option should be:
> > > >
> > > > ```js
> > > > echarts.registerMap('mall', thePolygonsGeoJSON);
> > > >
> > > > var option = {
> > > > geo: {
> > > > background: 'mall.png',
> > > > backgroundCoord: {x: 0, y: 0, width: 1000, height: 600},
> > > > mapType: 'mall'
> > > > }
> > > > }
> > > > ```
> > > >
> > > > where the GeoJSON 'mall' and background image 'mall.png' are
> specified
> > in
> > > > different styles.
> > > > Is it a little strange?
> > > >
> > > > Or, another approach:
> > > > the users can describe the polygons not in GeoJSON (since it is a
> > little
> > > > difficult to make
> > > > GeoJSON), but using a custom series, or a series type 'polygon' (or
> > > > 'lines', that already exists).
> > > >
> > > > ```js
> > > > var option = {
> > > >   geo: {
> > > >background: 'mall.png',
> > > >backgroundCoord: {x: 0, y: 0, width: 1000, height: 600},
> > > >   },
> > > >   series: [{
> > > >   type: 'polygon',// or type: 'lines'
> > > >   data: [
> > > >  // points of a polygon
> > > >  [[px0,py0], [px1,py1], ...],
> > > >  // Or even a SVGPath ? (which is more convenient for
> > > > designers?)
> > > >  'path://M164,210.677v33.47l154.656,66.356L468,243z',
> > > >  ...
> > > >   ]
> > > >   }]
> > > > };
> > > >
> > > > Is it appropriate?
> > > > I am thinking that how to make it easier for designers to convert the
> > SVG
> > > > or Adobe

[GitHub] c0411034 opened a new issue #8286: 使用浏览器Zoom功能ToolTips鼠标移位问题

2018-05-04 Thread GitBox 
c0411034 opened a new issue #8286: 使用浏览器Zoom功能ToolTips鼠标移位问题
URL: https://github.com/apache/incubator-echarts/issues/8286
 
 
   
   
   
   ###使用浏览器Zoom功能ToolTips鼠标移位问题 [问题简述]
   
   
   
   
   
   ### Version & Environment [版本及环境]
   + ECharts version [ECharts 版本]:4.x
   + Browser version [浏览器类型和版本]:chrome
   + OS Version [操作系统类型和版本]:win10
   
   
   
   
   
   ### Expected behaviour [期望结果]尽快修复bug
   
   
   
   
   
   ### ECharts option [ECharts配置项]
   
   
   ```javascript
   option = {
   
   }
   
   ```
   
   
   
   
   ### Other comments [其他信息]
   当浏览器使用了css的 zoom 功能时，所有echart的tooltips都出现移位的现象，有时间可以修复一下呀
   
![image](https://user-images.githubusercontent.com/7091580/39619542-d0ed74ba-4fba-11e8-8d22-9a34876be241.png)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] mqliutie commented on issue #5037: echarts 的series的type为'lines'时，怎么让tooltip显示出该图表的数据？

2018-05-04 Thread GitBox 
mqliutie commented on issue #5037: echarts 
的series的type为'lines'时，怎么让tooltip显示出该图表的数据？
URL: 
https://github.com/apache/incubator-echarts/issues/5037#issuecomment-386530714
 
 
   http://www.echartsjs.com/gallery/editor.html?c=geo-lines
   
   这个例子能实现 `tooltip (value)` 嘛
   
   分割线
   ```
   tooltip: {
   trigger: 'item',
   formatter: (data) => {
   return data.data.value
   },
   textStyle: {
   fontSize: 24,
   color: 'red'
   }
   }
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] ranxiangfu opened a new issue #8285: requestAnimationFrame()方法永无休止的执行

2018-05-04 Thread GitBox 
ranxiangfu opened a new issue #8285: requestAnimationFrame()方法永无休止的执行
URL: https://github.com/apache/incubator-echarts/issues/8285
 
 
   
   
   
   ### One-line summary [问题简述]
   
   - 背景
   
   Angular5.0 + echarts3.8.5
   
   问题还要从 [#7047](https://github.com/apache/incubator-echarts/issues/7047) 
开始说起，Animation对象里的_startLoop函数里有个递归调用step，并且self._running一直是true，这使得step一直会被调用。这在Angular的zone会触发变更检查，导致浏览器持续占用cpu。
   
   我仔细看了 
[#7047](https://github.com/apache/incubator-echarts/issues/7047)里的讨论，他们通过NgZone里的runOutsideAngular()方法让AnimationFrame避开Angular的脏检查。但是requestAnimationFrame()方法仍然是一直在执行的，尽管我切换到其他页面（无图表和动画的页面），它还是一直在执行。
   性能图可以看到requestAnimationFrame()还是在一直执行：
   
![image](https://user-images.githubusercontent.com/31944996/39616870-0d27fa14-4fb0-11e8-90fe-f8c57288aea1.png)
   通过ngDoCheck()钩子看到控制台一直在打印:
   
![image](https://user-images.githubusercontent.com/31944996/39616919-477cffac-4fb0-11e8-9d29-b41402406e7c.png)
   
   - 疑问
   requestAnimationFrame()应该是由页面上某个图表实例触发的，那么当我切换页面之后，这个实例在后续 
理应被GC，那么requestAnimationFrame()函数也应该停止执行，而不是仍然在递归的调用。
   
   
另外当我某个页面绘制的echarts图表有一个比较复杂的动画时，由于动画的原因占用CPU会变高。而且只要打开过这个页面，访问整个项目的任何页面都变得CPU特别高，因为requestAnimationFrame()一直在执行。
   
   ### Version & Environment [版本及环境]
   + ECharts version [ECharts 版本]:  3.8.5
   + Browser version [浏览器类型和版本]:  Chrome 64.0.3282.186（正式版本） （64 位）
   + OS Version [操作系统类型和版本]:  windows 10
   
   
   
   
   
   ### Expected behaviour [期望结果]
   requestAnimationFrame()方法在页面切换后停止执行。
   
   
   
   
   ### ECharts option [ECharts配置项]
   
   
   ```javascript
   option = {
   
   }
   
   ```
   
   
   
   
   ### Other comments [其他信息]
   
   
   我的图表是基于地图的迁徙图，模仿GL实例做的：http://gallery.echartsjs.com/editor.html?c=xB1a5uJTR
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] ranxiangfu commented on issue #7047: 在Angular应用中使用echart，会持续占用cpu

2018-05-04 Thread GitBox 
ranxiangfu commented on issue #7047: 在Angular应用中使用echart，会持续占用cpu
URL: 
https://github.com/apache/incubator-echarts/issues/7047#issuecomment-386258104
 
 
   @hpyou @Ovilia 
我遇到的问题和题主的是一样的，通过runOutsideAngular是可以让AnimationFrame避开Angular的脏检查，但是当切换到其他页面的时候，上一个页面的requestAnimationFrame还是一直在执行。
   
   - 验证方式：
   
   
首先打开有图表的某个页面，通过ngDoCheck()可以发现requestAnimationFrame触发了脏检查：控制台一直在打印。当我切换到一个很简单的页面（没有任何动画和图表），却发现ngDoCheck()依然被一直触发，通过内存分析也可以看到requestAnimationFrame在一直执行，我觉得这是有问题的。
   
而且当我某个页面绘制的echarts图表有一个比较复杂的动画时，只要打开过这个页面，访问整个整个项目的任何页面都变得CPU特别高，因为requestAnimationFrame一直在执行。
   
   我觉得这是有问题的，requestAnimationFrame不应该被一直执行。
   
   - 我的项目环境是Angular5.0和echarts3.8.5


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] mqliutie commented on issue #5037: echarts 的series的type为'lines'时，怎么让tooltip显示出该图表的数据？

2018-05-04 Thread GitBox 
mqliutie commented on issue #5037: echarts 
的series的type为'lines'时，怎么让tooltip显示出该图表的数据？
URL: 
https://github.com/apache/incubator-echarts/issues/5037#issuecomment-386530714
 
 
   http://www.echartsjs.com/gallery/editor.html?c=geo-lines
   
   这个例子能实现 `tooltip` 嘛


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

Re: [Discussion] Support image and SVG as the background of GEO coordinate system in echarts.

2018-05-04 Thread SHUANG SU 
But I doubt that parse an SVG file is probably a heavy workload if we
implement a complete (not rough) parser. (?)

And it probably difficult to determine which shapes are needed to be user
interactive if the SVG is very complicated.
(for example, highlight when hovering).

So I think could we render the SVG directly into HTML document?
Meanwhile, if user interaction is required, the designer can provide a
separate SVG file, which including only  elements,
to specify all of the s that are needed to be interactive.

(This idea comes from Dingding, and TianYu agrees that).




--
 Su Shuang (100pah)
--


2018-05-04 12:34 GMT+08:00 沈毅 :

> Use SVG directly means parse SVG file and rendered it with Canvas? I think
> it's better because it can be resolution independent. Also we can change
> the style of each element to encode the data.
>
>
> SHUANG SU  于2018年5月2日周三 下午2:29写道：
>
> > Shen Yi,
> >
> > Using image as geo background, will cause distortion when zooming.
> > May be, it is a better way to use SVG directly on the browser (make a
> > zrender/graphic/SVGImage) ?
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > --
> >  Su Shuang (100pah)
> > --
> >
> >
> > 2018-04-30 2:45 GMT+08:00 SHUANG SU :
> >
> > >
> > > (1)
> > > > And if background image
> > > > has SVG image source, will the node information in SVG been parsed
> and
> > > > displayed?
> > >
> > > Does the simple way appropriate?
> > > ```js
> > > var img = new Image()
> > > img.src = 'some.svg';
> > > // drawImage to canvas.
> > > ```
> > >
> > > There might be some compatible issue for old browser (
> > > https://caniuse.com/#feat=svg-img) in this way,
> > > but I think it might bring complexity if imclude SVG parsing code to
> > > echarts,
> > > and not necessary if not need to interact with the inner shape of a
> SVG.
> > >
> > >
> > > (2)
> > > > Are background and backgroundCoord general properties for the geo
> > > > component? Can they be used with mapType property
> > >
> > > I think that both the `background` and `mapType` can be specified on
> > > option.
> > > The view rect can be calculated by union the `backgroundCoord: {x, y,
> > > width, height}`
> > > and the GeoJSON (specified by `mayType`, if the user needs it).
> > >
> > > But for this part, consider a scenario:
> > > The background is a shopping mall map, and the user might need some
> > > polygons
> > > to describe some area (which can be interactive, like, highlight when
> > > hovering).
> > > If the polygons are described using GeoJSON, the option should be:
> > >
> > > ```js
> > > echarts.registerMap('mall', thePolygonsGeoJSON);
> > >
> > > var option = {
> > > geo: {
> > > background: 'mall.png',
> > > backgroundCoord: {x: 0, y: 0, width: 1000, height: 600},
> > > mapType: 'mall'
> > > }
> > > }
> > > ```
> > >
> > > where the GeoJSON 'mall' and background image 'mall.png' are specified
> in
> > > different styles.
> > > Is it a little strange?
> > >
> > > Or, another approach:
> > > the users can describe the polygons not in GeoJSON (since it is a
> little
> > > difficult to make
> > > GeoJSON), but using a custom series, or a series type 'polygon' (or
> > > 'lines', that already exists).
> > >
> > > ```js
> > > var option = {
> > >   geo: {
> > >background: 'mall.png',
> > >backgroundCoord: {x: 0, y: 0, width: 1000, height: 600},
> > >   },
> > >   series: [{
> > >   type: 'polygon',// or type: 'lines'
> > >   data: [
> > >  // points of a polygon
> > >  [[px0,py0], [px1,py1], ...],
> > >  // Or even a SVGPath ? (which is more convenient for
> > > designers?)
> > >  'path://M164,210.677v33.47l154.656,66.356L468,243z',
> > >  ...
> > >   ]
> > >   }]
> > > };
> > >
> > > Is it appropriate?
> > > I am thinking that how to make it easier for designers to convert the
> SVG
> > > or Adobe Illustrator path to the input of the echarts.
> > > In echarts 2, special tag needed to be markd on a SVG shape if it is
> > > needed to be parsed and be interactive in echarts.
> > > But adding special tags is not convenient I think.
> > >
> > >
> > >
> > >
> > >
> > > --
> > >  Su Shuang (100pah)
> > > --
> > >
> > >
> > >
> > > 2018-04-29 23:57 GMT+08:00 沈毅 :
> > >
> > >> Some questions.
> > >>
> > >> Are background and backgroundCoord general properties for the geo
> > >> component? Can they be used with mapType property? And if background
> > image
> > >> has SVG image source, will the node information in SVG been parsed and
> > >> displayed?
> > >>
> > >> SHUANG SU  于2018年4月29日周日 上午12:29写道：
> > >>
> > >> > Pissang and All,
> > >> >

[GitHub] mqliutie commented on issue #7618: 4.0版本中配置项中的geo的label的位置（position/offset的配置）失效

2018-05-04 Thread GitBox 
mqliutie commented on issue #7618: 4.0版本中配置项中的geo的label的位置（position/offset的配置）失效
URL: 
https://github.com/apache/incubator-echarts/issues/7618#issuecomment-386521838
 
 
   无效 +1 
   请问后来怎么解决的呢


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

Re: [VOTE] Release Apache ECharts 4.1.0.rc1

2018-05-04 Thread SHUANG SU 
I have added the license for test files on the commit
https://github.com/apache/incubator-echarts/commit/cb324330bd2b4c69d4dd467cea8c945d7d2d898a
,
but not repack them yet because of the Rat issue.


--
 Su Shuang (100pah)
--


2018-05-04 10:47 GMT+08:00 John D. Ament :

> For questions in how to use rat, please consult the rat mailing lists.
>
> However, i saw the license missing from test files as well.
>
> John
>
> On Thu, May 3, 2018, 10:24 PM SHUANG SU  wrote:
>
> > John,
> >
> > I've checked the source code of Apache Cordova and Apache Spark, and then
> > realized that we only add Apache license to "JavaScript source code".
> > But actually, almost all of the files able to add a
> > comment, including HTML, XML, shell, should be added an Apache license.
> > Do I get it right?
> >
> > So I've added licenses for them, and add an "echarts/.rat-excludes" for
> > Apache Rat, and updated the tool "build/addHeader.js".
> >
> > Apache Rat can be run via command line like that:
> >
> > ```shell
> > sh build/rat.sh
> > ```
> >
> >
> > But, John,
> >
> > I am being puzzled by Apache Rat when specifying excludes in the
> > ".rat-excludes" file:
> > For example, when I specify the directory "benchmark/dep" to be excluded
> in
> > the ".rat-excludes" file, it does not work.
> > But if I specify a directory "dep" to be excluded, it works, but it is
> not
> > what I expected.
> > (I expect that not all of the directories "dep" are excluded, but only
> > "benchmark/dep" does).
> >
> > I can not find the solution from the doc of Apache Rat (
> > https://creadur.apache.org/rat/)
> > (In fact, I think the doc is too simple, no detailed explanation or use
> > cases).
> > And I have read its source code, but not helped, and found nothing about
> > this scenario from its test case.
> >
> > So do you have some suggestion about this issue (how to add a path to be
> > excluded in the ".rat-excludes" file)?
> > Or some detailed doc?
> >
> > Thanks.
> >
> >
> >
> >
> >
> > --
> >  Su Shuang (100pah)
> > --
> >
> >
> > 2018-05-04 2:26 GMT+08:00 SHUANG SU :
> >
> > > Thanks, Kevin and John ~
> > >
> > > ---
> > >
> > > John,
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > --
> > >  Su Shuang (100pah)
> > > --
> > >
> > >
> > > 2018-05-03 23:22 GMT+08:00 John D. Ament :
> > >
> > >> Sorry, I missed your prior email.
> > >>
> > >> RE Apache Rat, its more to check that the files have the right header.
> > >> But
> > >> yes, it can add the header where missing.
> > >>
> > >> When i run rat manually, many files are missing headers.
> > >>
> > >> As a podling and an Apache project, you are expected to be able to run
> > >> Rat.
> > >>
> > >> John
> > >>
> > >> On Thu, May 3, 2018 at 11:19 AM Kevin A. McGrail  >
> > >> wrote:
> > >>
> > >> > Hi Shuang, I don't know that John will have the cycles to respond
> but
> > >> there
> > >> > is nothing stopping you from proposing a new RC and taking a vote
> > >> though of
> > >> > course, you generally only want to do so when you believe issues
> have
> > >> been
> > >> > hammered out.
> > >> >
> > >> > Regards,
> > >> > KAM
> > >> >
> > >> > --
> > >> > Kevin A. McGrail
> > >> > Asst. Treasurer & VP Fundraising, Apache Software Foundation
> > >> > Chair Emeritus Apache SpamAssassin Project
> > >> > https://www.linkedin.com/in/kmcgrail - 703.798.0171
> > <(703)%20798-0171>
> > >> >
> > >> > On Wed, May 2, 2018 at 2:18 AM, SHUANG SU 
> > >> wrote:
> > >> >
> > >> > > John,
> > >> > >
> > >> > > Could I release rc2 now?
> > >> > >
> > >> > >
> > >> > > --
> > >> > >  Su Shuang (100pah)
> > >> > > --
> > >> > >
> > >> > >
> > >> > > 2018-04-30 1:23 GMT+08:00 SHUANG SU :
> > >> > >
> > >> > > > John,
> > >> > > >
> > >> > > > I think that Apache Rat is used to check which files are missing
> > >> > license
> > >> > > > and add licenses for them. (Do I understand it right?)
> > >> > > >
> > >> > > > Before we know the tool Apache Rat, another tool,
> > >> > > `echarts/build/addHeader.js`,
> > >> > > > has been created to do that job:
> > >> > > >
> > >> > > > Run it in the Node.js environment:
> > >> > > > `node build/addHeader.js`
> > >> > > > Then the source files that are missing license will be added an
> > >> Apache
> > >> > > > License.
> > >> > > >
> > >> > > > I have also tried Apache Rat just now to check the license, got
> > the
> > >> > same
> > >> > > > result.
> > >> > > > (but got some trouble when trying to add a license, have not
> > >> followed
> > >> > up
> > >> > > > on this issue yet.)
> > >> > > >
> > >> > > > For most of the JavaScript project developers, Java environment
> is
> > >> not
>

[GitHub] mqliutie commented on issue #6236: 能否自定义legend的选中事件

2018-05-04 Thread GitBox 
mqliutie commented on issue #6236: 能否自定义legend的选中事件
URL: 
https://github.com/apache/incubator-echarts/issues/6236#issuecomment-386516290
 
 
   如何触发 ` legendselectchanged`  事件, 在我没有点击 `legend` 的情况下
   
   
   ```
   myChart.dispatchAction({
   type: 'legendToggleSelect',
   name: '上海 Top10'
   });
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] mqliutie commented on issue #6236: 能否自定义legend的选中事件

2018-05-04 Thread GitBox 
mqliutie commented on issue #6236: 能否自定义legend的选中事件
URL: 
https://github.com/apache/incubator-echarts/issues/6236#issuecomment-386516290
 
 
   如何触发 ` legendselectchanged`  事件, 在我没有点击 `legend` 的情况下
   
   -分割线---
   
   ```
   myChart.dispatchAction({
   type: 'legendToggleSelect',
   name: '上海 Top10'
   });
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] mqliutie commented on issue #6236: 能否自定义legend的选中事件

2018-05-04 Thread GitBox 
mqliutie commented on issue #6236: 能否自定义legend的选中事件
URL: 
https://github.com/apache/incubator-echarts/issues/6236#issuecomment-386516290
 
 
   如何触发 ` legendselectchanged`  事件, 在我没有点击 `legend` 的情况下


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] stdrickforce opened a new issue #8284: PieCharts 和 Legend 结合使用时，会产生关键字冲突的问题

2018-05-04 Thread GitBox 
stdrickforce opened a new issue #8284: PieCharts 和 Legend 结合使用时，会产生关键字冲突的问题
URL: https://github.com/apache/incubator-echarts/issues/8284
 
 
   
   
   
   ### One-line summary [问题简述]
   
   pieCharts 在使用 legend 的时候，如果数据和图例的名字都为 get 的话，会报错导致图片无法出来。
   
   稍微看了一下，应该是 createHashmap 占用了 get / set / constructor / each / removeKey 
这几个关键字，而 legend 组件用到了 hashmap，从而在业务中包含 get 图例时，get 方法被覆盖，导致错误。
   
   
   
   ### Version & Environment [版本及环境]
   + ECharts version [ECharts 版本]:
   4.1.0
   + Browser version [浏览器类型和版本]:
   Google Chrome Version 65.0.3325.181 (Official Build) (64-bit)
   + OS Version [操作系统类型和版本]:
   macOS High Sierra Version 10.13.3(17D102)
   
   
   ### Expected behaviour [期望结果]
   可以正常显示 get 的图例
   
   
   
   
   
   ### ECharts option [ECharts配置项]
   ```
   option = {
   title : {
   text: '测试',
   subtext: '纯属虚构',
   x:'center'
   },
   legend: {
   orient: 'vertical',
   left: 'left',
   data: ['get', 'set']
   },
   series : [
   {
   name: '访问来源',
   type: 'pie',
   radius : '55%',
   center: ['50%', '60%'],
   data:[
   {value:335, name:'get'},
   {value:310, name:'set'},
   ],
   }
   ]
   };
   
   ```
   
   ### Other comments [其他信息]
   测试代码就在压缩包里
   
[test.zip](https://github.com/apache/incubator-echarts/files/1973416/test.zip)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org

[GitHub] hanfengcan commented on issue #7503: echarts 4.0如何在ppt中使用

2018-05-04 Thread GitBox 
hanfengcan commented on issue #7503: echarts 4.0如何在ppt中使用
URL: 
https://github.com/apache/incubator-echarts/issues/7503#issuecomment-386513544
 
 
   过了好久了,什么时候过审核呢


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org