[GitHub] vijay19920608 opened a new issue #9002: 引入bmap报错
vijay19920608 opened a new issue #9002: 引入bmap报错
URL: https://github.com/apache/incubator-echarts/issues/9002
我是按需引入的，
引入的模块有：
require('echarts/lib/chart/lines')
require('echarts/dist/extension/dataTool.min')
require('echarts/dist/extension/bmap.min')
require('echarts/lib/chart/effectScatter')
require('echarts/lib/component/grid')
require('echarts/lib/component/tooltip')
require('echarts/lib/component/toolbox')
require('echarts/lib/component/geo')
require('echarts/lib/echarts')
但是一直报错，请问怎样正确引入bmap
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] nick-running commented on issue #7234: vue + echarts 单页面大数据加载性能问题
nick-running commented on issue #7234: vue + echarts 单页面大数据加载性能问题 URL: https://github.com/apache/incubator-echarts/issues/7234#issuecomment-418233203 @zhangwang9li 我试了下把data里的chart换成我定义的一个变量chart来配置，果然很流畅了。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] anneyangyue commented on issue #2049: 能否支持x轴是时间格式，可以无限缩放
anneyangyue commented on issue #2049: 能否支持x轴是时间格式，可以无限缩放 URL: https://github.com/apache/incubator-echarts/issues/2049#issuecomment-418227754 一直放大，坐标轴的起始坐标和终止坐标相同时，再次放大，坐标轴的刻度范围不在之前的范围内了 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] Ovilia commented on issue #8986: Error when inserting new Series in a place different to the end of the list (for line chart)
Ovilia commented on issue #8986: Error when inserting new Series in a place different to the end of the list (for line chart) URL: https://github.com/apache/incubator-echarts/issues/8986#issuecomment-418225217 How about adding id for series? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] LIHAO520 commented on issue #7625: appendData()调用方式有限制么
LIHAO520 commented on issue #7625: appendData()调用方式有限制么 URL: https://github.com/apache/incubator-echarts/issues/7625#issuecomment-418220613 你好，你现在的这个问题解决了吗？我想请教一个问题，seriesIndex这个序列号指的是每一个轨迹的序列号吗？比如我有100辆车，我需要给这100辆车添加数据轨迹，要写100个序列号吗？这个data是你获取到的数据，在哪里限制了data的分批动态加载，除了这个定时请求，希望回复一下 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] ZaZaLee commented on issue #8999: 力矢量图如何设置坐标
ZaZaLee commented on issue #8999: 力矢量图如何设置坐标 URL: https://github.com/apache/incubator-echarts/issues/8999#issuecomment-418213726 自动布局不能设置初始位置吗，因为自动布局在数量较多的时候会比较杂乱 就是期望能够设置位置，不用自动布局。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] dfonnegra commented on issue #8986: Error when inserting new Series in a place different to the end of the list (for line chart)
dfonnegra commented on issue #8986: Error when inserting new Series in a place different to the end of the list (for line chart) URL: https://github.com/apache/incubator-echarts/issues/8986#issuecomment-418174082 Here it is, https://codepen.io/daniel-fonnegra-garc-a/project/editor/AdzOPg The state change is so big because the new series are inserted in the index 0 of the list so the whole elements of the list are changed. I realized that the problem is in the change of series list. If I remove that change (i.e just changing the axes) the error is not thrown. Anyways, don't you think its strange that both states are drawn correctly (option1 and option2) but when i change option1 to option2 the error is thrown? It looks like the merging is not correctly made. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] cuijian-dexter edited a comment on issue #8997: Pie chart adds limitScale parameter
cuijian-dexter edited a comment on issue #8997: Pie chart adds limitScale parameter URL: https://github.com/apache/incubator-echarts/pull/8997#issuecomment-418143326 @100pah Thank you for reminding me. I know what you mean. I will repair it tomorrow and commit it again. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] cuijian-dexter commented on issue #8997: Pie chart adds limitScale parameter
cuijian-dexter commented on issue #8997: Pie chart adds limitScale parameter URL: https://github.com/apache/incubator-echarts/pull/8997#issuecomment-418143326 @100pah Thank you for reminding me. I know what you mean. I will repair it tomorrow and submit it again. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] 100pah commented on issue #9000: Tooltip in line chart.
100pah commented on issue #9000: Tooltip in line chart. URL: https://github.com/apache/incubator-echarts/issues/9000#issuecomment-418142747 Excuse me I can not find where your case is. Is it in another issue? Generally, when too many series cause the size of the default tooltip longer than viewport, we probably customize the tooltip by `tooltip.format`, switch it to another simple style. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] 100pah commented on issue #8997: Pie chart adds limitScale parameter
100pah commented on issue #8997: Pie chart adds limitScale parameter URL: https://github.com/apache/incubator-echarts/pull/8997#issuecomment-418137198 About the code: (1) I think the option should not be on `series.label`, because both `label` and `label` line are controlled by the option. Probably it is better to be on `series` directly. (2) Discussion: I think the literal meaning of "limitScale" does not hint at what the feature does for users. Any idea about the option name @Ovilia @pissang ? (3) @cuijian-dexter the model should not be modified in the layout stage. In fact, I think this feature should be implemented in the view rendering stage (PieView). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] geekboy0801 commented on issue #9000: Tooltip in line chart.
geekboy0801 commented on issue #9000: Tooltip in line chart. URL: https://github.com/apache/incubator-echarts/issues/9000#issuecomment-418136435 Hi, @100pah . Thank you for your kind reply. But what do you think about the case of too many series, such as my case? In such cases, tooltip should be too long to show it and as a result it overflows. In my poor view of point, this is a simple bug. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
Re: How to add new committers
Hi Wenli, I do not know if incubator has a specific process but here are a few thoughts: - See https://community.apache.org/newcommitter.html - Is the patch trivial? If not, they will need an ICLA. https://www.apache.org/licenses/icla.pdf When in doubt, ask the Secretary at ASF's opinion. - Community is more important than code so this is awesome. Promoting community growth is one of the best things to invest your time in and something I did not appreciate for too long. - If their code is good, and the PR is sane, and a CLA is filed, use it as a way to perhaps pair them with another committer. They do NOT have to be a committer to be a contributor. Regards, KAM On 9/3/2018 2:47 AM, Wenli Zhang wrote: > Dear mentors, > > We are considering merging new PR at > https://github.com/apache/incubator-echarts/pull/8966 . Since this is the > first time we accept commit from community, I have a few questions to ask: > > 1. Does he need to become a committer (so that he need to follow > https://www.apache.org/dev/new-committers-guide.html ) before or after we > merge the pull request? > > 2. Is there anything else we need to do before and after we merge the PR? > > Thanks! > > Zhang Wenli > http://zhangwenli.com > -- Kevin A. McGrail VP Fundraising, Apache Software Foundation Chair Emeritus Apache SpamAssassin Project https://www.linkedin.com/in/kmcgrail - 703.798.0171 - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] troy351 commented on issue #8998: UTF8 encode world.json
troy351 commented on issue #8998: UTF8 encode world.json URL: https://github.com/apache/incubator-echarts/pull/8998#issuecomment-418131886 压缩了地图文件，用UTF8编码了，之前这个文件没有压缩有900k+ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] 100pah commented on issue #8998: UTF8 encode world.json
100pah commented on issue #8998: UTF8 encode world.json URL: https://github.com/apache/incubator-echarts/pull/8998#issuecomment-418131377 请问这个提交是在修改什么？ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] 100pah commented on issue #8996: 折线图中折点在chrome部分比例中不显示
100pah commented on issue #8996: 折线图中折点在chrome部分比例中不显示 URL: https://github.com/apache/incubator-echarts/issues/8996#issuecomment-418130406 缺乏信息，无法判断您的问题到底是什么。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] 100pah commented on issue #8999: 力矢量图如何设置坐标
100pah commented on issue #8999: 力矢量图如何设置坐标 URL: https://github.com/apache/incubator-echarts/issues/8999#issuecomment-418128232 如果 “力矢量图” 指的是 “力导向图” 的话，因为是自动布局的，所以设置初始位置，似乎没有什么意义？ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] 100pah commented on issue #9000: Tooltip in line chart.
100pah commented on issue #9000: Tooltip in line chart.
URL:
https://github.com/apache/incubator-echarts/issues/9000#issuecomment-418126833
Thanks.
I think `tooltip.trigger: 'axis'` make similar experience like highcharts
does:
```js
option = {
tooltip: {
trigger: 'axis',
axisPointer: {
type: 'none'
}
},
xAxis: {
type: 'category',
data: ['Mon', 'Tue', 'Wed', 'Thu', 'Fri', 'Sat', 'Sun']
},
yAxis: {
type: 'value'
},
series: [{
data: [820, 932, 901, 934, 1290, 1330, 1320],
type: 'line'
}]
};
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] 100pah closed issue #8975: custom类别的图形 双Y轴位置异常
100pah closed issue #8975: custom类别的图形 双Y轴位置异常 URL: https://github.com/apache/incubator-echarts/issues/8975 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] geekboy0801 opened a new issue #9000: Tooltip in line chart.
geekboy0801 opened a new issue #9000: Tooltip in line chart. URL: https://github.com/apache/incubator-echarts/issues/9000 ### One-line summary [问题简述] Triggering tooltip when moving mouse on the *line chart*. Highcharts tooltip triggers smoothly when the mouse is moving on the chart apart from the points which make up line chart, but Echarts doesn't in my experience. Echarts only triggers tooltip near the points. Echart: https://ecomfe.github.io/echarts-examples/public/editor.html?c=line-simple Highchart: https://jsfiddle.net/208odfjb/1/ Can i implement the same behavior by means of Echarts or not? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] ZaZaLee opened a new issue #8999: 力矢量图如何设置坐标
ZaZaLee opened a new issue #8999: 力矢量图如何设置坐标
URL: https://github.com/apache/incubator-echarts/issues/8999
### One-line summary [问题简述]
使用力矢量图设置动态图形展示，期望能够设置图标的初始位置，
从目前的option里面找不到x,y坐标的参数
### Version & Environment [版本及环境]
+ ECharts version [ECharts 版本]:2.2.7
+ Browser version [浏览器类型和版本]:chrome 68.0.3440.106
+ OS Version [操作系统类型和版本]:mac & windows
### Expected behaviour [期望结果]
期望能够设置力矢量图图标的初始坐标位置
### ECharts option [ECharts配置项]
```javascript
option = {
}
```
### Other comments [其他信息]
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] Ovilia closed issue #8994: Pie chart gets cut-off because clipPaths never are cleared
Ovilia closed issue #8994: Pie chart gets cut-off because clipPaths never are cleared URL: https://github.com/apache/incubator-echarts/issues/8994 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] 100pah closed issue #8747: 双Y轴双bar图有负数的问题
100pah closed issue #8747: 双Y轴双bar图有负数的问题 URL: https://github.com/apache/incubator-echarts/issues/8747 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] troy351 opened a new pull request #8998: UTF8 encode world.json
troy351 opened a new pull request #8998: UTF8 encode world.json URL: https://github.com/apache/incubator-echarts/pull/8998 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] cuijian-dexter commented on issue #8759: Enhance pie chart label display policy
cuijian-dexter commented on issue #8759: Enhance pie chart label display policy URL: https://github.com/apache/incubator-echarts/pull/8759#issuecomment-418072130 @Ovilia new pull request of pie charts https://github.com/apache/incubator-echarts/pull/8997 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] cuijian-dexter opened a new pull request #8997: The value of the fan page of the pie chart is less than a certain value. The label and labelLine of this fan page are not displayed.
cuijian-dexter opened a new pull request #8997: The value of the fan page of
the pie chart is less than a certain value. The label and labelLine of this fan
page are not displayed.
URL: https://github.com/apache/incubator-echarts/pull/8997
The value of the fan page of the pie chart is less than a certain value. The
label and labelLine of this fan page are not displayed.
options={
title: {
text: '饼图标题',
left: 16,
textStyle: {
fontSize: 14
}
},
tooltip: {
trigger: 'item',
axisPointer: {
//坐标轴指示器，坐标轴触发有效type: 'shadow'//默认为直线，可选为：'line'|'shadow'
},
extraCssText: 'max-width: 300px; word-break:break-all; white-space:
normal'
},
legend: {
data: [
]
},
series: [
{
type: 'pie',
label: {
normal: {
show: true,
limitScale: 0.02//小于2%的，不显示
},
emphasis: {
show: true,
textStyle: {
fontSize: '14',
fontWeight: 'bold'
}
}
},
labelLine: {
lineStyle: {
color: '#D9D9D9'
}
},
data: [
]
}
]
};
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] cuijian-dexter commented on issue #8759: Enhance pie chart label display policy
cuijian-dexter commented on issue #8759: Enhance pie chart label display policy URL: https://github.com/apache/incubator-echarts/pull/8759#issuecomment-418062440 @Ovilia Okay, I have deleted the pie-related code. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] Ovilia commented on issue #8759: Enhance pie chart label display policy
Ovilia commented on issue #8759: Enhance pie chart label display policy URL: https://github.com/apache/incubator-echarts/pull/8759#issuecomment-418057019 You need to remove the pie-related code from the PR. Undo the changes in pie chart; commit; pull request. Here's how to open another PR on GitHub: https://stackoverflow.com/questions/8450036/how-to-open-multiple-pull-requests-on-github You can also wait for the PR to be closed and then add a new PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] cuijian-dexter commented on issue #8759: Enhance pie chart label display policy
cuijian-dexter commented on issue #8759: Enhance pie chart label display policy
URL:
https://github.com/apache/incubator-echarts/pull/8759#issuecomment-418055180
@Ovilia
This is the options of pie chart.Adding the limitScale parameter.
Less than limitScale, do not show.
Do I need to resubmit a Pull Request?
options = {
title: {
text: '饼图标题',
left: 16,
textStyle: {
fontSize: 14
}
},
tooltip : {
trigger: 'item',
axisPointer : {// 坐标轴指示器，坐标轴触发有效
type : 'shadow'// 默认为直线，可选为：'line' | 'shadow'
},
extraCssText: 'max-width: 300px; word-break:break-all;
white-space: normal'
},
legend:{
data: []
},
series: [
{
type: 'pie',
label: {
normal: {
show: true,
limitScale:0.02//小于2%的，不显示
},
emphasis: {
show: true,
textStyle: {
fontSize: '14',
fontWeight: 'bold'
}
}
},
labelLine: {
lineStyle: {
// color: '#D9D9D9'
}
},
data: []
}
]
};
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] Ovilia commented on issue #8759: Enhance pie chart label display policy
Ovilia commented on issue #8759: Enhance pie chart label display policy URL: https://github.com/apache/incubator-echarts/pull/8759#issuecomment-418052190 @cuijian-dexter The pie chart label filtering and funnel label positioning seems to be two different topics. I reviewed the funnel part and that seems to be working. How about removing the pie chart part in this PR (you can make another PR later)? And please format your code as I mentioned above. Thanks for your contribution. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] Ovilia commented on a change in pull request #8759: Enhance pie chart label display policy
Ovilia commented on a change in pull request #8759: Enhance pie chart label
display policy
URL: https://github.com/apache/incubator-echarts/pull/8759#discussion_r214621892
##
File path: src/chart/funnel/funnelLayout.js
##
@@ -71,9 +71,19 @@ function labelLayout(data) {
var linePoints;
if (isLabelInside) {
-textX = (points[0][0] + points[1][0] + points[2][0] +
points[3][0]) / 4;
-textY = (points[0][1] + points[1][1] + points[2][1] +
points[3][1]) / 4;
-textAlign = 'center';
+if (labelPosition === 'insideLeft'){
Review comment:
Add space: `if (labelPosition === 'insideLeft') {`.
Also change the similar problems.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] Ovilia commented on a change in pull request #8759: Enhance pie chart label display policy
Ovilia commented on a change in pull request #8759: Enhance pie chart label
display policy
URL: https://github.com/apache/incubator-echarts/pull/8759#discussion_r214621959
##
File path: src/chart/funnel/funnelLayout.js
##
@@ -71,9 +71,19 @@ function labelLayout(data) {
var linePoints;
if (isLabelInside) {
-textX = (points[0][0] + points[1][0] + points[2][0] +
points[3][0]) / 4;
-textY = (points[0][1] + points[1][1] + points[2][1] +
points[3][1]) / 4;
-textAlign = 'center';
+if (labelPosition === 'insideLeft'){
+textX = (points[0][0] + points[3][0])/2 + 5;
Review comment:
`) / 2`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] deqingli commented on issue #8966: Add node align for the Sankey diagram
deqingli commented on issue #8966: Add node align for the Sankey diagram URL: https://github.com/apache/incubator-echarts/pull/8966#issuecomment-418047361 @jas0ncn To add one more sentence, the next version here refers to the version after 4.2. Best Wishes, Deqing This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] cuijian-dexter edited a comment on issue #8759: Enhance pie chart label display policy
cuijian-dexter edited a comment on issue #8759: Enhance pie chart label display policy URL: https://github.com/apache/incubator-echarts/pull/8759#issuecomment-408029853 Label line may be outside the canvas when pie items are too much. #8390 #8507 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] jas0ncn closed pull request #8966: Add node align for the Sankey diagram
jas0ncn closed pull request #8966: Add node align for the Sankey diagram
URL: https://github.com/apache/incubator-echarts/pull/8966
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/extension/dataTool/prepareBoxplotData.js
b/extension/dataTool/prepareBoxplotData.js
index d191d6a50..1dc4f7aca 100644
--- a/extension/dataTool/prepareBoxplotData.js
+++ b/extension/dataTool/prepareBoxplotData.js
@@ -18,8 +18,6 @@
* under the License.
*/
-var quantile = require("./quantile");
-
var numberUtil = require("../../lib/util/number");
/*
@@ -78,9 +76,9 @@ function _default(rawData, opt) {
for (var i = 0; i < rawData.length; i++) {
axisData.push(i + '');
var ascList = numberUtil.asc(rawData[i].slice());
-var Q1 = quantile(ascList, 0.25);
-var Q2 = quantile(ascList, 0.5);
-var Q3 = quantile(ascList, 0.75);
+var Q1 = numberUtil.quantile(ascList, 0.25);
+var Q2 = numberUtil.quantile(ascList, 0.5);
+var Q3 = numberUtil.quantile(ascList, 0.75);
var min = ascList[0];
var max = ascList[ascList.length - 1];
var bound = (boundIQR == null ? 1.5 : boundIQR) * (Q3 - Q1);
diff --git a/src/chart/sankey/SankeySeries.js b/src/chart/sankey/SankeySeries.js
index e5acf52a1..ac8138412 100644
--- a/src/chart/sankey/SankeySeries.js
+++ b/src/chart/sankey/SankeySeries.js
@@ -106,6 +106,9 @@ var SankeySeries = SeriesModel.extend({
// Value can be 'vertical'
orient: 'horizontal',
+// Value can be 'left'
+align: 'justify',
+
// The dx of the node
nodeWidth: 20,
@@ -155,4 +158,4 @@ var SankeySeries = SeriesModel.extend({
});
-export default SankeySeries;
\ No newline at end of file
+export default SankeySeries;
diff --git a/src/chart/sankey/sankeyLayout.js b/src/chart/sankey/sankeyLayout.js
index f37fb84bc..142fa5773 100644
--- a/src/chart/sankey/sankeyLayout.js
+++ b/src/chart/sankey/sankeyLayout.js
@@ -57,7 +57,9 @@ export default function (ecModel, api, payload) {
var orient = seriesModel.get('orient');
-layoutSankey(nodes, edges, nodeWidth, nodeGap, width, height,
iterations, orient);
+var align = seriesModel.get('align');
+
+layoutSankey(nodes, edges, nodeWidth, nodeGap, width, height,
iterations, orient, align);
});
}
@@ -77,8 +79,8 @@ function getViewRect(seriesModel, api) {
);
}
-function layoutSankey(nodes, edges, nodeWidth, nodeGap, width, height,
iterations, orient) {
-computeNodeBreadths(nodes, edges, nodeWidth, width, height, orient);
+function layoutSankey(nodes, edges, nodeWidth, nodeGap, width, height,
iterations, orient, align) {
+computeNodeBreadths(nodes, edges, nodeWidth, width, height, orient, align);
computeNodeDepths(nodes, edges, height, width, nodeGap, iterations,
orient);
computeEdgeDepths(nodes, orient);
}
@@ -107,7 +109,7 @@ function computeNodeValues(nodes) {
* @param {number} nodeWidth the dx of the node
* @param {number} width the whole width of the area to draw the view
*/
-function computeNodeBreadths(nodes, edges, nodeWidth, width, height, orient) {
+function computeNodeBreadths(nodes, edges, nodeWidth, width, height, orient,
align) {
// Used to mark whether the edge is deleted. if it is deleted,
// the value is 0, otherwise it is 1.
var remainEdges = [];
@@ -166,7 +168,10 @@ function computeNodeBreadths(nodes, edges, nodeWidth,
width, height, orient) {
}
}
-moveSinksRight(nodes, x);
+// only 'justify' will align node in the last column.
+if (align === 'justify') {
+moveSinksRight(nodes, x);
+}
if (orient === 'vertical') {
kx = (height - nodeWidth) / (x - 1);
@@ -514,4 +519,4 @@ function computeEdgeDepths(nodes, orient) {
ty += edge.getLayout().dy;
});
});
-}
\ No newline at end of file
+}
diff --git a/test/sankey-align.html b/test/sankey-align.html
new file mode 100644
index 0..b2368fea4
--- /dev/null
+++ b/test/sankey-align.html
@@ -0,0 +1,103 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+html, body, #main {
+width: 100%;
+height: 100%;
+/*border: 1px solid #000;*/
+}
+
+
+
+require([
+'echarts'
+// 'echarts/chart/sankey',
+// 'echarts/component/tooltip'
+], function (echarts) {
+
+var chart = echarts.init(document.getElementById('main'),
null, {
+
+});
+
+window.onresize = function () {
+chart.resize();
+};
+
+chart.on('click',
[GitHub] jas0ncn commented on issue #8966: Add node align for the Sankey diagram
jas0ncn commented on issue #8966: Add node align for the Sankey diagram URL: https://github.com/apache/incubator-echarts/pull/8966#issuecomment-418044803 Thanks! waiting for it This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] deqingli commented on issue #8966: Add node align for the Sankey diagram
deqingli commented on issue #8966: Add node align for the Sankey diagram URL: https://github.com/apache/incubator-echarts/pull/8966#issuecomment-418044073 @jas0ncn If nothing unexpected happens, I am going to release it in the next version. Best Wishes, Deqing This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] jas0ncn edited a comment on issue #8966: Add node align for the Sankey diagram
jas0ncn edited a comment on issue #8966: Add node align for the Sankey diagram URL: https://github.com/apache/incubator-echarts/pull/8966#issuecomment-418041098 @deqingli Thanks reply! I agree with you, is there a timetable for implementing `layer`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] jas0ncn commented on issue #8966: Add node align for the Sankey diagram
jas0ncn commented on issue #8966: Add node align for the Sankey diagram URL: https://github.com/apache/incubator-echarts/pull/8966#issuecomment-418041098 @deqingli Thanks reply! I agree with you, is there a timetable for implementing `layout`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] jas0ncn opened a new pull request #8966: Add node align for the Sankey diagram
jas0ncn opened a new pull request #8966: Add node align for the Sankey diagram URL: https://github.com/apache/incubator-echarts/pull/8966 Currently, the Sankey diagram will align all the node without `outEgdes` in the last column. It doesn't make sense when I draw a flow diagram using Sankey. I added the `align` option to `SankeySeries` and sets a default value `justify` which for compatible previous behaviors. The other value for the `align` option is `left`, which will not trigger `moveSinksRight` function and keep node left. Here are two pics for comparing them.  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] jas0ncn closed pull request #8966: Add node align for the Sankey diagram
jas0ncn closed pull request #8966: Add node align for the Sankey diagram
URL: https://github.com/apache/incubator-echarts/pull/8966
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/extension/dataTool/prepareBoxplotData.js
b/extension/dataTool/prepareBoxplotData.js
index d191d6a50..1dc4f7aca 100644
--- a/extension/dataTool/prepareBoxplotData.js
+++ b/extension/dataTool/prepareBoxplotData.js
@@ -18,8 +18,6 @@
* under the License.
*/
-var quantile = require("./quantile");
-
var numberUtil = require("../../lib/util/number");
/*
@@ -78,9 +76,9 @@ function _default(rawData, opt) {
for (var i = 0; i < rawData.length; i++) {
axisData.push(i + '');
var ascList = numberUtil.asc(rawData[i].slice());
-var Q1 = quantile(ascList, 0.25);
-var Q2 = quantile(ascList, 0.5);
-var Q3 = quantile(ascList, 0.75);
+var Q1 = numberUtil.quantile(ascList, 0.25);
+var Q2 = numberUtil.quantile(ascList, 0.5);
+var Q3 = numberUtil.quantile(ascList, 0.75);
var min = ascList[0];
var max = ascList[ascList.length - 1];
var bound = (boundIQR == null ? 1.5 : boundIQR) * (Q3 - Q1);
diff --git a/src/chart/sankey/SankeySeries.js b/src/chart/sankey/SankeySeries.js
index e5acf52a1..ac8138412 100644
--- a/src/chart/sankey/SankeySeries.js
+++ b/src/chart/sankey/SankeySeries.js
@@ -106,6 +106,9 @@ var SankeySeries = SeriesModel.extend({
// Value can be 'vertical'
orient: 'horizontal',
+// Value can be 'left'
+align: 'justify',
+
// The dx of the node
nodeWidth: 20,
@@ -155,4 +158,4 @@ var SankeySeries = SeriesModel.extend({
});
-export default SankeySeries;
\ No newline at end of file
+export default SankeySeries;
diff --git a/src/chart/sankey/sankeyLayout.js b/src/chart/sankey/sankeyLayout.js
index f37fb84bc..142fa5773 100644
--- a/src/chart/sankey/sankeyLayout.js
+++ b/src/chart/sankey/sankeyLayout.js
@@ -57,7 +57,9 @@ export default function (ecModel, api, payload) {
var orient = seriesModel.get('orient');
-layoutSankey(nodes, edges, nodeWidth, nodeGap, width, height,
iterations, orient);
+var align = seriesModel.get('align');
+
+layoutSankey(nodes, edges, nodeWidth, nodeGap, width, height,
iterations, orient, align);
});
}
@@ -77,8 +79,8 @@ function getViewRect(seriesModel, api) {
);
}
-function layoutSankey(nodes, edges, nodeWidth, nodeGap, width, height,
iterations, orient) {
-computeNodeBreadths(nodes, edges, nodeWidth, width, height, orient);
+function layoutSankey(nodes, edges, nodeWidth, nodeGap, width, height,
iterations, orient, align) {
+computeNodeBreadths(nodes, edges, nodeWidth, width, height, orient, align);
computeNodeDepths(nodes, edges, height, width, nodeGap, iterations,
orient);
computeEdgeDepths(nodes, orient);
}
@@ -107,7 +109,7 @@ function computeNodeValues(nodes) {
* @param {number} nodeWidth the dx of the node
* @param {number} width the whole width of the area to draw the view
*/
-function computeNodeBreadths(nodes, edges, nodeWidth, width, height, orient) {
+function computeNodeBreadths(nodes, edges, nodeWidth, width, height, orient,
align) {
// Used to mark whether the edge is deleted. if it is deleted,
// the value is 0, otherwise it is 1.
var remainEdges = [];
@@ -166,7 +168,10 @@ function computeNodeBreadths(nodes, edges, nodeWidth,
width, height, orient) {
}
}
-moveSinksRight(nodes, x);
+// only 'justify' will align node in the last column.
+if (align === 'justify') {
+moveSinksRight(nodes, x);
+}
if (orient === 'vertical') {
kx = (height - nodeWidth) / (x - 1);
@@ -514,4 +519,4 @@ function computeEdgeDepths(nodes, orient) {
ty += edge.getLayout().dy;
});
});
-}
\ No newline at end of file
+}
diff --git a/test/sankey-align.html b/test/sankey-align.html
new file mode 100644
index 0..b2368fea4
--- /dev/null
+++ b/test/sankey-align.html
@@ -0,0 +1,103 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+html, body, #main {
+width: 100%;
+height: 100%;
+/*border: 1px solid #000;*/
+}
+
+
+
+require([
+'echarts'
+// 'echarts/chart/sankey',
+// 'echarts/component/tooltip'
+], function (echarts) {
+
+var chart = echarts.init(document.getElementById('main'),
null, {
+
+});
+
+window.onresize = function () {
+chart.resize();
+};
+
+chart.on('click',
[GitHub] deqingli commented on issue #8966: Add node align for the Sankey diagram
deqingli commented on issue #8966: Add node align for the Sankey diagram URL: https://github.com/apache/incubator-echarts/pull/8966#issuecomment-418038971 hi @jas0ncn, I'm the author of Sankey diagram, thank you for your PR. Many people have given me feedback before you mentioned the problem. I tried to add a `align` configuration item like you, like D3, but I found that this does not solve the fundamental problem, because if the user wants a node to display at a specific layer in the middle, there is no way to satisfy it. So I am going to add a new layout, set up a `layer` configuration item, and the user specifies the nodes for each layer. Thanks again! Best wishes, Deqing This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] cuijian-dexter commented on issue #8759: 1.饼图的扇页的值小于一定值，不显示此扇页的label和labelLine。2.为漏斗图position增加insideLeft和insideRight
cuijian-dexter commented on issue #8759: 1.饼图的扇页的值小于一定值，不显示此扇页的label和labelLine。2.为漏斗图position增加insideLeft和insideRight URL: https://github.com/apache/incubator-echarts/pull/8759#issuecomment-418036253 @Ovilia ok,I'll change it right away This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] Ovilia closed issue #6847: Echarts3 怎么设置部分地图不可点击
Ovilia closed issue #6847: Echarts3 怎么设置部分地图不可点击 URL: https://github.com/apache/incubator-echarts/issues/6847 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] Ovilia commented on issue #8759: 1.饼图的扇页的值小于一定值，不显示此扇页的label和labelLine。2.为漏斗图position增加insideLeft和insideRight
Ovilia commented on issue #8759: 1.饼图的扇页的值小于一定值，不显示此扇页的label和labelLine。2.为漏斗图position增加insideLeft和insideRight URL: https://github.com/apache/incubator-echarts/pull/8759#issuecomment-418035066 @cuijian-dexter Hi @cuijian-dexter , I think this feature is very useful although we have to discuss it in details. But first of all, could you please change the title and comments into English so that more community members can understand? Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] Ovilia commented on issue #8736: 完善文档
Ovilia commented on issue #8736: 完善文档 URL: https://github.com/apache/incubator-echarts/pull/8736#issuecomment-418034407 Not necessary change. Sorry I have to close this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] Ovilia closed pull request #8736: 完善文档
Ovilia closed pull request #8736: 完善文档
URL: https://github.com/apache/incubator-echarts/pull/8736
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/extension/bmap/README.md b/extension/bmap/README.md
index 0bf1ec164..9c2499551 100644
--- a/extension/bmap/README.md
+++ b/extension/bmap/README.md
@@ -31,9 +31,11 @@ ECharts 百度地图扩展，可以在百度地图上展现 [点图](http://echa
如果是 webpack 打包，也可以 require 引入
+先在入口文件的`index.html`里引入百度地图的jssdk`http://api.map.baidu.com/api?v=2.0&ak=";>`，然后
+
```js
require('echarts');
-require('echarts/extension/bmap/bmap');
+require('echarts/extension/bmap/bmap'); //
或者require('echarts/dist/extension/bmap.min');
```
插件会自动注册相应的组件。
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] Ovilia commented on issue #8966: Add node align for the Sankey diagram
Ovilia commented on issue #8966: Add node align for the Sankey diagram URL: https://github.com/apache/incubator-echarts/pull/8966#issuecomment-418032863 Hi @jas0ncn . Can you provide a further explanation of how this `align` works? For example, if it is set to be `'left'`, and parent level is `n`, will its child be place at `n + 1` position? Or can it set to be at `leafN - x` position, where `leafN` is the level of leaves and `x` can be configured? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] Ovilia closed issue #6864: Pie Chart Disappears On Resize
Ovilia closed issue #6864: Pie Chart Disappears On Resize URL: https://github.com/apache/incubator-echarts/issues/6864 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] Ovilia commented on issue #6864: Pie Chart Disappears On Resize
Ovilia commented on issue #6864: Pie Chart Disappears On Resize URL: https://github.com/apache/incubator-echarts/issues/6864#issuecomment-418030576 #8994 has more detailed information for this issue. Close for duplicate. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] Ovilia commented on issue #8994: Pie chart gets cut-off because clipPaths never are cleared
Ovilia commented on issue #8994: Pie chart gets cut-off because clipPaths never are cleared URL: https://github.com/apache/incubator-echarts/issues/8994#issuecomment-418030402 Thanks @billylittlefield for detailed information. We will look into it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] Ovilia commented on issue #8993: 如何设置饼图外拉的线的起点位置，使其不是从正中位置出来，而是可以自定义位置。
Ovilia commented on issue #8993: 如何设置饼图外拉的线的起点位置，使其不是从正中位置出来，而是可以自定义位置。 URL: https://github.com/apache/incubator-echarts/issues/8993#issuecomment-418029986 目前不支持这个，你是希望以什么方式指定？绝对的角度？还是什么？ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] Ovilia edited a comment on issue #8992: How to remove the round and the arrow on a markLine ?
Ovilia edited a comment on issue #8992: How to remove the round and the arrow on a markLine ? URL: https://github.com/apache/incubator-echarts/issues/8992#issuecomment-418029695 What is the *round*? Can you provide an image to show? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] Ovilia commented on issue #8986: Error when inserting new Series in a place different to the end of the list (for line chart)
Ovilia commented on issue #8986: Error when inserting new Series in a place different to the end of the list (for line chart) URL: https://github.com/apache/incubator-echarts/issues/8986#issuecomment-418028165 As I said, you need to remove the unrelated part and make the option as small as possible so that you can locate what goes wrong. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] Ovilia commented on issue #8395: dataset.source 为空数组造成 echarts 抛错
Ovilia commented on issue #8395: dataset.source 为空数组造成 echarts 抛错 URL: https://github.com/apache/incubator-echarts/issues/8395#issuecomment-418026217 已修复 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
[GitHub] Ovilia closed issue #8395: dataset.source 为空数组造成 echarts 抛错
Ovilia closed issue #8395: dataset.source 为空数组造成 echarts 抛错 URL: https://github.com/apache/incubator-echarts/issues/8395 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org For additional commands, e-mail: dev-h...@echarts.apache.org
How to add new committers
Dear mentors, We are considering merging new PR at https://github.com/apache/incubator-echarts/pull/8966 . Since this is the first time we accept commit from community, I have a few questions to ask: 1. Does he need to become a committer (so that he need to follow https://www.apache.org/dev/new-committers-guide.html ) before or after we merge the pull request? 2. Is there anything else we need to do before and after we merge the PR? Thanks! Zhang Wenli http://zhangwenli.com
