Re: [VOTE] Release Apache ECharts (incubating) 5.0.0 (release candidate 2)

2020-11-16 Thread Zhongxiang Wang
Hi,

I've found there are some compatibility issues in Windows build, which may 
cause a failed build.

In Mac OS, we can build without any issue. But in Windows, we cannot run 
successfully `prepublish`, `build`, and `release` scripts, and it throws many 
errors when building.
Please see the issue [1] on GitHub for more details about errors.
Since these issues have a severe influence on building the project in Windows, 
I've made a fix in the pull request [2] on GitHub.

Another minor issue in the content of this voting thread:
- The link to `Build Guide` is not correct, which should be [3].

[1] https://github.com/apache/incubator-echarts/issues/13628
[2] https://github.com/apache/incubator-echarts/pull/13629
[3] https://github.com/apache/incubator-echarts/blob/5.0.0/README.md#build

Thanks.

On 2020/11/11 12:51:04, SHUANG SU  wrote: 
> I am pleased to be calling this vote for the release of Apache ECharts
> (incubating) 5.0.0 (release candidate 2).
> 
> The release candidate to be voted over is available at:
> https://dist.apache.org/repos/dist/dev/incubator/echarts/5.0.0-rc.2/
> 
> The release candidate is signed with a GPG key available at:
> https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS
> 
> The Git commit for this release is:
> https://gitbox.apache.org/repos/asf?p=incubator-echarts.git;a=commit;h=d7658ec
> 
> The Release Note is available in:
> https://dist.apache.org/repos/dist/dev/incubator/echarts/5.0.0-rc.2/RELEASE_NOTE.txt
> 
> Build Guide:
> https://github.com/apache/incubator-echarts/blob/5.0.0-rc.2/README.md#build
> 
> Doc for 5.0.0-rc.2:
> https://echarts.apache.org/next/en/option.html
> 
> Examples for 5.0.0-rc.2:
> https://echarts.apache.org/next/examples/en/index.html
> 
> 
> Please vote on releasing this package as:
> Apache ECharts (incubating) 5.0.0 (release candidate 2)
> by "2020-11-14T13:45:01.761Z".
> 
> [ ] +1 Release this package
> [ ] 0 I don't feel strongly about it, but don't object
> [ ] -1 Do not release this package because...
> 
> Anyone can participate in testing and voting, not just committers, please
> feel free to try out the release candidate and provide your votes.
> 
> A checklist for reference:
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> 
> --
> 
> 
> Thanks,
> --
>  Su Shuang (100pah)
> --
> 

-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org



Re: [VOTE] Release Apache ECharts (incubating) 5.0.0 (release candidate 2)

2020-11-16 Thread Dave Fisher
+1 (binding)

Checked signatures, hash, incubating in name, DISCLAIMER, LICENSE, NOTICE.

Builds on macOS with npm updated.

Regards,
Dave

> On Nov 11, 2020, at 4:51 AM, SHUANG SU  wrote:
> 
> I am pleased to be calling this vote for the release of Apache ECharts
> (incubating) 5.0.0 (release candidate 2).
> 
> The release candidate to be voted over is available at:
> https://dist.apache.org/repos/dist/dev/incubator/echarts/5.0.0-rc.2/
> 
> The release candidate is signed with a GPG key available at:
> https://dist.apache.org/repos/dist/dev/incubator/echarts/KEYS
> 
> The Git commit for this release is:
> https://gitbox.apache.org/repos/asf?p=incubator-echarts.git;a=commit;h=d7658ec
> 
> The Release Note is available in:
> https://dist.apache.org/repos/dist/dev/incubator/echarts/5.0.0-rc.2/RELEASE_NOTE.txt
> 
> Build Guide:
> https://github.com/apache/incubator-echarts/blob/5.0.0-rc.2/README.md#build
> 
> Doc for 5.0.0-rc.2:
> https://echarts.apache.org/next/en/option.html
> 
> Examples for 5.0.0-rc.2:
> https://echarts.apache.org/next/examples/en/index.html
> 
> 
> Please vote on releasing this package as:
> Apache ECharts (incubating) 5.0.0 (release candidate 2)
> by "2020-11-14T13:45:01.761Z".
> 
> [ ] +1 Release this package
> [ ] 0 I don't feel strongly about it, but don't object
> [ ] -1 Do not release this package because...
> 
> Anyone can participate in testing and voting, not just committers, please
> feel free to try out the release candidate and provide your votes.
> 
> A checklist for reference:
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> 
> --
> 
> 
> Thanks,
> --
> Su Shuang (100pah)
> --


-
To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
For additional commands, e-mail: dev-h...@echarts.apache.org