[jira] [Commented] (EDGENT-327) some http urls in the website prevent full local testing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EDGENT-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15812813#comment-15812813
 ] 

ASF GitHub Bot commented on EDGENT-327:
---

Github user dlaboss commented on a diff in the pull request:


https://github.com/apache/incubator-edgent-website/pull/89#discussion_r95242892
  
--- Diff: site/_config.yml ---
@@ -126,9 +126,9 @@ host:127.0.0.1
 sourcerepourl: https://github.com/apache/incubator-edgent
 downloadsurl: /docs/downloads
 projurl: /
-#docsurl: /javadoc/latest
+docsurl: /javadoc/latest
 # above yields things like the following when running on a "jekyll serve" 
test server
--- End diff --

woops, sorry, just noticed your jira comment that the script is run after 
the site is built hence the msgs will still show up when running "jekyll serve" 
https://issues.apache.org/jira/browse/EDGENT-327?focusedCommentId=15812317=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15812317
If that's the case maybe add some commentary to README.md (where it 
describes running "jekyll serve") so folks know its safe to ignore those 
particular error msgs?


> some http urls in the website prevent full local testing
> 
>
> Key: EDGENT-327
> URL: https://issues.apache.org/jira/browse/EDGENT-327
> Project: Edgent
>  Issue Type: Task
>  Components: Web Site
>Reporter: Dale LaBossiere
>Assignee: Queenie Ma
>Priority: Trivial
>
> If you create a local / test instance of the website (e.g., "jekyll server") 
> all of the javadoc related links go to the live website.
> site/_config.yml defines docurl which is used in many places. See the note 
> there about issues encountered when I tried changing it from a http url to a 
> / url... though overall it seemed to work.
> Also the javadoc "latest", 1.0.0, ... links in 
> site/_data/mydoc/mydoc_topnav.yml are http links.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-edgent-website pull request #89: [EDGENT-327] Use local Javadoc UR...

[queeniema]

Github user queeniema commented on a diff in the pull request:


https://github.com/apache/incubator-edgent-website/pull/89#discussion_r95235577
  
--- Diff: site/_config.yml ---
@@ -126,9 +126,9 @@ host:127.0.0.1
 sourcerepourl: https://github.com/apache/incubator-edgent
 downloadsurl: /docs/downloads
 projurl: /
-#docsurl: /javadoc/latest
+docsurl: /javadoc/latest
 # above yields things like the following when running on a "jekyll serve" 
test server
--- End diff --

Yes, they should be. I overlooked that. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (EDGENT-327) some http urls in the website prevent full local testing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EDGENT-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15812711#comment-15812711
 ] 

ASF GitHub Bot commented on EDGENT-327:
---

Github user dlaboss commented on a diff in the pull request:


https://github.com/apache/incubator-edgent-website/pull/89#discussion_r95234993
  
--- Diff: site/_config.yml ---
@@ -126,9 +126,9 @@ host:127.0.0.1
 sourcerepourl: https://github.com/apache/incubator-edgent
 downloadsurl: /docs/downloads
 projurl: /
-#docsurl: /javadoc/latest
+docsurl: /javadoc/latest
 # above yields things like the following when running on a "jekyll serve" 
test server
--- End diff --

With your fixes these comments are no longer true so shouldn't they and the 
orig/wrong commented out docsurl should just be removed?


> some http urls in the website prevent full local testing
> 
>
> Key: EDGENT-327
> URL: https://issues.apache.org/jira/browse/EDGENT-327
> Project: Edgent
>  Issue Type: Task
>  Components: Web Site
>Reporter: Dale LaBossiere
>Assignee: Queenie Ma
>Priority: Trivial
>
> If you create a local / test instance of the website (e.g., "jekyll server") 
> all of the javadoc related links go to the live website.
> site/_config.yml defines docurl which is used in many places. See the note 
> there about issues encountered when I tried changing it from a http url to a 
> / url... though overall it seemed to work.
> Also the javadoc "latest", 1.0.0, ... links in 
> site/_data/mydoc/mydoc_topnav.yml are http links.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-edgent-website pull request #89: [EDGENT-327] Use local Javadoc UR...

[dlaboss]

Github user dlaboss commented on a diff in the pull request:


https://github.com/apache/incubator-edgent-website/pull/89#discussion_r95234993
  
--- Diff: site/_config.yml ---
@@ -126,9 +126,9 @@ host:127.0.0.1
 sourcerepourl: https://github.com/apache/incubator-edgent
 downloadsurl: /docs/downloads
 projurl: /
-#docsurl: /javadoc/latest
+docsurl: /javadoc/latest
 # above yields things like the following when running on a "jekyll serve" 
test server
--- End diff --

With your fixes these comments are no longer true so shouldn't they and the 
orig/wrong commented out docsurl should just be removed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (EDGENT-327) some http urls in the website prevent full local testing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EDGENT-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15812323#comment-15812323
 ] 

ASF GitHub Bot commented on EDGENT-327:
---

Github user ddebrunner commented on a diff in the pull request:


https://github.com/apache/incubator-edgent-website/pull/89#discussion_r95203301
  
--- Diff: build.sh ---
@@ -1,6 +1,7 @@
 set -e
 cd site
 jekyll build -d ../content_tmp
+sed -i "" "/^@import/d; s/'DejaVu Sans',//g; s/'DejaVu Sans Mono',//g; 
s/'DejaVu Serif',//g" ../content_tmp/javadoc/*/stylesheet.css
--- End diff --

Good to have a comment here as to why this (sed) is being done.


> some http urls in the website prevent full local testing
> 
>
> Key: EDGENT-327
> URL: https://issues.apache.org/jira/browse/EDGENT-327
> Project: Edgent
>  Issue Type: Task
>  Components: Web Site
>Reporter: Dale LaBossiere
>Assignee: Queenie Ma
>Priority: Trivial
>
> If you create a local / test instance of the website (e.g., "jekyll server") 
> all of the javadoc related links go to the live website.
> site/_config.yml defines docurl which is used in many places. See the note 
> there about issues encountered when I tried changing it from a http url to a 
> / url... though overall it seemed to work.
> Also the javadoc "latest", 1.0.0, ... links in 
> site/_data/mydoc/mydoc_topnav.yml are http links.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EDGENT-327) some http urls in the website prevent full local testing

[Queenie Ma (JIRA)]

[ 
https://issues.apache.org/jira/browse/EDGENT-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15812317#comment-15812317
 ] 

Queenie Ma commented on EDGENT-327:
---

I just committed some changes that removes the DejaVu references in 
{{stylesheet.css}} in {{build.sh}}. Since these replacements do not occur until 
the site is built, running {{jekyll serve}} will still show the {{ERROR 
`/javadoc/latest/resources/fonts/dejavu.css' not found}} message. For the other 
error message regarding {{favicon.ico}}, it seems that Jekyll automatically 
looks for that file so I just added it to the root of the site.

> some http urls in the website prevent full local testing
> 
>
> Key: EDGENT-327
> URL: https://issues.apache.org/jira/browse/EDGENT-327
> Project: Edgent
>  Issue Type: Task
>  Components: Web Site
>Reporter: Dale LaBossiere
>Assignee: Queenie Ma
>Priority: Trivial
>
> If you create a local / test instance of the website (e.g., "jekyll server") 
> all of the javadoc related links go to the live website.
> site/_config.yml defines docurl which is used in many places. See the note 
> there about issues encountered when I tried changing it from a http url to a 
> / url... though overall it seemed to work.
> Also the javadoc "latest", 1.0.0, ... links in 
> site/_data/mydoc/mydoc_topnav.yml are http links.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (EDGENT-327) some http urls in the website prevent full local testing

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/EDGENT-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15812303#comment-15812303
 ] 

ASF GitHub Bot commented on EDGENT-327:
---

GitHub user queeniema opened a pull request:

https://github.com/apache/incubator-edgent-website/pull/89

[EDGENT-327] Use local Javadoc URLs

- Removed all references to the DejaVu font in `stylesheet.css` during the 
site build process
- Added a new `favicon.ico` file to the root of the site

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/queeniema/incubator-edgent-website EDGENT-327

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-edgent-website/pull/89.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #89


commit 7080f26d0ba23b5de8ee933f5a37bb88e1123ac3
Author: Queenie Ma 
Date:   2017-01-05T19:10:51Z

[EDGENT-327] Use local Javadoc URLs




> some http urls in the website prevent full local testing
> 
>
> Key: EDGENT-327
> URL: https://issues.apache.org/jira/browse/EDGENT-327
> Project: Edgent
>  Issue Type: Task
>  Components: Web Site
>Reporter: Dale LaBossiere
>Assignee: Queenie Ma
>Priority: Trivial
>
> If you create a local / test instance of the website (e.g., "jekyll server") 
> all of the javadoc related links go to the live website.
> site/_config.yml defines docurl which is used in many places. See the note 
> there about issues encountered when I tried changing it from a http url to a 
> / url... though overall it seemed to work.
> Also the javadoc "latest", 1.0.0, ... links in 
> site/_data/mydoc/mydoc_topnav.yml are http links.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-edgent-website pull request #89: [EDGENT-327] Use local Javadoc UR...

[queeniema]

GitHub user queeniema opened a pull request:

https://github.com/apache/incubator-edgent-website/pull/89

[EDGENT-327] Use local Javadoc URLs

- Removed all references to the DejaVu font in `stylesheet.css` during the 
site build process
- Added a new `favicon.ico` file to the root of the site

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/queeniema/incubator-edgent-website EDGENT-327

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-edgent-website/pull/89.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #89


commit 7080f26d0ba23b5de8ee933f5a37bb88e1123ac3
Author: Queenie Ma 
Date:   2017-01-05T19:10:51Z

[EDGENT-327] Use local Javadoc URLs




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---