[jira] [Commented] (EDGENT-327) some http urls in the website prevent full local testing
[ https://issues.apache.org/jira/browse/EDGENT-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815404#comment-15815404 ] Dale LaBossiere commented on EDGENT-327: [~queeniema] As your contribs also addressed https://issues.apache.org/jira/browse/EDGENT-360 please take ownership of it - and credit for resolving it! :-) > some http urls in the website prevent full local testing > > > Key: EDGENT-327 > URL: https://issues.apache.org/jira/browse/EDGENT-327 > Project: Edgent > Issue Type: Task > Components: Web Site >Reporter: Dale LaBossiere >Assignee: Queenie Ma >Priority: Trivial > > If you create a local / test instance of the website (e.g., "jekyll server") > all of the javadoc related links go to the live website. > site/_config.yml defines docurl which is used in many places. See the note > there about issues encountered when I tried changing it from a http url to a > / url... though overall it seemed to work. > Also the javadoc "latest", 1.0.0, ... links in > site/_data/mydoc/mydoc_topnav.yml are http links. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EDGENT-327) some http urls in the website prevent full local testing
[ https://issues.apache.org/jira/browse/EDGENT-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815388#comment-15815388 ] ASF GitHub Bot commented on EDGENT-327: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-edgent-website/pull/89 > some http urls in the website prevent full local testing > > > Key: EDGENT-327 > URL: https://issues.apache.org/jira/browse/EDGENT-327 > Project: Edgent > Issue Type: Task > Components: Web Site >Reporter: Dale LaBossiere >Assignee: Queenie Ma >Priority: Trivial > > If you create a local / test instance of the website (e.g., "jekyll server") > all of the javadoc related links go to the live website. > site/_config.yml defines docurl which is used in many places. See the note > there about issues encountered when I tried changing it from a http url to a > / url... though overall it seemed to work. > Also the javadoc "latest", 1.0.0, ... links in > site/_data/mydoc/mydoc_topnav.yml are http links. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EDGENT-327) some http urls in the website prevent full local testing
[ https://issues.apache.org/jira/browse/EDGENT-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814869#comment-15814869 ] ASF GitHub Bot commented on EDGENT-327: --- Github user dlaboss commented on the issue: https://github.com/apache/incubator-edgent-website/pull/89 +1 thanks for straightening this out! > some http urls in the website prevent full local testing > > > Key: EDGENT-327 > URL: https://issues.apache.org/jira/browse/EDGENT-327 > Project: Edgent > Issue Type: Task > Components: Web Site >Reporter: Dale LaBossiere >Assignee: Queenie Ma >Priority: Trivial > > If you create a local / test instance of the website (e.g., "jekyll server") > all of the javadoc related links go to the live website. > site/_config.yml defines docurl which is used in many places. See the note > there about issues encountered when I tried changing it from a http url to a > / url... though overall it seemed to work. > Also the javadoc "latest", 1.0.0, ... links in > site/_data/mydoc/mydoc_topnav.yml are http links. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EDGENT-327) some http urls in the website prevent full local testing
[ https://issues.apache.org/jira/browse/EDGENT-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15812813#comment-15812813 ] ASF GitHub Bot commented on EDGENT-327: --- Github user dlaboss commented on a diff in the pull request: https://github.com/apache/incubator-edgent-website/pull/89#discussion_r95242892 --- Diff: site/_config.yml --- @@ -126,9 +126,9 @@ host:127.0.0.1 sourcerepourl: https://github.com/apache/incubator-edgent downloadsurl: /docs/downloads projurl: / -#docsurl: /javadoc/latest +docsurl: /javadoc/latest # above yields things like the following when running on a "jekyll serve" test server --- End diff -- woops, sorry, just noticed your jira comment that the script is run after the site is built hence the msgs will still show up when running "jekyll serve" https://issues.apache.org/jira/browse/EDGENT-327?focusedCommentId=15812317=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15812317 If that's the case maybe add some commentary to README.md (where it describes running "jekyll serve") so folks know its safe to ignore those particular error msgs? > some http urls in the website prevent full local testing > > > Key: EDGENT-327 > URL: https://issues.apache.org/jira/browse/EDGENT-327 > Project: Edgent > Issue Type: Task > Components: Web Site >Reporter: Dale LaBossiere >Assignee: Queenie Ma >Priority: Trivial > > If you create a local / test instance of the website (e.g., "jekyll server") > all of the javadoc related links go to the live website. > site/_config.yml defines docurl which is used in many places. See the note > there about issues encountered when I tried changing it from a http url to a > / url... though overall it seemed to work. > Also the javadoc "latest", 1.0.0, ... links in > site/_data/mydoc/mydoc_topnav.yml are http links. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EDGENT-327) some http urls in the website prevent full local testing
[ https://issues.apache.org/jira/browse/EDGENT-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15812711#comment-15812711 ] ASF GitHub Bot commented on EDGENT-327: --- Github user dlaboss commented on a diff in the pull request: https://github.com/apache/incubator-edgent-website/pull/89#discussion_r95234993 --- Diff: site/_config.yml --- @@ -126,9 +126,9 @@ host:127.0.0.1 sourcerepourl: https://github.com/apache/incubator-edgent downloadsurl: /docs/downloads projurl: / -#docsurl: /javadoc/latest +docsurl: /javadoc/latest # above yields things like the following when running on a "jekyll serve" test server --- End diff -- With your fixes these comments are no longer true so shouldn't they and the orig/wrong commented out docsurl should just be removed? > some http urls in the website prevent full local testing > > > Key: EDGENT-327 > URL: https://issues.apache.org/jira/browse/EDGENT-327 > Project: Edgent > Issue Type: Task > Components: Web Site >Reporter: Dale LaBossiere >Assignee: Queenie Ma >Priority: Trivial > > If you create a local / test instance of the website (e.g., "jekyll server") > all of the javadoc related links go to the live website. > site/_config.yml defines docurl which is used in many places. See the note > there about issues encountered when I tried changing it from a http url to a > / url... though overall it seemed to work. > Also the javadoc "latest", 1.0.0, ... links in > site/_data/mydoc/mydoc_topnav.yml are http links. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EDGENT-327) some http urls in the website prevent full local testing
[ https://issues.apache.org/jira/browse/EDGENT-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15812323#comment-15812323 ] ASF GitHub Bot commented on EDGENT-327: --- Github user ddebrunner commented on a diff in the pull request: https://github.com/apache/incubator-edgent-website/pull/89#discussion_r95203301 --- Diff: build.sh --- @@ -1,6 +1,7 @@ set -e cd site jekyll build -d ../content_tmp +sed -i "" "/^@import/d; s/'DejaVu Sans',//g; s/'DejaVu Sans Mono',//g; s/'DejaVu Serif',//g" ../content_tmp/javadoc/*/stylesheet.css --- End diff -- Good to have a comment here as to why this (sed) is being done. > some http urls in the website prevent full local testing > > > Key: EDGENT-327 > URL: https://issues.apache.org/jira/browse/EDGENT-327 > Project: Edgent > Issue Type: Task > Components: Web Site >Reporter: Dale LaBossiere >Assignee: Queenie Ma >Priority: Trivial > > If you create a local / test instance of the website (e.g., "jekyll server") > all of the javadoc related links go to the live website. > site/_config.yml defines docurl which is used in many places. See the note > there about issues encountered when I tried changing it from a http url to a > / url... though overall it seemed to work. > Also the javadoc "latest", 1.0.0, ... links in > site/_data/mydoc/mydoc_topnav.yml are http links. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EDGENT-327) some http urls in the website prevent full local testing
[ https://issues.apache.org/jira/browse/EDGENT-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15812317#comment-15812317 ] Queenie Ma commented on EDGENT-327: --- I just committed some changes that removes the DejaVu references in {{stylesheet.css}} in {{build.sh}}. Since these replacements do not occur until the site is built, running {{jekyll serve}} will still show the {{ERROR `/javadoc/latest/resources/fonts/dejavu.css' not found}} message. For the other error message regarding {{favicon.ico}}, it seems that Jekyll automatically looks for that file so I just added it to the root of the site. > some http urls in the website prevent full local testing > > > Key: EDGENT-327 > URL: https://issues.apache.org/jira/browse/EDGENT-327 > Project: Edgent > Issue Type: Task > Components: Web Site >Reporter: Dale LaBossiere >Assignee: Queenie Ma >Priority: Trivial > > If you create a local / test instance of the website (e.g., "jekyll server") > all of the javadoc related links go to the live website. > site/_config.yml defines docurl which is used in many places. See the note > there about issues encountered when I tried changing it from a http url to a > / url... though overall it seemed to work. > Also the javadoc "latest", 1.0.0, ... links in > site/_data/mydoc/mydoc_topnav.yml are http links. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EDGENT-327) some http urls in the website prevent full local testing
[ https://issues.apache.org/jira/browse/EDGENT-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15812303#comment-15812303 ] ASF GitHub Bot commented on EDGENT-327: --- GitHub user queeniema opened a pull request: https://github.com/apache/incubator-edgent-website/pull/89 [EDGENT-327] Use local Javadoc URLs - Removed all references to the DejaVu font in `stylesheet.css` during the site build process - Added a new `favicon.ico` file to the root of the site You can merge this pull request into a Git repository by running: $ git pull https://github.com/queeniema/incubator-edgent-website EDGENT-327 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-edgent-website/pull/89.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #89 commit 7080f26d0ba23b5de8ee933f5a37bb88e1123ac3 Author: Queenie MaDate: 2017-01-05T19:10:51Z [EDGENT-327] Use local Javadoc URLs > some http urls in the website prevent full local testing > > > Key: EDGENT-327 > URL: https://issues.apache.org/jira/browse/EDGENT-327 > Project: Edgent > Issue Type: Task > Components: Web Site >Reporter: Dale LaBossiere >Assignee: Queenie Ma >Priority: Trivial > > If you create a local / test instance of the website (e.g., "jekyll server") > all of the javadoc related links go to the live website. > site/_config.yml defines docurl which is used in many places. See the note > there about issues encountered when I tried changing it from a http url to a > / url... though overall it seemed to work. > Also the javadoc "latest", 1.0.0, ... links in > site/_data/mydoc/mydoc_topnav.yml are http links. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EDGENT-327) some http urls in the website prevent full local testing
[ https://issues.apache.org/jira/browse/EDGENT-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15805357#comment-15805357 ] Queenie Ma commented on EDGENT-327: --- I'm not sure why that favicon.ico message appears. I don't see any references to it in the javadoc folder, which is odd... If the external URL is used, then an error is displayed in the browser console when you navigate to the [page|https://edgent.incubator.apache.org/javadoc/latest/index.html], rather than in the Jekyll output. {quote} Failed to load resource: the server responded with a status of 404 (Not Found) https://edgent.incubator.apache.org/javadoc/latest/resources/fonts/dejavu.css {quote} > some http urls in the website prevent full local testing > > > Key: EDGENT-327 > URL: https://issues.apache.org/jira/browse/EDGENT-327 > Project: Edgent > Issue Type: Task > Components: Web Site >Reporter: Dale LaBossiere >Assignee: Queenie Ma >Priority: Trivial > > If you create a local / test instance of the website (e.g., "jekyll server") > all of the javadoc related links go to the live website. > site/_config.yml defines docurl which is used in many places. See the note > there about issues encountered when I tried changing it from a http url to a > / url... though overall it seemed to work. > Also the javadoc "latest", 1.0.0, ... links in > site/_data/mydoc/mydoc_topnav.yml are http links. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EDGENT-327) some http urls in the website prevent full local testing
[ https://issues.apache.org/jira/browse/EDGENT-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15804851#comment-15804851 ] Dale LaBossiere commented on EDGENT-327: In addition to the dejavu.css msg I encountered the /favico.ico msg. Does it have the same cause/workarounds? I'm out of my element here but the question that comes to me is: why is dejavu.css "missing" when using one form of docsurl and not the other? Is it in fact present in the generated filetree result for one case and not in the other? Or the import statement present (or different) in one case and not the other? > some http urls in the website prevent full local testing > > > Key: EDGENT-327 > URL: https://issues.apache.org/jira/browse/EDGENT-327 > Project: Edgent > Issue Type: Task > Components: Web Site >Reporter: Dale LaBossiere >Assignee: Queenie Ma >Priority: Trivial > > If you create a local / test instance of the website (e.g., "jekyll server") > all of the javadoc related links go to the live website. > site/_config.yml defines docurl which is used in many places. See the note > there about issues encountered when I tried changing it from a http url to a > / url... though overall it seemed to work. > Also the javadoc "latest", 1.0.0, ... links in > site/_data/mydoc/mydoc_topnav.yml are http links. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EDGENT-327) some http urls in the website prevent full local testing
[ https://issues.apache.org/jira/browse/EDGENT-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15802747#comment-15802747 ] Queenie Ma commented on EDGENT-327: --- I looked into the {{ERROR `/javadoc/latest/resources/fonts/dejavu.css' not found}} messages. It seems to be a bug in the Javadoc tool due to a dangling reference to dejavu.css in stylesheet.css. Note the {{@import}} statement below. {code:title=stylesheet.css|borderStyle=solid} @import url('resources/fonts/dejavu.css'); body { background-color:#ff; color:#353833; font-family:'DejaVu Sans', Arial, Helvetica, sans-serif; font-size:14px; margin:0; } ... {code} Found this related issue: https://bugs.eclipse.org/bugs/show_bug.cgi?id=470739. A person who commented on that issue submitted a Java bug, but it seems that the bug hasn't been fixed. Workarounds are: # Manually add the dejavu.css font file to the generated Javadoc (not sure where to get that file) # Remove the {{@import}} statement and use a different default font Thoughts? > some http urls in the website prevent full local testing > > > Key: EDGENT-327 > URL: https://issues.apache.org/jira/browse/EDGENT-327 > Project: Edgent > Issue Type: Task > Components: Web Site >Reporter: Dale LaBossiere >Assignee: Queenie Ma >Priority: Trivial > > If you create a local / test instance of the website (e.g., "jekyll server") > all of the javadoc related links go to the live website. > site/_config.yml defines docurl which is used in many places. See the note > there about issues encountered when I tried changing it from a http url to a > / url... though overall it seemed to work. > Also the javadoc "latest", 1.0.0, ... links in > site/_data/mydoc/mydoc_topnav.yml are http links. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EDGENT-327) some http urls in the website prevent full local testing
[ https://issues.apache.org/jira/browse/EDGENT-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15802629#comment-15802629 ] ASF GitHub Bot commented on EDGENT-327: --- Github user queeniema closed the pull request at: https://github.com/apache/incubator-edgent-website/pull/88 > some http urls in the website prevent full local testing > > > Key: EDGENT-327 > URL: https://issues.apache.org/jira/browse/EDGENT-327 > Project: Edgent > Issue Type: Task > Components: Web Site >Reporter: Dale LaBossiere >Assignee: Queenie Ma >Priority: Trivial > > If you create a local / test instance of the website (e.g., "jekyll server") > all of the javadoc related links go to the live website. > site/_config.yml defines docurl which is used in many places. See the note > there about issues encountered when I tried changing it from a http url to a > / url... though overall it seemed to work. > Also the javadoc "latest", 1.0.0, ... links in > site/_data/mydoc/mydoc_topnav.yml are http links. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EDGENT-327) some http urls in the website prevent full local testing
[ https://issues.apache.org/jira/browse/EDGENT-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15802603#comment-15802603 ] ASF GitHub Bot commented on EDGENT-327: --- Github user dlaboss commented on a diff in the pull request: https://github.com/apache/incubator-edgent-website/pull/88#discussion_r94857262 --- Diff: site/_config.yml --- @@ -126,9 +126,9 @@ host:127.0.0.1 sourcerepourl: https://github.com/apache/incubator-edgent downloadsurl: /docs/downloads projurl: / -#docsurl: /javadoc/latest +docsurl: /javadoc/latest # above yields things like the following when running on a "jekyll serve" test server # [2016-12-22 15:23:31] ERROR `/favicon.ico' not found. # [2016-12-22 15:33:17] ERROR `/javadoc/latest/resources/fonts/dejavu.css' not found. # the following is undesirable as it doesn't link to the "jekyll serve" test server -docsurl: https://edgent.incubator.apache.org/javadoc/latest +# docsurl: https://edgent.incubator.apache.org/javadoc/latest --- End diff -- Yeah, I thought the javadoc looked correct too but wasn't confident they were completely benign. But even if benign, I think it's a bad idea to commit something that's generating them. At best folks will be later be surprised / confused by them. > some http urls in the website prevent full local testing > > > Key: EDGENT-327 > URL: https://issues.apache.org/jira/browse/EDGENT-327 > Project: Edgent > Issue Type: Task > Components: Web Site >Reporter: Dale LaBossiere >Assignee: Queenie Ma >Priority: Trivial > > If you create a local / test instance of the website (e.g., "jekyll server") > all of the javadoc related links go to the live website. > site/_config.yml defines docurl which is used in many places. See the note > there about issues encountered when I tried changing it from a http url to a > / url... though overall it seemed to work. > Also the javadoc "latest", 1.0.0, ... links in > site/_data/mydoc/mydoc_topnav.yml are http links. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EDGENT-327) some http urls in the website prevent full local testing
[ https://issues.apache.org/jira/browse/EDGENT-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15802554#comment-15802554 ] ASF GitHub Bot commented on EDGENT-327: --- Github user queeniema commented on a diff in the pull request: https://github.com/apache/incubator-edgent-website/pull/88#discussion_r94853886 --- Diff: site/_config.yml --- @@ -126,9 +126,9 @@ host:127.0.0.1 sourcerepourl: https://github.com/apache/incubator-edgent downloadsurl: /docs/downloads projurl: / -#docsurl: /javadoc/latest +docsurl: /javadoc/latest # above yields things like the following when running on a "jekyll serve" test server # [2016-12-22 15:23:31] ERROR `/favicon.ico' not found. # [2016-12-22 15:33:17] ERROR `/javadoc/latest/resources/fonts/dejavu.css' not found. # the following is undesirable as it doesn't link to the "jekyll serve" test server -docsurl: https://edgent.incubator.apache.org/javadoc/latest +# docsurl: https://edgent.incubator.apache.org/javadoc/latest --- End diff -- I still see the error messages related to `dejavu.css`, but the Javadoc looks correct. > some http urls in the website prevent full local testing > > > Key: EDGENT-327 > URL: https://issues.apache.org/jira/browse/EDGENT-327 > Project: Edgent > Issue Type: Task > Components: Web Site >Reporter: Dale LaBossiere >Assignee: Queenie Ma >Priority: Trivial > > If you create a local / test instance of the website (e.g., "jekyll server") > all of the javadoc related links go to the live website. > site/_config.yml defines docurl which is used in many places. See the note > there about issues encountered when I tried changing it from a http url to a > / url... though overall it seemed to work. > Also the javadoc "latest", 1.0.0, ... links in > site/_data/mydoc/mydoc_topnav.yml are http links. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EDGENT-327) some http urls in the website prevent full local testing
[ https://issues.apache.org/jira/browse/EDGENT-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15802542#comment-15802542 ] ASF GitHub Bot commented on EDGENT-327: --- Github user queeniema commented on a diff in the pull request: https://github.com/apache/incubator-edgent-website/pull/88#discussion_r94853271 --- Diff: site/_data/mydoc/mydoc_topnav.yml --- @@ -60,24 +60,24 @@ javadoc_dropdowns: version: all output: web items: -- title: lastest - external_url: http://edgent.incubator.apache.org/javadoc/latest/index.html +- title: latest + url: /..\/javadoc\/latest --- End diff -- When testing locally, Jekyll wasn't recognizing the path without the backslashes. Does `url: /javadoc/latest` work for anyone else? > some http urls in the website prevent full local testing > > > Key: EDGENT-327 > URL: https://issues.apache.org/jira/browse/EDGENT-327 > Project: Edgent > Issue Type: Task > Components: Web Site >Reporter: Dale LaBossiere >Assignee: Queenie Ma >Priority: Trivial > > If you create a local / test instance of the website (e.g., "jekyll server") > all of the javadoc related links go to the live website. > site/_config.yml defines docurl which is used in many places. See the note > there about issues encountered when I tried changing it from a http url to a > / url... though overall it seemed to work. > Also the javadoc "latest", 1.0.0, ... links in > site/_data/mydoc/mydoc_topnav.yml are http links. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EDGENT-327) some http urls in the website prevent full local testing
[ https://issues.apache.org/jira/browse/EDGENT-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15802490#comment-15802490 ] ASF GitHub Bot commented on EDGENT-327: --- Github user dlaboss commented on a diff in the pull request: https://github.com/apache/incubator-edgent-website/pull/88#discussion_r94849130 --- Diff: site/_data/mydoc/mydoc_topnav.yml --- @@ -60,24 +60,24 @@ javadoc_dropdowns: version: all output: web items: -- title: lastest - external_url: http://edgent.incubator.apache.org/javadoc/latest/index.html +- title: latest + url: /..\/javadoc\/latest --- End diff -- newbie question: why the backslash characters? > some http urls in the website prevent full local testing > > > Key: EDGENT-327 > URL: https://issues.apache.org/jira/browse/EDGENT-327 > Project: Edgent > Issue Type: Task > Components: Web Site >Reporter: Dale LaBossiere >Assignee: Queenie Ma >Priority: Trivial > > If you create a local / test instance of the website (e.g., "jekyll server") > all of the javadoc related links go to the live website. > site/_config.yml defines docurl which is used in many places. See the note > there about issues encountered when I tried changing it from a http url to a > / url... though overall it seemed to work. > Also the javadoc "latest", 1.0.0, ... links in > site/_data/mydoc/mydoc_topnav.yml are http links. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (EDGENT-327) some http urls in the website prevent full local testing
[ https://issues.apache.org/jira/browse/EDGENT-327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15802231#comment-15802231 ] ASF GitHub Bot commented on EDGENT-327: --- GitHub user queeniema opened a pull request: https://github.com/apache/incubator-edgent-website/pull/88 [EDGENT-327] Use local Javadoc URLs You can merge this pull request into a Git repository by running: $ git pull https://github.com/queeniema/incubator-edgent-website EDGENT-327 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-edgent-website/pull/88.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #88 commit d6fa38716ec171d67e77c9cc51a00abd1cb55f51 Author: Queenie MaDate: 2017-01-05T19:10:51Z [EDGENT-327] Use local Javadoc URLs > some http urls in the website prevent full local testing > > > Key: EDGENT-327 > URL: https://issues.apache.org/jira/browse/EDGENT-327 > Project: Edgent > Issue Type: Task > Components: Web Site >Reporter: Dale LaBossiere >Assignee: Queenie Ma >Priority: Trivial > > If you create a local / test instance of the website (e.g., "jekyll server") > all of the javadoc related links go to the live website. > site/_config.yml defines docurl which is used in many places. See the note > there about issues encountered when I tried changing it from a http url to a > / url... though overall it seemed to work. > Also the javadoc "latest", 1.0.0, ... links in > site/_data/mydoc/mydoc_topnav.yml are http links. -- This message was sent by Atlassian JIRA (v6.3.4#6332)