[jira] [Commented] (FALCON-1405) Oozie workflow should not fail if post-processing fails
[ https://issues.apache.org/jira/browse/FALCON-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989053#comment-14989053 ] Ajay Yadava commented on FALCON-1405: - Yes, but this patch can still not be committed as users can still choose to disable Oozie JMS notifications. > Oozie workflow should not fail if post-processing fails > --- > > Key: FALCON-1405 > URL: https://issues.apache.org/jira/browse/FALCON-1405 > Project: Falcon > Issue Type: Improvement >Reporter: Pallavi Rao >Assignee: Narayan Periwal > Attachments: FALCON-1405-v0.patch, FALCON-1405-v1.patch > > > Currently, even if the user workflow succeeds and post-processing fails, the > workflow is marked as failed. > IMO, the post-processing should be an optional step. We should wire workflow > to succeed even if the post-processing fails. Especially, after FALCON-1231, > we won't even depend on post-processing for completion notification. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FALCON-1405) Oozie workflow should not fail if post-processing fails
[ https://issues.apache.org/jira/browse/FALCON-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989052#comment-14989052 ] Ajay Yadava commented on FALCON-1405: - Yes, but this patch can still not be committed as users can still choose to disable Oozie JMS notifications. > Oozie workflow should not fail if post-processing fails > --- > > Key: FALCON-1405 > URL: https://issues.apache.org/jira/browse/FALCON-1405 > Project: Falcon > Issue Type: Improvement >Reporter: Pallavi Rao >Assignee: Narayan Periwal > Attachments: FALCON-1405-v0.patch, FALCON-1405-v1.patch > > > Currently, even if the user workflow succeeds and post-processing fails, the > workflow is marked as failed. > IMO, the post-processing should be an optional step. We should wire workflow > to succeed even if the post-processing fails. Especially, after FALCON-1231, > we won't even depend on post-processing for completion notification. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FALCON-1405) Oozie workflow should not fail if post-processing fails
[ https://issues.apache.org/jira/browse/FALCON-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989013#comment-14989013 ] Pragya Mittal commented on FALCON-1405: --- [~ajayyadava] As discussed the patch will work fine once oozie JMS notifications are enabled(FALCON-1231), since log mover failure exception does not effect post-processing action. > Oozie workflow should not fail if post-processing fails > --- > > Key: FALCON-1405 > URL: https://issues.apache.org/jira/browse/FALCON-1405 > Project: Falcon > Issue Type: Improvement >Reporter: Pallavi Rao >Assignee: Narayan Periwal > Attachments: FALCON-1405-v0.patch, FALCON-1405-v1.patch > > > Currently, even if the user workflow succeeds and post-processing fails, the > workflow is marked as failed. > IMO, the post-processing should be an optional step. We should wire workflow > to succeed even if the post-processing fails. Especially, after FALCON-1231, > we won't even depend on post-processing for completion notification. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FALCON-1405) Oozie workflow should not fail if post-processing fails
[ https://issues.apache.org/jira/browse/FALCON-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14907706#comment-14907706 ] Srikanth Sundarrajan commented on FALCON-1405: -- Yes. FALCON-1231 is marked as "required" for this. > Oozie workflow should not fail if post-processing fails > --- > > Key: FALCON-1405 > URL: https://issues.apache.org/jira/browse/FALCON-1405 > Project: Falcon > Issue Type: Improvement >Reporter: Pallavi Rao >Assignee: Narayan Periwal > Attachments: FALCON-1405-v0.patch, FALCON-1405-v1.patch > > > Currently, even if the user workflow succeeds and post-processing fails, the > workflow is marked as failed. > IMO, the post-processing should be an optional step. We should wire workflow > to succeed even if the post-processing fails. Especially, after FALCON-1231, > we won't even depend on post-processing for completion notification. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FALCON-1405) Oozie workflow should not fail if post-processing fails
[ https://issues.apache.org/jira/browse/FALCON-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14907707#comment-14907707 ] Srikanth Sundarrajan commented on FALCON-1405: -- Yes. FALCON-1231 is marked as "required" for this. > Oozie workflow should not fail if post-processing fails > --- > > Key: FALCON-1405 > URL: https://issues.apache.org/jira/browse/FALCON-1405 > Project: Falcon > Issue Type: Improvement >Reporter: Pallavi Rao >Assignee: Narayan Periwal > Attachments: FALCON-1405-v0.patch, FALCON-1405-v1.patch > > > Currently, even if the user workflow succeeds and post-processing fails, the > workflow is marked as failed. > IMO, the post-processing should be an optional step. We should wire workflow > to succeed even if the post-processing fails. Especially, after FALCON-1231, > we won't even depend on post-processing for completion notification. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FALCON-1405) Oozie workflow should not fail if post-processing fails
[ https://issues.apache.org/jira/browse/FALCON-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14907668#comment-14907668 ] Srikanth Sundarrajan commented on FALCON-1405: -- +1. This can be committed. While on this, [~sandeep.samudrala], was suggesting in an offline conversation that the post processing be moved to the falcon server. Which is indeed the way forward with the new scheduler work happening. I am inclined as it seems to lower the resource utilization, while burdening the falcon server a bit more. What do others feel ? Flip side of course is that the logs haven't been moved (as there might be a delay in when falcon server picks this up), and users wonder why logs aren't available even after the workflow has completed. > Oozie workflow should not fail if post-processing fails > --- > > Key: FALCON-1405 > URL: https://issues.apache.org/jira/browse/FALCON-1405 > Project: Falcon > Issue Type: Improvement >Reporter: Pallavi Rao >Assignee: Narayan Periwal > Attachments: FALCON-1405-v0.patch, FALCON-1405-v1.patch > > > Currently, even if the user workflow succeeds and post-processing fails, the > workflow is marked as failed. > IMO, the post-processing should be an optional step. We should wire workflow > to succeed even if the post-processing fails. Especially, after FALCON-1231, > we won't even depend on post-processing for completion notification. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FALCON-1405) Oozie workflow should not fail if post-processing fails
[ https://issues.apache.org/jira/browse/FALCON-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14907698#comment-14907698 ] Ajay Yadava commented on FALCON-1405: - Shouldn't this wait for FALCON-1231? > Oozie workflow should not fail if post-processing fails > --- > > Key: FALCON-1405 > URL: https://issues.apache.org/jira/browse/FALCON-1405 > Project: Falcon > Issue Type: Improvement >Reporter: Pallavi Rao >Assignee: Narayan Periwal > Attachments: FALCON-1405-v0.patch, FALCON-1405-v1.patch > > > Currently, even if the user workflow succeeds and post-processing fails, the > workflow is marked as failed. > IMO, the post-processing should be an optional step. We should wire workflow > to succeed even if the post-processing fails. Especially, after FALCON-1231, > we won't even depend on post-processing for completion notification. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FALCON-1405) Oozie workflow should not fail if post-processing fails
[ https://issues.apache.org/jira/browse/FALCON-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736526#comment-14736526 ] Peeyush Bishnoi commented on FALCON-1405: - Thanks [~nperiwal] for the comment. In Falcon, post-processing action is itself an important action which invokes other Falcon services and with this context I thought it is good to log, if post-processing fails. BTW, I have applied and tested the patch, it looks good. +1. > Oozie workflow should not fail if post-processing fails > --- > > Key: FALCON-1405 > URL: https://issues.apache.org/jira/browse/FALCON-1405 > Project: Falcon > Issue Type: Improvement >Reporter: Pallavi Rao >Assignee: Narayan Periwal > Attachments: FALCON-1405-v0.patch, FALCON-1405-v1.patch > > > Currently, even if the user workflow succeeds and post-processing fails, the > workflow is marked as failed. > IMO, the post-processing should be an optional step. We should wire workflow > to succeed even if the post-processing fails. Especially, after FALCON-1231, > we won't even depend on post-processing for completion notification. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FALCON-1405) Oozie workflow should not fail if post-processing fails
[ https://issues.apache.org/jira/browse/FALCON-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736233#comment-14736233 ] Narayan Periwal commented on FALCON-1405: - [~peeyushb], The post-processing action is no different from user-action. Falcon does not maintain any explicit logs for the user-action, so why differentiate just post-processing action. By design, once Falcon submits the coord, users expect all logs to go to Oozie or Hadoop. Also, if the users are interested in getting the logs for post-processing, there is a falcon log api which the user can query to get access to the logs. > Oozie workflow should not fail if post-processing fails > --- > > Key: FALCON-1405 > URL: https://issues.apache.org/jira/browse/FALCON-1405 > Project: Falcon > Issue Type: Improvement >Reporter: Pallavi Rao >Assignee: Narayan Periwal > Attachments: FALCON-1405-v0.patch, FALCON-1405-v1.patch > > > Currently, even if the user workflow succeeds and post-processing fails, the > workflow is marked as failed. > IMO, the post-processing should be an optional step. We should wire workflow > to succeed even if the post-processing fails. Especially, after FALCON-1231, > we won't even depend on post-processing for completion notification. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FALCON-1405) Oozie workflow should not fail if post-processing fails
[ https://issues.apache.org/jira/browse/FALCON-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730391#comment-14730391 ] Narayan Periwal commented on FALCON-1405: - [~pallavi.rao], Thanks for pointing out the mistake. I have updated the patch. [~peeyushb], The reason for failure of post-processing will be there in the regular hadoop logs or oozie log. So, there is no need to explicitly log for the failure of post-processing in the falcon code. > Oozie workflow should not fail if post-processing fails > --- > > Key: FALCON-1405 > URL: https://issues.apache.org/jira/browse/FALCON-1405 > Project: Falcon > Issue Type: Improvement >Reporter: Pallavi Rao >Assignee: Narayan Periwal > Attachments: FALCON-1405-v0.patch, FALCON-1405-v1.patch > > > Currently, even if the user workflow succeeds and post-processing fails, the > workflow is marked as failed. > IMO, the post-processing should be an optional step. We should wire workflow > to succeed even if the post-processing fails. Especially, after FALCON-1231, > we won't even depend on post-processing for completion notification. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FALCON-1405) Oozie workflow should not fail if post-processing fails
[ https://issues.apache.org/jira/browse/FALCON-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730533#comment-14730533 ] Peeyush Bishnoi commented on FALCON-1405: - [~nperiwal] Yes I agree with you that failure reason might be available in regular service component logs. But I have a opinion that if reason is logged in falcon.application.log due to which post-processing fails it will be highly useful to the users. This will help specially to the user's who don't know much about Hadoop. Later, for narrow down the issue, respective component regular logs can be checked for further detailed exception for the issue. > Oozie workflow should not fail if post-processing fails > --- > > Key: FALCON-1405 > URL: https://issues.apache.org/jira/browse/FALCON-1405 > Project: Falcon > Issue Type: Improvement >Reporter: Pallavi Rao >Assignee: Narayan Periwal > Attachments: FALCON-1405-v0.patch, FALCON-1405-v1.patch > > > Currently, even if the user workflow succeeds and post-processing fails, the > workflow is marked as failed. > IMO, the post-processing should be an optional step. We should wire workflow > to succeed even if the post-processing fails. Especially, after FALCON-1231, > we won't even depend on post-processing for completion notification. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FALCON-1405) Oozie workflow should not fail if post-processing fails
[ https://issues.apache.org/jira/browse/FALCON-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14728735#comment-14728735 ] Peeyush Bishnoi commented on FALCON-1405: - [~nperiwal] Patch looks simple and good. Is it possible to log as well due to which probable reason post-processing fails. > Oozie workflow should not fail if post-processing fails > --- > > Key: FALCON-1405 > URL: https://issues.apache.org/jira/browse/FALCON-1405 > Project: Falcon > Issue Type: Improvement >Reporter: Pallavi Rao >Assignee: Narayan Periwal > Attachments: FALCON-1405-v0.patch > > > Currently, even if the user workflow succeeds and post-processing fails, the > workflow is marked as failed. > IMO, the post-processing should be an optional step. We should wire workflow > to succeed even if the post-processing fails. Especially, after FALCON-1231, > we won't even depend on post-processing for completion notification. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FALCON-1405) Oozie workflow should not fail if post-processing fails
[ https://issues.apache.org/jira/browse/FALCON-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730333#comment-14730333 ] Pallavi Rao commented on FALCON-1405: - +1 for the patch. Just make sure this goes in after FALCON-1231 > Oozie workflow should not fail if post-processing fails > --- > > Key: FALCON-1405 > URL: https://issues.apache.org/jira/browse/FALCON-1405 > Project: Falcon > Issue Type: Improvement >Reporter: Pallavi Rao >Assignee: Narayan Periwal > Attachments: FALCON-1405-v0.patch > > > Currently, even if the user workflow succeeds and post-processing fails, the > workflow is marked as failed. > IMO, the post-processing should be an optional step. We should wire workflow > to succeed even if the post-processing fails. Especially, after FALCON-1231, > we won't even depend on post-processing for completion notification. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FALCON-1405) Oozie workflow should not fail if post-processing fails
[ https://issues.apache.org/jira/browse/FALCON-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14702629#comment-14702629 ] Pallavi Rao commented on FALCON-1405: - Post-processing is a Java action and can fail due to various reasons, such as, 1. Interim issues with Hadoop/YARN. 2. Post processing also does some log movement. This might fail because of HDFS quota issue. 3. The JMS destination may be temporarily down. If it is a code issue, we can fix. If it is an temporary infra issue, can't do much there. But, the point is, if the user workflow goes through fine and the post-processing alone fails, we should still treat it as SUCCESS, as the user workflow has completed. Oozie workflow should not fail if post-processing fails --- Key: FALCON-1405 URL: https://issues.apache.org/jira/browse/FALCON-1405 Project: Falcon Issue Type: Improvement Reporter: Pallavi Rao Assignee: Pallavi Rao Currently, even if the user workflow succeeds and post-processing fails, the workflow is marked as failed. IMO, the post-processing should be an optional step. We should wire workflow to succeed even if the post-processing fails. Especially, after FALCON-1231, we won't even depend on post-processing for completion notification. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FALCON-1405) Oozie workflow should not fail if post-processing fails
[ https://issues.apache.org/jira/browse/FALCON-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14701437#comment-14701437 ] Peeyush Bishnoi commented on FALCON-1405: - [~pallavi.rao] Can you also please put the scenario in which post-processing fails, as this will help to narrow down the issue more appropriately. Oozie workflow should not fail if post-processing fails --- Key: FALCON-1405 URL: https://issues.apache.org/jira/browse/FALCON-1405 Project: Falcon Issue Type: Improvement Reporter: Pallavi Rao Assignee: Pallavi Rao Currently, even if the user workflow succeeds and post-processing fails, the workflow is marked as failed. IMO, the post-processing should be an optional step. We should wire workflow to succeed even if the post-processing fails. Especially, after FALCON-1231, we won't even depend on post-processing for completion notification. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
