[jira] [Commented] (FALCON-1552) Migration of ProcessInstanceManagerIT to use falcon unit
[ https://issues.apache.org/jira/browse/FALCON-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013150#comment-15013150 ] Pallavi Rao commented on FALCON-1552: - Builds fine. Will commit in a bit. > Migration of ProcessInstanceManagerIT to use falcon unit > - > > Key: FALCON-1552 > URL: https://issues.apache.org/jira/browse/FALCON-1552 > Project: Falcon > Issue Type: Sub-task >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Attachments: FALCON-1552-v0.patch, FALCON-1552-v1.patch, > FALCON-1552-v2.patch, FALCON-1552-v3.patch, FALCON-1552-v4.patch, > FALCON-1552-v5.patch > > > As Integration tests are flaky, we have a plan of migrating some integration > tests using falcon unit. As part of this, we migrate ProcessInstanceManagerIT > using falcon unit in this jira -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FALCON-1552) Migration of ProcessInstanceManagerIT to use falcon unit
[ https://issues.apache.org/jira/browse/FALCON-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013211#comment-15013211 ] Narayan Periwal commented on FALCON-1552: - Thanks [~pallavi.rao] > Migration of ProcessInstanceManagerIT to use falcon unit > - > > Key: FALCON-1552 > URL: https://issues.apache.org/jira/browse/FALCON-1552 > Project: Falcon > Issue Type: Sub-task >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Fix For: trunk > > Attachments: FALCON-1552-v0.patch, FALCON-1552-v1.patch, > FALCON-1552-v2.patch, FALCON-1552-v3.patch, FALCON-1552-v4.patch, > FALCON-1552-v5.patch > > > As Integration tests are flaky, we have a plan of migrating some integration > tests using falcon unit. As part of this, we migrate ProcessInstanceManagerIT > using falcon unit in this jira -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FALCON-1552) Migration of ProcessInstanceManagerIT to use falcon unit
[ https://issues.apache.org/jira/browse/FALCON-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010818#comment-15010818 ] Narayan Periwal commented on FALCON-1552: - [~pallavi.rao], The issue which caused the test to fail is resolved and i have updated the patch. Thanks for the help. > Migration of ProcessInstanceManagerIT to use falcon unit > - > > Key: FALCON-1552 > URL: https://issues.apache.org/jira/browse/FALCON-1552 > Project: Falcon > Issue Type: Sub-task >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Attachments: FALCON-1552-v0.patch, FALCON-1552-v1.patch, > FALCON-1552-v2.patch, FALCON-1552-v3.patch, FALCON-1552-v4.patch, > FALCON-1552-v5.patch > > > As Integration tests are flaky, we have a plan of migrating some integration > tests using falcon unit. As part of this, we migrate ProcessInstanceManagerIT > using falcon unit in this jira -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FALCON-1552) Migration of ProcessInstanceManagerIT to use falcon unit
[
https://issues.apache.org/jira/browse/FALCON-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001804#comment-15001804
]
Pallavi Rao commented on FALCON-1552:
-
[~nperiwal], I still see a failed test which I think is related to your patch:
{code}
testLibExtensions(org.apache.falcon.resource.EntityManagerJerseyIT) Time
elapsed: 0.68 sec <<< FAILURE!
java.io.FileNotFoundException: File
/Users/pallavi.rao/falcon/asf/falcon/webapp/target/tmp-hadoop-pallavi.rao/jail-fs/global/projects/falcon/working/libext/FEED/retention
does not exist
at
org.apache.hadoop.fs.RawLocalFileSystem.listStatus(RawLocalFileSystem.java:371)
at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:1483)
at org.apache.hadoop.fs.FileSystem.listStatus(FileSystem.java:1523)
at
org.apache.hadoop.fs.ChecksumFileSystem.listStatus(ChecksumFileSystem.java:568)
at
org.apache.falcon.hadoop.JailedFileSystem.listStatus(JailedFileSystem.java:114)
at
org.apache.falcon.resource.EntityManagerJerseyIT.assertLibs(EntityManagerJerseyIT.java:97)
at
org.apache.falcon.resource.EntityManagerJerseyIT.testLibExtensions(EntityManagerJerseyIT.java:124)
{code}
> Migration of ProcessInstanceManagerIT to use falcon unit
> -
>
> Key: FALCON-1552
> URL: https://issues.apache.org/jira/browse/FALCON-1552
> Project: Falcon
> Issue Type: Sub-task
>Reporter: Narayan Periwal
>Assignee: Narayan Periwal
> Attachments: FALCON-1552-v0.patch, FALCON-1552-v1.patch,
> FALCON-1552-v2.patch, FALCON-1552-v3.patch, FALCON-1552-v4.patch
>
>
> As Integration tests are flaky, we have a plan of migrating some integration
> tests using falcon unit. As part of this, we migrate ProcessInstanceManagerIT
> using falcon unit in this jira
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FALCON-1552) Migration of ProcessInstanceManagerIT to use falcon unit
[ https://issues.apache.org/jira/browse/FALCON-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14998225#comment-14998225 ] Narayan Periwal commented on FALCON-1552: - [~pallavi.rao], I looked at the patch and found it was not the latest. I am updating the latest patch. I tested that the tests for ProcessInstanceManagerIT are passing now but some of the tests in EntityManagerjerseyIT that are flaky, still fails. > Migration of ProcessInstanceManagerIT to use falcon unit > - > > Key: FALCON-1552 > URL: https://issues.apache.org/jira/browse/FALCON-1552 > Project: Falcon > Issue Type: Sub-task >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Attachments: FALCON-1552-v0.patch, FALCON-1552-v1.patch, > FALCON-1552-v2.patch, FALCON-1552-v3.patch > > > As Integration tests are flaky, we have a plan of migrating some integration > tests using falcon unit. As part of this, we migrate ProcessInstanceManagerIT > using falcon unit in this jira -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FALCON-1552) Migration of ProcessInstanceManagerIT to use falcon unit
[
https://issues.apache.org/jira/browse/FALCON-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996146#comment-14996146
]
Pallavi Rao commented on FALCON-1552:
-
[~nperiwal], I tried applying the latest patch attached and I saw lot of IT
failures.
{code}
Failed tests:
EntityManagerJerseyIT.testDuplicateDeleteCommands:622->testDuplicateCommandsResponse:629
expected:<400> but was:<200>
EntityManagerJerseyIT.testLibExtensions:124->assertLibs:97 » FileNotFound
File...
ProcessInstanceManagerIT.testGetInstanceStatus:112 » NullPointer
ProcessInstanceManagerIT.testGetInstanceStatusPagination:127 » NullPointer
ProcessInstanceManagerIT.testKillInstances:143 » NullPointer
ProcessInstanceManagerIT.testReRunInstances:170 » NullPointer
ProcessInstanceManagerIT.testResumesInstances:220 » NullPointer
ProcessInstanceManagerIT.testSuspendInstances:200 » NullPointer
{code}
Is the patch latest?
> Migration of ProcessInstanceManagerIT to use falcon unit
> -
>
> Key: FALCON-1552
> URL: https://issues.apache.org/jira/browse/FALCON-1552
> Project: Falcon
> Issue Type: Sub-task
>Reporter: Narayan Periwal
>Assignee: Narayan Periwal
> Attachments: FALCON-1552-v0.patch, FALCON-1552-v1.patch,
> FALCON-1552-v2.patch, FALCON-1552-v3.patch
>
>
> As Integration tests are flaky, we have a plan of migrating some integration
> tests using falcon unit. As part of this, we migrate ProcessInstanceManagerIT
> using falcon unit in this jira
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FALCON-1552) Migration of ProcessInstanceManagerIT to use falcon unit
[ https://issues.apache.org/jira/browse/FALCON-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993418#comment-14993418 ] Pallavi Rao commented on FALCON-1552: - +1. Will commit if no further review comments. > Migration of ProcessInstanceManagerIT to use falcon unit > - > > Key: FALCON-1552 > URL: https://issues.apache.org/jira/browse/FALCON-1552 > Project: Falcon > Issue Type: Sub-task >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Attachments: FALCON-1552-v0.patch, FALCON-1552-v1.patch, > FALCON-1552-v2.patch, FALCON-1552-v3.patch > > > As Integration tests are flaky, we have a plan of migrating some integration > tests using falcon unit. As part of this, we migrate ProcessInstanceManagerIT > using falcon unit in this jira -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FALCON-1552) Migration of ProcessInstanceManagerIT to use falcon unit
[ https://issues.apache.org/jira/browse/FALCON-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992129#comment-14992129 ] Ajay Yadava commented on FALCON-1552: - Can you please share the performance numbers as well? > Migration of ProcessInstanceManagerIT to use falcon unit > - > > Key: FALCON-1552 > URL: https://issues.apache.org/jira/browse/FALCON-1552 > Project: Falcon > Issue Type: Sub-task >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Attachments: FALCON-1552-v0.patch, FALCON-1552-v1.patch > > > As Integration tests are flaky, we have a plan of migrating some integration > tests using falcon unit. As part of this, we migrate ProcessInstanceManagerIT > using falcon unit in this jira -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FALCON-1552) Migration of ProcessInstanceManagerIT to use falcon unit
[ https://issues.apache.org/jira/browse/FALCON-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992307#comment-14992307 ] Ajay Yadava commented on FALCON-1552: - Thanks [~nperiwal]. Can you please share the current execution time? I just want to ensure that it is fast as expected. > Migration of ProcessInstanceManagerIT to use falcon unit > - > > Key: FALCON-1552 > URL: https://issues.apache.org/jira/browse/FALCON-1552 > Project: Falcon > Issue Type: Sub-task >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Attachments: FALCON-1552-v0.patch, FALCON-1552-v1.patch, > FALCON-1552-v2.patch > > > As Integration tests are flaky, we have a plan of migrating some integration > tests using falcon unit. As part of this, we migrate ProcessInstanceManagerIT > using falcon unit in this jira -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FALCON-1552) Migration of ProcessInstanceManagerIT to use falcon unit
[ https://issues.apache.org/jira/browse/FALCON-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992356#comment-14992356 ] Narayan Periwal commented on FALCON-1552: - [~ajayydv], Current execution time of ProcessInstanceManager is around 55 seconds. > Migration of ProcessInstanceManagerIT to use falcon unit > - > > Key: FALCON-1552 > URL: https://issues.apache.org/jira/browse/FALCON-1552 > Project: Falcon > Issue Type: Sub-task >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Attachments: FALCON-1552-v0.patch, FALCON-1552-v1.patch, > FALCON-1552-v2.patch > > > As Integration tests are flaky, we have a plan of migrating some integration > tests using falcon unit. As part of this, we migrate ProcessInstanceManagerIT > using falcon unit in this jira -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FALCON-1552) Migration of ProcessInstanceManagerIT to use falcon unit
[ https://issues.apache.org/jira/browse/FALCON-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992130#comment-14992130 ] Ajay Yadava commented on FALCON-1552: - Can you please share the performance numbers as well? > Migration of ProcessInstanceManagerIT to use falcon unit > - > > Key: FALCON-1552 > URL: https://issues.apache.org/jira/browse/FALCON-1552 > Project: Falcon > Issue Type: Sub-task >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Attachments: FALCON-1552-v0.patch, FALCON-1552-v1.patch > > > As Integration tests are flaky, we have a plan of migrating some integration > tests using falcon unit. As part of this, we migrate ProcessInstanceManagerIT > using falcon unit in this jira -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FALCON-1552) Migration of ProcessInstanceManagerIT to use falcon unit
[ https://issues.apache.org/jira/browse/FALCON-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992244#comment-14992244 ] Narayan Periwal commented on FALCON-1552: - Addressed the minor checkstyle issues. > Migration of ProcessInstanceManagerIT to use falcon unit > - > > Key: FALCON-1552 > URL: https://issues.apache.org/jira/browse/FALCON-1552 > Project: Falcon > Issue Type: Sub-task >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Attachments: FALCON-1552-v0.patch, FALCON-1552-v1.patch, > FALCON-1552-v2.patch > > > As Integration tests are flaky, we have a plan of migrating some integration > tests using falcon unit. As part of this, we migrate ProcessInstanceManagerIT > using falcon unit in this jira -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FALCON-1552) Migration of ProcessInstanceManagerIT to use falcon unit
[ https://issues.apache.org/jira/browse/FALCON-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14992243#comment-14992243 ] Narayan Periwal commented on FALCON-1552: - [~ajayydv], The processInstanceManagerIT was disabled initially, and the testcase fails even when I ran, so we cannot compare this. I will add the time differences once I migrate other integration tests. Even while the wait time here of the sleep job is 30 or 40 seconds, still this will not affect the time taken by the tests as I dont wait for the process to succeed every time. This time is just to ensure that the instances remain in the running state so that we can check the suspended and such functionality. > Migration of ProcessInstanceManagerIT to use falcon unit > - > > Key: FALCON-1552 > URL: https://issues.apache.org/jira/browse/FALCON-1552 > Project: Falcon > Issue Type: Sub-task >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Attachments: FALCON-1552-v0.patch, FALCON-1552-v1.patch, > FALCON-1552-v2.patch > > > As Integration tests are flaky, we have a plan of migrating some integration > tests using falcon unit. As part of this, we migrate ProcessInstanceManagerIT > using falcon unit in this jira -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FALCON-1552) Migration of ProcessInstanceManagerIT to use falcon unit
[ https://issues.apache.org/jira/browse/FALCON-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14991833#comment-14991833 ] Narayan Periwal commented on FALCON-1552: - [~pallavi.rao] and [~pavan kumar], addressed your review comments. > Migration of ProcessInstanceManagerIT to use falcon unit > - > > Key: FALCON-1552 > URL: https://issues.apache.org/jira/browse/FALCON-1552 > Project: Falcon > Issue Type: Sub-task >Reporter: Narayan Periwal >Assignee: Narayan Periwal > Attachments: FALCON-1552-v0.patch, FALCON-1552-v1.patch > > > As Integration tests are flaky, we have a plan of migrating some integration > tests using falcon unit. As part of this, we migrate ProcessInstanceManagerIT > using falcon unit in this jira -- This message was sent by Atlassian JIRA (v6.3.4#6332)
