[jira] [Commented] (FELIX-5339) Enhance the diagnostics API to retrieve missing custom dependecies

[Pierre De Rop (JIRA)]

[ 
https://issues.apache.org/jira/browse/FELIX-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15467802#comment-15467802
 ] 

Pierre De Rop commented on FELIX-5339:
--

I just committed your patch in revision 1759454 ...

(please change this issue to resolve state if you are ok).

thank you !

> Enhance the diagnostics API to retrieve missing custom dependecies
> --
>
> Key: FELIX-5339
> URL: https://issues.apache.org/jira/browse/FELIX-5339
> Project: Felix
>  Issue Type: New Feature
>  Components: Dependency Manager, Dependency Manager Shell
>Reporter: Raluca Grigoras
>Assignee: Pierre De Rop
>Priority: Minor
> Attachments: FELIX-5339.patch, FELIX-5339.patch
>
>
> The 'dm wtf' command only displays the missing 'out of the box' dependencies 
> (service, resource, bundle, configuration). There are cases however, when the 
> missing dependency is a custom dependency. In this case, the missing 
> dependency is not displayed by the command, even if there are unregistered 
> components due to this. It may be useful to enhance the diagnostics API to 
> retrieve all missing custom dependencies and to use this in the 'dm wtf' 
> command.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: September Board Report

[Carsten Ziegeler]

Thanks,

I've submitted the report

Carsten

 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Commented] (FELIX-5339) Enhance the diagnostics API to retrieve missing custom dependecies

[Pierre De Rop (JIRA)]

[ 
https://issues.apache.org/jira/browse/FELIX-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15467444#comment-15467444
 ] 

Pierre De Rop commented on FELIX-5339:
--

Thanks, I will look into it soon.

> Enhance the diagnostics API to retrieve missing custom dependecies
> --
>
> Key: FELIX-5339
> URL: https://issues.apache.org/jira/browse/FELIX-5339
> Project: Felix
>  Issue Type: New Feature
>  Components: Dependency Manager, Dependency Manager Shell
>Reporter: Raluca Grigoras
>Assignee: Pierre De Rop
>Priority: Minor
> Attachments: FELIX-5339.patch, FELIX-5339.patch
>
>
> The 'dm wtf' command only displays the missing 'out of the box' dependencies 
> (service, resource, bundle, configuration). There are cases however, when the 
> missing dependency is a custom dependency. In this case, the missing 
> dependency is not displayed by the command, even if there are unregistered 
> components due to this. It may be useful to enhance the diagnostics API to 
> retrieve all missing custom dependencies and to use this in the 'dm wtf' 
> command.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (FELIX-5339) Enhance the diagnostics API to retrieve missing custom dependecies

[Raluca Grigoras (JIRA)]

 [ 
https://issues.apache.org/jira/browse/FELIX-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Raluca Grigoras updated FELIX-5339:
---
Attachment: FELIX-5339.patch

Patch created by git format-patch, relative to the dependencymanager folder 
from the github mirror of the felix repository.

> Enhance the diagnostics API to retrieve missing custom dependecies
> --
>
> Key: FELIX-5339
> URL: https://issues.apache.org/jira/browse/FELIX-5339
> Project: Felix
>  Issue Type: New Feature
>  Components: Dependency Manager, Dependency Manager Shell
>Reporter: Raluca Grigoras
>Assignee: Pierre De Rop
>Priority: Minor
> Attachments: FELIX-5339.patch, FELIX-5339.patch
>
>
> The 'dm wtf' command only displays the missing 'out of the box' dependencies 
> (service, resource, bundle, configuration). There are cases however, when the 
> missing dependency is a custom dependency. In this case, the missing 
> dependency is not displayed by the command, even if there are unregistered 
> components due to this. It may be useful to enhance the diagnostics API to 
> retrieve all missing custom dependencies and to use this in the 'dm wtf' 
> command.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FELIX-5332) Serializer

[David Leangen (JIRA)]

[ 
https://issues.apache.org/jira/browse/FELIX-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15467168#comment-15467168
 ] 

David Leangen commented on FELIX-5332:
--

[~bosschaert], in your example above, you suggest:

{code}
mySpecialCodec.decode(sometextfile).withSchema(mySchema).to(MyDTO.class)
{code}

Do you think we should make Schema a public interface, so mySchema is a Schema 
object? Or should Schema be "hidden" in the implementation, so mySchema is the 
name of the Schema, and the Schema object is private to the implementation?

If Schema is public, we would need to update the API to include both the Schema 
and Node interfaces. Is that ok? I think that would be clearer, and therefore 
preferable, but I don't know how much flexibility you have with regards to API 
changes.

BTW, I believe that the above would actually be:

{code}
mySpecialCodec.decode(sometextfile).to(mySchema)
{code}

or maybe

{code}
mySpecialCodec.decode(sometextfile).with(mySchema)
{code}

The reason is because including both the Schema *and* the target DTO is 
redundant, and could cause problems if there is a conflict between the two 
(i.e. the target DTO does not match the schema).

> Serializer
> --
>
> Key: FELIX-5332
> URL: https://issues.apache.org/jira/browse/FELIX-5332
> Project: Felix
>  Issue Type: New Feature
>  Components: Converter
>Reporter: David Leangen
> Attachments: diff-serializer.txt
>
>
> Test case and a bit of code to show how a Serializer could work.
> To work as a Serializer, the type information needs to be embedded into the 
> output.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FELIX-5332) Serializer

[David Bosschaert (JIRA)]

[ 
https://issues.apache.org/jira/browse/FELIX-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15466950#comment-15466950
 ] 

David Bosschaert commented on FELIX-5332:
-

[~dleangen], yes, ideally it would be a patch on the existing codebase :)

> Serializer
> --
>
> Key: FELIX-5332
> URL: https://issues.apache.org/jira/browse/FELIX-5332
> Project: Felix
>  Issue Type: New Feature
>  Components: Converter
>Reporter: David Leangen
> Attachments: diff-serializer.txt
>
>
> Test case and a bit of code to show how a Serializer could work.
> To work as a Serializer, the type information needs to be embedded into the 
> output.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: September Board Report

[Jean-Baptiste Onofré]

+1

LGTM

Regards
JB



On Sep 6, 2016, 10:04, at 10:04, Jan Willem Janssen 
 wrote:
>Hi Carsten,
>
>> On 05 Sep 2016, at 16:49, Carsten Ziegeler 
>wrote:
>> 
>> Hi,
>> 
>> I've prepared the September Board Report at
>> 
>>
>https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=64553383
>> 
>> Please review, comment, adjust
>
>LGTM, +1.
>
>Thanks,
>
>--
>Met vriendelijke groeten | Kind regards
>
>Jan Willem Janssen | Software Architect
>+31 631 765 814
>
>
>My world is something with Amdatu and Apache
>
>Luminis Technologies
>Churchillplein 1
>7314 BZ  Apeldoorn
>+31 88 586 46 00
>
>https://www.luminis.eu
>
>KvK (CoC) 09 16 28 93
>BTW (VAT) NL8170.94.441.B.01

Re: September Board Report

[Jan Willem Janssen]

Hi Carsten,

> On 05 Sep 2016, at 16:49, Carsten Ziegeler  wrote:
> 
> Hi,
> 
> I've prepared the September Board Report at
> 
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=64553383
> 
> Please review, comment, adjust

LGTM, +1.

Thanks,

--
Met vriendelijke groeten | Kind regards

Jan Willem Janssen | Software Architect
+31 631 765 814


My world is something with Amdatu and Apache

Luminis Technologies
Churchillplein 1
7314 BZ  Apeldoorn
+31 88 586 46 00

https://www.luminis.eu

KvK (CoC) 09 16 28 93
BTW (VAT) NL8170.94.441.B.01



signature.asc
Description: Message signed with OpenPGP using GPGMail