[GitHub] [felix-atomos] tjwatson opened a new pull request #18: Add Android example and restructure readmes
tjwatson opened a new pull request #18: Add Android example and restructure readmes URL: https://github.com/apache/felix-atomos/pull/18 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [felix-atomos] tjwatson commented on a change in pull request #15: more flexible substrate builder
tjwatson commented on a change in pull request #15: more flexible substrate builder URL: https://github.com/apache/felix-atomos/pull/15#discussion_r400358972 ## File path: atomos.maven/src/main/java/org/apache/felix/atomos/maven/AtomosIndexMojo.java ## @@ -63,7 +63,7 @@ public void execute() throws MojoExecutionException AtomosIndexMojo::isJarFile).map(a -> a.getFile().toPath()).collect( Collectors.toList()); -SubstrateUtil.indexContent(paths, outputDirectory.toPath()); +//SubstrateUtil.indexContent(paths, outputDirectory.toPath()); Review comment: I assume this still needs to be reworked to the refactored stuff. I have on my list of things to do is add sniff integration tests to make sure the examples still work. The atomos.examples.index resulting JAR no longer works because the atomos index is no longer written. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [felix-atomos] tjwatson commented on a change in pull request #15: more flexible substrate builder
tjwatson commented on a change in pull request #15: more flexible substrate
builder
URL: https://github.com/apache/felix-atomos/pull/15#discussion_r400366271
##
File path:
atomos.maven/src/main/java/org/apache/felix/atomos/maven/NativeImageMojo.java
##
@@ -109,78 +86,16 @@ public void execute() throws MojoExecutionException
try
{
Files.createDirectories(outputDirectory.toPath());
-
Config config = new Config();
-
config.additionalInitializeAtBuildTime =
additionalInitializeAtBuildTime;
-if (imageName == null || imageName.isEmpty())
Review comment:
I probably don't need to review this just yet. It seems the current state
is that the Mojos are not hooked into the utilities yet. The resulting build
of atomos.examples.substrate.maven.equinox doesn't produce a native-image yet.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [felix-atomos] tjwatson commented on a change in pull request #15: more flexible substrate builder
tjwatson commented on a change in pull request #15: more flexible substrate builder URL: https://github.com/apache/felix-atomos/pull/15#discussion_r400358352 ## File path: atomos.maven/pom.xml ## @@ -9,16 +9,12 @@ org.apache.felix.atomos.maven Review comment: Shouldn't the artifact ID also be atomos-maven-plugin This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FELIX-6242) Conversion of boolean to Long results in Integer
[ https://issues.apache.org/jira/browse/FELIX-6242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070803#comment-17070803 ] A. J. David Bosschaert commented on FELIX-6242: --- Thanks for the details, [~cziegeler] - I plan to look into this soon. > Conversion of boolean to Long results in Integer > > > Key: FELIX-6242 > URL: https://issues.apache.org/jira/browse/FELIX-6242 > Project: Felix > Issue Type: Bug > Components: Converter >Affects Versions: converter-1.0.12 >Reporter: Carsten Ziegeler >Assignee: A. J. David Bosschaert >Priority: Major > Fix For: converter-1.0.14 > > > When converting a boolean to a Long, an Integer is returned. the following > test fails: > assertEquals(Long.valueOf(1), > converter.convert(Boolean.TRUE).to(Long.class)); -- This message was sent by Atlassian Jira (v8.3.4#803005)
