Re: [VOTE] Release Apache Felix org.apache.felix.configadmin.plugin.interpolation 1.1.2

2021-02-17 Thread Jean-Baptiste Onofre
+1 (binding)

Regards
JB

> Le 17 févr. 2021 à 17:03, dav...@apache.org a écrit :
> 
> Hi all,
> 
> I would like to call a vote on
> the org.apache.felix.configadmin.plugin.interpolation 1.1.2 release
> 
> We fixed one issue:
> https://issues.apache.org/jira/browse/FELIX-6384
> 
> Staging repositories:
> https://repository.apache.org/content/repositories/orgapachefelix-1369
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> https://github.com/apache/felix-dev/blob/master/check_staged_release.sh
> 
> Usage:
> sh check_staged_release.sh 1369 /tmp/felix-staging
> 
> Please vote to approve this release:
> 
> [ ] +1 Approve the release
> [ ] -1 Veto the release (please provide specific comments)
> 
> This vote remains open for at least 72h
> 
> Best regards,
> 
> David Bosschaert



Re: [VOTE] Release Felix SCR version 2.1.26

2021-02-17 Thread JB Onofré
+1 (binding)

Regards 
JB

> Le 17 févr. 2021 à 21:40, Raymond Augé  a 
> écrit :
> 
> +1
> 
> - Ray
> 
>> On Wed, Feb 17, 2021 at 3:27 PM Thomas Watson  wrote:
>> 
>> Hi all,
>> 
>> I would like to call a vote on
>> the org.apache.felix.scr 2.1.26 release
>> 
>> We fixed the following issues:
>> https://issues.apache.org/jira/browse/FELIX-6352
>> https://issues.apache.org/jira/browse/FELIX-6361
>> https://issues.apache.org/jira/browse/FELIX-6353
>> https://issues.apache.org/jira/browse/FELIX-6351
>> https://issues.apache.org/jira/browse/FELIX-6349
>> 
>> Staging repositories:
>> https://repository.apache.org/content/repositories/orgapachefelix-1370
>> 
>> You can use this UNIX script to download the release and verify the
>> signatures:
>> https://github.com/apache/felix-dev/blob/master/check_staged_release.sh
>> 
>> Usage:
>> sh check_staged_release.sh 1370 /tmp/felix-staging
>> 
>> Please vote to approve this release:
>> 
>> [ ] +1 Approve the release
>> [ ] -1 Veto the release (please provide specific comments)
>> 
>> This vote remains open for at least 72h
>> 
>> Thanks
>> 
>> Tom
>> 
> 
> 
> -- 
> *Raymond Augé* (@rotty3000)
> Senior Software Architect *Liferay, Inc.* (@Liferay)
> OSGi Fellow



Re: [VOTE] Release Felix SCR version 2.1.26

2021-02-17 Thread Raymond Augé
+1

- Ray

On Wed, Feb 17, 2021 at 3:27 PM Thomas Watson  wrote:

> Hi all,
>
> I would like to call a vote on
> the org.apache.felix.scr 2.1.26 release
>
> We fixed the following issues:
> https://issues.apache.org/jira/browse/FELIX-6352
> https://issues.apache.org/jira/browse/FELIX-6361
> https://issues.apache.org/jira/browse/FELIX-6353
> https://issues.apache.org/jira/browse/FELIX-6351
> https://issues.apache.org/jira/browse/FELIX-6349
>
> Staging repositories:
> https://repository.apache.org/content/repositories/orgapachefelix-1370
>
> You can use this UNIX script to download the release and verify the
> signatures:
> https://github.com/apache/felix-dev/blob/master/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 1370 /tmp/felix-staging
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] -1 Veto the release (please provide specific comments)
>
> This vote remains open for at least 72h
>
> Thanks
>
> Tom
>


-- 
*Raymond Augé* (@rotty3000)
Senior Software Architect *Liferay, Inc.* (@Liferay)
OSGi Fellow


[VOTE] Release Felix SCR version 2.1.26

2021-02-17 Thread Thomas Watson
Hi all,

I would like to call a vote on
the org.apache.felix.scr 2.1.26 release

We fixed the following issues:
https://issues.apache.org/jira/browse/FELIX-6352
https://issues.apache.org/jira/browse/FELIX-6361
https://issues.apache.org/jira/browse/FELIX-6353
https://issues.apache.org/jira/browse/FELIX-6351
https://issues.apache.org/jira/browse/FELIX-6349

Staging repositories:
https://repository.apache.org/content/repositories/orgapachefelix-1370

You can use this UNIX script to download the release and verify the
signatures:
https://github.com/apache/felix-dev/blob/master/check_staged_release.sh

Usage:
sh check_staged_release.sh 1370 /tmp/felix-staging

Please vote to approve this release:

[ ] +1 Approve the release
[ ] -1 Veto the release (please provide specific comments)

This vote remains open for at least 72h

Thanks

Tom


Re: [VOTE] Release Apache Felix org.apache.felix.configadmin.plugin.interpolation 1.1.2

2021-02-17 Thread Raymond Augé
+1

- Ray

On Wed, Feb 17, 2021 at 12:23 PM Pierre De Rop 
wrote:

> Hi,
>
> +1
>
> thanks & regards
> /Pierre
>
> On Wed, Feb 17, 2021 at 5:14 PM Thomas Watson  wrote:
>
> > +1
> >
> > Tom
> >
> > On Wed, Feb 17, 2021 at 10:03 AM  wrote:
> >
> > > Hi all,
> > >
> > > I would like to call a vote on
> > > the org.apache.felix.configadmin.plugin.interpolation 1.1.2 release
> > >
> > > We fixed one issue:
> > > https://issues.apache.org/jira/browse/FELIX-6384
> > >
> > > Staging repositories:
> > > https://repository.apache.org/content/repositories/orgapachefelix-1369
> > >
> > > You can use this UNIX script to download the release and verify the
> > > signatures:
> > >
> https://github.com/apache/felix-dev/blob/master/check_staged_release.sh
> > >
> > > Usage:
> > > sh check_staged_release.sh 1369 /tmp/felix-staging
> > >
> > > Please vote to approve this release:
> > >
> > > [ ] +1 Approve the release
> > > [ ] -1 Veto the release (please provide specific comments)
> > >
> > > This vote remains open for at least 72h
> > >
> > > Best regards,
> > >
> > > David Bosschaert
> > >
> >
>


-- 
*Raymond Augé* (@rotty3000)
Senior Software Architect *Liferay, Inc.* (@Liferay)
OSGi Fellow


Re: [VOTE] Release Apache Felix org.apache.felix.configadmin.plugin.interpolation 1.1.2

2021-02-17 Thread Pierre De Rop
Hi,

+1

thanks & regards
/Pierre

On Wed, Feb 17, 2021 at 5:14 PM Thomas Watson  wrote:

> +1
>
> Tom
>
> On Wed, Feb 17, 2021 at 10:03 AM  wrote:
>
> > Hi all,
> >
> > I would like to call a vote on
> > the org.apache.felix.configadmin.plugin.interpolation 1.1.2 release
> >
> > We fixed one issue:
> > https://issues.apache.org/jira/browse/FELIX-6384
> >
> > Staging repositories:
> > https://repository.apache.org/content/repositories/orgapachefelix-1369
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> > https://github.com/apache/felix-dev/blob/master/check_staged_release.sh
> >
> > Usage:
> > sh check_staged_release.sh 1369 /tmp/felix-staging
> >
> > Please vote to approve this release:
> >
> > [ ] +1 Approve the release
> > [ ] -1 Veto the release (please provide specific comments)
> >
> > This vote remains open for at least 72h
> >
> > Best regards,
> >
> > David Bosschaert
> >
>


[jira] [Closed] (FELIX-6315) Factory components are eagerly deactivated

2021-02-17 Thread Tom Watson (Jira)


 [ 
https://issues.apache.org/jira/browse/FELIX-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tom Watson closed FELIX-6315.
-

> Factory components are eagerly deactivated
> --
>
> Key: FELIX-6315
> URL: https://issues.apache.org/jira/browse/FELIX-6315
> Project: Felix
>  Issue Type: Bug
>  Components: Declarative Services (SCR)
>Affects Versions: scr-2.1.20
>Reporter: Robert Varga
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: scr-2.1.24
>
>
> When a factory component with a services is is created via a call to 
> ComponentFactory.newInstance(), it is treated as a delayed component where 
> service reference counting is concerned. Specifically, if the resulting 
> service undergoes a getService()/ungetService(), the component configuration 
> is deactivated because the reference count reaches zero:
> {noformat}
> 2020-07-31T17:48:18,135 | INFO  | Blueprint Extender: 3 | 
> AbstractAdaptedService   | 145 - 
> org.opendaylight.mdsal.binding-dom-adapter - 6.0.5.SNAPSHOT | Binding/DOM 
> adapter for DataBroker deactivated (0)
> java.lang.Throwable: null
> at 
> org.opendaylight.mdsal.binding.dom.adapter.osgi.AbstractAdaptedService.stop(AbstractAdaptedService.java:40)
>  [bundleFile:?]
> at 
> org.opendaylight.mdsal.binding.dom.adapter.osgi.OSGiDataBroker.deactivate(OSGiDataBroker.java:76)
>  [bundleFile:?]
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native 
> Method) ~[?:?]
> at 
> jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  ~[?:?]
> at 
> jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  ~[?:?]
> at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?]
> at 
> org.apache.felix.scr.impl.inject.methods.BaseMethod.invokeMethod(BaseMethod.java:242)
>  [bundleFile:?]
> at 
> org.apache.felix.scr.impl.inject.methods.BaseMethod.access$500(BaseMethod.java:41)
>  [bundleFile:?]
> at 
> org.apache.felix.scr.impl.inject.methods.BaseMethod$Resolved.invoke(BaseMethod.java:678)
>  [bundleFile:?]
> at 
> org.apache.felix.scr.impl.inject.methods.BaseMethod.invoke(BaseMethod.java:524)
>  [bundleFile:?]
> at 
> org.apache.felix.scr.impl.inject.methods.ActivateMethod.invoke(ActivateMethod.java:318)
>  [bundleFile:?]
> at 
> org.apache.felix.scr.impl.inject.methods.ActivateMethod.invoke(ActivateMethod.java:308)
>  [bundleFile:?]
> at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.disposeImplementationObject(SingleComponentManager.java:409)
>  [bundleFile:?]
> at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.deleteComponent(SingleComponentManager.java:164)
>  [bundleFile:?]
> at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.ungetService(SingleComponentManager.java:1022)
>  [bundleFile:?]
> at 
> org.eclipse.osgi.internal.serviceregistry.ServiceFactoryUse$2.run(ServiceFactoryUse.java:260)
>  [org.eclipse.osgi-3.12.100.jar:?]
> at 
> org.eclipse.osgi.internal.serviceregistry.ServiceFactoryUse$2.run(ServiceFactoryUse.java:1)
>  [org.eclipse.osgi-3.12.100.jar:?]
> at java.security.AccessController.doPrivileged(Native Method) [?:?]
> at 
> org.eclipse.osgi.internal.serviceregistry.ServiceFactoryUse.factoryUngetService(ServiceFactoryUse.java:258)
>  [org.eclipse.osgi-3.12.100.jar:?]
> at 
> org.eclipse.osgi.internal.serviceregistry.ServiceFactoryUse.ungetService(ServiceFactoryUse.java:160)
>  [org.eclipse.osgi-3.12.100.jar:?]
> at 
> org.eclipse.osgi.internal.serviceregistry.ServiceConsumer$2.ungetService(ServiceConsumer.java:50)
>  [org.eclipse.osgi-3.12.100.jar:?]
> at 
> org.eclipse.osgi.internal.serviceregistry.ServiceRegistrationImpl.ungetService(ServiceRegistrationImpl.java:593)
>  [org.eclipse.osgi-3.12.100.jar:?]
> at 
> org.eclipse.osgi.internal.serviceregistry.ServiceRegistry.ungetService(ServiceRegistry.java:540)
>  [org.eclipse.osgi-3.12.100.jar:?]
> at 
> org.eclipse.osgi.internal.framework.BundleContextImpl.ungetService(BundleContextImpl.java:666)
>  [org.eclipse.osgi-3.12.100.jar:?]
> at 
> org.opendaylight.controller.blueprint.ext.StaticServiceReferenceRecipe.doStop(StaticServiceReferenceRecipe.java:90)
>  [bundleFile:?]
> at 
> org.apache.aries.blueprint.container.AbstractServiceReferenceRecipe.stop(AbstractServiceReferenceRecipe.java:156)
>  [bundleFile:1.10.2]
> at 
> org.opendaylight.controller.blueprint.ext.AbstractDependentComponentFactoryMetadata.stopServiceRecipes(AbstractDependentComponentFactoryMetadata.java:211)
>  [bundleFile:?]
> at 
> 

[jira] [Closed] (FELIX-6325) OSGi log package is mandatory but imported as optional

2021-02-17 Thread Tom Watson (Jira)


 [ 
https://issues.apache.org/jira/browse/FELIX-6325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tom Watson closed FELIX-6325.
-

> OSGi log package is mandatory but imported as optional
> --
>
> Key: FELIX-6325
> URL: https://issues.apache.org/jira/browse/FELIX-6325
> Project: Felix
>  Issue Type: Bug
>  Components: Declarative Services (SCR)
>Affects Versions: scr-2.1.22
>Reporter: Tom Watson
>Assignee: Tom Watson
>Priority: Major
> Fix For: scr-2.1.24
>
>
> If the required log package is not available when SCR is resolved the 
> following exception happens on startup of SCR:
> org.osgi.framework.BundleException: Activator start error in bundle 
> org.apache.felix.scr [48].
> at 
> org.apache.felix.framework.Felix.activateBundle(Felix.java:2290)
> at 
> org.apache.felix.framework.Felix.startBundle(Felix.java:2146)
> at 
> org.apache.felix.framework.BundleImpl.start(BundleImpl.java:998)
> at 
> org.apache.felix.framework.BundleImpl.start(BundleImpl.java:984)
> at 
> org.apache.karaf.features.internal.service.BundleInstallSupportImpl.startBundle(BundleInstallSupportImpl.java:165)
> at 
> org.apache.karaf.features.internal.service.FeaturesServiceImpl.startBundle(FeaturesServiceImpl.java:1153)
> at 
> org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:1036)
> ... 6 more
> Caused by: java.lang.NoClassDefFoundError: 
> org/osgi/service/log/LoggerFactory
> at 
> org.apache.felix.scr.impl.logger.LogManager.(LogManager.java:59)
> at 
> org.apache.felix.scr.impl.logger.ScrLogManager.(ScrLogManager.java:62)
> at 
> org.apache.felix.scr.impl.logger.ScrLogManager.scr(ScrLogManager.java:58)
> at 
> org.apache.felix.scr.impl.Activator.start(Activator.java:119)
> at 
> org.apache.felix.framework.util.SecureAction.startActivator(SecureAction.java:697)
> at 
> org.apache.felix.framework.Felix.activateBundle(Felix.java:2240)
> ... 12 more
> Caused by: java.lang.ClassNotFoundException: 
> org.osgi.service.log.LoggerFactory not found by org.apache.felix.scr [48]
> at 
> org.apache.felix.framework.BundleWiringImpl.findClassOrResourceByDelegation(BundleWiringImpl.java:1639)
> at 
> org.apache.felix.framework.BundleWiringImpl.access$200(BundleWiringImpl.java:80)
> at 
> org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.loadClass(BundleWiringImpl.java:2053)
> at 
> java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)
> ... 18 more



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (FELIX-6327) NoSuchElementException can occur with SingleDynamicCustomizer when services are removed

2021-02-17 Thread Tom Watson (Jira)


 [ 
https://issues.apache.org/jira/browse/FELIX-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tom Watson closed FELIX-6327.
-

> NoSuchElementException can occur with SingleDynamicCustomizer when services 
> are removed
> ---
>
> Key: FELIX-6327
> URL: https://issues.apache.org/jira/browse/FELIX-6327
> Project: Felix
>  Issue Type: Bug
>  Components: Declarative Services (SCR)
>Affects Versions: scr-2.1.22
>Reporter: Tom Watson
>Assignee: Tom Watson
>Priority: Critical
> Fix For: scr-2.1.24
>
>
> The fix for issue FELIX-6317 introduced this issue.  The following exception 
> can occur when the bound reference is removed and an attempt is made to bind 
> to the next best reference.  If the reference is bound but then we detect 
> that that reference has been removed then we check again for the next best 
> service.  If there are none then the following exception is thrown:
> {quote}
> java.util.NoSuchElementException
>   at 
> java.base/java.util.TreeMap$PrivateEntryIterator.nextEntry(TreeMap.java:1206)
>   at java.base/java.util.TreeMap$ValueIterator.next(TreeMap.java:1253)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager$SingleDynamicCustomizer.tryinvokeBind(DependencyManager.java:939)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager$SingleDynamicCustomizer.removedService(DependencyManager.java:1036)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager$SingleDynamicCustomizer.removedService(DependencyManager.java:805)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerRemoved(ServiceTracker.java:1226)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerRemoved(ServiceTracker.java:1121)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.untrack(ServiceTracker.java:981)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:1160)
>   at 
> org.apache.felix.scr.impl.BundleComponentActivator$ListenerInfo.serviceChanged(BundleComponentActivator.java:114)
> {quote}
> There are some other issues with the current code where conditions could 
> leave a DependencyManager in a state where it always thinks there is a thead 
> working on tryinvokeBind.  Additional safeguards are needed to ensure the 
> state of the DependencyManager is restored on exit of tryinvokeBind.
> I'm marking as critical because this is a regression and likely worse than 
> the original symptom of FELIX-6317 albeit probably much less likely to occur.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: [VOTE] Release Apache Felix org.apache.felix.configadmin.plugin.interpolation 1.1.2

2021-02-17 Thread Thomas Watson
+1

Tom

On Wed, Feb 17, 2021 at 10:03 AM  wrote:

> Hi all,
>
> I would like to call a vote on
> the org.apache.felix.configadmin.plugin.interpolation 1.1.2 release
>
> We fixed one issue:
> https://issues.apache.org/jira/browse/FELIX-6384
>
> Staging repositories:
> https://repository.apache.org/content/repositories/orgapachefelix-1369
>
> You can use this UNIX script to download the release and verify the
> signatures:
> https://github.com/apache/felix-dev/blob/master/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 1369 /tmp/felix-staging
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] -1 Veto the release (please provide specific comments)
>
> This vote remains open for at least 72h
>
> Best regards,
>
> David Bosschaert
>


Re: [VOTE] Release Apache Felix org.apache.felix.configadmin.plugin.interpolation 1.1.2

2021-02-17 Thread Carsten Ziegeler

+1

Carsten

Am 17.02.2021 um 17:03 schrieb dav...@apache.org:

Hi all,

I would like to call a vote on
the org.apache.felix.configadmin.plugin.interpolation 1.1.2 release

We fixed one issue:
https://issues.apache.org/jira/browse/FELIX-6384

Staging repositories:
https://repository.apache.org/content/repositories/orgapachefelix-1369

You can use this UNIX script to download the release and verify the
signatures:
https://github.com/apache/felix-dev/blob/master/check_staged_release.sh

Usage:
sh check_staged_release.sh 1369 /tmp/felix-staging

Please vote to approve this release:

[ ] +1 Approve the release
[ ] -1 Veto the release (please provide specific comments)

This vote remains open for at least 72h

Best regards,

David Bosschaert



--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


[VOTE] Release Apache Felix org.apache.felix.configadmin.plugin.interpolation 1.1.2

2021-02-17 Thread davidb
Hi all,

I would like to call a vote on
the org.apache.felix.configadmin.plugin.interpolation 1.1.2 release

We fixed one issue:
https://issues.apache.org/jira/browse/FELIX-6384

Staging repositories:
https://repository.apache.org/content/repositories/orgapachefelix-1369

You can use this UNIX script to download the release and verify the
signatures:
https://github.com/apache/felix-dev/blob/master/check_staged_release.sh

Usage:
sh check_staged_release.sh 1369 /tmp/felix-staging

Please vote to approve this release:

[ ] +1 Approve the release
[ ] -1 Veto the release (please provide specific comments)

This vote remains open for at least 72h

Best regards,

David Bosschaert


Planning to release Felix SCR

2021-02-17 Thread Thomas Watson
Hi,

I plan to start the process for the next release of Felix SCR at version
2.1.26

The following issues have been fixed since the last release 2.1.24

FELIX-6361
FELIX-6353
FELIX-6351
FELIX-6349

Let me know if you have any questions/concerns while I start the release.

Thanks

Tom


[jira] [Updated] (FELIX-6273) Improve behaviour when delimiter is set but the type is not

2021-02-17 Thread A. J. David Bosschaert (Jira)


 [ 
https://issues.apache.org/jira/browse/FELIX-6273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert updated FELIX-6273:
--
Fix Version/s: (was: configadmin-interpolation-plugin-1.1.2)
   configadmin-interpolation-plugin-1.1.4

> Improve behaviour when delimiter is set but the type is not
> ---
>
> Key: FELIX-6273
> URL: https://issues.apache.org/jira/browse/FELIX-6273
> Project: Felix
>  Issue Type: Improvement
>  Components: Configuration Admin
>Affects Versions: configadmin-interpolation-plugin-1.1.0
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: configadmin-interpolation-plugin-1.1.4
>
>
> When configuring property values with a delimiter, it is expected that the 
> property is an array. Otherwise, the delimited does not make sense IMO.
> Assuming I have exporter {{PROP=foo,bar}}.
> If I configure interpolation for a property value as
> prop="$[env:PROP;delimiter=,]"
> At runtime it get interpolated to {{prop = foo,bar}}, which is 
> clearly not what I expected. The correct syntax is
> prop="$[env:PROP;type=String[];delimiter=,]"
> after which the interpolation result is indeed {{ prop = [foo, bar] 
> }}.
> There are a number of ways this could be improved
> - fail interpolation with an exception
> - log a WARN/ERROR message
> - assume that if a delimiter is present but the type is not, the type is 
> {{String[]}}, and not {{String}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [felix-atomos] karlpauls merged pull request #46: Add a headers provider hook

2021-02-17 Thread GitBox


karlpauls merged pull request #46:
URL: https://github.com/apache/felix-atomos/pull/46


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [felix-atomos] karlpauls commented on pull request #46: Add a headers provider hook

2021-02-17 Thread GitBox


karlpauls commented on pull request #46:
URL: https://github.com/apache/felix-atomos/pull/46#issuecomment-780525300


   @tjwatson, I fixed a couple of missing framework.waitForStop calls in the 
tests and additionally some java doc. Furthermore, I changed the apply for the 
header provider to wrap the result in a new map to make sure headers can't be 
changed after the fact as well as that we can modify the headers. Ultimately, I 
introduced a new temporary header to indicate that we want to recalculate the 
requires. With that, it looks like the tests are passing and I think we have 
everything - please have another look if you agree with these changes. I think 
we are good to merge.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (FELIX-6387) SAX XML parser does not work properly

2021-02-17 Thread Carsten Ziegeler (Jira)


[ 
https://issues.apache.org/jira/browse/FELIX-6387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285724#comment-17285724
 ] 

Carsten Ziegeler commented on FELIX-6387:
-

It seems that SCR is doing fine, but the bundle using hibernate has the problem.
[~ankitaagar] Can you confirm that just replacing the SCR implementation is 
causing this problem to happen?

> SAX XML parser does not work properly 
> --
>
> Key: FELIX-6387
> URL: https://issues.apache.org/jira/browse/FELIX-6387
> Project: Felix
>  Issue Type: Bug
>  Components: Declarative Services (SCR)
>Reporter: Ankita Agarwal
>Priority: Critical
>
> Felix Scr has updated from kxml2 to standard SAX XML parser. After updating 
> to the org.apache.felix.scr/2.1.20, below errors are filled in the logs:
> 10.02.2021 00:24:13.479 *ERROR* [FelixStartLevel] 
> com.az.nexus.hibernate.service.impl.SessionFactoryServiceImpl Error 
> registering Hibernate SessionFactorybl-bundle (nexus_uk_core)10.02.2021 
> 00:24:13.479 *ERROR* [FelixStartLevel] 
> com.az.nexus.hibernate.service.impl.SessionFactoryServiceImpl Error 
> registering Hibernate SessionFactorybl-bundle 
> (nexus_uk_core)org.hibernate.HibernateException: Could not parse 
> configuration: nexus_uk_core-hibernate.cfg.xml at 
> org.hibernate.cfg.Configuration.doConfigure(Configuration.java:2246) at 
> org.hibernate.cfg.Configuration.configure(Configuration.java:2158) at 
> com.az.nexus.hibernate.factory.HibernateSessionFactory.createSessionFactory(HibernateSessionFactory.java:65)
>  at 
> com.az.nexus.hibernate.service.impl.SessionFactoryServiceImpl.registerSessionFactory(SessionFactoryServiceImpl.java:207)
>  at com.az.nexus.bl.Activator.start(Activator.java:149) at 
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke(Method.java:498) at 
> org.apache.felix.scr.impl.inject.methods.BaseMethod.invokeMethod(BaseMethod.java:242)
>  at 
> org.apache.felix.scr.impl.inject.methods.BaseMethod.access$500(BaseMethod.java:41)
>  at 
> org.apache.felix.scr.impl.inject.methods.BaseMethod$Resolved.invoke(BaseMethod.java:678)
>  at 
> org.apache.felix.scr.impl.inject.methods.BaseMethod.invoke(BaseMethod.java:524)
>  at 
> org.apache.felix.scr.impl.inject.methods.ActivateMethod.invoke(ActivateMethod.java:318)
>  at 
> org.apache.felix.scr.impl.inject.methods.ActivateMethod.invoke(ActivateMethod.java:308)
>  at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.createImplementationObject(SingleComponentManager.java:342)
>  at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.createComponent(SingleComponentManager.java:115)
>  at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:984)
>  at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.getServiceInternal(SingleComponentManager.java:957)
>  at 
> org.apache.felix.scr.impl.manager.AbstractComponentManager.activateInternal(AbstractComponentManager.java:766)
>  at 
> org.apache.felix.scr.impl.manager.DependencyManager$SingleStaticCustomizer.addedService(DependencyManager.java:1091)
>  at 
> org.apache.felix.scr.impl.manager.DependencyManager$SingleStaticCustomizer.addedService(DependencyManager.java:1043)
>  at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerAdded(ServiceTracker.java:1216)
>  at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerAdded(ServiceTracker.java:1137)
>  at 
> org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.trackAdding(ServiceTracker.java:944)
>  at 
> org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.track(ServiceTracker.java:880)
>  at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:1168)
>  at 
> org.apache.felix.scr.impl.BundleComponentActivator$ListenerInfo.serviceChanged(BundleComponentActivator.java:125)
>  at 
> org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
>  at 
> org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
>  at 
> org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
>  at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4833) at 
> org.apache.felix.framework.Felix.registerService(Felix.java:3804) at 
> org.apache.felix.framework.BundleContextImpl.registerService(BundleContextImpl.java:328)
>  at 
> org.apache.felix.scr.impl.manager.AbstractComponentManager$3.register(AbstractComponentManager.java:907)
>  at 
>