[VOTE] Release Apache Felix Http Jetty 4.2.26 and 5.1.10
Hi, we solved one issue for Http Jetty 5.1.10 https://issues.apache.org/jira/browse/FELIX-6690 and one for Http Jetty 4.2.26 https://issues.apache.org/jira/browse/FELIX-6689 Staging repository: https://repository.apache.org/content/repositories/orgapachefelix-1490 You can use this UNIX script to download the release and verify the signatures: https://github.com/apache/felix-dev/blob/master/check_staged_release.sh Usage: sh check_staged_release.sh 1490 /tmp/felix-staging Please vote to approve this release: [ ] +1 Approve the release [ ] -1 Veto the release (please provide specific comments) This vote will be open for 72 hours. Regards Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
Re: [PR] Jetty 12.0.6 and add jetty websocket support [felix-dev]
cziegeler commented on PR #298: URL: https://github.com/apache/felix-dev/pull/298#issuecomment-1968369815 I created https://issues.apache.org/jira/browse/FELIX-6692 to further track this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (FELIX-6692) Add Jetty WebSocket support
Carsten Ziegeler created FELIX-6692: --- Summary: Add Jetty WebSocket support Key: FELIX-6692 URL: https://issues.apache.org/jira/browse/FELIX-6692 Project: Felix Issue Type: Improvement Components: HTTP Service Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: http.jetty12-1.0.4 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Jetty 12.0.6 and add jetty websocket support [felix-dev]
paulrutter commented on PR #298: URL: https://github.com/apache/felix-dev/pull/298#issuecomment-1968353199 @cziegeler thanks for the review, i will process the comments and see if i can add a example WebServlet in https://github.com/apache/felix-dev/tree/master/http/samples/whiteboard/src/main/java/org/apache/felix/http/samples/whiteboard as part of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Jetty 12.0.6 and add jetty websocket support [felix-dev]
cziegeler commented on PR #298: URL: https://github.com/apache/felix-dev/pull/298#issuecomment-1968336845 Ok, fair enough. As commented we should probably not include the client. Is there any demo project somewhere that allows to actually test this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Jetty 12.0.6 and add jetty websocket support [felix-dev]
cziegeler commented on code in PR #298: URL: https://github.com/apache/felix-dev/pull/298#discussion_r1505437449 ## http/jetty12/pom.xml: ## @@ -37,12 +37,12 @@ scm:git:https://github.com/apache/felix-dev.git scm:git:https://github.com/apache/felix-dev.git https://gitbox.apache.org/repos/asf?p=felix-dev.git -org.apache.felix.http.jetty12-1.0.2 +org.apache.felix.http.jetty12-1.0.3 17 -12.0.5 +12.0.6 Review Comment: I've updated to 12.0.6 with a separate issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Jetty 12.0.6 and add jetty websocket support [felix-dev]
cziegeler commented on code in PR #298:
URL: https://github.com/apache/felix-dev/pull/298#discussion_r1505437215
##
http/jetty12/pom.xml:
##
@@ -414,6 +422,21 @@
jetty-session
${jetty.version}
+
+ org.eclipse.jetty.websocket
+ jetty-websocket-jetty-api
+ ${jetty.version}
+
+
+ org.eclipse.jetty.websocket
+ jetty-websocket-jetty-server
+ ${jetty.version}
+
+
+ org.eclipse.jetty.websocket
+ jetty-websocket-jetty-client
+ ${jetty.version}
+
Review Comment:
I think we should not include the client and only server parts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Resolved] (FELIX-6689) Update to Jetty 9.4.54.v20240208
[ https://issues.apache.org/jira/browse/FELIX-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved FELIX-6689. - Resolution: Fixed https://github.com/apache/felix-dev/commit/e3b8f498ac48329f0ab062fa23d8fd6d5683956b > Update to Jetty 9.4.54.v20240208 > > > Key: FELIX-6689 > URL: https://issues.apache.org/jira/browse/FELIX-6689 > Project: Felix > Issue Type: Improvement > Components: HTTP Service >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: http.jetty-4.2.26 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (FELIX-6691) Update to Jetty 12.0.6
[ https://issues.apache.org/jira/browse/FELIX-6691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved FELIX-6691. - Resolution: Fixed https://github.com/apache/felix-dev/commit/94f6a674829bdd94ad46604690c2d8a485d8ec77 > Update to Jetty 12.0.6 > -- > > Key: FELIX-6691 > URL: https://issues.apache.org/jira/browse/FELIX-6691 > Project: Felix > Issue Type: Improvement > Components: HTTP Service >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: http.jetty12-1.0.4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (FELIX-6690) Update to Jetty 11.0.20
[ https://issues.apache.org/jira/browse/FELIX-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved FELIX-6690. - Resolution: Fixed https://github.com/apache/felix-dev/commit/a464f8c236b0419be916271357e588dd18f932be > Update to Jetty 11.0.20 > --- > > Key: FELIX-6690 > URL: https://issues.apache.org/jira/browse/FELIX-6690 > Project: Felix > Issue Type: Improvement > Components: HTTP Service >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: http.jetty-5.1.10 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Jetty 12.0.6 and add jetty websocket support [felix-dev]
paulrutter commented on PR #298: URL: https://github.com/apache/felix-dev/pull/298#issuecomment-1968304091 @cziegeler yes, i tried that. But it's quite hard to determine which bundles you need, with all the transitive (and partly overlapping) dependencies. See for example https://repo1.maven.org/maven2/org/eclipse/jetty/websocket/jetty-websocket-jetty-server/12.0.6/jetty-websocket-jetty-server-12.0.6.pom. I could not get all those separate bundles to start, but i might not have the tried with the right combination of bundles. Since http2 is bundled with Felix Http, which is in the same order as websockets, adding websockets to the bundle as well made most sense to me. Also, since it was part of the former Felix http bundle for Jetty 9/11. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (FELIX-6690) Update to Jetty 11.0.20
[ https://issues.apache.org/jira/browse/FELIX-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler reassigned FELIX-6690: --- Assignee: Carsten Ziegeler > Update to Jetty 11.0.20 > --- > > Key: FELIX-6690 > URL: https://issues.apache.org/jira/browse/FELIX-6690 > Project: Felix > Issue Type: Improvement > Components: HTTP Service >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: http.jetty-5.1.10 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (FELIX-6691) Update to Jetty 12.0.6
Carsten Ziegeler created FELIX-6691: --- Summary: Update to Jetty 12.0.6 Key: FELIX-6691 URL: https://issues.apache.org/jira/browse/FELIX-6691 Project: Felix Issue Type: Improvement Components: HTTP Service Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: http.jetty12-1.0.4 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (FELIX-6690) Update to Jetty 11.0.20
Carsten Ziegeler created FELIX-6690: --- Summary: Update to Jetty 11.0.20 Key: FELIX-6690 URL: https://issues.apache.org/jira/browse/FELIX-6690 Project: Felix Issue Type: Improvement Components: HTTP Service Reporter: Carsten Ziegeler Fix For: http.jetty-5.1.10 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (FELIX-6689) Update to Jetty 9.4.54.v20240208
Carsten Ziegeler created FELIX-6689: --- Summary: Update to Jetty 9.4.54.v20240208 Key: FELIX-6689 URL: https://issues.apache.org/jira/browse/FELIX-6689 Project: Felix Issue Type: Improvement Components: HTTP Service Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: http.jetty-4.2.26 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (FELIX-6688) Context path of outer servlet container is not respected for authentication
Carsten Ziegeler created FELIX-6688: --- Summary: Context path of outer servlet container is not respected for authentication Key: FELIX-6688 URL: https://issues.apache.org/jira/browse/FELIX-6688 Project: Felix Issue Type: Bug Components: Web Console Affects Versions: webconsole-4.9.6, webconsole-5.0.0 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: webconsole-5.0.2, webconsole-4.9.8 With the switch to the http whiteboard, the invocation of an authentication handler changed. In order to be compatible with previous versions, the context path of the whiteboard context used for the webconsole needs to be stripped of (by a request wrapper). However, the whole context path, including the one from the container is removed. If now the authentication handler is doing a redirect, that context path of the container is missing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Jetty 12.0.6 and add jetty websocket support [felix-dev]
cziegeler commented on PR #298: URL: https://github.com/apache/felix-dev/pull/298#issuecomment-1968277103 Thanks @paulrutter . Did you try installing the required bundles in addition to the Apache Felix jetty12 bundle? I'm not totally against embedding this support, but would prefer having it optional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
