[GitHub] [felix-dev] dmatej commented on pull request #152: FELIX-6533 Fixed processing maven version from Felix.properties

[GitBox]

dmatej commented on PR #152:
URL: https://github.com/apache/felix-dev/pull/152#issuecomment-1131758622

   Is it better now? I removed changes in generics and one for cycle, 
whitespaces, and moved the code out of the osgi packages to own class.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [felix-dev] dmatej commented on pull request #152: FELIX-6533 Fixed processing maven version from Felix.properties

[GitBox]

dmatej commented on PR #152:
URL: https://github.com/apache/felix-dev/pull/152#issuecomment-1131719330

   The fix is this cleanup, result of it, fixed state, not some "fixed if 
condition". This is a minimized change, except some generics I left in one 
smaller class (NativeLibraryClause) and autoremoved whitespaces in Version (can 
be disabled in review). I can remove them too, but then it will take more of my 
time and we are just going back to swamps.
   
   I don't understand why the specified API is included directly into the Felix 
framework module, but ok, I will move it somewhere else, despite it will reduce 
readability for developers.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org