[jira] [Commented] (FELIX-5339) Enhance the diagnostics API to retrieve missing custom dependecies

2016-09-06 Thread Pierre De Rop (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15467802#comment-15467802
 ] 

Pierre De Rop commented on FELIX-5339:
--

I just committed your patch in revision 1759454 ...

(please change this issue to resolve state if you are ok).

thank you !

> Enhance the diagnostics API to retrieve missing custom dependecies
> --
>
> Key: FELIX-5339
> URL: https://issues.apache.org/jira/browse/FELIX-5339
> Project: Felix
>  Issue Type: New Feature
>  Components: Dependency Manager, Dependency Manager Shell
>Reporter: Raluca Grigoras
>Assignee: Pierre De Rop
>Priority: Minor
> Attachments: FELIX-5339.patch, FELIX-5339.patch
>
>
> The 'dm wtf' command only displays the missing 'out of the box' dependencies 
> (service, resource, bundle, configuration). There are cases however, when the 
> missing dependency is a custom dependency. In this case, the missing 
> dependency is not displayed by the command, even if there are unregistered 
> components due to this. It may be useful to enhance the diagnostics API to 
> retrieve all missing custom dependencies and to use this in the 'dm wtf' 
> command.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (FELIX-5339) Enhance the diagnostics API to retrieve missing custom dependecies

2016-09-06 Thread Pierre De Rop (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15467444#comment-15467444
 ] 

Pierre De Rop commented on FELIX-5339:
--

Thanks, I will look into it soon.

> Enhance the diagnostics API to retrieve missing custom dependecies
> --
>
> Key: FELIX-5339
> URL: https://issues.apache.org/jira/browse/FELIX-5339
> Project: Felix
>  Issue Type: New Feature
>  Components: Dependency Manager, Dependency Manager Shell
>Reporter: Raluca Grigoras
>Assignee: Pierre De Rop
>Priority: Minor
> Attachments: FELIX-5339.patch, FELIX-5339.patch
>
>
> The 'dm wtf' command only displays the missing 'out of the box' dependencies 
> (service, resource, bundle, configuration). There are cases however, when the 
> missing dependency is a custom dependency. In this case, the missing 
> dependency is not displayed by the command, even if there are unregistered 
> components due to this. It may be useful to enhance the diagnostics API to 
> retrieve all missing custom dependencies and to use this in the 'dm wtf' 
> command.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (FELIX-5339) Enhance the diagnostics API to retrieve missing custom dependecies

2016-09-05 Thread Raluca Grigoras (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15466460#comment-15466460
 ] 

Raluca Grigoras commented on FELIX-5339:


No need to, I will attach a patch today :).

> Enhance the diagnostics API to retrieve missing custom dependecies
> --
>
> Key: FELIX-5339
> URL: https://issues.apache.org/jira/browse/FELIX-5339
> Project: Felix
>  Issue Type: New Feature
>  Components: Dependency Manager, Dependency Manager Shell
>Reporter: Raluca Grigoras
>Assignee: Pierre De Rop
>Priority: Minor
> Attachments: FELIX-5339.patch
>
>
> The 'dm wtf' command only displays the missing 'out of the box' dependencies 
> (service, resource, bundle, configuration). There are cases however, when the 
> missing dependency is a custom dependency. In this case, the missing 
> dependency is not displayed by the command, even if there are unregistered 
> components due to this. It may be useful to enhance the diagnostics API to 
> retrieve all missing custom dependencies and to use this in the 'dm wtf' 
> command.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (FELIX-5339) Enhance the diagnostics API to retrieve missing custom dependecies

2016-09-05 Thread Pierre De Rop (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15466437#comment-15466437
 ] 

Pierre De Rop commented on FELIX-5339:
--

oops, sorry, the patch is not correct. I will fix it a bit later.

> Enhance the diagnostics API to retrieve missing custom dependecies
> --
>
> Key: FELIX-5339
> URL: https://issues.apache.org/jira/browse/FELIX-5339
> Project: Felix
>  Issue Type: New Feature
>  Components: Dependency Manager, Dependency Manager Shell
>Reporter: Raluca Grigoras
>Assignee: Pierre De Rop
>Priority: Minor
> Attachments: FELIX-5339.patch
>
>
> The 'dm wtf' command only displays the missing 'out of the box' dependencies 
> (service, resource, bundle, configuration). There are cases however, when the 
> missing dependency is a custom dependency. In this case, the missing 
> dependency is not displayed by the command, even if there are unregistered 
> components due to this. It may be useful to enhance the diagnostics API to 
> retrieve all missing custom dependencies and to use this in the 'dm wtf' 
> command.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (FELIX-5339) Enhance the diagnostics API to retrieve missing custom dependecies

2016-09-05 Thread Pierre De Rop (JIRA)

[ 
https://issues.apache.org/jira/browse/FELIX-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465783#comment-15465783
 ] 

Pierre De Rop commented on FELIX-5339:
--

Hello Raluca;

I have joined to this issue a simple proposed patch, which seems to work.
Can you please review it ? Or may be you already have your own patch  ?

Then if you are OK, I can commit the attached patch, which also includes a 
junit test 
(see testCanFindCustomDependencyRootFailure, TimeoutDependency, and 
TimeoutDependencyImpl).

thank you.

> Enhance the diagnostics API to retrieve missing custom dependecies
> --
>
> Key: FELIX-5339
> URL: https://issues.apache.org/jira/browse/FELIX-5339
> Project: Felix
>  Issue Type: New Feature
>  Components: Dependency Manager, Dependency Manager Shell
>Reporter: Raluca Grigoras
>Assignee: Pierre De Rop
>Priority: Minor
>
> The 'dm wtf' command only displays the missing 'out of the box' dependencies 
> (service, resource, bundle, configuration). There are cases however, when the 
> missing dependency is a custom dependency. In this case, the missing 
> dependency is not displayed by the command, even if there are unregistered 
> components due to this. It may be useful to enhance the diagnostics API to 
> retrieve all missing custom dependencies and to use this in the 'dm wtf' 
> command.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)