RE: Rates module

[Angel Cajas]

Hello Ed,

Thanks for taking some time to see this topic. We have received your comments 
and we will start to work on the requested changes as soon as possible.

Angel

-Original Message-
From: Ed Cable  
Sent: lunes, 30 de julio de 2018 6:51 p. m.
To: Dev ; Shruthi M R 
Cc: Adriana Pinto 
Subject: Re: Rates module

Hello Angel,

Thank you for raising this on the list again. I had been meaning to reach out 
to you and your team to ensure we get your contributions into one of the 
forthcoming releases.

I've cc'd Shruthi who can take the lead on reviewing but invite all community 
members (not just committers) to review and provided feedback on changes made.

Ed

On Mon, Jul 30, 2018 at 4:16 PM Angel Cajas  wrote:

> Hi ,
>
> I created an issue some time ago to add some previously defined rates 
> to calculate the minimum and maximum nominal rate for a loan.
> I committed and pushed those changes to a forked repository and crated 
> a new a pull request on the dev branch of this repository:
> https://github.com/apache/fineract.
> I hope that I can get your feedback about the changes I did.
>
> Thanks for your attention
>


--
*Ed Cable*
President/CEO, Mifos Initiative
edca...@mifos.org | Skype: edcable | Mobile: +1.484.477.8649

*Collectively Creating a World of 3 Billion Maries | *http://mifos.org 
  

Re: Fineract CN GSoC 2018 Interns: Send your PRs

[Awasum Yannick]

Graham,

Have you been able to solve your problem with the authentication?

On Thu, Aug 2, 2018 at 6:58 PM Awasum Yannick  wrote:

> Hello Ruphine, Pembe,
>
> I merged your PRs for the front end. Thanks very much for your
> contributions so far. Keep up.
>
> Ruphine am still to review the new PR for the Groups backend.
>
> Write unit tests for the work done so far for both backend and front end
> if you touched both.
>
> Thanks.
> Awasum
>
> On Thu, Aug 2, 2018 at 4:58 PM Ruphine Kengne 
> wrote:
>
>> Hello,
>>
>> I have send some PRs as requested.
>>
>> One to fineract-cn-fims-web-app available here ,
>> https://github.com/apache/fineract-cn-fims-web-app/pulls
>>
>> and the other to fineract-cn-group available here ,
>> https://github.com/apache/fineract-cn-group/pulls
>>
>>
>> Regard
>> Ruphine kengne
>>
>> On 28 July 2018 at 09:08, Awasum Yannick  wrote:
>>
>> > Hello Interns,
>> >
>> > Given we are near the end of GSoC 2018, I am recommending for everyone
>> to
>> > start sending in the PRs for the work we have done so far.
>> >
>> > I will be available to start reviewing today or tomorrow (Sunday).
>> > @Pembe Miriam  , I already started with yours
>> > and
>> > left some comments here:
>> > https://github.com/apache/fineract-cn-group-finance/pull/2
>> >
>> > I also encourage you all to write unit tests for the work done so far
>> as we
>> > might not be able to merge your PRs without proper tests.
>> >
>> > Also write user and developer documentations for your work and add more
>> > clarity on user stories and requirements which have evolved over the
>> course
>> > of the GSoC period so others can get context. Use confluence.
>> >
>> > I am available to answer questions if you are having problems mostly in
>> my
>> > night period. I'm at GMT + 1 time zone. Lets try to get everyone
>> unblocked
>> > and complete the GSoC project within the next few weeks.
>> >
>> >
>> > Thanks.
>> > Awasum
>> >
>>
>

Re: Fineract CN GSoC 2018 Interns: Send your PRs

[Awasum Yannick]

Hello Ruphine, Pembe,

I merged your PRs for the front end. Thanks very much for your
contributions so far. Keep up.

Ruphine am still to review the new PR for the Groups backend.

Write unit tests for the work done so far for both backend and front end if
you touched both.

Thanks.
Awasum

On Thu, Aug 2, 2018 at 4:58 PM Ruphine Kengne 
wrote:

> Hello,
>
> I have send some PRs as requested.
>
> One to fineract-cn-fims-web-app available here ,
> https://github.com/apache/fineract-cn-fims-web-app/pulls
>
> and the other to fineract-cn-group available here ,
> https://github.com/apache/fineract-cn-group/pulls
>
>
> Regard
> Ruphine kengne
>
> On 28 July 2018 at 09:08, Awasum Yannick  wrote:
>
> > Hello Interns,
> >
> > Given we are near the end of GSoC 2018, I am recommending for everyone to
> > start sending in the PRs for the work we have done so far.
> >
> > I will be available to start reviewing today or tomorrow (Sunday).
> > @Pembe Miriam  , I already started with yours
> > and
> > left some comments here:
> > https://github.com/apache/fineract-cn-group-finance/pull/2
> >
> > I also encourage you all to write unit tests for the work done so far as
> we
> > might not be able to merge your PRs without proper tests.
> >
> > Also write user and developer documentations for your work and add more
> > clarity on user stories and requirements which have evolved over the
> course
> > of the GSoC period so others can get context. Use confluence.
> >
> > I am available to answer questions if you are having problems mostly in
> my
> > night period. I'm at GMT + 1 time zone. Lets try to get everyone
> unblocked
> > and complete the GSoC project within the next few weeks.
> >
> >
> > Thanks.
> > Awasum
> >
>

Re: Fineract CN GSoC 2018 Interns: Send your PRs

[Ruphine Kengne]

Hello,

I have send some PRs as requested.

One to fineract-cn-fims-web-app available here ,
https://github.com/apache/fineract-cn-fims-web-app/pulls

and the other to fineract-cn-group available here ,
https://github.com/apache/fineract-cn-group/pulls


Regard
Ruphine kengne

On 28 July 2018 at 09:08, Awasum Yannick  wrote:

> Hello Interns,
>
> Given we are near the end of GSoC 2018, I am recommending for everyone to
> start sending in the PRs for the work we have done so far.
>
> I will be available to start reviewing today or tomorrow (Sunday).
> @Pembe Miriam  , I already started with yours
> and
> left some comments here:
> https://github.com/apache/fineract-cn-group-finance/pull/2
>
> I also encourage you all to write unit tests for the work done so far as we
> might not be able to merge your PRs without proper tests.
>
> Also write user and developer documentations for your work and add more
> clarity on user stories and requirements which have evolved over the course
> of the GSoC period so others can get context. Use confluence.
>
> I am available to answer questions if you are having problems mostly in my
> night period. I'm at GMT + 1 time zone. Lets try to get everyone unblocked
> and complete the GSoC project within the next few weeks.
>
>
> Thanks.
> Awasum
>

Re: Code Committ Process for Fineract Committers

[Mexina Daniel]

Hello Steve

This was really helpfully, thank you

The next question will be, how can i work around it so that i can merge this PR 
that seems to fix some of the issues and other PRs that are really needed to be 
merged.

Best Regards


- Original Message -
From: "Steve Conrad" 
To: "dev" 
Cc: "Myrle Krantz" , "Avik Ganguly" 
, "edcable" , "Isaac Kamga" 
, "santosh" , "Nazeer 
Hussain Shaik" , "nayan ambali" 
, "shruthi" 
Sent: Wednesday, August 1, 2018 6:02:26 PM
Subject: Re: Code Committ Process for Fineract Committers

Hi Mexina -

I did run into some issues with Integration Tests as well when I was
merging - it seems that some of the setup data files are configured for
Windows paths. I was able to work around that, but we should have someone
look into cleaning up the integration tests so that they run more easily.

As far as your specific question about the merge process, it can be a bit
confusing. As the instructions indicate, you will create a new new branch
in your cloned repo In this case, the PR doesn't have a ticket name. @Ed
Cable  should we require any PRs to be attached to a
ticket? Otherwise, the name of the branch would be something like
wkk91193-bulk-impoort-fix-importhandler.

It is important that whenever someone wants to submit a PR, they create a
branch that contains only the changes that are to be merged. In this case,
the forked repo name is  wkk91193 and the remote branch name is
extend-mifos-data-import-tool-branch-all-modules That is how you get only
the changes that are specific to that PR.

Hope that helps clarify. Please let me know if you have other questions.
Thanks,
Steve

On Wed, Aug 1, 2018 at 9:18 AM Mexina Daniel  wrote:

> Hello Myrle
>
> Thank you for the clarifications you have provided,
>
> I also was experiencing some challenges during merging of PRs,
>
> 1. Don't all integration tests has to be successfully for a committer to
> go on with merging?, i see Steve was able to merge but when i run
> integrationTests in my end there are some which still fails.
>
> 2. When i was trying to merge the PRs which fix the integratioTest
> https://github.com/apache/fineract/pull/444 which failed by instructions
> from
> https://cwiki.apache.org/confluence/display/FINERACT/Merge+a+pull+request+to+a+mirrored+Apache+repo
>  On step 3 of merging pull request, i don't understand the command
>
> " > git pull https://github.com//fineract.git
> "
>
> How does it exactly pull from specific PR, unless am misunderstanding the
> variable "forked-reponame" and "remote-branch-name"
>
> Can you help?
>
> Best Regards
>
> - Original Message -
> From: "Myrle Krantz" 
> To: "dev" 
> Cc: "Avik Ganguly" , "edcable" <
> edca...@mifos.org>, "Isaac Kamga" , "santosh" <
> sant...@confluxtechnologies.com>, "Nazeer Hussain Shaik" <
> nazeerhussain.sh...@gmail.com>, "nayan ambali" ,
> shru...@confluxtechnologies.com
> Sent: Saturday, July 28, 2018 5:57:31 PM
> Subject: Re: Code Committ Process for Fineract Committers
>
> Hey Ed,
>
> All Fineract committers have access rights to change all Fineract
> repositories. They can merge their own or others PRs. Nazeer, Nayan, Steve,
> Santosh, Ed, Avik are all committers. There are a total of 20+ committers.
>
> The process for committing changes is different depending on the
> repository. We have two kinds of repositories. Mirrored repositories and
> gitbox repositories.
>
> Mirrored repositories are:
> 
> fineract-site
> fineract
>
> As Steve pointed out, mirrored repositories are changed via the process
> described here:
>
>
> https://cwiki.apache.org/confluence/display/FINERACT/Merge+a+pull+request+to+a+mirrored+Apache+repo
>
> I personally find that process painful. It is possible that someone tried
> that, failed at it, and came to the mistaken conclusion that he didn’t have
> access rights.
>
>
> Gitbox repositories are:
> —-
> All the Fineract CN repositories
>
> (We are in the process of changing fineract-site to a gitbox repository.)
>
> In gitbox repositories, PRs can be merged via the Github UI most of us are
> familiar with. In November of last year, I explained what you need to do to
> enable this here on the mailing list:
>
>
> https://lists.apache.org/thread.html/dec82c43eddd37b2e90020120e285d5cffe04f1fe448e1dfa1b9c49b@%3Cdev.fineract.apache.org%3E
>
> If you are a committer and have tried to merge a change-set and failed,
> don’t suffer in silence. You are allowed to make changes. Tell us you’re
> struggling so we can help you. I promise to never say RTFM to a committer.
> And if someone else does it, I’ll call them on it.
>
> Best Regards,
> Myrle
>
>
>
>
> On Fri 27. Jul 2018 at 19:08 Steve Conrad  wrote:
>
> > Hi all,
> >
> > I was able to merge PRs using the process described in this document:
> >
> >
> >
> https://cwiki.apache.org/confluence/display/FINERACT/Merge+a+pull+request+to+a+mirrored+Apache+repo
> >
> > Myrle created this doc and I made a few updates to it.
> >
> > However, it may be that we need to use