Re: FINERACT-614

2019-03-22 Thread Vishwas Babu
My bad ! I must have done so accidentally while deleting a few stale
branches I had created.

I am on my phone right now and will restore the same first think tomorrow
morning

Regards ,
Vishwas

On Friday, March 22, 2019, Myrle Krantz  wrote:

> Hey Vishwas,
>
> I'm a bit confused right now.  Perhaps you can help me.  After creating a
> branch for FINERACT-614 I was going to sit down today to work on the
> findbugs issues it contained, and maybe update the branch from develop so
> that it can be merged.
>
> But it seems that you've deleted that branch.  I can't find any indication
> that you merged it.  I'm probably missing something.  Can you help me
> understand what?
>
> Here's the pull request I used to create the branch:
> https://github.com/apache/fineract/pull/465/commits/
> aaa61695cf27419a2bc9e018fc6e2715512a1094
>
> And here's where you (apparently) deleted the branch:
> https://lists.apache.org/thread.html/342f708d3573cb312cdd693bb490b6
> 7fba268d2f88969c67743a60c9@%3Ccommits.fineract.apache.org%3E
>
> Best,
> Myrle
>


-- 
Sent from my iPad


FINERACT-614

2019-03-22 Thread Myrle Krantz
Hey Vishwas,

I'm a bit confused right now.  Perhaps you can help me.  After creating a
branch for FINERACT-614 I was going to sit down today to work on the
findbugs issues it contained, and maybe update the branch from develop so
that it can be merged.

But it seems that you've deleted that branch.  I can't find any indication
that you merged it.  I'm probably missing something.  Can you help me
understand what?

Here's the pull request I used to create the branch:
https://github.com/apache/fineract/pull/465/commits/aaa61695cf27419a2bc9e018fc6e2715512a1094

And here's where you (apparently) deleted the branch:
https://lists.apache.org/thread.html/342f708d3573cb312cdd693bb490b67fba268d2f88969c67743a60c9@%3Ccommits.fineract.apache.org%3E

Best,
Myrle