RE: Meet 'marmotinni', an ASJS testing framework
If we go a step further and also emit Flex class name in another property (perhaps in the 'class' property of DOM elements) we could make RIATest automatically recognize which Flex component does each DOM element represent and even aim to have a universal syntax for test scripts that can be run against both SWF target and JS target of the same Flex application. What this basically means is that you can write a test script on a SWF target and then make sure the same script runs exactly the same way on the JS target. That coupled with the ability to run the tests on multiple browsers and 2 operating systems will give a very powerful way to validate the JS output and ensure it works exactly the same way as the SWF output of the same Flex app. This will require modifications to RIATest but the end result will be really exciting so I think we can consider adding such capability to an upcoming RIATest version. Sorry, I was too quick. This is not going to work. The actions on SWF and HTML objects are done in different terms so there is no way to have identical tests. Ignore this particular idea. Tigran.
Re: Meet 'marmotinni', an ASJS testing framework
On 4/14/13 11:30 PM, Tigran Najaryan tig...@gmail.com wrote: If we go a step further and also emit Flex class name in another property (perhaps in the 'class' property of DOM elements) we could make RIATest automatically recognize which Flex component does each DOM element represent and even aim to have a universal syntax for test scripts that can be run against both SWF target and JS target of the same Flex application. What this basically means is that you can write a test script on a SWF target and then make sure the same script runs exactly the same way on the JS target. That coupled with the ability to run the tests on multiple browsers and 2 operating systems will give a very powerful way to validate the JS output and ensure it works exactly the same way as the SWF output of the same Flex app. This will require modifications to RIATest but the end result will be really exciting so I think we can consider adding such capability to an upcoming RIATest version. Sorry, I was too quick. This is not going to work. The actions on SWF and HTML objects are done in different terms so there is no way to have identical tests. Ignore this particular idea. OK, but given that we trans-compile AS to JS and your test language is ES-like, there is no way to wrap things so they work? Tigran. -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Git equiv of viewvc?
Hi, When we were in SVN we had this: https://svn.apache.org/repos/asf/flex/sdk/branches/develop/ And even better this: http://svn.apache.org/viewvc/flex/sdk/branches/develop/ I found this but it not exactly useful or the same. http://git.apache.org/flex-sdk.git/ Do we have a git equiv of ether of these? If not what do we need infra to do to set one up? Thanks, Justin
CS Extensions
I'd like to start that project to export FXG from creative suite apps. Some questions: 1) Should I start this on a personal github account, or have we settled on something else? 2) CS Extensions have dependencies on a number of Adobe swcs. How do we handle the project vis a vis Apache's policies and binaries? I don't think those dependencies can be included…
RE: Meet 'marmotinni', an ASJS testing framework
OK, but given that we trans-compile AS to JS and your test language is ES- like, there is no way to wrap things so they work? I don't think so. The problem is that tests on Flex apps compiled to SWF use action names specific to each component (usually corresponding to appropriate Flex event names) as defined by Flex Automation framework. For example to open a ComboBox and select an item you do something like this in RIATest: FlexComboBox(myCB).open(); FlexComboBox(myCB ).select(Some item); The open() and select() actions are handled by the automation delegate for mx.controls.ComboBox component. On the contrary the same application compiled to JS will not only know nothing about FlexComboBox (which could be solved by my earlier suggestion), it also does not use open() and select() actions, it uses either low-level mouse events dispatched directly to HTML DOM elements, or HTML element specific events. In this case the correct action will be change(): HtmlSelect(myCB).change(Some item); Note that we do not even have an action corresponding to open(). We could do click() but it does not have exact same effect. In some other cases a sequence of Flex-specific actions can be replaced by mouse events. For example Flex Automation Framework uses itemOpen() action to expand an item of mx.controls.Tree, however this must be likely simulated using simple click() action on the relevant DOM element in the JS version of the test. So, generally there is no match between the actions that one needs to simulate on the SWF output and the actions that must be simulated on the JS output to have the exact same effect. The names of the actions, the parameters and the sequence, everything can be different. This unfortunately means it is not possible to have a single uniform test script that can act on both output versions the same way. Tigran.
Re: Git equiv of viewvc?
Maybe there's a way to get gitweb installed? [1] [1]https://git.wiki.kernel.org/index.php/Gitweb On Apr 15, 2013, at 10:10 AM, Justin Mclean wrote: Hi, When we were in SVN we had this: https://svn.apache.org/repos/asf/flex/sdk/branches/develop/ And even better this: http://svn.apache.org/viewvc/flex/sdk/branches/develop/ I found this but it not exactly useful or the same. http://git.apache.org/flex-sdk.git/ Do we have a git equiv of ether of these? If not what do we need infra to do to set one up? Thanks, Justin
Re: CS Extensions
Exciting stuff! I would love to help you on this one, time permitting. On Mon, Apr 15, 2013 at 12:35 AM, Harbs harbs.li...@gmail.com wrote: I'd like to start that project to export FXG from creative suite apps. Some questions: 1) Should I start this on a personal github account, or have we settled on something else? What do you think of the flex-utilities git repo? 2) CS Extensions have dependencies on a number of Adobe swcs. How do we handle the project vis a vis Apache's policies and binaries? I don't think those dependencies can be included… We can always have a build script that downloads the required external dependencies. As long as they are of compatible licenses and we dont check them into our repos, we should be fine. After all, the Flex SDK depends on Flash Player, AIR, Batik, etc. The build script just downloads them for the user (after a license confirmation) Please let me know how I can help. Thanks, Om
Web site content need updating SVN - Git
Hi, This page still mentions snv for creating patches - anyone want to fix? http://flex.apache.org/community-getinvolved.html Justin
Re: Git equiv of viewvc?
What is about https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git and for branch 'develop' https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git;a=tree;h=refs/heads/develop;hb=develop ? Sent from my iPhone On 15.04.2013, at 15:10, Justin Mclean jus...@classsoftware.com wrote: Hi, When we were in SVN we had this: https://svn.apache.org/repos/asf/flex/sdk/branches/develop/ And even better this: http://svn.apache.org/viewvc/flex/sdk/branches/develop/ I found this but it not exactly useful or the same. http://git.apache.org/flex-sdk.git/ Do we have a git equiv of ether of these? If not what do we need infra to do to set one up? Thanks, Justin
Re: Git equiv of viewvc?
Hi, What is about https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git That better. and for branch 'develop' https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git;a=tree;h=refs/heads/develop;hb=develop ? Sadly clicking on summary takes you off the develop branch. How did you navigate to the develop branch in the first place? Anyway we can change it so that it shows develop by default? Thanks, Justin
Re: Git equiv of viewvc?
Hi, What is about https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git and for branch 'develop' https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git;a=tree;h=refs/heads/develop;hb=develop ? Might be good to add this info to: http://flex.apache.org/dev-sourcecode.html Justin
Re: [FalconJx] JSGoogEmitter ClasstCastException
Cyrill, Excellent contribution, thank you. While you're on a roll, would you mind having a look at some of the ToDo's scattered throughout the code? Only one technical detail: if you're using Eclipse, can you please use this 'formatter' before committing code: https://issues.apache.org/jira/browse/FLEX-33485 There are some whitespace issues with your commit that will confuse the diffs between committers. EdB On Sun, Apr 14, 2013 at 7:04 PM, Cyrill Zadra cyrill.za...@gmail.com wrote: Hi Just pushed a fix to develop branch which fixes a ClassCastException for following scenario. package vo { public interface ITestInterface { } } package vo { public class TestObject implements ITestInterface { public function TestObject() { } } } Erik you may have a review look at it ;-) Cyrill -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
Re: [DISCUSS] How do we want to handle Whiteboard?
Thanks Mark, you are a good man :-) Om On Sun, Apr 14, 2013 at 5:31 AM, Mark Kessler kesslerconsult...@gmail.comwrote: I ended up creating a GITHub account... however, I will probably redo the repo on it since I uploaded a clone of the Flex-SDK with my changes already in it. This means the work I've done already doesn't stand out. so give me about 20 mins and I'll have Logistically speaking that would be least cumbersome process. ... but developers aren't logical lol :p -Mark On Sun, Apr 14, 2013 at 3:34 AM, OmPrakash Muppirala bigosma...@gmail.comwrote: On Apr 13, 2013 11:44 PM, Alex Harui aha...@adobe.com wrote: Is the Git whiteboard read-write? Are there any issues with opening it if we do end up going to Github? If not, can you request that it be opened? I'm not sure how you were going about that for the other repos. Thanks, -Alex Mark, maybe you can create a public GitHub project for now to share your code? Then you will have to manually check it into wherever we decide to host the whiteboard. Logistically speaking that would be least cumbersome process. Thanks, Om
Re: CS Extensions
I'm a bit crazy for trying to start this right now. I'm off to a conference in less than two weeks, and time is not exactly a commodity in large supply right now… ;-) It will likely remain largely a skeleton for a few weeks, but at least I can get it started. I figure the support will come in stages. Where do you think I should start? I figure I'll start with Rect and add attributes to that until it's more-or-less complete. It can grow organically from there. Makes sense? I was thinking of starting it on a whiteboard, but I guess the utilities repro makes sense. If there's no objections, I'll start it there. Harbs On Apr 15, 2013, at 10:42 AM, OmPrakash Muppirala wrote: Exciting stuff! I would love to help you on this one, time permitting. On Mon, Apr 15, 2013 at 12:35 AM, Harbs harbs.li...@gmail.com wrote: I'd like to start that project to export FXG from creative suite apps. Some questions: 1) Should I start this on a personal github account, or have we settled on something else? What do you think of the flex-utilities git repo? 2) CS Extensions have dependencies on a number of Adobe swcs. How do we handle the project vis a vis Apache's policies and binaries? I don't think those dependencies can be included… We can always have a build script that downloads the required external dependencies. As long as they are of compatible licenses and we dont check them into our repos, we should be fine. After all, the Flex SDK depends on Flash Player, AIR, Batik, etc. The build script just downloads them for the user (after a license confirmation) Please let me know how I can help. Thanks, Om
Re: Web site content need updating SVN - Git
I'm on it. Harbs On Apr 15, 2013, at 10:54 AM, Justin Mclean wrote: Hi, This page still mentions snv for creating patches - anyone want to fix? http://flex.apache.org/community-getinvolved.html Justin
[jira] [Updated] (FLEX-33476) Get Involved Page Outdated
[ https://issues.apache.org/jira/browse/FLEX-33476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harbs updated FLEX-33476: - Assignee: Harbs Get Involved Page Outdated -- Key: FLEX-33476 URL: https://issues.apache.org/jira/browse/FLEX-33476 Project: Apache Flex Issue Type: Documentation Reporter: Harbs Assignee: Harbs Priority: Minor The Get Involved page here https://flex.apache.org/community-getinvolved.html refers to svn instead of git. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Web site content need updating SVN - Git
One question: There's a link for [Mustella tests][5] on the page, but there's no link on the bottom. Where's it supposed to link to? On Apr 15, 2013, at 10:54 AM, Justin Mclean wrote: Hi, This page still mentions snv for creating patches - anyone want to fix? http://flex.apache.org/community-getinvolved.html Justin
Re: Web site content need updating SVN - Git
Hi, I'm on it. Thanks - much appreciated. Justin
Re: Web site content need updating SVN - Git
Please check my corrections before I publish it: http://flex.staging.apache.org/community-getinvolved.html On Apr 15, 2013, at 11:47 AM, Justin Mclean wrote: Hi, I'm on it. Thanks - much appreciated. Justin
[FalconJS] populating the 'id' property at runtime
I am trying to understand how to make sure the 'id' property is available on the DOM elements. It looks like if I simply modify function org.apache.flex.core.UIBase.prototype.set_id() to directly assign the 'value' to this.element.id it works, the id property becomes available at runtime and is shown by Firebug. Is there a reason why set_id() currently does not do it? If this modification is acceptable I will submit a patch. Tigran.
Re: Web site content need updating SVN - Git
HI, Please check my corrections before I publish it: http://flex.staging.apache.org/community-getinvolved.html I go ahead and publish it has to better than what was there before :-) Perhaps someone can commit on git show vs git format-patch as I'm not sure what the best way of doing it. Thanks, Justin
Re: Web site content need updating SVN - Git
Hi, Or git diff??? Justin
Re: [FalconJS] populating the 'id' property at runtime
I can't think of no other reason than it wasn't needed. Unless somehow having an id attribute would mess with JS calls to the object that has the element... But since all JS objects exist in separate namespaces, I don't think it should matter. How about you submit a patch, I create a new public branch (ha, look at me thinking all gitty ;-)) and you work with that branch? EdB On Mon, Apr 15, 2013 at 11:25 AM, Tigran Najaryan tig...@gmail.com wrote: I am trying to understand how to make sure the 'id' property is available on the DOM elements. It looks like if I simply modify function org.apache.flex.core.UIBase.prototype.set_id() to directly assign the 'value' to this.element.id it works, the id property becomes available at runtime and is shown by Firebug. Is there a reason why set_id() currently does not do it? If this modification is acceptable I will submit a patch. Tigran. -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
Re: Git equiv of viewvc?
On bottom of page https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git all branches are listed. Click tree on develop an you'll be there :-). On 15.04.2013, at 16:07, Justin Mclean jus...@classsoftware.com wrote: Hi, What is about https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git That better. and for branch 'develop' https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git;a=tree;h=refs/heads/develop;hb=develop ? Sadly clicking on summary takes you off the develop branch. How did you navigate to the develop branch in the first place? Anyway we can change it so that it shows develop by default? Thanks, Justin
RE: [DISCUSS] How do we want to handle Whiteboard?
Oops, I posted the link [1] in my user page, but not in the dev list. [1] https://github.com/KesslerConsulting/example -Mark -Original Message- From: omup...@gmail.com [mailto:omup...@gmail.com] On Behalf Of OmPrakash Muppirala Sent: Monday, April 15, 2013 4:16 AM To: dev@flex.apache.org Subject: Re: [DISCUSS] How do we want to handle Whiteboard? Thanks Mark, you are a good man :-) Om smime.p7s Description: S/MIME cryptographic signature
Re: Web site content need updating SVN - Git
Yeah. I was wondering about that. In the meanwhile, I published it. If someone with more git knowhow wants to change that, feel free… ;-) On Apr 15, 2013, at 12:31 PM, Justin Mclean wrote: HI, Please check my corrections before I publish it: http://flex.staging.apache.org/community-getinvolved.html I go ahead and publish it has to better than what was there before :-) Perhaps someone can commit on git show vs git format-patch as I'm not sure what the best way of doing it. Thanks, Justin
[jira] [Resolved] (FLEX-33476) Get Involved Page Outdated
[ https://issues.apache.org/jira/browse/FLEX-33476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Harbs resolved FLEX-33476. -- Resolution: Fixed Get Involved Page Outdated -- Key: FLEX-33476 URL: https://issues.apache.org/jira/browse/FLEX-33476 Project: Apache Flex Issue Type: Documentation Reporter: Harbs Assignee: Harbs Priority: Minor The Get Involved page here https://flex.apache.org/community-getinvolved.html refers to svn instead of git. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Git equiv of viewvc?
Oh yeah... Even better ;-). Thanks Cyrill On Mon, Apr 15, 2013 at 7:37 PM, Frédéric THOMAS webdoubl...@hotmail.com wrote: Now we have FishEye, https://fisheye6.atlassian.com/browse/flex-sdk and https://fisheye6.atlassian.com/graph/flex-sdk should give you what you need -Fred -Message d'origine- From: Cyrill Zadra Sent: Monday, April 15, 2013 12:29 PM To: dev@flex.apache.org Subject: Re: Git equiv of viewvc? On bottom of page https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git all branches are listed. Click tree on develop an you'll be there :-). On 15.04.2013, at 16:07, Justin Mclean jus...@classsoftware.com wrote: Hi, What is about https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git That better. and for branch 'develop' https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git;a=tree;h=refs/heads/develop;hb=develop ? Sadly clicking on summary takes you off the develop branch. How did you navigate to the develop branch in the first place? Anyway we can change it so that it shows develop by default? Thanks, Justin
Re: Web site content need updating SVN - Git
'git format-patch BRANCH --stdout FLEX-007.patch' where BRANCH is the branch you want your patch be merged into from whether the branch you're working on, you can omit it if the origin and destination branch are the same and FLEX-007, the Jira Issue Id relative to your patch. -Fred -Message d'origine- From: Harbs Sent: Monday, April 15, 2013 12:33 PM To: dev@flex.apache.org Subject: Re: Web site content need updating SVN - Git Yeah. I was wondering about that. In the meanwhile, I published it. If someone with more git knowhow wants to change that, feel free… ;-) On Apr 15, 2013, at 12:31 PM, Justin Mclean wrote: HI, Please check my corrections before I publish it: http://flex.staging.apache.org/community-getinvolved.html I go ahead and publish it has to better than what was there before :-) Perhaps someone can commit on git show vs git format-patch as I'm not sure what the best way of doing it. Thanks, Justin
Re: Components donation
Hi guys, Is there someone who can indicate the next steps or if we need a vote before accepting any new components ? Thanks, -Fred -Message d'origine- From: Frédéric THOMAS Sent: Tuesday, March 12, 2013 10:01 AM To: dev@flex.apache.org Subject: Re: Components donation Hi Jérémy, Everybody is busy at the moment, I guess that's the reason why you haven't got so much returns but in few days, I'll put back this thread on the top. Thanks, -Fred -Message d'origine- From: Jérémy Reynaud Sent: Tuesday, March 12, 2013 9:49 AM To: dev@flex.apache.org Subject: RE: Components donation Thanks for your feedbacks and answers. We will start the process soon. Jérémy -Message d'origine- De : Frédéric THOMAS [mailto:webdoubl...@hotmail.com] Envoyé : lundi 11 mars 2013 15:49 À : dev@flex.apache.org Objet : Re: Components donation Jérémy, Note: I gave you a quick answer, like that you can have a good overview of the process but more precise details will be given by our PMCs probably later today. Thanks, -Fred -Message d'origine- From: Frédéric THOMAS Sent: Monday, March 11, 2013 3:37 PM To: dev@flex.apache.org Subject: Re: Components donation Hi Jérémy, First, thank you for your interest donating those components to Apache Flex. 1- The components: Given we've got progress component and we haven't got any dual slider (Spark Mobile) and yours looks very nice, I would personaly go at least for the latter, but I'm not only by myself and I not sure about the policies we've got regarding how we choose the components they could be donated. 2- For the license, it depends, from what I've seen from now (most of that was writen before by Alex Harui for other donations): The ASF has a policy to not take software regardless of the license unless the copyright holder grants it. By signing the ICLA you have indicated that you have permission from the copyright holder to make any contributions that you make. I think steps are to file ICLAs [1], and a CCLA [2] if there is a corporate entity involved. Then fill out the software grant [3]. 3- The donation process: 1. You fill out and sign all legal documents 2. Some of us will review the code (it can be given via a zip associated to a JIRA ticket). If it looks ok, we will start the committer approval process for you. Takes a minimum of 3 business days. 3. We discuss where this code should land, the package names. 4. Once the software grant is recorded, someone can check the code into SVN. 5. Once it is in, it gets another review. This means making sure there are no binaries, that the headers are correct, that your copyrights (but not any third-party copyrights) are moved to the NOTICES file (which must be done by you or with your explicit permission). 6. Based on 3, all kinds of good stuff happens. -Fred [1] http://www.apache.org/licenses/icla.txt [2] http://www.apache.org/licenses/cla-corporate.txt [3] http://www.apache.org/licenses/software-grant.txt -Message d'origine- From: Jérémy Reynaud Sent: Monday, March 11, 2013 3:01 PM To: dev@flex.apache.org Subject: Components donation Hi, I’m Jérémy Reynaud, CTO and co-founder of KeepCore, company based in Montpellier, France. We propose commercial FLEX components on our dedicated website: http://www.flex-component.com/ We recently think about releasing some of them on the website for free. But maybe another and better solution could be to donate them to the Apache FLEX community. So here are my questions: - Does it make sense? Do you think these components are interesting for the community? - If yes, what is the process to donate them? The components are: - A dual slider (Spark Mobile), demo: http://www.flex-component.com/demo/apache/KCDualSliderV1.1/ - A progress spinner / “super” busy indicator (Spark Mobile), demo: http://www.flex-component.com/demo/apache/KCProgressSpinnerV1.1/ Thanks for your answers. Best regards, Jérémy
Re: Components donation
I don't think a VOTE is strictly necessary. A DISCUSS might be nice, though. Also, we need to make sure all legal obligations are met and all proper documents are filed. When in doubt, we need to check with Apache's legal department, I think. EdB On Mon, Apr 15, 2013 at 2:08 PM, Frédéric THOMAS webdoubl...@hotmail.com wrote: Hi guys, Is there someone who can indicate the next steps or if we need a vote before accepting any new components ? Thanks, -Fred -Message d'origine- From: Frédéric THOMAS Sent: Tuesday, March 12, 2013 10:01 AM To: dev@flex.apache.org Subject: Re: Components donation Hi Jérémy, Everybody is busy at the moment, I guess that's the reason why you haven't got so much returns but in few days, I'll put back this thread on the top. Thanks, -Fred -Message d'origine- From: Jérémy Reynaud Sent: Tuesday, March 12, 2013 9:49 AM To: dev@flex.apache.org Subject: RE: Components donation Thanks for your feedbacks and answers. We will start the process soon. Jérémy -Message d'origine- De : Frédéric THOMAS [mailto:webdoubl...@hotmail.com] Envoyé : lundi 11 mars 2013 15:49 À : dev@flex.apache.org Objet : Re: Components donation Jérémy, Note: I gave you a quick answer, like that you can have a good overview of the process but more precise details will be given by our PMCs probably later today. Thanks, -Fred -Message d'origine- From: Frédéric THOMAS Sent: Monday, March 11, 2013 3:37 PM To: dev@flex.apache.org Subject: Re: Components donation Hi Jérémy, First, thank you for your interest donating those components to Apache Flex. 1- The components: Given we've got progress component and we haven't got any dual slider (Spark Mobile) and yours looks very nice, I would personaly go at least for the latter, but I'm not only by myself and I not sure about the policies we've got regarding how we choose the components they could be donated. 2- For the license, it depends, from what I've seen from now (most of that was writen before by Alex Harui for other donations): The ASF has a policy to not take software regardless of the license unless the copyright holder grants it. By signing the ICLA you have indicated that you have permission from the copyright holder to make any contributions that you make. I think steps are to file ICLAs [1], and a CCLA [2] if there is a corporate entity involved. Then fill out the software grant [3]. 3- The donation process: 1. You fill out and sign all legal documents 2. Some of us will review the code (it can be given via a zip associated to a JIRA ticket). If it looks ok, we will start the committer approval process for you. Takes a minimum of 3 business days. 3. We discuss where this code should land, the package names. 4. Once the software grant is recorded, someone can check the code into SVN. 5. Once it is in, it gets another review. This means making sure there are no binaries, that the headers are correct, that your copyrights (but not any third-party copyrights) are moved to the NOTICES file (which must be done by you or with your explicit permission). 6. Based on 3, all kinds of good stuff happens. -Fred [1] http://www.apache.org/licenses/icla.txt [2] http://www.apache.org/licenses/cla-corporate.txt [3] http://www.apache.org/licenses/software-grant.txt -Message d'origine- From: Jérémy Reynaud Sent: Monday, March 11, 2013 3:01 PM To: dev@flex.apache.org Subject: Components donation Hi, I’m Jérémy Reynaud, CTO and co-founder of KeepCore, company based in Montpellier, France. We propose commercial FLEX components on our dedicated website: http://www.flex-component.com/ We recently think about releasing some of them on the website for free. But maybe another and better solution could be to donate them to the Apache FLEX community. So here are my questions: - Does it make sense? Do you think these components are interesting for the community? - If yes, what is the process to donate them? The components are: - A dual slider (Spark Mobile), demo: http://www.flex-component.com/demo/apache/KCDualSliderV1.1/ - A progress spinner / “super” busy indicator (Spark Mobile), demo: http://www.flex-component.com/demo/apache/KCProgressSpinnerV1.1/ Thanks for your answers. Best regards, Jérémy -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
Re: Web site content need updating SVN - Git
Thanks. I changed it. On Apr 15, 2013, at 2:57 PM, Frédéric THOMAS wrote: 'git format-patch BRANCH --stdout FLEX-007.patch' where BRANCH is the branch you want your patch be merged into from whether the branch you're working on, you can omit it if the origin and destination branch are the same and FLEX-007, the Jira Issue Id relative to your patch. -Fred -Message d'origine- From: Harbs Sent: Monday, April 15, 2013 12:33 PM To: dev@flex.apache.org Subject: Re: Web site content need updating SVN - Git Yeah. I was wondering about that. In the meanwhile, I published it. If someone with more git knowhow wants to change that, feel free… ;-) On Apr 15, 2013, at 12:31 PM, Justin Mclean wrote: HI, Please check my corrections before I publish it: http://flex.staging.apache.org/community-getinvolved.html I go ahead and publish it has to better than what was there before :-) Perhaps someone can commit on git show vs git format-patch as I'm not sure what the best way of doing it. Thanks, Justin
Re: Git equiv of viewvc?
Nice! I'll add this to the web page… On Apr 15, 2013, at 2:37 PM, Frédéric THOMAS wrote: Now we have FishEye, https://fisheye6.atlassian.com/browse/flex-sdk and https://fisheye6.atlassian.com/graph/flex-sdk should give you what you need -Fred -Message d'origine- From: Cyrill Zadra Sent: Monday, April 15, 2013 12:29 PM To: dev@flex.apache.org Subject: Re: Git equiv of viewvc? On bottom of page https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git all branches are listed. Click tree on develop an you'll be there :-). On 15.04.2013, at 16:07, Justin Mclean jus...@classsoftware.com wrote: Hi, What is about https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git That better. and for branch 'develop' https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git;a=tree;h=refs/heads/develop;hb=develop ? Sadly clicking on summary takes you off the develop branch. How did you navigate to the develop branch in the first place? Anyway we can change it so that it shows develop by default? Thanks, Justin
[DISCUSS] Components donation (was: Components donation)
Hi all, Jérémy Reynaud, CTO and co-founder of KeepCore, proposes to donated 2 of their components [1], a dual slider[2] and a progress spinner[3], is there any interests accepting those components as part of the Flex-sdk ? I personally think the DualSlider could be a great addition, maybe the ProgressSpinner too, those components have been world wide tested since a good amount of time already (see the first post of the previous thread). Thoughts ? Thanks, -Fred [1] http://www.flex-component.com/ [2] http://www.flex-component.com/demo/apache/KCDualSliderV1.1/ [3] http://www.flex-component.com/demo/apache/KCProgressSpinnerV1.1/ -Message d'origine- From: Erik de Bruin Sent: Monday, April 15, 2013 2:15 PM To: dev@flex.apache.org Subject: Re: Components donation I don't think a VOTE is strictly necessary. A DISCUSS might be nice, though. Also, we need to make sure all legal obligations are met and all proper documents are filed. When in doubt, we need to check with Apache's legal department, I think. EdB On Mon, Apr 15, 2013 at 2:08 PM, Frédéric THOMAS webdoubl...@hotmail.com wrote: Hi guys, Is there someone who can indicate the next steps or if we need a vote before accepting any new components ? Thanks, -Fred -Message d'origine- From: Frédéric THOMAS Sent: Tuesday, March 12, 2013 10:01 AM To: dev@flex.apache.org Subject: Re: Components donation Hi Jérémy, Everybody is busy at the moment, I guess that's the reason why you haven't got so much returns but in few days, I'll put back this thread on the top. Thanks, -Fred -Message d'origine- From: Jérémy Reynaud Sent: Tuesday, March 12, 2013 9:49 AM To: dev@flex.apache.org Subject: RE: Components donation Thanks for your feedbacks and answers. We will start the process soon. Jérémy -Message d'origine- De : Frédéric THOMAS [mailto:webdoubl...@hotmail.com] Envoyé : lundi 11 mars 2013 15:49 À : dev@flex.apache.org Objet : Re: Components donation Jérémy, Note: I gave you a quick answer, like that you can have a good overview of the process but more precise details will be given by our PMCs probably later today. Thanks, -Fred -Message d'origine- From: Frédéric THOMAS Sent: Monday, March 11, 2013 3:37 PM To: dev@flex.apache.org Subject: Re: Components donation Hi Jérémy, First, thank you for your interest donating those components to Apache Flex. 1- The components: Given we've got progress component and we haven't got any dual slider (Spark Mobile) and yours looks very nice, I would personaly go at least for the latter, but I'm not only by myself and I not sure about the policies we've got regarding how we choose the components they could be donated. 2- For the license, it depends, from what I've seen from now (most of that was writen before by Alex Harui for other donations): The ASF has a policy to not take software regardless of the license unless the copyright holder grants it. By signing the ICLA you have indicated that you have permission from the copyright holder to make any contributions that you make. I think steps are to file ICLAs [1], and a CCLA [2] if there is a corporate entity involved. Then fill out the software grant [3]. 3- The donation process: 1. You fill out and sign all legal documents 2. Some of us will review the code (it can be given via a zip associated to a JIRA ticket). If it looks ok, we will start the committer approval process for you. Takes a minimum of 3 business days. 3. We discuss where this code should land, the package names. 4. Once the software grant is recorded, someone can check the code into SVN. 5. Once it is in, it gets another review. This means making sure there are no binaries, that the headers are correct, that your copyrights (but not any third-party copyrights) are moved to the NOTICES file (which must be done by you or with your explicit permission). 6. Based on 3, all kinds of good stuff happens. -Fred [1] http://www.apache.org/licenses/icla.txt [2] http://www.apache.org/licenses/cla-corporate.txt [3] http://www.apache.org/licenses/software-grant.txt -Message d'origine- From: Jérémy Reynaud Sent: Monday, March 11, 2013 3:01 PM To: dev@flex.apache.org Subject: Components donation Hi, I’m Jérémy Reynaud, CTO and co-founder of KeepCore, company based in Montpellier, France. We propose commercial FLEX components on our dedicated website: http://www.flex-component.com/ We recently think about releasing some of them on the website for free. But maybe another and better solution could be to donate them to the Apache FLEX community. So here are my questions: - Does it make sense? Do you think these components are interesting for the community? - If yes, what is the process to donate them? The components are: - A dual slider (Spark Mobile), demo: http://www.flex-component.com/demo/apache/KCDualSliderV1.1/ - A progress spinner / “super” busy indicator (Spark Mobile), demo:
Re: Git equiv of viewvc?
I just noticed from the commit you just did, that you send the user to the commit graph history instead of the file browsing link. -Fred -Message d'origine- From: Harbs Sent: Monday, April 15, 2013 2:21 PM To: dev@flex.apache.org Subject: Re: Git equiv of viewvc? Nice! I'll add this to the web page… On Apr 15, 2013, at 2:37 PM, Frédéric THOMAS wrote: Now we have FishEye, https://fisheye6.atlassian.com/browse/flex-sdk and https://fisheye6.atlassian.com/graph/flex-sdk should give you what you need -Fred -Message d'origine- From: Cyrill Zadra Sent: Monday, April 15, 2013 12:29 PM To: dev@flex.apache.org Subject: Re: Git equiv of viewvc? On bottom of page https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git all branches are listed. Click tree on develop an you'll be there :-). On 15.04.2013, at 16:07, Justin Mclean jus...@classsoftware.com wrote: Hi, What is about https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git That better. and for branch 'develop' https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git;a=tree;h=refs/heads/develop;hb=develop ? Sadly clicking on summary takes you off the develop branch. How did you navigate to the develop branch in the first place? Anyway we can change it so that it shows develop by default? Thanks, Justin
Re: Git equiv of viewvc?
Yes. Is that a problem? On Apr 15, 2013, at 3:39 PM, Frédéric THOMAS wrote: I just noticed from the commit you just did, that you send the user to the commit graph history instead of the file browsing link. -Fred -Message d'origine- From: Harbs Sent: Monday, April 15, 2013 2:21 PM To: dev@flex.apache.org Subject: Re: Git equiv of viewvc? Nice! I'll add this to the web page… On Apr 15, 2013, at 2:37 PM, Frédéric THOMAS wrote: Now we have FishEye, https://fisheye6.atlassian.com/browse/flex-sdk and https://fisheye6.atlassian.com/graph/flex-sdk should give you what you need -Fred -Message d'origine- From: Cyrill Zadra Sent: Monday, April 15, 2013 12:29 PM To: dev@flex.apache.org Subject: Re: Git equiv of viewvc? On bottom of page https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git all branches are listed. Click tree on develop an you'll be there :-). On 15.04.2013, at 16:07, Justin Mclean jus...@classsoftware.com wrote: Hi, What is about https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git That better. and for branch 'develop' https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git;a=tree;h=refs/heads/develop;hb=develop ? Sadly clicking on summary takes you off the develop branch. How did you navigate to the develop branch in the first place? Anyway we can change it so that it shows develop by default? Thanks, Justin
Re: Git equiv of viewvc?
I think you can tell them to review the commit history, in that case, the link you provided is ok, or you keep what you wrote and send them to the browse link, just swap graph with browse in the link you provided. -Fred -Message d'origine- From: Harbs Sent: Monday, April 15, 2013 2:42 PM To: dev@flex.apache.org Subject: Re: Git equiv of viewvc? Yes. Is that a problem? On Apr 15, 2013, at 3:39 PM, Frédéric THOMAS wrote: I just noticed from the commit you just did, that you send the user to the commit graph history instead of the file browsing link. -Fred -Message d'origine- From: Harbs Sent: Monday, April 15, 2013 2:21 PM To: dev@flex.apache.org Subject: Re: Git equiv of viewvc? Nice! I'll add this to the web page… On Apr 15, 2013, at 2:37 PM, Frédéric THOMAS wrote: Now we have FishEye, https://fisheye6.atlassian.com/browse/flex-sdk and https://fisheye6.atlassian.com/graph/flex-sdk should give you what you need -Fred -Message d'origine- From: Cyrill Zadra Sent: Monday, April 15, 2013 12:29 PM To: dev@flex.apache.org Subject: Re: Git equiv of viewvc? On bottom of page https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git all branches are listed. Click tree on develop an you'll be there :-). On 15.04.2013, at 16:07, Justin Mclean jus...@classsoftware.com wrote: Hi, What is about https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git That better. and for branch 'develop' https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git;a=tree;h=refs/heads/develop;hb=develop ? Sadly clicking on summary takes you off the develop branch. How did you navigate to the develop branch in the first place? Anyway we can change it so that it shows develop by default? Thanks, Justin
Re: Git equiv of viewvc?
Well, I did write project progress. ;-) If you think commit history is better, I'll be happy to change it. I thought a generalized term was more accurate. The reason I linked to the graph was that I thought the graph is a nice visualization and it's more obvious how to get to the file view from the graph than vice versa. On Apr 15, 2013, at 3:53 PM, Frédéric THOMAS wrote: I think you can tell them to review the commit history, in that case, the link you provided is ok, or you keep what you wrote and send them to the browse link, just swap graph with browse in the link you provided. -Fred -Message d'origine- From: Harbs Sent: Monday, April 15, 2013 2:42 PM To: dev@flex.apache.org Subject: Re: Git equiv of viewvc? Yes. Is that a problem? On Apr 15, 2013, at 3:39 PM, Frédéric THOMAS wrote: I just noticed from the commit you just did, that you send the user to the commit graph history instead of the file browsing link. -Fred -Message d'origine- From: Harbs Sent: Monday, April 15, 2013 2:21 PM To: dev@flex.apache.org Subject: Re: Git equiv of viewvc? Nice! I'll add this to the web page… On Apr 15, 2013, at 2:37 PM, Frédéric THOMAS wrote: Now we have FishEye, https://fisheye6.atlassian.com/browse/flex-sdk and https://fisheye6.atlassian.com/graph/flex-sdk should give you what you need -Fred -Message d'origine- From: Cyrill Zadra Sent: Monday, April 15, 2013 12:29 PM To: dev@flex.apache.org Subject: Re: Git equiv of viewvc? On bottom of page https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git all branches are listed. Click tree on develop an you'll be there :-). On 15.04.2013, at 16:07, Justin Mclean jus...@classsoftware.com wrote: Hi, What is about https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git That better. and for branch 'develop' https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git;a=tree;h=refs/heads/develop;hb=develop ? Sadly clicking on summary takes you off the develop branch. How did you navigate to the develop branch in the first place? Anyway we can change it so that it shows develop by default? Thanks, Justin
Re: [DISCUSS] Components donation (was: Components donation)
I agree. Harbs On Apr 15, 2013, at 3:31 PM, Frédéric THOMAS wrote: Hi all, Jérémy Reynaud, CTO and co-founder of KeepCore, proposes to donated 2 of their components [1], a dual slider[2] and a progress spinner[3], is there any interests accepting those components as part of the Flex-sdk ? I personally think the DualSlider could be a great addition, maybe the ProgressSpinner too, those components have been world wide tested since a good amount of time already (see the first post of the previous thread). Thoughts ? Thanks, -Fred [1] http://www.flex-component.com/ [2] http://www.flex-component.com/demo/apache/KCDualSliderV1.1/ [3] http://www.flex-component.com/demo/apache/KCProgressSpinnerV1.1/ -Message d'origine- From: Erik de Bruin Sent: Monday, April 15, 2013 2:15 PM To: dev@flex.apache.org Subject: Re: Components donation I don't think a VOTE is strictly necessary. A DISCUSS might be nice, though. Also, we need to make sure all legal obligations are met and all proper documents are filed. When in doubt, we need to check with Apache's legal department, I think. EdB On Mon, Apr 15, 2013 at 2:08 PM, Frédéric THOMAS webdoubl...@hotmail.com wrote: Hi guys, Is there someone who can indicate the next steps or if we need a vote before accepting any new components ? Thanks, -Fred -Message d'origine- From: Frédéric THOMAS Sent: Tuesday, March 12, 2013 10:01 AM To: dev@flex.apache.org Subject: Re: Components donation Hi Jérémy, Everybody is busy at the moment, I guess that's the reason why you haven't got so much returns but in few days, I'll put back this thread on the top. Thanks, -Fred -Message d'origine- From: Jérémy Reynaud Sent: Tuesday, March 12, 2013 9:49 AM To: dev@flex.apache.org Subject: RE: Components donation Thanks for your feedbacks and answers. We will start the process soon. Jérémy -Message d'origine- De : Frédéric THOMAS [mailto:webdoubl...@hotmail.com] Envoyé : lundi 11 mars 2013 15:49 À : dev@flex.apache.org Objet : Re: Components donation Jérémy, Note: I gave you a quick answer, like that you can have a good overview of the process but more precise details will be given by our PMCs probably later today. Thanks, -Fred -Message d'origine- From: Frédéric THOMAS Sent: Monday, March 11, 2013 3:37 PM To: dev@flex.apache.org Subject: Re: Components donation Hi Jérémy, First, thank you for your interest donating those components to Apache Flex. 1- The components: Given we've got progress component and we haven't got any dual slider (Spark Mobile) and yours looks very nice, I would personaly go at least for the latter, but I'm not only by myself and I not sure about the policies we've got regarding how we choose the components they could be donated. 2- For the license, it depends, from what I've seen from now (most of that was writen before by Alex Harui for other donations): The ASF has a policy to not take software regardless of the license unless the copyright holder grants it. By signing the ICLA you have indicated that you have permission from the copyright holder to make any contributions that you make. I think steps are to file ICLAs [1], and a CCLA [2] if there is a corporate entity involved. Then fill out the software grant [3]. 3- The donation process: 1. You fill out and sign all legal documents 2. Some of us will review the code (it can be given via a zip associated to a JIRA ticket). If it looks ok, we will start the committer approval process for you. Takes a minimum of 3 business days. 3. We discuss where this code should land, the package names. 4. Once the software grant is recorded, someone can check the code into SVN. 5. Once it is in, it gets another review. This means making sure there are no binaries, that the headers are correct, that your copyrights (but not any third-party copyrights) are moved to the NOTICES file (which must be done by you or with your explicit permission). 6. Based on 3, all kinds of good stuff happens. -Fred [1] http://www.apache.org/licenses/icla.txt [2] http://www.apache.org/licenses/cla-corporate.txt [3] http://www.apache.org/licenses/software-grant.txt -Message d'origine- From: Jérémy Reynaud Sent: Monday, March 11, 2013 3:01 PM To: dev@flex.apache.org Subject: Components donation Hi, I’m Jérémy Reynaud, CTO and co-founder of KeepCore, company based in Montpellier, France. We propose commercial FLEX components on our dedicated website: http://www.flex-component.com/ We recently think about releasing some of them on the website for free. But maybe another and better solution could be to donate them to the Apache FLEX community. So here are my questions: - Does it make sense? Do you think these components are interesting for the community? - If yes, what is the process to donate them?
Re: Git merge of README and RELEASE_NOTES
From your clean develop branch: git checkout origin/release4.9 RELEASE_NOTES FILE2 FILEX git commit -m Merge RELEASE_NOTES, etc.. from release4.9 branch git push -Message d'origine- From: Justin Mclean Sent: Monday, April 15, 2013 10:26 AM To: dev@flex.apache.org Subject: Git merge of README and RELEASE_NOTES Hi, Can someone go through the git steps required to merge the READ and RELEASE_NOTES files in the 4.9.1 branch into the current develop branch. Thanks, Justin
Re: Git equiv of viewvc?
As you like. -Fred -Message d'origine- From: Harbs Sent: Monday, April 15, 2013 3:04 PM To: dev@flex.apache.org Subject: Re: Git equiv of viewvc? Well, I did write project progress. ;-) If you think commit history is better, I'll be happy to change it. I thought a generalized term was more accurate. The reason I linked to the graph was that I thought the graph is a nice visualization and it's more obvious how to get to the file view from the graph than vice versa. On Apr 15, 2013, at 3:53 PM, Frédéric THOMAS wrote: I think you can tell them to review the commit history, in that case, the link you provided is ok, or you keep what you wrote and send them to the browse link, just swap graph with browse in the link you provided. -Fred -Message d'origine- From: Harbs Sent: Monday, April 15, 2013 2:42 PM To: dev@flex.apache.org Subject: Re: Git equiv of viewvc? Yes. Is that a problem? On Apr 15, 2013, at 3:39 PM, Frédéric THOMAS wrote: I just noticed from the commit you just did, that you send the user to the commit graph history instead of the file browsing link. -Fred -Message d'origine- From: Harbs Sent: Monday, April 15, 2013 2:21 PM To: dev@flex.apache.org Subject: Re: Git equiv of viewvc? Nice! I'll add this to the web page… On Apr 15, 2013, at 2:37 PM, Frédéric THOMAS wrote: Now we have FishEye, https://fisheye6.atlassian.com/browse/flex-sdk and https://fisheye6.atlassian.com/graph/flex-sdk should give you what you need -Fred -Message d'origine- From: Cyrill Zadra Sent: Monday, April 15, 2013 12:29 PM To: dev@flex.apache.org Subject: Re: Git equiv of viewvc? On bottom of page https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git all branches are listed. Click tree on develop an you'll be there :-). On 15.04.2013, at 16:07, Justin Mclean jus...@classsoftware.com wrote: Hi, What is about https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git That better. and for branch 'develop' https://git-wip-us.apache.org/repos/asf?p=flex-sdk.git;a=tree;h=refs/heads/develop;hb=develop ? Sadly clicking on summary takes you off the develop branch. How did you navigate to the develop branch in the first place? Anyway we can change it so that it shows develop by default? Thanks, Justin
[FalconJX] JSGoogEmitter.emitMethod
HI Erik Got following scenario: public function TestClass() { super(); } JSGoogEmiter produces following javascript - /** * @constructor */ TestClass = function() { var self = this; goog.base(this); }; .. which produces a google closure error - ERROR - incorrect use of goog.base: Could not find goog.inherits for base class So I'm looking for a way where goog.base is only written if TestClass has a superClass and I found the implementation for the output in emitMethod... don't want to offend you.. but with all those conditions in this method I'm a little confused .. can't we somehow seperate method and constructor case? Cyrill
Re: [FalconJx] JSGoogEmitter ClasstCastException
Yep .. try to help you out. Cyrill On Mon, Apr 15, 2013 at 4:14 PM, Erik de Bruin e...@ixsoftware.nl wrote: Cyrill, Excellent contribution, thank you. While you're on a roll, would you mind having a look at some of the ToDo's scattered throughout the code? Only one technical detail: if you're using Eclipse, can you please use this 'formatter' before committing code: https://issues.apache.org/jira/browse/FLEX-33485 There are some whitespace issues with your commit that will confuse the diffs between committers. EdB On Sun, Apr 14, 2013 at 7:04 PM, Cyrill Zadra cyrill.za...@gmail.com wrote: Hi Just pushed a fix to develop branch which fixes a ClassCastException for following scenario. package vo { public interface ITestInterface { } } package vo { public class TestObject implements ITestInterface { public function TestObject() { } } } Erik you may have a review look at it ;-) Cyrill -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
Re: [FalconJX] JSGoogEmitter.emitMethod
Cyrill, I'm (usually) not easily offended ;-) My code is written in a whatever gets me there first style, so if you want to break it up, please feel free to refactor! On the topic of your code: will such code ever come from Flash Builder (or another IDE)? I mean: the code calls super(), but there is no super class... Not saying we shouldn't handle this properly, just want to make sure I understand the test case. EdB On Mon, Apr 15, 2013 at 3:17 PM, Cyrill Zadra cyrill.za...@gmail.com wrote: HI Erik Got following scenario: public function TestClass() { super(); } JSGoogEmiter produces following javascript - /** * @constructor */ TestClass = function() { var self = this; goog.base(this); }; .. which produces a google closure error - ERROR - incorrect use of goog.base: Could not find goog.inherits for base class So I'm looking for a way where goog.base is only written if TestClass has a superClass and I found the implementation for the output in emitMethod... don't want to offend you.. but with all those conditions in this method I'm a little confused .. can't we somehow seperate method and constructor case? Cyrill -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
Re: [FalconJX] JSGoogEmitter.emitMethod
Cool ... I'll give it a try :-) On the topic of your code: will such code ever come from Flash Builder (or another IDE)? I mean: the code calls super(), but there is no super class... Not saying we shouldn't handle this properly, just want to make sure I understand the test case. Yes from FlashBuilder ... Its actually class mx.logging.AbstractTarget.as from apache flex sdk. Cyrill
Re: [FalconJX] JSGoogEmitter.emitMethod
See, I'd never have thought to look that deep into the abyss of the SDK :-) Go forth and fix! :) EdB On Mon, Apr 15, 2013 at 4:29 PM, Cyrill Zadra cyrill.za...@gmail.com wrote: Cool ... I'll give it a try :-) On the topic of your code: will such code ever come from Flash Builder (or another IDE)? I mean: the code calls super(), but there is no super class... Not saying we shouldn't handle this properly, just want to make sure I understand the test case. Yes from FlashBuilder ... Its actually class mx.logging.AbstractTarget.as from apache flex sdk. Cyrill -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
Re: [FalconJS] populating the 'id' property at runtime
There are issues with the id of elements in HTML being unique. If they are not unique, they seem to have a negative affect on screen readers. I don't know if that would be a reason to disabled that, but it's something to know. It's for this reason (and the fact that document.getElementById only returns one element, not a collection even if there are more than one elements with the same id) that ASP.NET messes with all of your ids in a control (which ends up being extremely annoying down stream). As an alternative to using the browser's native id attribute (in cases where that might be a problem) you can use a data attribute: input data-flex-id=myid Kevin N. On 4/15/13 5:25 AM, Tigran Najaryan wrote: I am trying to understand how to make sure the 'id' property is available on the DOM elements. It looks like if I simply modify function org.apache.flex.core.UIBase.prototype.set_id() to directly assign the 'value' to this.element.id it works, the id property becomes available at runtime and is shown by Firebug. Is there a reason why set_id() currently does not do it? If this modification is acceptable I will submit a patch. Tigran.
Re: [FalconJS] populating the 'id' property at runtime
As an alternative to using the browser's native id attribute (in cases where that might be a problem) you can use a data attribute: input data-flex-id=myid That sounds like the proper way to do this, if RIATest can run on that type of attributes. I didn't check, but doesn't the compiler on the Flash side mind if you try to use the same id twice? EdB -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
Re: [DISCUSS] Components donation (was: Components donation)
+ 1, the dual slider looks very nice and useful, arnoud On 15-04-2013, at 15:05, Harbs harbs.li...@gmail.com wrote: I agree. Harbs On Apr 15, 2013, at 3:31 PM, Frédéric THOMAS wrote: Hi all, Jérémy Reynaud, CTO and co-founder of KeepCore, proposes to donated 2 of their components [1], a dual slider[2] and a progress spinner[3], is there any interests accepting those components as part of the Flex-sdk ? I personally think the DualSlider could be a great addition, maybe the ProgressSpinner too, those components have been world wide tested since a good amount of time already (see the first post of the previous thread). Thoughts ? Thanks, -Fred [1] http://www.flex-component.com/ [2] http://www.flex-component.com/demo/apache/KCDualSliderV1.1/ [3] http://www.flex-component.com/demo/apache/KCProgressSpinnerV1.1/ -Message d'origine- From: Erik de Bruin Sent: Monday, April 15, 2013 2:15 PM To: dev@flex.apache.org Subject: Re: Components donation I don't think a VOTE is strictly necessary. A DISCUSS might be nice, though. Also, we need to make sure all legal obligations are met and all proper documents are filed. When in doubt, we need to check with Apache's legal department, I think. EdB On Mon, Apr 15, 2013 at 2:08 PM, Frédéric THOMAS webdoubl...@hotmail.com wrote: Hi guys, Is there someone who can indicate the next steps or if we need a vote before accepting any new components ? Thanks, -Fred -Message d'origine- From: Frédéric THOMAS Sent: Tuesday, March 12, 2013 10:01 AM To: dev@flex.apache.org Subject: Re: Components donation Hi Jérémy, Everybody is busy at the moment, I guess that's the reason why you haven't got so much returns but in few days, I'll put back this thread on the top. Thanks, -Fred -Message d'origine- From: Jérémy Reynaud Sent: Tuesday, March 12, 2013 9:49 AM To: dev@flex.apache.org Subject: RE: Components donation Thanks for your feedbacks and answers. We will start the process soon. Jérémy -Message d'origine- De : Frédéric THOMAS [mailto:webdoubl...@hotmail.com] Envoyé : lundi 11 mars 2013 15:49 À : dev@flex.apache.org Objet : Re: Components donation Jérémy, Note: I gave you a quick answer, like that you can have a good overview of the process but more precise details will be given by our PMCs probably later today. Thanks, -Fred -Message d'origine- From: Frédéric THOMAS Sent: Monday, March 11, 2013 3:37 PM To: dev@flex.apache.org Subject: Re: Components donation Hi Jérémy, First, thank you for your interest donating those components to Apache Flex. 1- The components: Given we've got progress component and we haven't got any dual slider (Spark Mobile) and yours looks very nice, I would personaly go at least for the latter, but I'm not only by myself and I not sure about the policies we've got regarding how we choose the components they could be donated. 2- For the license, it depends, from what I've seen from now (most of that was writen before by Alex Harui for other donations): The ASF has a policy to not take software regardless of the license unless the copyright holder grants it. By signing the ICLA you have indicated that you have permission from the copyright holder to make any contributions that you make. I think steps are to file ICLAs [1], and a CCLA [2] if there is a corporate entity involved. Then fill out the software grant [3]. 3- The donation process: 1. You fill out and sign all legal documents 2. Some of us will review the code (it can be given via a zip associated to a JIRA ticket). If it looks ok, we will start the committer approval process for you. Takes a minimum of 3 business days. 3. We discuss where this code should land, the package names. 4. Once the software grant is recorded, someone can check the code into SVN. 5. Once it is in, it gets another review. This means making sure there are no binaries, that the headers are correct, that your copyrights (but not any third-party copyrights) are moved to the NOTICES file (which must be done by you or with your explicit permission). 6. Based on 3, all kinds of good stuff happens. -Fred [1] http://www.apache.org/licenses/icla.txt [2] http://www.apache.org/licenses/cla-corporate.txt [3] http://www.apache.org/licenses/software-grant.txt -Message d'origine- From: Jérémy Reynaud Sent: Monday, March 11, 2013 3:01 PM To: dev@flex.apache.org Subject: Components donation Hi, I’m Jérémy Reynaud, CTO and co-founder of KeepCore, company based in Montpellier, France. We propose commercial FLEX components on our dedicated website: http://www.flex-component.com/ We recently think about releasing some of them on the website for free. But maybe another and better solution could be to donate them to the Apache FLEX community. So here are my questions: - Does it make
Re: Meet 'marmotinni', an ASJS testing framework
On 4/15/13 12:39 AM, Tigran Najaryan tig...@gmail.com wrote: OK, but given that we trans-compile AS to JS and your test language is ES- like, there is no way to wrap things so they work? I don't think so. The problem is that tests on Flex apps compiled to SWF use action names specific to each component (usually corresponding to appropriate Flex event names) as defined by Flex Automation framework. For example to open a ComboBox and select an item you do something like this in RIATest: OK, but FlexJS is essentially wrapping JS constructs and presenting them in AS. The goal for the components is the present the same APIs to the developer by wrapping and emulating where appropriate. So, forget what the current Flex Automation API does. If you had a chance to design a new automation API for FlexJS where the components are already wrapping (that uses plug-ins), could it be done? -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: [DISCUSS] Components donation (was: Components donation)
On Apr 15, 2013 8:02 AM, Alex Harui aha...@adobe.com wrote: Fine with me. FWIW, I think we do need an official vote. My current understanding is that the only non-committer contributions that don't need a vote are patches. I am sorry, but I don't think that is a vote is required. Can you point us to some policy or discussion threads regarding this, where you think this decision was made? And what if a new component is submitted via a patch? Which category would that fall under? Thanks, Om On 4/15/13 6:05 AM, Harbs harbs.li...@gmail.com wrote: I agree. Harbs On Apr 15, 2013, at 3:31 PM, Frédéric THOMAS wrote: Hi all, Jérémy Reynaud, CTO and co-founder of KeepCore, proposes to donated 2 of their components [1], a dual slider[2] and a progress spinner[3], is there any interests accepting those components as part of the Flex-sdk ? I personally think the DualSlider could be a great addition, maybe the ProgressSpinner too, those components have been world wide tested since a good amount of time already (see the first post of the previous thread). Thoughts ? Thanks, -Fred [1] http://www.flex-component.com/ [2] http://www.flex-component.com/demo/apache/KCDualSliderV1.1/ [3] http://www.flex-component.com/demo/apache/KCProgressSpinnerV1.1/ -Message d'origine- From: Erik de Bruin Sent: Monday, April 15, 2013 2:15 PM To: dev@flex.apache.org Subject: Re: Components donation I don't think a VOTE is strictly necessary. A DISCUSS might be nice, though. Also, we need to make sure all legal obligations are met and all proper documents are filed. When in doubt, we need to check with Apache's legal department, I think. EdB On Mon, Apr 15, 2013 at 2:08 PM, Frédéric THOMAS webdoubl...@hotmail.com wrote: Hi guys, Is there someone who can indicate the next steps or if we need a vote before accepting any new components ? Thanks, -Fred -Message d'origine- From: Frédéric THOMAS Sent: Tuesday, March 12, 2013 10:01 AM To: dev@flex.apache.org Subject: Re: Components donation Hi Jérémy, Everybody is busy at the moment, I guess that's the reason why you haven't got so much returns but in few days, I'll put back this thread on the top. Thanks, -Fred -Message d'origine- From: Jérémy Reynaud Sent: Tuesday, March 12, 2013 9:49 AM To: dev@flex.apache.org Subject: RE: Components donation Thanks for your feedbacks and answers. We will start the process soon. Jérémy -Message d'origine- De : Frédéric THOMAS [mailto:webdoubl...@hotmail.com] Envoyé : lundi 11 mars 2013 15:49 À : dev@flex.apache.org Objet : Re: Components donation Jérémy, Note: I gave you a quick answer, like that you can have a good overview of the process but more precise details will be given by our PMCs probably later today. Thanks, -Fred -Message d'origine- From: Frédéric THOMAS Sent: Monday, March 11, 2013 3:37 PM To: dev@flex.apache.org Subject: Re: Components donation Hi Jérémy, First, thank you for your interest donating those components to Apache Flex. 1- The components: Given we've got progress component and we haven't got any dual slider (Spark Mobile) and yours looks very nice, I would personaly go at least for the latter, but I'm not only by myself and I not sure about the policies we've got regarding how we choose the components they could be donated. 2- For the license, it depends, from what I've seen from now (most of that was writen before by Alex Harui for other donations): The ASF has a policy to not take software regardless of the license unless the copyright holder grants it. By signing the ICLA you have indicated that you have permission from the copyright holder to make any contributions that you make. I think steps are to file ICLAs [1], and a CCLA [2] if there is a corporate entity involved. Then fill out the software grant [3]. 3- The donation process: 1. You fill out and sign all legal documents 2. Some of us will review the code (it can be given via a zip associated to a JIRA ticket). If it looks ok, we will start the committer approval process for you. Takes a minimum of 3 business days. 3. We discuss where this code should land, the package names. 4. Once the software grant is recorded, someone can check the code into SVN. 5. Once it is in, it gets another review. This means making sure there are no binaries, that the headers are correct, that your copyrights (but not any third-party copyrights) are moved to the NOTICES file (which must be done by you or with your explicit permission). 6. Based on 3, all kinds of good stuff happens. -Fred [1] http://www.apache.org/licenses/icla.txt [2] http://www.apache.org/licenses/cla-corporate.txt [3] http://www.apache.org/licenses/software-grant.txt -Message d'origine-
Re: CS Extensions
FWIW, Adobe made the CS extension for PS available here: http://download.macromedia.com/pub/photoshop/photoshopcs5_fxg_p2_mac_093010. zxp http://download.macromedia.com/pub/photoshop/photoshopcs5_fxg_p2_win32_09301 0.zxp http://download.macromedia.com/pub/photoshop/photoshopcs5_fxg_p2_win64_09301 0.zxp http://download.macromedia.com/pub/photoshop/photoshopcs5_fxg_p3_mac_050311. zxp http://download.macromedia.com/pub/photoshop/photoshopcs5_fxg_p3_win32_05031 1.zxp http://download.macromedia.com/pub/photoshop/photoshopcs5_fxg_p3_win64_05031 1.zxp I have no idea what is in these downloads or what is the right version for you, so good luck. -Alex On 4/15/13 12:42 AM, OmPrakash Muppirala bigosma...@gmail.com wrote: Exciting stuff! I would love to help you on this one, time permitting. On Mon, Apr 15, 2013 at 12:35 AM, Harbs harbs.li...@gmail.com wrote: I'd like to start that project to export FXG from creative suite apps. Some questions: 1) Should I start this on a personal github account, or have we settled on something else? What do you think of the flex-utilities git repo? 2) CS Extensions have dependencies on a number of Adobe swcs. How do we handle the project vis a vis Apache's policies and binaries? I don't think those dependencies can be includedŠ We can always have a build script that downloads the required external dependencies. As long as they are of compatible licenses and we dont check them into our repos, we should be fine. After all, the Flex SDK depends on Flash Player, AIR, Batik, etc. The build script just downloads them for the user (after a license confirmation) Please let me know how I can help. Thanks, Om -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: [DISCUSS] Components donation (was: Components donation)
What if some components are or are not willed by some of us, a decision as to be taken, maybe a lazy vote could stand ? -Fred -Message d'origine- From: OmPrakash Muppirala Sent: Monday, April 15, 2013 5:09 PM To: dev@flex.apache.org Subject: Re: [DISCUSS] Components donation (was: Components donation) On Apr 15, 2013 8:02 AM, Alex Harui aha...@adobe.com wrote: Fine with me. FWIW, I think we do need an official vote. My current understanding is that the only non-committer contributions that don't need a vote are patches. I am sorry, but I don't think that is a vote is required. Can you point us to some policy or discussion threads regarding this, where you think this decision was made? And what if a new component is submitted via a patch? Which category would that fall under? Thanks, Om On 4/15/13 6:05 AM, Harbs harbs.li...@gmail.com wrote: I agree. Harbs On Apr 15, 2013, at 3:31 PM, Frédéric THOMAS wrote: Hi all, Jérémy Reynaud, CTO and co-founder of KeepCore, proposes to donated 2 of their components [1], a dual slider[2] and a progress spinner[3], is there any interests accepting those components as part of the Flex-sdk ? I personally think the DualSlider could be a great addition, maybe the ProgressSpinner too, those components have been world wide tested since a good amount of time already (see the first post of the previous thread). Thoughts ? Thanks, -Fred [1] http://www.flex-component.com/ [2] http://www.flex-component.com/demo/apache/KCDualSliderV1.1/ [3] http://www.flex-component.com/demo/apache/KCProgressSpinnerV1.1/ -Message d'origine- From: Erik de Bruin Sent: Monday, April 15, 2013 2:15 PM To: dev@flex.apache.org Subject: Re: Components donation I don't think a VOTE is strictly necessary. A DISCUSS might be nice, though. Also, we need to make sure all legal obligations are met and all proper documents are filed. When in doubt, we need to check with Apache's legal department, I think. EdB On Mon, Apr 15, 2013 at 2:08 PM, Frédéric THOMAS webdoubl...@hotmail.com wrote: Hi guys, Is there someone who can indicate the next steps or if we need a vote before accepting any new components ? Thanks, -Fred -Message d'origine- From: Frédéric THOMAS Sent: Tuesday, March 12, 2013 10:01 AM To: dev@flex.apache.org Subject: Re: Components donation Hi Jérémy, Everybody is busy at the moment, I guess that's the reason why you haven't got so much returns but in few days, I'll put back this thread on the top. Thanks, -Fred -Message d'origine- From: Jérémy Reynaud Sent: Tuesday, March 12, 2013 9:49 AM To: dev@flex.apache.org Subject: RE: Components donation Thanks for your feedbacks and answers. We will start the process soon. Jérémy -Message d'origine- De : Frédéric THOMAS [mailto:webdoubl...@hotmail.com] Envoyé : lundi 11 mars 2013 15:49 À : dev@flex.apache.org Objet : Re: Components donation Jérémy, Note: I gave you a quick answer, like that you can have a good overview of the process but more precise details will be given by our PMCs probably later today. Thanks, -Fred -Message d'origine- From: Frédéric THOMAS Sent: Monday, March 11, 2013 3:37 PM To: dev@flex.apache.org Subject: Re: Components donation Hi Jérémy, First, thank you for your interest donating those components to Apache Flex. 1- The components: Given we've got progress component and we haven't got any dual slider (Spark Mobile) and yours looks very nice, I would personaly go at least for the latter, but I'm not only by myself and I not sure about the policies we've got regarding how we choose the components they could be donated. 2- For the license, it depends, from what I've seen from now (most of that was writen before by Alex Harui for other donations): The ASF has a policy to not take software regardless of the license unless the copyright holder grants it. By signing the ICLA you have indicated that you have permission from the copyright holder to make any contributions that you make. I think steps are to file ICLAs [1], and a CCLA [2] if there is a corporate entity involved. Then fill out the software grant [3]. 3- The donation process: 1. You fill out and sign all legal documents 2. Some of us will review the code (it can be given via a zip associated to a JIRA ticket). If it looks ok, we will start the committer approval process for you. Takes a minimum of 3 business days. 3. We discuss where this code should land, the package names. 4. Once the software grant is recorded, someone can check the code into SVN. 5. Once it is in, it gets another review. This means making sure there are no binaries, that the headers are correct, that your copyrights (but not any third-party copyrights) are moved to the NOTICES file (which must be done by you or with your explicit permission). 6. Based on 3,
RE: [DISCUSS] Components donation (was: Components donation)
I'm guessing we are going to need these for the Flex site when we figure them out. 1. Steps / requirements for new components. 2. Steps / requirements for new Features that add onto existing components. -Mark -Original Message- From: omup...@gmail.com [mailto:omup...@gmail.com] On Behalf Of OmPrakash Muppirala Sent: Monday, April 15, 2013 11:09 AM To: dev@flex.apache.org Subject: Re: [DISCUSS] Components donation (was: Components donation) On Apr 15, 2013 8:02 AM, Alex Harui aha...@adobe.com wrote: Fine with me. FWIW, I think we do need an official vote. My current understanding is that the only non-committer contributions that don't need a vote are patches. I am sorry, but I don't think that is a vote is required. Can you point us to some policy or discussion threads regarding this, where you think this decision was made? And what if a new component is submitted via a patch? Which category would that fall under? Thanks, Om
[jira] [Created] (FLEX-33495) Flex FileReference.browse() opens a save dialog in Firefox - NOT an open dialog
James Chow created FLEX-33495: - Summary: Flex FileReference.browse() opens a save dialog in Firefox - NOT an open dialog Key: FLEX-33495 URL: https://issues.apache.org/jira/browse/FLEX-33495 Project: Apache Flex Issue Type: Bug Environment: window 7 firefox Reporter: James Chow FileReference.browse() in IE will open an OPEN dialog but FireFox with latest Flash opens a SAVE dialog. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [FalconJX] JSGoogEmitter.emitMethod
the code calls super(), but there is no super class The implicit superclass is Object. - Gordon Sent from my iPad On Apr 15, 2013, at 7:07 AM, Erik de Bruin e...@ixsoftware.nl wrote: Cyrill, I'm (usually) not easily offended ;-) My code is written in a whatever gets me there first style, so if you want to break it up, please feel free to refactor! On the topic of your code: will such code ever come from Flash Builder (or another IDE)? I mean: the code calls super(), but there is no super class... Not saying we shouldn't handle this properly, just want to make sure I understand the test case. EdB On Mon, Apr 15, 2013 at 3:17 PM, Cyrill Zadra cyrill.za...@gmail.com wrote: HI Erik Got following scenario: public function TestClass() { super(); } JSGoogEmiter produces following javascript - /** * @constructor */ TestClass = function() { var self = this; goog.base(this); }; .. which produces a google closure error - ERROR - incorrect use of goog.base: Could not find goog.inherits for base class So I'm looking for a way where goog.base is only written if TestClass has a superClass and I found the implementation for the output in emitMethod... don't want to offend you.. but with all those conditions in this method I'm a little confused .. can't we somehow seperate method and constructor case? Cyrill -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl
Re: CS Extensions
On 4/15/13 1:19 AM, Harbs harbs.li...@gmail.com wrote: 2) CS Extensions have dependencies on a number of Adobe swcs. How do we handle the project vis a vis Apache's policies and binaries? I don't think those dependencies can be includedŠ We can always have a build script that downloads the required external dependencies. As long as they are of compatible licenses and we dont check them into our repos, we should be fine. After all, the Flex SDK depends on Flash Player, AIR, Batik, etc. The build script just downloads them for the user (after a license confirmation) Please let me know how I can help. There is a difference in the treatment of the Flash Player and AIR SDKs, which do not have Apache compatible licenses and are considered build tools since the SWCs do not have code that goes in the output SWF, and the OSMF.swc which does have a compatible license and whose code might go in the SWF. And yet another treatment for the embedded font library, which does not have a compatible license and therefore must only be used for optional features. Which SWCs are you going to need and/or optionally need and where can we get licensing information on them? -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: [FalconJS] populating the 'id' property at runtime
On 4/15/13 7:45 AM, Erik de Bruin e...@ixsoftware.nl wrote: As an alternative to using the browser's native id attribute (in cases where that might be a problem) you can use a data attribute: input data-flex-id=myid That sounds like the proper way to do this, if RIATest can run on that type of attributes. I didn't check, but doesn't the compiler on the Flash side mind if you try to use the same id twice? Yes, but only with in an MXML file. I think Kevin is pointing out a potential issue where you have several MXML files of which more than one uses the same ID. That's the main reason I didn't wire set_id to the DOM's id: I wasn't sure of the implications. I also was trying to find time to re-read the Web Components/Shadow DOM proposals to understand how id's work there. But realistically, anyone with multiple MXML files trying to make an accessible HTML will probably have to come up with their own scheme to make sure id's are unique within their app. And since we still need a way for folks to set the id in order to get accessibility to work, it might be best for now to just gamble and wire up set_id to the id. No need for a branch. Just do it. I'll try to get someone to think about the accessibility issues. -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
View source
Is there an easy way to enable View Source without FB? -Mark
[jira] [Assigned] (FLEX-33495) Flex FileReference.browse() opens a save dialog in Firefox - NOT an open dialog
[ https://issues.apache.org/jira/browse/FLEX-33495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Kessler reassigned FLEX-33495: --- Assignee: Mark Kessler Flex FileReference.browse() opens a save dialog in Firefox - NOT an open dialog --- Key: FLEX-33495 URL: https://issues.apache.org/jira/browse/FLEX-33495 Project: Apache Flex Issue Type: Bug Environment: window 7 firefox Reporter: James Chow Assignee: Mark Kessler FileReference.browse() in IE will open an OPEN dialog but FireFox with latest Flash opens a SAVE dialog. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
RE: Meet 'marmotinni', an ASJS testing framework
From: Alex Harui [mailto:aha...@adobe.com] OK, but FlexJS is essentially wrapping JS constructs and presenting them in AS. The goal for the components is the present the same APIs to the developer by wrapping and emulating where appropriate. Sorry, I probably miss something but I do not see what does this change from automation point of view. So, forget what the current Flex Automation API does. If you had a chance to design a new automation API for FlexJS where the components are already wrapping (that uses plug-ins), could it be done? The current JS output produces a HTML page at runtime which can be automated by in-browser HTML automation tools. I am not sure there is a need for separate automation API. I think the right approach would be to generate JS in a way that is 'friendly' to automation tools. Including the 'id' property or honoring the 'automationName' property defined in the MXML are steps in the right direction. Some 'best practice' points for successful HTML automation are: 1. As mentioned earlier having unique and/or descriptive property values defined on generated DOM elements. 2. Ensuring helper HTML elements that are generated in DOM hierarchy purely for cosmetics are clearly marked so that they can be easily ignored by the automation tool. Ideally the automation tool must only operate on HTML elements which are functional part of the UI and can be directly interacted by the human user. 3. Ensuring that descriptive properties remain constant across builds and during runtime. The autogenerated ids which keep changing from run to run or from build to build are exactly what must NOT be done and which are very undesirable from automation point of view. JS libraries such as ExtJS are known for autogenerating the ids and are very unfriendly for automation. We spent considerable efforts to teach RIATest to ignore autogenerated ids in ExtJS, it is a lot more desirable to make sure the JS output does not do this for Flex. One other reason why I think there is no need for separate automation API is that it may require significant efforts to develop and maintain (e.g. the Flex Automation Framework is currently about 62K lines of source code). I will keep thinking about the automation aspects of FlexJS and will post back if I have anything useful to say. Tigran.
Re: [DISCUSS] Components donation (was: Components donation)
On 4/15/13 8:09 AM, OmPrakash Muppirala bigosma...@gmail.com wrote: On Apr 15, 2013 8:02 AM, Alex Harui aha...@adobe.com wrote: Fine with me. FWIW, I think we do need an official vote. My current understanding is that the only non-committer contributions that don't need a vote are patches. I am sorry, but I don't think that is a vote is required. Can you point us to some policy or discussion threads regarding this, where you think this decision was made? Greg Reddin said here: http://mail-archives.apache.org/mod_mbox/flex-dev/201303.mbox/%3cCAKWVykWKAz p1pjf0mcbv2c+d8zuf-ufkeiby1ywxpzmbn1o...@mail.gmail.com%3e That the template here: http://incubator.apache.org/ip-clearance/ip-clearance-template.html implies that a vote is required. Now if someone cobbles together a new component and submits it in JIRA, I think that might not need a vote. But my interpretation is that stuff that already exists and especially, has been made public before, probably does. And what if a new component is submitted via a patch? Which category would that fall under? Thanks, Om On 4/15/13 6:05 AM, Harbs harbs.li...@gmail.com wrote: I agree. Harbs On Apr 15, 2013, at 3:31 PM, Frédéric THOMAS wrote: Hi all, Jérémy Reynaud, CTO and co-founder of KeepCore, proposes to donated 2 of their components [1], a dual slider[2] and a progress spinner[3], is there any interests accepting those components as part of the Flex-sdk ? I personally think the DualSlider could be a great addition, maybe the ProgressSpinner too, those components have been world wide tested since a good amount of time already (see the first post of the previous thread). Thoughts ? Thanks, -Fred [1] http://www.flex-component.com/ [2] http://www.flex-component.com/demo/apache/KCDualSliderV1.1/ [3] http://www.flex-component.com/demo/apache/KCProgressSpinnerV1.1/ -Message d'origine- From: Erik de Bruin Sent: Monday, April 15, 2013 2:15 PM To: dev@flex.apache.org Subject: Re: Components donation I don't think a VOTE is strictly necessary. A DISCUSS might be nice, though. Also, we need to make sure all legal obligations are met and all proper documents are filed. When in doubt, we need to check with Apache's legal department, I think. EdB On Mon, Apr 15, 2013 at 2:08 PM, Frédéric THOMAS webdoubl...@hotmail.com wrote: Hi guys, Is there someone who can indicate the next steps or if we need a vote before accepting any new components ? Thanks, -Fred -Message d'origine- From: Frédéric THOMAS Sent: Tuesday, March 12, 2013 10:01 AM To: dev@flex.apache.org Subject: Re: Components donation Hi Jérémy, Everybody is busy at the moment, I guess that's the reason why you haven't got so much returns but in few days, I'll put back this thread on the top. Thanks, -Fred -Message d'origine- From: Jérémy Reynaud Sent: Tuesday, March 12, 2013 9:49 AM To: dev@flex.apache.org Subject: RE: Components donation Thanks for your feedbacks and answers. We will start the process soon. Jérémy -Message d'origine- De : Frédéric THOMAS [mailto:webdoubl...@hotmail.com] Envoyé : lundi 11 mars 2013 15:49 À : dev@flex.apache.org Objet : Re: Components donation Jérémy, Note: I gave you a quick answer, like that you can have a good overview of the process but more precise details will be given by our PMCs probably later today. Thanks, -Fred -Message d'origine- From: Frédéric THOMAS Sent: Monday, March 11, 2013 3:37 PM To: dev@flex.apache.org Subject: Re: Components donation Hi Jérémy, First, thank you for your interest donating those components to Apache Flex. 1- The components: Given we've got progress component and we haven't got any dual slider (Spark Mobile) and yours looks very nice, I would personaly go at least for the latter, but I'm not only by myself and I not sure about the policies we've got regarding how we choose the components they could be donated. 2- For the license, it depends, from what I've seen from now (most of that was writen before by Alex Harui for other donations): The ASF has a policy to not take software regardless of the license unless the copyright holder grants it. By signing the ICLA you have indicated that you have permission from the copyright holder to make any contributions that you make. I think steps are to file ICLAs [1], and a CCLA [2] if there is a corporate entity involved. Then fill out the software grant [3]. 3- The donation process: 1. You fill out and sign all legal documents 2. Some of us will review the code (it can be given via a zip associated to a JIRA ticket). If it looks ok, we will start the committer approval process for you. Takes a minimum of 3 business days. 3. We discuss where this code should land, the package names. 4. Once the software grant is recorded, someone can check the code
Re: View source
ViewSource.addMenuItem(this, srcview/index.html) does not work ? -Fred -Message d'origine- From: Kessler CTR Mark J Sent: Monday, April 15, 2013 6:01 PM To: dev@flex.apache.org Subject: View source Is there an easy way to enable View Source without FB? -Mark
Re: [DISCUSS] Components donation (was: Components donation)
On 4/15/13 8:27 AM, Frédéric THOMAS webdoubl...@hotmail.com wrote: What if some components are or are not willed by some of us, a decision as to be taken, maybe a lazy vote could stand ? See my reply to Om. Apache does have a process as part of the IP clearance that implies that a vote is necessary. I think Greg said in his reponse that for small contributions via JIRA, the process should be the commit process. You can veto (theoretically on technical, non-subjective reasons). -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
RE: [FalconJS] populating the 'id' property at runtime
As an alternative to using the browser's native id attribute (in cases where that might be a problem) you can use a data attribute: input data-flex-id=myid That sounds like the proper way to do this, if RIATest can run on that type of attributes. Yes, RIATest can run on any public attribute. It is just that the id attribute is used by default and results in a bit cleaner script syntax. It also useful during recording, and is shown in the object inspector view. However data-flex-id attribute is also fully usable. We can probably even teach RIATest to use it by default for all DOM elements which are generated by FlexJS. Similarly for the automationName property (which is currently a standard property for mx.core.UIComponent) would be best to populate it into data-automation-name DOM attribute. Tigran.
RE: [FalconJS] populating the 'id' property at runtime
From: Alex Harui [mailto:aha...@adobe.com] And since we still need a way for folks to set the id in order to get accessibility to work, it might be best for now to just gamble and wire up set_id to the id. No need for a branch. Just do it. I'll try to get someone to think about the accessibility issues. OK, I will post the patch to Jira (it is actually just a single line of code) when I reach my work PC. Tigran.
Re: Meet 'marmotinni', an ASJS testing framework
On 4/15/13 9:10 AM, Tigran Najaryan tig...@gmail.com wrote: From: Alex Harui [mailto:aha...@adobe.com] OK, but FlexJS is essentially wrapping JS constructs and presenting them in AS. The goal for the components is the present the same APIs to the developer by wrapping and emulating where appropriate. Sorry, I probably miss something but I do not see what does this change from automation point of view. OK, probably just wishful thinking on my part. I think we both agree that it would be great if you could write a test on AS and have it run in JS. What I was trying to point out is that in FlexJS, the JS code for Combobox, for example, is not generated by cross compiling the AS code for ComboBox. Instead, under the covers of the ComboBox API, we hand-wrote one that works on Flash, and another one that works in JS (that uses the HTMLSelect). We haven't implemented an API in ComboBox or one of its plug-ins that plays back selection of an option, but if we did, and called it maybe playbackSelection, it would make the right calls in AS and a different set of calls in JS, so theoretically, the test script that calls playbackSelection would just do the right thing. But this may break down in more complex scenarios. Just for my education, does the RTS file get compiled or is it interpreted by the test engine? And thanks for the list of things to keep in mind. That was very helpful. -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: CS Extensions
I'm all for this! I think we should at least attempt to get the source to the current FXG export extensions or have they been donated already? Also, check out DrawScript http://drawscri.pt. On Mon, Apr 15, 2013 at 2:35 AM, Harbs harbs.li...@gmail.com wrote: I'd like to start that project to export FXG from creative suite apps. Some questions: 1) Should I start this on a personal github account, or have we settled on something else? 2) CS Extensions have dependencies on a number of Adobe swcs. How do we handle the project vis a vis Apache's policies and binaries? I don't think those dependencies can be included…
Re: CS Extensions
DrawScript looks cool. I would not hold my breath on getting the source donated, but if someone wants to try, that would be cool. On Apr 15, 2013, at 8:37 PM, jude wrote: I'm all for this! I think we should at least attempt to get the source to the current FXG export extensions or have they been donated already? Also, check out DrawScript http://drawscri.pt. On Mon, Apr 15, 2013 at 2:35 AM, Harbs harbs.li...@gmail.com wrote: I'd like to start that project to export FXG from creative suite apps. Some questions: 1) Should I start this on a personal github account, or have we settled on something else? 2) CS Extensions have dependencies on a number of Adobe swcs. How do we handle the project vis a vis Apache's policies and binaries? I don't think those dependencies can be included…
Re: CS Extensions
Drawscript looks good, except that it writes to actionscript/javascript directly. I dont think that it is a good idea necessarily. In the case of JS, it is geared towards drawing on the Canvas element. Problem is that anything drawn on the canvas immediately loses hitTest, accessibility,etc. Thanks, Om On Mon, Apr 15, 2013 at 11:10 AM, Harbs harbs.li...@gmail.com wrote: DrawScript looks cool. I would not hold my breath on getting the source donated, but if someone wants to try, that would be cool. On Apr 15, 2013, at 8:37 PM, jude wrote: I'm all for this! I think we should at least attempt to get the source to the current FXG export extensions or have they been donated already? Also, check out DrawScript http://drawscri.pt. On Mon, Apr 15, 2013 at 2:35 AM, Harbs harbs.li...@gmail.com wrote: I'd like to start that project to export FXG from creative suite apps. Some questions: 1) Should I start this on a personal github account, or have we settled on something else? 2) CS Extensions have dependencies on a number of Adobe swcs. How do we handle the project vis a vis Apache's policies and binaries? I don't think those dependencies can be included…
Re: CS Extensions
I just asked Olav Kvern who's done a bunch of path work for InDesign and Illustrator and he's okay with donating his work to this project. That should help jump-start things very nicely! On Apr 15, 2013, at 9:17 PM, OmPrakash Muppirala wrote: Drawscript looks good, except that it writes to actionscript/javascript directly. I dont think that it is a good idea necessarily. In the case of JS, it is geared towards drawing on the Canvas element. Problem is that anything drawn on the canvas immediately loses hitTest, accessibility,etc. Thanks, Om On Mon, Apr 15, 2013 at 11:10 AM, Harbs harbs.li...@gmail.com wrote: DrawScript looks cool. I would not hold my breath on getting the source donated, but if someone wants to try, that would be cool. On Apr 15, 2013, at 8:37 PM, jude wrote: I'm all for this! I think we should at least attempt to get the source to the current FXG export extensions or have they been donated already? Also, check out DrawScript http://drawscri.pt. On Mon, Apr 15, 2013 at 2:35 AM, Harbs harbs.li...@gmail.com wrote: I'd like to start that project to export FXG from creative suite apps. Some questions: 1) Should I start this on a personal github account, or have we settled on something else? 2) CS Extensions have dependencies on a number of Adobe swcs. How do we handle the project vis a vis Apache's policies and binaries? I don't think those dependencies can be included…
Re: CS Extensions
If this would be indesign to html5. That would be very cool. Sent from my iPhone On Apr 15, 2013, at 2:45 PM, Harbs harbs.li...@gmail.com wrote: I just asked Olav Kvern who's done a bunch of path work for InDesign and Illustrator and he's okay with donating his work to this project. That should help jump-start things very nicely! On Apr 15, 2013, at 9:17 PM, OmPrakash Muppirala wrote: Drawscript looks good, except that it writes to actionscript/javascript directly. I dont think that it is a good idea necessarily. In the case of JS, it is geared towards drawing on the Canvas element. Problem is that anything drawn on the canvas immediately loses hitTest, accessibility,etc. Thanks, Om On Mon, Apr 15, 2013 at 11:10 AM, Harbs harbs.li...@gmail.com wrote: DrawScript looks cool. I would not hold my breath on getting the source donated, but if someone wants to try, that would be cool. On Apr 15, 2013, at 8:37 PM, jude wrote: I'm all for this! I think we should at least attempt to get the source to the current FXG export extensions or have they been donated already? Also, check out DrawScript http://drawscri.pt. On Mon, Apr 15, 2013 at 2:35 AM, Harbs harbs.li...@gmail.com wrote: I'd like to start that project to export FXG from creative suite apps. Some questions: 1) Should I start this on a personal github account, or have we settled on something else? 2) CS Extensions have dependencies on a number of Adobe swcs. How do we handle the project vis a vis Apache's policies and binaries? I don't think those dependencies can be included…
Re: CS Extensions
Someone has done that already: http://ajarproductions.com/pages/products/in5/ On Apr 15, 2013, at 10:06 PM, Dave Fisher wrote: If this would be indesign to html5. That would be very cool. Sent from my iPhone On Apr 15, 2013, at 2:45 PM, Harbs harbs.li...@gmail.com wrote: I just asked Olav Kvern who's done a bunch of path work for InDesign and Illustrator and he's okay with donating his work to this project. That should help jump-start things very nicely! On Apr 15, 2013, at 9:17 PM, OmPrakash Muppirala wrote: Drawscript looks good, except that it writes to actionscript/javascript directly. I dont think that it is a good idea necessarily. In the case of JS, it is geared towards drawing on the Canvas element. Problem is that anything drawn on the canvas immediately loses hitTest, accessibility,etc. Thanks, Om On Mon, Apr 15, 2013 at 11:10 AM, Harbs harbs.li...@gmail.com wrote: DrawScript looks cool. I would not hold my breath on getting the source donated, but if someone wants to try, that would be cool. On Apr 15, 2013, at 8:37 PM, jude wrote: I'm all for this! I think we should at least attempt to get the source to the current FXG export extensions or have they been donated already? Also, check out DrawScript http://drawscri.pt. On Mon, Apr 15, 2013 at 2:35 AM, Harbs harbs.li...@gmail.com wrote: I'd like to start that project to export FXG from creative suite apps. Some questions: 1) Should I start this on a personal github account, or have we settled on something else? 2) CS Extensions have dependencies on a number of Adobe swcs. How do we handle the project vis a vis Apache's policies and binaries? I don't think those dependencies can be included…
Re: Git merge of README and RELEASE_NOTES
HI, git checkout origin/release4.9 RELEASE_NOTES FILE2 FILEX That just replaces the current RELEASE_NOTES file with the 4.9 one. What do you need to do to merge the changes on both files together? Thanks, Justin
Re: [DISCUSS] Components donation (was: Components donation)
So that means IP donations require a vote and going through the IP clearance. But what about commiters already signed the Apache agreement... Does that require a vote or just a public showing and a general consensus? Or are we voting on those too? -Mark On Mon, Apr 15, 2013 at 12:15 PM, Alex Harui aha...@adobe.com wrote: On 4/15/13 8:27 AM, Frédéric THOMAS webdoubl...@hotmail.com wrote: What if some components are or are not willed by some of us, a decision as to be taken, maybe a lazy vote could stand ? See my reply to Om. Apache does have a process as part of the IP clearance that implies that a vote is necessary. I think Greg said in his reponse that for small contributions via JIRA, the process should be the commit process. You can veto (theoretically on technical, non-subjective reasons). -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: Git merge of README and RELEASE_NOTES
ok, so, you need to go by an intermediary branch as git merge or rebase only commits From your clean develop branch: git checkout -b temp git checkout origin/release4.9 RELEASE_NOTES FILE2 FILEX git add -u git commit -m Merge RELEASE_NOTES, etc.. from release4.9 branch git checkout develop git rebase temp git mergeTool RELEASE_NOTES git rebase --continue git mergeTool FILE2 git rebase --continue git mergeTool FILEX git rebase --continue git branch -d temp git push -Message d'origine- From: Justin Mclean Sent: Tuesday, April 16, 2013 12:20 AM To: dev@flex.apache.org Subject: Re: Git merge of README and RELEASE_NOTES HI, git checkout origin/release4.9 RELEASE_NOTES FILE2 FILEX That just replaces the current RELEASE_NOTES file with the 4.9 one. What do you need to do to merge the changes on both files together? Thanks, Justin
[jira] [Closed] (FLEX-24780) Initially I can change the selectedItem in a List programmatically, but if the event preventDefault is called anytime, I can no longer change the selectedItem programatica
[ https://issues.apache.org/jira/browse/FLEX-24780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Kessler closed FLEX-24780. --- Initially I can change the selectedItem in a List programmatically, but if the event preventDefault is called anytime, I can no longer change the selectedItem programatically. --- Key: FLEX-24780 URL: https://issues.apache.org/jira/browse/FLEX-24780 Project: Apache Flex Issue Type: Bug Components: Spark: List Affects Versions: Adobe Flex SDK 4.0 (Release) Environment: Affected OS(s): All OS Platforms Affected OS(s): All OS Platforms Browser: Firefox 2.x Language Found: English Reporter: Adobe JIRA Assignee: Mark Kessler Fix For: Adobe Flex SDK Next 1.Click the button. The selectedItem is changed programmatically. 2.Click on the list. The changing handler is called, the preventDefault is executed and the selectedItem is not changed. 3.Click on the button again. The changing handler is executed and the selectedItem does not change. fx:Script ![CDATA[ import spark.events.IndexChangeEvent; protected function myButton_clickHandler(event:MouseEvent):void{ if(myList.selectedIndex == 0) myList.selectedIndex = 1; else myList.selectedIndex = 0; } protected function myList_changingHandler(event:IndexChangeEvent):void{ event.preventDefault(); } ]] /fx:Script s:layout s:VerticalLayout/ /s:layout s:Button id=myButton label=Change selected index click=myButton_clickHandler(event)/ s:List id=myList changing=myList_changingHandler(event) s:ArrayCollection fx:StringItem1/fx:String fx:StringItem2/fx:String /s:ArrayCollection /s:List -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (FLEX-27797) Spark Datagrid double click is fired even when you make the first and second click in different points (rows) !
[ https://issues.apache.org/jira/browse/FLEX-27797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Kessler reassigned FLEX-27797: --- Assignee: Mark Kessler Spark Datagrid double click is fired even when you make the first and second click in different points (rows) ! --- Key: FLEX-27797 URL: https://issues.apache.org/jira/browse/FLEX-27797 Project: Apache Flex Issue Type: Bug Components: Spark: DataGrid Affects Versions: Adobe Flex SDK 4.5.1 (Release) Environment: Affected OS(s): Windows Affected OS(s): Windows 7 Language Found: English Reporter: Adobe JIRA Assignee: Mark Kessler Steps to reproduce: 1. Put a spark Datagrid with data 2. Set gridDoubleClick function and doubleClickEnabled to true 3. make the first click in a row, and the second in another row, the doubleClick is fired anyway. Actual Results: Double click is fired Expected Results: Double click should not fire if you make the two clicks in differentes positions (or rows at least) Workaround (if any): Register a click event, use an external var to register the item clicked in the first item, and then check that in your doubleclick handler. Or don't use doubleClick handler and user a click handler like this: var lastTime:Date = new Date(0); function OnClickHandler(event:Event):void { if ((new Date()).time - lastTime.time 250) { return; } lastTime = new Date(); ... } -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FLEX-27797) Spark Datagrid double click is fired even when you make the first and second click in different points (rows) !
[ https://issues.apache.org/jira/browse/FLEX-27797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Kessler resolved FLEX-27797. - Resolution: Fixed Fix Version/s: Adobe Flex SDK Next This was resolved with FLEX-33190. Spark Datagrid double click is fired even when you make the first and second click in different points (rows) ! --- Key: FLEX-27797 URL: https://issues.apache.org/jira/browse/FLEX-27797 Project: Apache Flex Issue Type: Bug Components: Spark: DataGrid Affects Versions: Adobe Flex SDK 4.5.1 (Release) Environment: Affected OS(s): Windows Affected OS(s): Windows 7 Language Found: English Reporter: Adobe JIRA Assignee: Mark Kessler Fix For: Adobe Flex SDK Next Steps to reproduce: 1. Put a spark Datagrid with data 2. Set gridDoubleClick function and doubleClickEnabled to true 3. make the first click in a row, and the second in another row, the doubleClick is fired anyway. Actual Results: Double click is fired Expected Results: Double click should not fire if you make the two clicks in differentes positions (or rows at least) Workaround (if any): Register a click event, use an external var to register the item clicked in the first item, and then check that in your doubleclick handler. Or don't use doubleClick handler and user a click handler like this: var lastTime:Date = new Date(0); function OnClickHandler(event:Event):void { if ((new Date()).time - lastTime.time 250) { return; } lastTime = new Date(); ... } -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (FLEX-27797) Spark Datagrid double click is fired even when you make the first and second click in different points (rows) !
[ https://issues.apache.org/jira/browse/FLEX-27797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Kessler closed FLEX-27797. --- Spark Datagrid double click is fired even when you make the first and second click in different points (rows) ! --- Key: FLEX-27797 URL: https://issues.apache.org/jira/browse/FLEX-27797 Project: Apache Flex Issue Type: Bug Components: Spark: DataGrid Affects Versions: Adobe Flex SDK 4.5.1 (Release) Environment: Affected OS(s): Windows Affected OS(s): Windows 7 Language Found: English Reporter: Adobe JIRA Assignee: Mark Kessler Fix For: Adobe Flex SDK Next Steps to reproduce: 1. Put a spark Datagrid with data 2. Set gridDoubleClick function and doubleClickEnabled to true 3. make the first click in a row, and the second in another row, the doubleClick is fired anyway. Actual Results: Double click is fired Expected Results: Double click should not fire if you make the two clicks in differentes positions (or rows at least) Workaround (if any): Register a click event, use an external var to register the item clicked in the first item, and then check that in your doubleclick handler. Or don't use doubleClick handler and user a click handler like this: var lastTime:Date = new Date(0); function OnClickHandler(event:Event):void { if ((new Date()).time - lastTime.time 250) { return; } lastTime = new Date(); ... } -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [DISCUSS] Components donation (was: Components donation)
I agree, I was doing minor changes, bug fixes and such just CTR. The feature addition I have available, I put on the thread first (although I did a sloppy job of providing a timely code example) thinking it was a good practice to show before commiting. So waiting a few days for feed back then posting sounds good. thanks -Mark On Mon, Apr 15, 2013 at 8:05 PM, Alex Harui aha...@adobe.com wrote: On 4/15/13 3:45 PM, Mark Kessler kesslerconsult...@gmail.com wrote: So that means IP donations require a vote and going through the IP clearance. But what about commiters already signed the Apache agreement... Does that require a vote or just a public showing and a general consensus? Or are we voting on those too? Apache Flex is currently operating under CTR (commit then review). As a committer you have the responsibility of making sure you have the legal right to contribute any changes you commit, but there is no upfront process. You check in whatever you want, and theoretically, your fellow committers will review the changes. If another committer vetoes the commit then you should revert the changes. Vetoes are supposed to be based on technical merit. Of course, if it were me, before checking in anything big or involving a lot of work, I would probably start a thread on the mailing list first. -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui
Re: Git merge of README and RELEASE_NOTES
Hi, ok, so, you need to go by an intermediary branch as git merge or rebase only commits It there a simpler way of doing this? In svn it just a svn merge followed by a svn ci - assuming you're happy with the merge. If we want to merge the entire tree would we follow the same process? (eg like what we have to do after a release) Do you have to do a git mergeTool on every file? Lets give that a try: git checkout -b temp git checkout origin/release4.9 RELEASE_NOTES FILE2 FILEX OK I ran git checkout origin/release4.9 RELEASE_NOTES README and a git status only show README changed, however git diff README shows no changes, ignoring that I continue. git add -u Why is -u needed? git commit -m Merge RELEASE_NOTES, etc.. from release4.9 branch A bit scary: 1 file changed, 36 insertions(+), 63 deletions(-) Why did it do this when git diff showed no changes? git checkout develop Switched to branch 'develop' Your branch is ahead of 'origin/develop' by 1 commit. (use git push to publish your local commits) Think that's OK. git rebase temp At this point if I do a git status I get: # On branch develop # Your branch is ahead of 'origin/develop' by 2 commits. # (use git push to publish your local commits) # nothing to commit, working directory clean Which is a little strange as I would of expected changed from the git checkout develop. git mergeTool RELEASE_NOTES Gives No files need merging So I assume no need to to do a git rebase --continue? Try git mergeTool README and I also get No files need merging This is not what I expected I know it made changes to the file in the commit above. git status give at this point: # On branch develop # Your branch is ahead of 'origin/develop' by 2 commits. # (use git push to publish your local commits) # nothing to commit, working directory clean What are here 2 commits when I've only done one? git branch -d temp deletes branch If at this point if I do this git diff --stat origin/develop I get: README| 99 --- RELEASE_NOTES | 26 +- Why is it saying both README and RELEASE_NOTES have changed when only one file was changed with the commit? Looking at the changes (via git diff origin/develop) to README I see that it has merged the files incorrectly and certainly not what I expected. It's removed the more recent changes about FP 11.7 and AIR 3.7, using git rather than svn and changes to TLF but it did add the single line that changed the version number 4.9 to 4.9.1. RELEASE_NOTES have similar issues. Why did this not merge as expected? Why did git mergeTool say in both cases No files need merging when it obviously has (incorrectly) merged the files? Obviously Im not an expert git user and just know enough to keep getting myself into trouble. :-) I am just trying to understand what is going on here as currently it really doesn't make any sense to me at all and worse looks like it done the merge mostly in reverse? Thanks, Justin
Re: [DISCUSS] Components donation (was: Components donation)
Hi, I agree, I was doing minor changes, bug fixes and such just CTR. The feature addition I have available, I put on the thread first (although I did a sloppy job of providing a timely code example) thinking it was a good practice to show before commiting. Showing the changes to the code would also help (via git diff or whatever) that way people can see the scope of the change and makes it easier to review. Thanks, Justin
Re: Git merge of README and RELEASE_NOTES
If we want to merge the entire tree would we follow the same process? (eg like what we have to do after a release) Do you have to do a git mergeTool on every file? As I said before, in git merge or rebase will apply only on commits, not on files, if you have files with conflicts you want to merge, you will have to go by an intermediary branch checkout the files you want from the branch they are, add commit them, it will indeed add and commit only if the files are different, once committed on this temp branch, from the develop branch you can do a git rebase, it will stop the rebase operation on conflicts, you can then you a mergeTool if it has been configured, you can then continue the rebase. Obviously, if you merge or rebase an entire branch, you don't need to go by an intermediary branch. The good trick is to make your commits atomic, like that, you can merge/rebase this particular commit. OK I ran git checkout origin/release4.9 RELEASE_NOTES README and a git status only show README changed, however git diff README shows no changes, ignoring that I continue. that means only README was changed, you can see the diff running git diff --cached README, apparently the RELEASE_NOTES README are the same, you can check that running git diff develop..release4.9 RELEASE_NOTES git add -u Means add all my untracked files and the stages ones, that's the reason why I ask you to be on a clean develop branch. A bit scary: 1 file changed, 36 insertions(+), 63 deletions(-) . See the previous answer. And for the rest, it comes from what I just explained, the only thing wrong in what I wrote was 'git branch -d temp' instead of ''git branch -D temp'. -Fred -Message d'origine- From: Justin Mclean Sent: Tuesday, April 16, 2013 2:39 AM To: dev@flex.apache.org Subject: Re: Git merge of README and RELEASE_NOTES Hi, ok, so, you need to go by an intermediary branch as git merge or rebase only commits It there a simpler way of doing this? In svn it just a svn merge followed by a svn ci - assuming you're happy with the merge. If we want to merge the entire tree would we follow the same process? (eg like what we have to do after a release) Do you have to do a git mergeTool on every file? Lets give that a try: git checkout -b temp git checkout origin/release4.9 RELEASE_NOTES FILE2 FILEX OK I ran git checkout origin/release4.9 RELEASE_NOTES README and a git status only show README changed, however git diff README shows no changes, ignoring that I continue. git add -u Why is -u needed? git commit -m Merge RELEASE_NOTES, etc.. from release4.9 branch A bit scary: 1 file changed, 36 insertions(+), 63 deletions(-) Why did it do this when git diff showed no changes? git checkout develop Switched to branch 'develop' Your branch is ahead of 'origin/develop' by 1 commit. (use git push to publish your local commits) Think that's OK. git rebase temp At this point if I do a git status I get: # On branch develop # Your branch is ahead of 'origin/develop' by 2 commits. # (use git push to publish your local commits) # nothing to commit, working directory clean Which is a little strange as I would of expected changed from the git checkout develop. git mergeTool RELEASE_NOTES Gives No files need merging So I assume no need to to do a git rebase --continue? Try git mergeTool README and I also get No files need merging This is not what I expected I know it made changes to the file in the commit above. git status give at this point: # On branch develop # Your branch is ahead of 'origin/develop' by 2 commits. # (use git push to publish your local commits) # nothing to commit, working directory clean What are here 2 commits when I've only done one? git branch -d temp deletes branch If at this point if I do this git diff --stat origin/develop I get: README| 99 --- RELEASE_NOTES | 26 +- Why is it saying both README and RELEASE_NOTES have changed when only one file was changed with the commit? Looking at the changes (via git diff origin/develop) to README I see that it has merged the files incorrectly and certainly not what I expected. It's removed the more recent changes about FP 11.7 and AIR 3.7, using git rather than svn and changes to TLF but it did add the single line that changed the version number 4.9 to 4.9.1. RELEASE_NOTES have similar issues. Why did this not merge as expected? Why did git mergeTool say in both cases No files need merging when it obviously has (incorrectly) merged the files? Obviously Im not an expert git user and just know enough to keep getting myself into trouble. :-) I am just trying to understand what is going on here as currently it really doesn't make any sense to me at all and worse looks like it done the merge mostly in reverse? Thanks, Justin
Re: Git merge of README and RELEASE_NOTES
Re wrote a bit better I hope: As I said before, in git merge or rebase will apply only on commits, not on files, if you have files with conflicts you want to merge, you will have to go by an intermediary branch (temp), checkout the files you want to merge from the branch where they are, add and commit them into the temp branch, it will indeed add and commit files only if they are different, once committed on a temp branch, from the develop branch you can do a git rebase, it will stop the rebase operation on conflicts, you can then use a mergeTool if it has been configured, you can then continue the rebase. -Fred -Message d'origine- From: Frédéric THOMAS Sent: Tuesday, April 16, 2013 3:23 AM To: dev@flex.apache.org Subject: Re: Git merge of README and RELEASE_NOTES If we want to merge the entire tree would we follow the same process? (eg like what we have to do after a release) Do you have to do a git mergeTool on every file? As I said before, in git merge or rebase will apply only on commits, not on files, if you have files with conflicts you want to merge, you will have to go by an intermediary branch checkout the files you want from the branch they are, add commit them, it will indeed add and commit only if the files are different, once committed on this temp branch, from the develop branch you can do a git rebase, it will stop the rebase operation on conflicts, you can then you a mergeTool if it has been configured, you can then continue the rebase. Obviously, if you merge or rebase an entire branch, you don't need to go by an intermediary branch. The good trick is to make your commits atomic, like that, you can merge/rebase this particular commit. OK I ran git checkout origin/release4.9 RELEASE_NOTES README and a git status only show README changed, however git diff README shows no changes, ignoring that I continue. that means only README was changed, you can see the diff running git diff --cached README, apparently the RELEASE_NOTES README are the same, you can check that running git diff develop..release4.9 RELEASE_NOTES git add -u Means add all my untracked files and the stages ones, that's the reason why I ask you to be on a clean develop branch. A bit scary: 1 file changed, 36 insertions(+), 63 deletions(-) . See the previous answer. And for the rest, it comes from what I just explained, the only thing wrong in what I wrote was 'git branch -d temp' instead of ''git branch -D temp'. -Fred -Message d'origine- From: Justin Mclean Sent: Tuesday, April 16, 2013 2:39 AM To: dev@flex.apache.org Subject: Re: Git merge of README and RELEASE_NOTES Hi, ok, so, you need to go by an intermediary branch as git merge or rebase only commits It there a simpler way of doing this? In svn it just a svn merge followed by a svn ci - assuming you're happy with the merge. If we want to merge the entire tree would we follow the same process? (eg like what we have to do after a release) Do you have to do a git mergeTool on every file? Lets give that a try: git checkout -b temp git checkout origin/release4.9 RELEASE_NOTES FILE2 FILEX OK I ran git checkout origin/release4.9 RELEASE_NOTES README and a git status only show README changed, however git diff README shows no changes, ignoring that I continue. git add -u Why is -u needed? git commit -m Merge RELEASE_NOTES, etc.. from release4.9 branch A bit scary: 1 file changed, 36 insertions(+), 63 deletions(-) Why did it do this when git diff showed no changes? git checkout develop Switched to branch 'develop' Your branch is ahead of 'origin/develop' by 1 commit. (use git push to publish your local commits) Think that's OK. git rebase temp At this point if I do a git status I get: # On branch develop # Your branch is ahead of 'origin/develop' by 2 commits. # (use git push to publish your local commits) # nothing to commit, working directory clean Which is a little strange as I would of expected changed from the git checkout develop. git mergeTool RELEASE_NOTES Gives No files need merging So I assume no need to to do a git rebase --continue? Try git mergeTool README and I also get No files need merging This is not what I expected I know it made changes to the file in the commit above. git status give at this point: # On branch develop # Your branch is ahead of 'origin/develop' by 2 commits. # (use git push to publish your local commits) # nothing to commit, working directory clean What are here 2 commits when I've only done one? git branch -d temp deletes branch If at this point if I do this git diff --stat origin/develop I get: README| 99 --- RELEASE_NOTES | 26 +- Why is it saying both README and RELEASE_NOTES have changed when only one file was changed with the commit? Looking at the changes (via git diff origin/develop) to README I see that it
Re: [DISCUSS] Components donation (was: Components donation)
I agree. In my case I have example of it's use with view-source [1], a github whiteboard of the modified flex-sdk [2], the code pulled out of the components [3][4][5]. I could change to a diff if that would make things easier. So now we have steps up to this point. Should a JIRA issue been filed first to allow for a local git branch to be created with that JIRA name and centralize comments on the reviewing? How will the reviewing process go through approval from there? [1] http://people.apache.org/~mkessler/examples/DataProviderEnhance/app.swf [2] https://github.com/KesslerConsulting/example/tree/master/frameworks/projects/spark/src/spark/components [3] http://people.apache.org/~mkessler/examples/DataProviderEnhance/ComponentCode.txt [4] http://people.apache.org/~mkessler/examples/DataProviderEnhance/RegExPatterns.as [5] http://people.apache.org/~mkessler/examples/DataProviderEnhance/IDataProviderEnhance.as -Mark On Mon, Apr 15, 2013 at 8:42 PM, Justin Mclean jus...@classsoftware.comwrote: Hi, I agree, I was doing minor changes, bug fixes and such just CTR. The feature addition I have available, I put on the thread first (although I did a sloppy job of providing a timely code example) thinking it was a good practice to show before commiting. Showing the changes to the code would also help (via git diff or whatever) that way people can see the scope of the change and makes it easier to review. Thanks, Justin
Re: Git merge of README and RELEASE_NOTES
HI, if you have files with conflicts you want to merge, you will have to go by an intermediary branch This is almost always going to be the case with a release as it take time to vote on and create serval release candidates while develop work continues on in develop. apparently the RELEASE_NOTES README are the same, you can check that running git diff develop..release4.9 RELEASE_NOTES Both the README and RELEASE_NOTES are not the same. The develop RELEASE_NOTES still refer to incubator when the 4.9 branch doesn't. The README's differ by a significant amount. And for the rest, it comes from what I just explained Then why is the merge of both the README and RELEASE_NOTES incorrect? The procedure as you describe doesn't work and would overwrite more recent changes. For README for instance it show that this will change: + Apache Flex 4.9.1 is a minor update to Apache Flex 4.9. That's correct. But also show this will change: -Getting the latest sources via git +Getting the latest sources via Subversion And this: -http://airdownload.adobe.com/air/mac/download/3.5/AdobeAIRSDK.tbz2 +http://airdownload.adobe.com/air/mac/download/3.4/AdobeAIRSDK.tbz2 And this: -This version of Apache Flex was certified for use with AIR 3.5, and should +This version of Apache Flex was certified for use with AIR 3.4, and should be compatible with other versions of AIR newer than 3.1. However it hasn't -been tested on AIR 3.2, 3.3, 3.6 or 3.7. +been tested on AIR 3.2, 3.3 or 3.5. And this: -is compatible with versions 10.2 through 11.7. It has been tested with versions 11.1 +is compatible with versions 10.2 through 11.5. It has been tested with versions 11.1 And many other similar changes. It looks like it's reverting all changes we actually need - this should not happen! So I ask again why did git do this and more importantly what is the correct process so these changes are not lost. Thanks, Justin
Re: Git merge of README and RELEASE_NOTES
and I just noticed as well, to check the diff on RELEASE_NOTES, use: git diff origin/release4.9 RELEASE_NOTES -Message d'origine- From: Frédéric THOMAS Sent: Tuesday, April 16, 2013 3:31 AM To: dev@flex.apache.org Subject: Re: Git merge of README and RELEASE_NOTES Re wrote a bit better I hope: As I said before, in git merge or rebase will apply only on commits, not on files, if you have files with conflicts you want to merge, you will have to go by an intermediary branch (temp), checkout the files you want to merge from the branch where they are, add and commit them into the temp branch, it will indeed add and commit files only if they are different, once committed on a temp branch, from the develop branch you can do a git rebase, it will stop the rebase operation on conflicts, you can then use a mergeTool if it has been configured, you can then continue the rebase. -Fred -Message d'origine- From: Frédéric THOMAS Sent: Tuesday, April 16, 2013 3:23 AM To: dev@flex.apache.org Subject: Re: Git merge of README and RELEASE_NOTES If we want to merge the entire tree would we follow the same process? (eg like what we have to do after a release) Do you have to do a git mergeTool on every file? As I said before, in git merge or rebase will apply only on commits, not on files, if you have files with conflicts you want to merge, you will have to go by an intermediary branch checkout the files you want from the branch they are, add commit them, it will indeed add and commit only if the files are different, once committed on this temp branch, from the develop branch you can do a git rebase, it will stop the rebase operation on conflicts, you can then you a mergeTool if it has been configured, you can then continue the rebase. Obviously, if you merge or rebase an entire branch, you don't need to go by an intermediary branch. The good trick is to make your commits atomic, like that, you can merge/rebase this particular commit. OK I ran git checkout origin/release4.9 RELEASE_NOTES README and a git status only show README changed, however git diff README shows no changes, ignoring that I continue. that means only README was changed, you can see the diff running git diff --cached README, apparently the RELEASE_NOTES README are the same, you can check that running git diff develop..release4.9 RELEASE_NOTES git add -u Means add all my untracked files and the stages ones, that's the reason why I ask you to be on a clean develop branch. A bit scary: 1 file changed, 36 insertions(+), 63 deletions(-) . See the previous answer. And for the rest, it comes from what I just explained, the only thing wrong in what I wrote was 'git branch -d temp' instead of ''git branch -D temp'. -Fred -Message d'origine- From: Justin Mclean Sent: Tuesday, April 16, 2013 2:39 AM To: dev@flex.apache.org Subject: Re: Git merge of README and RELEASE_NOTES Hi, ok, so, you need to go by an intermediary branch as git merge or rebase only commits It there a simpler way of doing this? In svn it just a svn merge followed by a svn ci - assuming you're happy with the merge. If we want to merge the entire tree would we follow the same process? (eg like what we have to do after a release) Do you have to do a git mergeTool on every file? Lets give that a try: git checkout -b temp git checkout origin/release4.9 RELEASE_NOTES FILE2 FILEX OK I ran git checkout origin/release4.9 RELEASE_NOTES README and a git status only show README changed, however git diff README shows no changes, ignoring that I continue. git add -u Why is -u needed? git commit -m Merge RELEASE_NOTES, etc.. from release4.9 branch A bit scary: 1 file changed, 36 insertions(+), 63 deletions(-) Why did it do this when git diff showed no changes? git checkout develop Switched to branch 'develop' Your branch is ahead of 'origin/develop' by 1 commit. (use git push to publish your local commits) Think that's OK. git rebase temp At this point if I do a git status I get: # On branch develop # Your branch is ahead of 'origin/develop' by 2 commits. # (use git push to publish your local commits) # nothing to commit, working directory clean Which is a little strange as I would of expected changed from the git checkout develop. git mergeTool RELEASE_NOTES Gives No files need merging So I assume no need to to do a git rebase --continue? Try git mergeTool README and I also get No files need merging This is not what I expected I know it made changes to the file in the commit above. git status give at this point: # On branch develop # Your branch is ahead of 'origin/develop' by 2 commits. # (use git push to publish your local commits) # nothing to commit, working directory clean What are here 2 commits when I've only done one? git branch -d temp deletes branch If at this point if I do this git diff --stat origin/develop I get: README| 99
Re: Git merge of README and RELEASE_NOTES
Ok, tell me what files you want to merge, I'll do that tomorrow when I wake up, it's too now here 4:10. -Fred -Message d'origine- From: Justin Mclean Sent: Tuesday, April 16, 2013 4:02 AM To: dev@flex.apache.org Subject: Re: Git merge of README and RELEASE_NOTES HI, if you have files with conflicts you want to merge, you will have to go by an intermediary branch This is almost always going to be the case with a release as it take time to vote on and create serval release candidates while develop work continues on in develop. apparently the RELEASE_NOTES README are the same, you can check that running git diff develop..release4.9 RELEASE_NOTES Both the README and RELEASE_NOTES are not the same. The develop RELEASE_NOTES still refer to incubator when the 4.9 branch doesn't. The README's differ by a significant amount. And for the rest, it comes from what I just explained Then why is the merge of both the README and RELEASE_NOTES incorrect? The procedure as you describe doesn't work and would overwrite more recent changes. For README for instance it show that this will change: + Apache Flex 4.9.1 is a minor update to Apache Flex 4.9. That's correct. But also show this will change: -Getting the latest sources via git +Getting the latest sources via Subversion And this: - http://airdownload.adobe.com/air/mac/download/3.5/AdobeAIRSDK.tbz2 + http://airdownload.adobe.com/air/mac/download/3.4/AdobeAIRSDK.tbz2 And this: -This version of Apache Flex was certified for use with AIR 3.5, and should +This version of Apache Flex was certified for use with AIR 3.4, and should be compatible with other versions of AIR newer than 3.1. However it hasn't -been tested on AIR 3.2, 3.3, 3.6 or 3.7. +been tested on AIR 3.2, 3.3 or 3.5. And this: -is compatible with versions 10.2 through 11.7. It has been tested with versions 11.1 +is compatible with versions 10.2 through 11.5. It has been tested with versions 11.1 And many other similar changes. It looks like it's reverting all changes we actually need - this should not happen! So I ask again why did git do this and more importantly what is the correct process so these changes are not lost. Thanks, Justin
Re: Git merge of README and RELEASE_NOTES
Hi, I want to RELEASE_NOTE and README (from the develop and release branches) into the develop branch. But it's more about getting the process documented so we can actually make a release at some point. We want to make it as simple as possible for anyone who wants to put up there hand as a release manager. We will need to also merge the whole release branch into develop at a future point ie after the next release. Thanks, Justin
RE: How to get a clean working tree for flex-sdk
And what does ant release give? After I do 'ant release', 'git status' says nothing to commit (working directory clean) as expected. - Gordon -Original Message- From: Justin Mclean [mailto:jus...@classsoftware.com] Sent: Friday, April 12, 2013 11:09 PM To: dev@flex.apache.org Subject: Re: How to get a clean working tree for flex-sdk Hi, After you do 'ant clean main checkintests' in flex-sdk, 'git status' now says nothing to commit (working directory clean) And what does ant release give? Thanks, Justin
Merging 4.9.1 release bench into develop
Hi, I went ahead and merged the release branch into develop, looks we've been a bit naughty and looks like quite a few changes went on in the release branch that didn't happen in develop. Observations: - Had no luck with git rebase it seemed to want to throw away needed changes had much better luck with git merge origin/release4.9. - GIt conflict management is stupid. As far as I can see unlike SVN it doesn't intelligently merge files it leaves all conflicts up to you fix manually. This is a lot more manual work. - It's an all or nothing affair. It's not possible to push or commit partial changes as far as I can tell. This again is more work for a release manager - only way around this is to merge more frequently while making a release (each RC?) or keep changes in develop to a minimum while creating/voting on a release. There are issues with both approaches. - Version.as files are a pain. Git marks every one as a conflict they you have to fix by hand (find -exec and grep -v is your friend here). - Our .gitignore is set ignore things it shouldn't eg files in the ide and flex2 directories. - Please don't comment out lines in the build files as a temporary workaround - try and fix the issue. A commented out line is very easily forgotten about. Looks like there's been a couple of minor change made directly to trunk that are in in the 4.9 release - please be careful and don't check into trunk/master. I've not fixed this. I guess it should be merged with develop and reverted from trunk. If there's any issue with the merges (there was quite a few changes but mostly simple ones thankfully) reply in this thread. Thanks, Justin
Re: Merging 4.9.1 release bench into develop
On 4/15/13 9:49 PM, Justin Mclean jus...@classsoftware.com wrote: Hi, I went ahead and merged the release branch into develop, looks we've been a bit naughty and looks like quite a few changes went on in the release branch that didn't happen in develop. The git branching model seems to imply that changes to the release branch get merged into the develop branch at the end of the release. Did you only merge to trunk? Observations: - Had no luck with git rebase it seemed to want to throw away needed changes had much better luck with git merge origin/release4.9. - GIt conflict management is stupid. As far as I can see unlike SVN it doesn't intelligently merge files it leaves all conflicts up to you fix manually. This is a lot more manual work. Did you use MergeTool? I'm thinking of downloading it and trying it out. - It's an all or nothing affair. It's not possible to push or commit partial changes as far as I can tell. This again is more work for a release manager - only way around this is to merge more frequently while making a release (each RC?) or keep changes in develop to a minimum while creating/voting on a release. There are issues with both approaches. - Version.as files are a pain. Git marks every one as a conflict they you have to fix by hand (find -exec and grep -v is your friend here). What was the change to Version.as in the develop branch that conflicted? - Our .gitignore is set ignore things it shouldn't eg files in the ide and flex2 directories. - Please don't comment out lines in the build files as a temporary workaround - try and fix the issue. A commented out line is very easily forgotten about. Looks like there's been a couple of minor change made directly to trunk that are in in the 4.9 release - please be careful and don't check into trunk/master. I've not fixed this. I guess it should be merged with develop and reverted from trunk. If there's any issue with the merges (there was quite a few changes but mostly simple ones thankfully) reply in this thread. I'm just starting the fixing of the release target. I'm already confused by the changes made to build.properties which I will comment on in a separate thread. Thanks, Justin -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui