Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

[Justin Mclean]

Hi,

> The compiler, the language, and the Flash runtime are all designed to
> prevent you from making silly mistakes, so I think the best practice is t
> define data classes.  I've even considered adding a warning that detects
> use of plain object.
.
Sonar Cube can do that for you - for instance are what it reports on the SDK:

https://builds.apache.org/analysis/component_issues/index?id=org.apache.flex.flexjs.framework%3Aflexjs-framework-parent#resolved=false|rules=flex%3AS1434

thanks,
Justin

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

[Alex Harui]

Well, it may be just me, but I have the opposite thought...

IMO, instead of bracket access, we should take the time to create
ValueObjects for each of the data structures used in the ASDoc example.

I'm not even quite sure how to do #2 without blindly preventing renames of
all uses of the property names throughout the entire app.
I also think there are plenty of places where you don't need bracket
notation for plain objects.  I thought the only time minification is a
problem is when the data is externally supplied.

The compiler, the language, and the Flash runtime are all designed to
prevent you from making silly mistakes, so I think the best practice is to
define data classes.  I've even considered adding a warning that detects
use of plain object.

For example, in your example below, the following code

  doSomthing(myObj.foobaz);

could easily be accidentally written as:

  doSomthing(myObj.foobar);

Or 

  doSomthing(myObj.fooBaz);

If I take the time to define a data class




  public class MyObject
  {
 public var foobaz:String
  }

The compiler will catch this long before you will catch this at runtime.
Since we are all about developer productivity, that seems like the right
approach, but maybe generating data classes is too painful?

If anything, what I was going to suggest for ASDoc was to explore
converting JSON to AS data classes similar to how we just got AMF sort of
working.  It might be that only the SWF code needs to actually do the
conversion.  The JS code wouldn't need it unless someone is testing for
the type of the class with "as MyObject".

IOW, my claim is that it will save you time in the end to create data
classes.  You'll even get code hinting in many IDEs.  But of course, I
could be wrong.

Thoughts?
-Alex


On 9/26/17, 2:47 PM, "Harbs"  wrote:

>That’s probably it.
>
>It really needs bracket access.
>
>Alex, if you are looking for a task in the compiler, here’s a suggestion
>that would drastically reduce bugs in minified apps:
>
>1. For all untyped objects, dot notation should be rewritten to bracket
>notation:
>
>var myObj:Object = myArr[idx];
>doSomthing(myObj.foobaz);
>
>Should probably become:
>
>var myObj:Object = myArr[idx];
>doSomthing(myObj[“foobaz”]);
>
>2. Object literals should not be minified:
>
>var foo:Object = {
>   name:”foo”,
>age:15,
>   vegetable:true
>}
>
>Should be rewritten to:
>var foo:Object = {
>   “name":”foo”,
>“age":15,
>   “vegetable":true
>}
>
>I have been doing a LOT of manual fixing of these kinds of errors. It’s
>really tedious and hard to find all of them. Basically, unless you’re
>really good an find/replace, your app is almost guaranteed to blow up on
>some of these and then you need to find the needle in the haystack to fix
>it.
>
>Harbs
>
>> On Sep 27, 2017, at 12:33 AM, Alex Harui 
>>wrote:
>> 
>> You can grab the JSON files from the Jenkins server, but the Ant build
>> should also build them.
>> 
>> My guess is that the code isn't finding properties from the JSON objects
>> because GCC renamed the properties.
>> 
>> -Alex
>> 
>> On 9/26/17, 2:25 PM, "Harbs"  wrote:
>> 
>>> I can’t test because I’m missing the json files and I’m not sure how to
>>> generate them.
>>> 
>>> Looks like some binding problem probably due to renaming. The json
>>>files
>>> appear to be loading correctly from the web.
>>> 
 On Sep 26, 2017, at 11:41 PM, Alex Harui 
 wrote:
 
 Feel free to take a investigate.  Peter's old ASDoc page points to the
 js-debug version.  It loads slowly some times, but at least it is
 functional.  I'd rather work on other things right now than chasing
 down a
 js-release problem.
 
 -Alex
 
 On 9/26/17, 1:36 PM, "Harbs"  wrote:
 
> FWIW, the debug version is working, but the release version does not
> appear to work:
> 
> 
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache
>fl
> ex
> 
> 
>build.cloudapp.net%3A8080%2Fjob%2FFlexJS_ASDoc_Example%2FlastSuccessfu
>lB
> ui
> 
> 
>ld%2Fartifact%2Fexamples%2Fflexjs%2FASDoc%2Fbin%2Fjs-release%2Findex.h
>tm
> l&
> 
> 
>data=02%7C01%7C%7C54179a88620d4b09851a08d5051e4e2b%7Cfa7b1b5a7b3443879
>4a
> ed
> 
> 
>2c178decee1%7C0%7C0%7C636420550126149199=%2BTvYxjGSPD%2FJidjhxaw
>Ds
> cN
> 4YnE1vPWE%2BarU5wgrolk%3D=0
> 
> 
>ef
> le
> 
> 
>xbuild.cloudapp.net%3A8080%2Fjob%2FFlexJS_ASDoc_Example%2FlastSuccessf
>ul
> Bu
> 
> 
>ild%2Fartifact%2Fexamples%2Fflexjs%2FASDoc%2Fbin%2Fjs-release%2Findex.
>ht
> ml
> 
> 
>=02%7C01%7C%7C54179a88620d4b09851a08d5051e4e2b%7Cfa7b1b5a7b344387
>94
> ae
> 
> 

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

[Harbs]

That’s probably it.

It really needs bracket access.

Alex, if you are looking for a task in the compiler, here’s a suggestion that 
would drastically reduce bugs in minified apps:

1. For all untyped objects, dot notation should be rewritten to bracket 
notation:

var myObj:Object = myArr[idx];
doSomthing(myObj.foobaz);

Should probably become:

var myObj:Object = myArr[idx];
doSomthing(myObj[“foobaz”]);

2. Object literals should not be minified:

var foo:Object = {
name:”foo”,
age:15,
vegetable:true
}

Should be rewritten to:
var foo:Object = {
“name":”foo”,
“age":15,
“vegetable":true
}

I have been doing a LOT of manual fixing of these kinds of errors. It’s really 
tedious and hard to find all of them. Basically, unless you’re really good an 
find/replace, your app is almost guaranteed to blow up on some of these and 
then you need to find the needle in the haystack to fix it.

Harbs

> On Sep 27, 2017, at 12:33 AM, Alex Harui  wrote:
> 
> You can grab the JSON files from the Jenkins server, but the Ant build
> should also build them.
> 
> My guess is that the code isn't finding properties from the JSON objects
> because GCC renamed the properties.
> 
> -Alex
> 
> On 9/26/17, 2:25 PM, "Harbs"  wrote:
> 
>> I can’t test because I’m missing the json files and I’m not sure how to
>> generate them.
>> 
>> Looks like some binding problem probably due to renaming. The json files
>> appear to be loading correctly from the web.
>> 
>>> On Sep 26, 2017, at 11:41 PM, Alex Harui 
>>> wrote:
>>> 
>>> Feel free to take a investigate.  Peter's old ASDoc page points to the
>>> js-debug version.  It loads slowly some times, but at least it is
>>> functional.  I'd rather work on other things right now than chasing
>>> down a
>>> js-release problem.
>>> 
>>> -Alex
>>> 
>>> On 9/26/17, 1:36 PM, "Harbs"  wrote:
>>> 
 FWIW, the debug version is working, but the release version does not
 appear to work:
 
 https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapachefl
 ex
 
 build.cloudapp.net%3A8080%2Fjob%2FFlexJS_ASDoc_Example%2FlastSuccessfulB
 ui
 
 ld%2Fartifact%2Fexamples%2Fflexjs%2FASDoc%2Fbin%2Fjs-release%2Findex.htm
 l&
 
 data=02%7C01%7C%7C54179a88620d4b09851a08d5051e4e2b%7Cfa7b1b5a7b34438794a
 ed
 
 2c178decee1%7C0%7C0%7C636420550126149199=%2BTvYxjGSPD%2FJidjhxawDs
 cN
 4YnE1vPWE%2BarU5wgrolk%3D=0
 
 
 
> On Sep 26, 2017, at 11:02 PM, Alex Harui 
> wrote:
> 
> Or are you saying ASDoc isn't working for you on some browser?
 
>>> 
>> 
> 

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

[Alex Harui]

You can grab the JSON files from the Jenkins server, but the Ant build
should also build them.

My guess is that the code isn't finding properties from the JSON objects
because GCC renamed the properties.

-Alex

On 9/26/17, 2:25 PM, "Harbs"  wrote:

>I can’t test because I’m missing the json files and I’m not sure how to
>generate them.
>
>Looks like some binding problem probably due to renaming. The json files
>appear to be loading correctly from the web.
>
>> On Sep 26, 2017, at 11:41 PM, Alex Harui 
>>wrote:
>> 
>> Feel free to take a investigate.  Peter's old ASDoc page points to the
>> js-debug version.  It loads slowly some times, but at least it is
>> functional.  I'd rather work on other things right now than chasing
>>down a
>> js-release problem.
>> 
>> -Alex
>> 
>> On 9/26/17, 1:36 PM, "Harbs"  wrote:
>> 
>>> FWIW, the debug version is working, but the release version does not
>>> appear to work:
>>> 
>>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapachefl
>>>ex
>>> 
>>>build.cloudapp.net%3A8080%2Fjob%2FFlexJS_ASDoc_Example%2FlastSuccessfulB
>>>ui
>>> 
>>>ld%2Fartifact%2Fexamples%2Fflexjs%2FASDoc%2Fbin%2Fjs-release%2Findex.htm
>>>l&
>>> 
>>>data=02%7C01%7C%7C54179a88620d4b09851a08d5051e4e2b%7Cfa7b1b5a7b34438794a
>>>ed
>>> 
>>>2c178decee1%7C0%7C0%7C636420550126149199=%2BTvYxjGSPD%2FJidjhxawDs
>>>cN
>>> 4YnE1vPWE%2BarU5wgrolk%3D=0
>>> 
>>>>>le
>>> 
>>>xbuild.cloudapp.net%3A8080%2Fjob%2FFlexJS_ASDoc_Example%2FlastSuccessful
>>>Bu
>>> 
>>>ild%2Fartifact%2Fexamples%2Fflexjs%2FASDoc%2Fbin%2Fjs-release%2Findex.ht
>>>ml
>>> 
>>>=02%7C01%7C%7C54179a88620d4b09851a08d5051e4e2b%7Cfa7b1b5a7b34438794
>>>ae
>>> 
>>>d2c178decee1%7C0%7C0%7C636420550126149199=%2BTvYxjGSPD%2FJidjhxawD
>>>sc
>>> N4YnE1vPWE%2BarU5wgrolk%3D=0>
>>> 
 On Sep 26, 2017, at 11:02 PM, Alex Harui 
 wrote:
 
 Or are you saying ASDoc isn't working for you on some browser?
>>> 
>> 
>

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

[Harbs]

I can’t test because I’m missing the json files and I’m not sure how to 
generate them.

Looks like some binding problem probably due to renaming. The json files appear 
to be loading correctly from the web.

> On Sep 26, 2017, at 11:41 PM, Alex Harui  wrote:
> 
> Feel free to take a investigate.  Peter's old ASDoc page points to the
> js-debug version.  It loads slowly some times, but at least it is
> functional.  I'd rather work on other things right now than chasing down a
> js-release problem.
> 
> -Alex
> 
> On 9/26/17, 1:36 PM, "Harbs"  wrote:
> 
>> FWIW, the debug version is working, but the release version does not
>> appear to work:
>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapacheflex
>> build.cloudapp.net%3A8080%2Fjob%2FFlexJS_ASDoc_Example%2FlastSuccessfulBui
>> ld%2Fartifact%2Fexamples%2Fflexjs%2FASDoc%2Fbin%2Fjs-release%2Findex.html&
>> data=02%7C01%7C%7C54179a88620d4b09851a08d5051e4e2b%7Cfa7b1b5a7b34438794aed
>> 2c178decee1%7C0%7C0%7C636420550126149199=%2BTvYxjGSPD%2FJidjhxawDscN
>> 4YnE1vPWE%2BarU5wgrolk%3D=0
>> > xbuild.cloudapp.net%3A8080%2Fjob%2FFlexJS_ASDoc_Example%2FlastSuccessfulBu
>> ild%2Fartifact%2Fexamples%2Fflexjs%2FASDoc%2Fbin%2Fjs-release%2Findex.html
>> =02%7C01%7C%7C54179a88620d4b09851a08d5051e4e2b%7Cfa7b1b5a7b34438794ae
>> d2c178decee1%7C0%7C0%7C636420550126149199=%2BTvYxjGSPD%2FJidjhxawDsc
>> N4YnE1vPWE%2BarU5wgrolk%3D=0>
>> 
>>> On Sep 26, 2017, at 11:02 PM, Alex Harui 
>>> wrote:
>>> 
>>> Or are you saying ASDoc isn't working for you on some browser?
>> 
> 

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

[Alex Harui]

Feel free to take a investigate.  Peter's old ASDoc page points to the
js-debug version.  It loads slowly some times, but at least it is
functional.  I'd rather work on other things right now than chasing down a
js-release problem.

-Alex

On 9/26/17, 1:36 PM, "Harbs"  wrote:

>FWIW, the debug version is working, but the release version does not
>appear to work:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapacheflex
>build.cloudapp.net%3A8080%2Fjob%2FFlexJS_ASDoc_Example%2FlastSuccessfulBui
>ld%2Fartifact%2Fexamples%2Fflexjs%2FASDoc%2Fbin%2Fjs-release%2Findex.html&
>data=02%7C01%7C%7C54179a88620d4b09851a08d5051e4e2b%7Cfa7b1b5a7b34438794aed
>2c178decee1%7C0%7C0%7C636420550126149199=%2BTvYxjGSPD%2FJidjhxawDscN
>4YnE1vPWE%2BarU5wgrolk%3D=0
>xbuild.cloudapp.net%3A8080%2Fjob%2FFlexJS_ASDoc_Example%2FlastSuccessfulBu
>ild%2Fartifact%2Fexamples%2Fflexjs%2FASDoc%2Fbin%2Fjs-release%2Findex.html
>=02%7C01%7C%7C54179a88620d4b09851a08d5051e4e2b%7Cfa7b1b5a7b34438794ae
>d2c178decee1%7C0%7C0%7C636420550126149199=%2BTvYxjGSPD%2FJidjhxawDsc
>N4YnE1vPWE%2BarU5wgrolk%3D=0>
>
>> On Sep 26, 2017, at 11:02 PM, Alex Harui 
>>wrote:
>> 
>> Or are you saying ASDoc isn't working for you on some browser?
>

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

[Harbs]

FWIW, the debug version is working, but the release version does not appear to 
work:
http://apacheflexbuild.cloudapp.net:8080/job/FlexJS_ASDoc_Example/lastSuccessfulBuild/artifact/examples/flexjs/ASDoc/bin/js-release/index.html
 


> On Sep 26, 2017, at 11:02 PM, Alex Harui  wrote:
> 
> Or are you saying ASDoc isn't working for you on some browser?

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

[Alex Harui]

If I understand the problem (which I'm not sure, since the fix you posted
runs code if not Safari), you could create a
OneFlexibleChildLayoutWithSafariXSupport and put your fixes with browser
sniffing in there.  That way folks who don't need it, don't pay for the
sniffing.  There might be a version of Safari some day that behaves like
the other browsers.

My 2 cents,
-Alex

On 9/26/17, 1:25 PM, "Harbs"  wrote:

>I’m showing how to fix the “non-ForOverflow” layouts.
>
>The problem is that Safari handles flex layouts differently than other
>browsers.
>
>I’d like to use the flexbox layouts and AFAICT, they need browser
>sniffing to work across the board. Ideally, the browser sniffing should
>be included in the layout itself, but I was not sure the best way to do
>that…
>
>> On Sep 26, 2017, at 11:02 PM, Alex Harui 
>>wrote:
>> 
>> I'm not sure if you have the exact same problem as ASDoc, but the ASDoc
>> example is working fine with the "ForOverflow" layouts and no extra code
>> in the app.  Or are you saying ASDoc isn't working for you on some
>>browser?
>> 
>> IMO, that's the whole point of having many different flavors of layouts.
>> Folks can try different ones until they find one that works.  No need to
>> add custom code 3 places in the app.  Fixes for quirks get encapsulated
>> into a PAYG variant of a base component.
>> 
>> My 2 cents,
>> -Alex
>> 
>> On 9/26/17, 12:56 PM, "Harbs"  wrote:
>> 
>>> I ran into the Safari problem in my app.
>>> 
>>> I needed to add code like this:
>>> 
>>> var info:BrowserInfo = BrowserInfo.current();
>>> if(info.browser != "Safari" && info.formFactor.indexOf("iP") == -1){
>>> outerContainer.percentHeight = 100;
>>> leftResizeThumb.percentHeight = 100;
>>> }
>>> 
>>> The components look something like this:
>>> 
>>> >> id="dockAndOuterContainer"
>>> height="0%" style="align-items:stretch">
>>> 
>>> >>flexibleChild="outerContainer"/>
>>> 
>>> 
>>> 
>>> 
>>> 
>>> >> 
>>> Basically, all browsers except Safari and iOS browsers need to be set
>>>to
>>> 100%. Safari and iOS browsers CANNOT be set to 100%.
>>> 
>>> I’m not sure how to generalize this code…
>>> 
>>> I have it in three places in my app to make it behave correctly.
>>> 
>>> I’ve been meaning to bring up this issue on the dev@ list. Sorry I
>>>didn’t
>>> do it sooner… ;-)
>>> 
>>> Harbs
>>> 
 On Sep 26, 2017, at 10:44 PM, Alex Harui 
 wrote:
 
 I just reverted ASDoc back to the "ForOverflow" layouts.  ASDoc was
not
 showing up correctly for me (Safari).  Maybe flex-basis is handled
 differently on different browsers.  We can look into it more later.
 
 Looking into this did make me glad we are changing over to "Royale" so
 "Flex" and "FlexJS" will not be confused with FlexBox and the flex-xxx
 attributes.
 
 -Alex
 
 On 7/31/17, 12:57 AM, "Harbs"  wrote:
 
> The only example I found was the ASDoc app.
> 
> I switched it and it appears to work. (I pushed my changes.)
> 
>> On Jul 31, 2017, at 7:35 AM, Alex Harui 
>> wrote:
>> 
>> It will either work in the examples that use it or it won't.  Try it
>> and
>> find out.
>> 
>> -Alex
>> 
>> On 7/30/17, 3:04 AM, "Harbs"  wrote:
>> 
>>> I think I just ran into the same issue.
>>> 
>>> This layout seems to more-or-less do the job, but it’s kind of
>>>heavy.
>>> 
>>> I did some research into flexbox and it appear that setting
>>> flex-basis
>>> to
>>> 0 does the job. It needs to be set on ONLY the one flexible child.
>>> 
>>> Here’s a codepen which shows a use case.
>>> 
>>> 
>>> 
>>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcod
>>>ep
>>> en
>>> .i
>>> 
>>> 
>>> 
>>>o%2Fjpdevries%2Fpen%2FoXxPOP=02%7C01%7C%7C699bbb170b2c4f0bf3ae0
>>>8d
>>> 4d
>>> 73
>>> 
>>> 
>>> 
>>>2638a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63637005881876651
>>>1&
>>> sd
>>> at
>>> a=tSTNYANFFiQ4DMGYbAZaz0dJ9qYDYpcwP2ZoSYRIcG8%3D=0
>>> 
>>> 
>>> 
>>>>>de
>>> pe
>>> n.
>>> 
>>> 
>>> 
>>>io%2Fjpdevries%2Fpen%2FoXxPOP=02%7C01%7C%7C699bbb170b2c4f0bf3ae
>>>08
>>> d4
>>> d7
>>> 
>>> 
>>> 
>>>32638a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6363700588187665
>>>11
>>> 
>>> da
>>> ta=tSTNYANFFiQ4DMGYbAZaz0dJ9qYDYpcwP2ZoSYRIcG8%3D=0>
>>> 
>>> I noticed that the OneFlexibleLayouts have code which set the
>>> flex-basis

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

[Harbs]

I’m showing how to fix the “non-ForOverflow” layouts.

The problem is that Safari handles flex layouts differently than other browsers.

I’d like to use the flexbox layouts and AFAICT, they need browser sniffing to 
work across the board. Ideally, the browser sniffing should be included in the 
layout itself, but I was not sure the best way to do that…

> On Sep 26, 2017, at 11:02 PM, Alex Harui  wrote:
> 
> I'm not sure if you have the exact same problem as ASDoc, but the ASDoc
> example is working fine with the "ForOverflow" layouts and no extra code
> in the app.  Or are you saying ASDoc isn't working for you on some browser?
> 
> IMO, that's the whole point of having many different flavors of layouts.
> Folks can try different ones until they find one that works.  No need to
> add custom code 3 places in the app.  Fixes for quirks get encapsulated
> into a PAYG variant of a base component.
> 
> My 2 cents,
> -Alex
> 
> On 9/26/17, 12:56 PM, "Harbs"  wrote:
> 
>> I ran into the Safari problem in my app.
>> 
>> I needed to add code like this:
>> 
>> var info:BrowserInfo = BrowserInfo.current();
>> if(info.browser != "Safari" && info.formFactor.indexOf("iP") == -1){
>>  outerContainer.percentHeight = 100;
>>  leftResizeThumb.percentHeight = 100;
>> }
>> 
>> The components look something like this:
>> 
>>  > id="dockAndOuterContainer"
>> height="0%" style="align-items:stretch">
>>  
>>  > flexibleChild="outerContainer"/>
>>  
>>  
>>  
>>  
>>  
>>  > 
>> Basically, all browsers except Safari and iOS browsers need to be set to
>> 100%. Safari and iOS browsers CANNOT be set to 100%.
>> 
>> I’m not sure how to generalize this code…
>> 
>> I have it in three places in my app to make it behave correctly.
>> 
>> I’ve been meaning to bring up this issue on the dev@ list. Sorry I didn’t
>> do it sooner… ;-)
>> 
>> Harbs
>> 
>>> On Sep 26, 2017, at 10:44 PM, Alex Harui 
>>> wrote:
>>> 
>>> I just reverted ASDoc back to the "ForOverflow" layouts.  ASDoc was not
>>> showing up correctly for me (Safari).  Maybe flex-basis is handled
>>> differently on different browsers.  We can look into it more later.
>>> 
>>> Looking into this did make me glad we are changing over to "Royale" so
>>> "Flex" and "FlexJS" will not be confused with FlexBox and the flex-xxx
>>> attributes.
>>> 
>>> -Alex
>>> 
>>> On 7/31/17, 12:57 AM, "Harbs"  wrote:
>>> 
 The only example I found was the ASDoc app.
 
 I switched it and it appears to work. (I pushed my changes.)
 
> On Jul 31, 2017, at 7:35 AM, Alex Harui 
> wrote:
> 
> It will either work in the examples that use it or it won't.  Try it
> and
> find out.
> 
> -Alex
> 
> On 7/30/17, 3:04 AM, "Harbs"  wrote:
> 
>> I think I just ran into the same issue.
>> 
>> This layout seems to more-or-less do the job, but it’s kind of heavy.
>> 
>> I did some research into flexbox and it appear that setting
>> flex-basis
>> to
>> 0 does the job. It needs to be set on ONLY the one flexible child.
>> 
>> Here’s a codepen which shows a use case.
>> 
>> 
>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcodep
>> en
>> .i
>> 
>> 
>> o%2Fjpdevries%2Fpen%2FoXxPOP=02%7C01%7C%7C699bbb170b2c4f0bf3ae08d
>> 4d
>> 73
>> 
>> 
>> 2638a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636370058818766511&
>> sd
>> at
>> a=tSTNYANFFiQ4DMGYbAZaz0dJ9qYDYpcwP2ZoSYRIcG8%3D=0
>> 
>> 
>> > pe
>> n.
>> 
>> 
>> io%2Fjpdevries%2Fpen%2FoXxPOP=02%7C01%7C%7C699bbb170b2c4f0bf3ae08
>> d4
>> d7
>> 
>> 
>> 32638a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636370058818766511
>> 
>> da
>> ta=tSTNYANFFiQ4DMGYbAZaz0dJ9qYDYpcwP2ZoSYRIcG8%3D=0>
>> 
>> I noticed that the OneFlexibleLayouts have code which set the
>> flex-basis
>> of the children if a percentage value is set. When setting the size
>> of
>> the one flexible child to 0% this causes the flex-basis to be set to
>> 0
>> and then the one flexible child will fit the remaining space even if
>> it
>> might overflow because of its children.
>> 
>> I have wasted quite a bit of time before I discovered this. I’m not
>> sure
>> whether the OneFlexibleLayout classes should be changed, or maybe we
>> need
>> documentation that to fit content that might overflow, the percentage
>> should be set to 0. It could be there are cases where the entire
>> OnFlexibleLayout should be fit when 

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

[Alex Harui]

I'm not sure if you have the exact same problem as ASDoc, but the ASDoc
example is working fine with the "ForOverflow" layouts and no extra code
in the app.  Or are you saying ASDoc isn't working for you on some browser?

IMO, that's the whole point of having many different flavors of layouts.
Folks can try different ones until they find one that works.  No need to
add custom code 3 places in the app.  Fixes for quirks get encapsulated
into a PAYG variant of a base component.

My 2 cents,
-Alex

On 9/26/17, 12:56 PM, "Harbs"  wrote:

>I ran into the Safari problem in my app.
>
>I needed to add code like this:
>
>var info:BrowserInfo = BrowserInfo.current();
>if(info.browser != "Safari" && info.formFactor.indexOf("iP") == -1){
>   outerContainer.percentHeight = 100;
>   leftResizeThumb.percentHeight = 100;
>}
>
>The components look something like this:
>
>id="dockAndOuterContainer"
>height="0%" style="align-items:stretch">
>   
>flexibleChild="outerContainer"/>
>   
>   
>   
>   
>   
>   
>Basically, all browsers except Safari and iOS browsers need to be set to
>100%. Safari and iOS browsers CANNOT be set to 100%.
>
>I’m not sure how to generalize this code…
>
>I have it in three places in my app to make it behave correctly.
>
>I’ve been meaning to bring up this issue on the dev@ list. Sorry I didn’t
>do it sooner… ;-)
>
>Harbs
>
>> On Sep 26, 2017, at 10:44 PM, Alex Harui 
>>wrote:
>> 
>> I just reverted ASDoc back to the "ForOverflow" layouts.  ASDoc was not
>> showing up correctly for me (Safari).  Maybe flex-basis is handled
>> differently on different browsers.  We can look into it more later.
>> 
>> Looking into this did make me glad we are changing over to "Royale" so
>> "Flex" and "FlexJS" will not be confused with FlexBox and the flex-xxx
>> attributes.
>> 
>> -Alex
>> 
>> On 7/31/17, 12:57 AM, "Harbs"  wrote:
>> 
>>> The only example I found was the ASDoc app.
>>> 
>>> I switched it and it appears to work. (I pushed my changes.)
>>> 
 On Jul 31, 2017, at 7:35 AM, Alex Harui 
 wrote:
 
 It will either work in the examples that use it or it won't.  Try it
and
 find out.
 
 -Alex
 
 On 7/30/17, 3:04 AM, "Harbs"  wrote:
 
> I think I just ran into the same issue.
> 
> This layout seems to more-or-less do the job, but it’s kind of heavy.
> 
> I did some research into flexbox and it appear that setting
>flex-basis
> to
> 0 does the job. It needs to be set on ONLY the one flexible child.
> 
> Here’s a codepen which shows a use case.
> 
> 
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcodep
>en
> .i
> 
> 
>o%2Fjpdevries%2Fpen%2FoXxPOP=02%7C01%7C%7C699bbb170b2c4f0bf3ae08d
>4d
> 73
> 
> 
>2638a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636370058818766511&
>sd
> at
> a=tSTNYANFFiQ4DMGYbAZaz0dJ9qYDYpcwP2ZoSYRIcG8%3D=0
> 
> 
>pe
> n.
> 
> 
>io%2Fjpdevries%2Fpen%2FoXxPOP=02%7C01%7C%7C699bbb170b2c4f0bf3ae08
>d4
> d7
> 
> 
>32638a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636370058818766511
>
> da
> ta=tSTNYANFFiQ4DMGYbAZaz0dJ9qYDYpcwP2ZoSYRIcG8%3D=0>
> 
> I noticed that the OneFlexibleLayouts have code which set the
> flex-basis
> of the children if a percentage value is set. When setting the size
>of
> the one flexible child to 0% this causes the flex-basis to be set to
>0
> and then the one flexible child will fit the remaining space even if
>it
> might overflow because of its children.
> 
> I have wasted quite a bit of time before I discovered this. I’m not
> sure
> whether the OneFlexibleLayout classes should be changed, or maybe we
> need
> documentation that to fit content that might overflow, the percentage
> should be set to 0. It could be there are cases where the entire
> OnFlexibleLayout should be fit when smaller and expand (and not
>scroll)
> when bigger. In that case, the current behavior might be correct.
> 
> Thoughts?
> Harbs
> 
>> On May 23, 2017, at 10:16 AM, aha...@apache.org wrote:
>> 
>> give up on trying to use FlexBox for full-screen 3-pane views.
>> FlexBox
>> seems more happy stretching to content size instead of clipping at
>>the
>> computed flex-ed size.  These custom layouts will do the proper
>>sizing
>> 
>> 
>> Project: 
>> 
>> 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-w
>>ip
>> -u

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

[Harbs]

I ran into the Safari problem in my app.

I needed to add code like this:

var info:BrowserInfo = BrowserInfo.current();
if(info.browser != "Safari" && info.formFactor.indexOf("iP") == -1){
outerContainer.percentHeight = 100;
leftResizeThumb.percentHeight = 100;
}

The components look something like this:









 On Sep 26, 2017, at 10:44 PM, Alex Harui  wrote:
> 
> I just reverted ASDoc back to the "ForOverflow" layouts.  ASDoc was not
> showing up correctly for me (Safari).  Maybe flex-basis is handled
> differently on different browsers.  We can look into it more later.
> 
> Looking into this did make me glad we are changing over to "Royale" so
> "Flex" and "FlexJS" will not be confused with FlexBox and the flex-xxx
> attributes.
> 
> -Alex
> 
> On 7/31/17, 12:57 AM, "Harbs"  wrote:
> 
>> The only example I found was the ASDoc app.
>> 
>> I switched it and it appears to work. (I pushed my changes.)
>> 
>>> On Jul 31, 2017, at 7:35 AM, Alex Harui 
>>> wrote:
>>> 
>>> It will either work in the examples that use it or it won't.  Try it and
>>> find out.
>>> 
>>> -Alex
>>> 
>>> On 7/30/17, 3:04 AM, "Harbs"  wrote:
>>> 
 I think I just ran into the same issue.
 
 This layout seems to more-or-less do the job, but it’s kind of heavy.
 
 I did some research into flexbox and it appear that setting flex-basis
 to
 0 does the job. It needs to be set on ONLY the one flexible child.
 
 Here’s a codepen which shows a use case.
 
 https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcodepen
 .i
 
 o%2Fjpdevries%2Fpen%2FoXxPOP=02%7C01%7C%7C699bbb170b2c4f0bf3ae08d4d
 73
 
 2638a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636370058818766511
 at
 a=tSTNYANFFiQ4DMGYbAZaz0dJ9qYDYpcwP2ZoSYRIcG8%3D=0
 
 
 
 I noticed that the OneFlexibleLayouts have code which set the
 flex-basis
 of the children if a percentage value is set. When setting the size of
 the one flexible child to 0% this causes the flex-basis to be set to 0
 and then the one flexible child will fit the remaining space even if it
 might overflow because of its children.
 
 I have wasted quite a bit of time before I discovered this. I’m not
 sure
 whether the OneFlexibleLayout classes should be changed, or maybe we
 need
 documentation that to fit content that might overflow, the percentage
 should be set to 0. It could be there are cases where the entire
 OnFlexibleLayout should be fit when smaller and expand (and not scroll)
 when bigger. In that case, the current behavior might be correct.
 
 Thoughts?
 Harbs
 
> On May 23, 2017, at 10:16 AM, aha...@apache.org wrote:
> 
> give up on trying to use FlexBox for full-screen 3-pane views.
> FlexBox
> seems more happy stretching to content size instead of clipping at the
> computed flex-ed size.  These custom layouts will do the proper sizing
> 
> 
> Project: 
> 
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip
> -u
> 
> s.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo=02%7C01%7C%7C699bbb1
> 70
> 
> b2c4f0bf3ae08d4d732638a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63
> 63
> 
> 70058818766511=P%2FMkfZAwCYwpQEoCe5UGx8tW0mZaIZsMdDg6VxlaKWA%3D
> es
> erved=0
> Commit: 
> 
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip
> -u
> 
> s.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%2Fbdd34d2e=02%7C01
> %7
> 
> C%7C699bbb170b2c4f0bf3ae08d4d732638a%7Cfa7b1b5a7b34438794aed2c178decee1
> %7
> 
> C0%7C0%7C636370058818766511=QosBAau8lE4nCS7c%2F8B6GDc%2Bqa%2BpSko
> P5
> 5x3oji5FnI%3D=0
> Tree: 
> 
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip
> -u
> 
> s.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Ftree%2Fbdd34d2e=02%7C01%7
> C%
> 
> 7C699bbb170b2c4f0bf3ae08d4d732638a%7Cfa7b1b5a7b34438794aed2c178decee1%7
> C0
> 
> %7C0%7C636370058818766511=T4CCqwtn%2FgFTmAnaI%2BuCXqtX0P75ebpKVZO
> xf
> XOTbIE%3D=0
> Diff: 
> 
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip
> -u
> 
> 

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

[Harbs]

The only example I found was the ASDoc app.

I switched it and it appears to work. (I pushed my changes.)

> On Jul 31, 2017, at 7:35 AM, Alex Harui  wrote:
> 
> It will either work in the examples that use it or it won't.  Try it and
> find out.
> 
> -Alex
> 
> On 7/30/17, 3:04 AM, "Harbs"  wrote:
> 
>> I think I just ran into the same issue.
>> 
>> This layout seems to more-or-less do the job, but it’s kind of heavy.
>> 
>> I did some research into flexbox and it appear that setting flex-basis to
>> 0 does the job. It needs to be set on ONLY the one flexible child.
>> 
>> Here’s a codepen which shows a use case.
>> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcodepen.i
>> o%2Fjpdevries%2Fpen%2FoXxPOP=02%7C01%7C%7C699bbb170b2c4f0bf3ae08d4d73
>> 2638a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636370058818766511
>> a=tSTNYANFFiQ4DMGYbAZaz0dJ9qYDYpcwP2ZoSYRIcG8%3D=0
>> > io%2Fjpdevries%2Fpen%2FoXxPOP=02%7C01%7C%7C699bbb170b2c4f0bf3ae08d4d7
>> 32638a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636370058818766511
>> ta=tSTNYANFFiQ4DMGYbAZaz0dJ9qYDYpcwP2ZoSYRIcG8%3D=0>
>> 
>> I noticed that the OneFlexibleLayouts have code which set the flex-basis
>> of the children if a percentage value is set. When setting the size of
>> the one flexible child to 0% this causes the flex-basis to be set to 0
>> and then the one flexible child will fit the remaining space even if it
>> might overflow because of its children.
>> 
>> I have wasted quite a bit of time before I discovered this. I’m not sure
>> whether the OneFlexibleLayout classes should be changed, or maybe we need
>> documentation that to fit content that might overflow, the percentage
>> should be set to 0. It could be there are cases where the entire
>> OnFlexibleLayout should be fit when smaller and expand (and not scroll)
>> when bigger. In that case, the current behavior might be correct.
>> 
>> Thoughts?
>> Harbs
>> 
>>> On May 23, 2017, at 10:16 AM, aha...@apache.org wrote:
>>> 
>>> give up on trying to use FlexBox for full-screen 3-pane views.  FlexBox
>>> seems more happy stretching to content size instead of clipping at the
>>> computed flex-ed size.  These custom layouts will do the proper sizing
>>> 
>>> 
>>> Project: 
>>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-u
>>> s.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo=02%7C01%7C%7C699bbb170
>>> b2c4f0bf3ae08d4d732638a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6363
>>> 70058818766511=P%2FMkfZAwCYwpQEoCe5UGx8tW0mZaIZsMdDg6VxlaKWA%3D
>>> erved=0
>>> Commit: 
>>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-u
>>> s.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%2Fbdd34d2e=02%7C01%7
>>> C%7C699bbb170b2c4f0bf3ae08d4d732638a%7Cfa7b1b5a7b34438794aed2c178decee1%7
>>> C0%7C0%7C636370058818766511=QosBAau8lE4nCS7c%2F8B6GDc%2Bqa%2BpSkoP5
>>> 5x3oji5FnI%3D=0
>>> Tree: 
>>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-u
>>> s.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Ftree%2Fbdd34d2e=02%7C01%7C%
>>> 7C699bbb170b2c4f0bf3ae08d4d732638a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0
>>> %7C0%7C636370058818766511=T4CCqwtn%2FgFTmAnaI%2BuCXqtX0P75ebpKVZOxf
>>> XOTbIE%3D=0
>>> Diff: 
>>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-u
>>> s.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2Fbdd34d2e=02%7C01%7C%
>>> 7C699bbb170b2c4f0bf3ae08d4d732638a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0
>>> %7C0%7C636370058818766511=f8WVJXc81KrLMuUgRckULYCfglNL7d%2BfdjSbBBU
>>> 0fRo%3D=0
>>> 
>>> Branch: refs/heads/release0.8.0
>>> Commit: bdd34d2ef4d8117fa1b222ac470482a42dbea9eb
>>> Parents: c505d67
>>> Author: Alex Harui 
>>> Authored: Mon May 22 10:12:02 2017 -0700
>>> Committer: Alex Harui 
>>> Committed: Tue May 23 00:15:56 2017 -0700
>>> 
>>> --
>>> ...eFlexibleChildHorizontalLayoutForOverflow.as | 290 ++
>>> ...xibleChildHorizontalLayoutLockChildHeight.as |  91 --
>>> ...OneFlexibleChildVerticalLayoutForOverflow.as | 291
>>> +++
>>> ...FlexibleChildVerticalLayoutLockChildWidth.as |  93 --
>>> .../Basic/src/main/resources/basic-manifest.xml |   4 +-
>>> 5 files changed, 583 insertions(+), 186 deletions(-)
>>> --
>>> 
>>> 
>>> 
>>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-u
>>> s.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2Fbdd34d2e%2Fframeworks%2Fp
>>> rojects%2FBasic%2Fsrc%2Fmain%2Fflex%2Forg%2Fapache%2Fflex%2Fhtml%2Fbeads%
>>> 2Flayouts%2FOneFlexibleChildHorizontalLayoutForOverflow.as=02%7C01%7
>>> C%7C699bbb170b2c4f0bf3ae08d4d732638a%7Cfa7b1b5a7b34438794aed2c178decee1%7
>>> C0%7C0%7C636370058818766511=L7BjG%2BM7nTwguX%2BNaE5Op6BIT7XZrEqKFop
>>> 

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

[Alex Harui]

It will either work in the examples that use it or it won't.  Try it and
find out.

-Alex

On 7/30/17, 3:04 AM, "Harbs"  wrote:

>I think I just ran into the same issue.
>
>This layout seems to more-or-less do the job, but it’s kind of heavy.
>
>I did some research into flexbox and it appear that setting flex-basis to
>0 does the job. It needs to be set on ONLY the one flexible child.
>
>Here’s a codepen which shows a use case.
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcodepen.i
>o%2Fjpdevries%2Fpen%2FoXxPOP=02%7C01%7C%7C699bbb170b2c4f0bf3ae08d4d73
>2638a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636370058818766511
>a=tSTNYANFFiQ4DMGYbAZaz0dJ9qYDYpcwP2ZoSYRIcG8%3D=0
>io%2Fjpdevries%2Fpen%2FoXxPOP=02%7C01%7C%7C699bbb170b2c4f0bf3ae08d4d7
>32638a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636370058818766511
>ta=tSTNYANFFiQ4DMGYbAZaz0dJ9qYDYpcwP2ZoSYRIcG8%3D=0>
>
>I noticed that the OneFlexibleLayouts have code which set the flex-basis
>of the children if a percentage value is set. When setting the size of
>the one flexible child to 0% this causes the flex-basis to be set to 0
>and then the one flexible child will fit the remaining space even if it
>might overflow because of its children.
>
>I have wasted quite a bit of time before I discovered this. I’m not sure
>whether the OneFlexibleLayout classes should be changed, or maybe we need
>documentation that to fit content that might overflow, the percentage
>should be set to 0. It could be there are cases where the entire
>OnFlexibleLayout should be fit when smaller and expand (and not scroll)
>when bigger. In that case, the current behavior might be correct.
>
>Thoughts?
>Harbs
>
>> On May 23, 2017, at 10:16 AM, aha...@apache.org wrote:
>> 
>> give up on trying to use FlexBox for full-screen 3-pane views.  FlexBox
>>seems more happy stretching to content size instead of clipping at the
>>computed flex-ed size.  These custom layouts will do the proper sizing
>> 
>> 
>> Project: 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-u
>>s.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo=02%7C01%7C%7C699bbb170
>>b2c4f0bf3ae08d4d732638a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6363
>>70058818766511=P%2FMkfZAwCYwpQEoCe5UGx8tW0mZaIZsMdDg6VxlaKWA%3D
>>erved=0
>> Commit: 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-u
>>s.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%2Fbdd34d2e=02%7C01%7
>>C%7C699bbb170b2c4f0bf3ae08d4d732638a%7Cfa7b1b5a7b34438794aed2c178decee1%7
>>C0%7C0%7C636370058818766511=QosBAau8lE4nCS7c%2F8B6GDc%2Bqa%2BpSkoP5
>>5x3oji5FnI%3D=0
>> Tree: 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-u
>>s.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Ftree%2Fbdd34d2e=02%7C01%7C%
>>7C699bbb170b2c4f0bf3ae08d4d732638a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0
>>%7C0%7C636370058818766511=T4CCqwtn%2FgFTmAnaI%2BuCXqtX0P75ebpKVZOxf
>>XOTbIE%3D=0
>> Diff: 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-u
>>s.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2Fbdd34d2e=02%7C01%7C%
>>7C699bbb170b2c4f0bf3ae08d4d732638a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0
>>%7C0%7C636370058818766511=f8WVJXc81KrLMuUgRckULYCfglNL7d%2BfdjSbBBU
>>0fRo%3D=0
>> 
>> Branch: refs/heads/release0.8.0
>> Commit: bdd34d2ef4d8117fa1b222ac470482a42dbea9eb
>> Parents: c505d67
>> Author: Alex Harui 
>> Authored: Mon May 22 10:12:02 2017 -0700
>> Committer: Alex Harui 
>> Committed: Tue May 23 00:15:56 2017 -0700
>> 
>> --
>> ...eFlexibleChildHorizontalLayoutForOverflow.as | 290 ++
>> ...xibleChildHorizontalLayoutLockChildHeight.as |  91 --
>> ...OneFlexibleChildVerticalLayoutForOverflow.as | 291
>>+++
>> ...FlexibleChildVerticalLayoutLockChildWidth.as |  93 --
>> .../Basic/src/main/resources/basic-manifest.xml |   4 +-
>> 5 files changed, 583 insertions(+), 186 deletions(-)
>> --
>> 
>> 
>> 
>>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-u
>>s.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2Fbdd34d2e%2Fframeworks%2Fp
>>rojects%2FBasic%2Fsrc%2Fmain%2Fflex%2Forg%2Fapache%2Fflex%2Fhtml%2Fbeads%
>>2Flayouts%2FOneFlexibleChildHorizontalLayoutForOverflow.as=02%7C01%7
>>C%7C699bbb170b2c4f0bf3ae08d4d732638a%7Cfa7b1b5a7b34438794aed2c178decee1%7
>>C0%7C0%7C636370058818766511=L7BjG%2BM7nTwguX%2BNaE5Op6BIT7XZrEqKFop
>>0D%2Frc0Aw%3D=0
>> --
>> diff --git 
>>a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/layo
>>uts/OneFlexibleChildHorizontalLayoutForOverflow.as
>>b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/layo

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

[yishayw]

Here's a test app [1] that demonstrates it.

[1] https://paste.apache.org/i5Ui




--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/Re-07-13-git-commit-flex-asjs-refs-heads-release0-8-0-give-up-on-trying-to-use-FlexBox-for-full-scred-tp63598p63599.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

[Harbs]

I think I just ran into the same issue.

This layout seems to more-or-less do the job, but it’s kind of heavy.

I did some research into flexbox and it appear that setting flex-basis to 0 
does the job. It needs to be set on ONLY the one flexible child.

Here’s a codepen which shows a use case.
https://codepen.io/jpdevries/pen/oXxPOP 


I noticed that the OneFlexibleLayouts have code which set the flex-basis of the 
children if a percentage value is set. When setting the size of the one 
flexible child to 0% this causes the flex-basis to be set to 0 and then the one 
flexible child will fit the remaining space even if it might overflow because 
of its children.

I have wasted quite a bit of time before I discovered this. I’m not sure 
whether the OneFlexibleLayout classes should be changed, or maybe we need 
documentation that to fit content that might overflow, the percentage should be 
set to 0. It could be there are cases where the entire OnFlexibleLayout should 
be fit when smaller and expand (and not scroll) when bigger. In that case, the 
current behavior might be correct.

Thoughts?
Harbs

> On May 23, 2017, at 10:16 AM, aha...@apache.org wrote:
> 
> give up on trying to use FlexBox for full-screen 3-pane views.  FlexBox seems 
> more happy stretching to content size instead of clipping at the computed 
> flex-ed size.  These custom layouts will do the proper sizing
> 
> 
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/bdd34d2e
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/bdd34d2e
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/bdd34d2e
> 
> Branch: refs/heads/release0.8.0
> Commit: bdd34d2ef4d8117fa1b222ac470482a42dbea9eb
> Parents: c505d67
> Author: Alex Harui 
> Authored: Mon May 22 10:12:02 2017 -0700
> Committer: Alex Harui 
> Committed: Tue May 23 00:15:56 2017 -0700
> 
> --
> ...eFlexibleChildHorizontalLayoutForOverflow.as | 290 ++
> ...xibleChildHorizontalLayoutLockChildHeight.as |  91 --
> ...OneFlexibleChildVerticalLayoutForOverflow.as | 291 +++
> ...FlexibleChildVerticalLayoutLockChildWidth.as |  93 --
> .../Basic/src/main/resources/basic-manifest.xml |   4 +-
> 5 files changed, 583 insertions(+), 186 deletions(-)
> --
> 
> 
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/bdd34d2e/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/layouts/OneFlexibleChildHorizontalLayoutForOverflow.as
> --
> diff --git 
> a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/layouts/OneFlexibleChildHorizontalLayoutForOverflow.as
>  
> b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/layouts/OneFlexibleChildHorizontalLayoutForOverflow.as
> new file mode 100644
> index 000..c6abc22
> --- /dev/null
> +++ 
> b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/beads/layouts/OneFlexibleChildHorizontalLayoutForOverflow.as
> @@ -0,0 +1,290 @@
> +
> +//
> +//  Licensed to the Apache Software Foundation (ASF) under one or more
> +//  contributor license agreements.  See the NOTICE file distributed with
> +//  this work for additional information regarding copyright ownership.
> +//  The ASF licenses this file to You under the Apache License, Version 2.0
> +//  (the "License"); you may not use this file except in compliance with
> +//  the License.  You may obtain a copy of the License at
> +//
> +//  http://www.apache.org/licenses/LICENSE-2.0
> +//
> +//  Unless required by applicable law or agreed to in writing, software
> +//  distributed under the License is distributed on an "AS IS" BASIS,
> +//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> +//  See the License for the specific language governing permissions and
> +//  limitations under the License.
> +//
> +
> +package org.apache.flex.html.beads.layouts
> +{
> + import org.apache.flex.core.LayoutBase;
> + import org.apache.flex.core.IDocument;
> + import org.apache.flex.core.ILayoutChild;
> + import org.apache.flex.core.ILayoutHost;
> + import org.apache.flex.core.ILayoutView;
> + import org.apache.flex.core.ILayoutParent;
> + import org.apache.flex.core.IParentIUIBase;
> + import org.apache.flex.core.IStrand;
> + import org.apache.flex.core.IUIBase;
> + import org.apache.flex.core.ValuesManager;
> + import org.apache.flex.core.UIBase;
> + import org.apache.flex.events.Event;
> + import