Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

[Alex Harui]

The browser does not support RollOver/RollOut so we are running code to
emulate it, so wouldn't worry about the performance.  The browser's
implementation is likely faster than our JS implementation.Back when I
wrote this code, it wasn't clear that we could use mouseEnter/mouseLeave.
If folks agree that we can, then we can save a some code.

If we decide to use mouseEnter/mouseLeave we also need to decide whether
to stick with the Flex names of rollOver/rollOut or go with
mouseEnter/mouseLeave.  Already, all mouse events have different
capitalization of the event name (mouseDown vs mousedown) so folks "must"
use the event constants and not quoted strings in their code.

But it definitely sounds like this change is "just-in-case" code.  When
writing framework code, especially for FlexJS, we need to not just fix
whatever problem you are working on, but also consider the impact on all
other users of the framework code.  When writing application code, I'm
also prone to writing the quick fix if I'm not concerned about code
re-use.  But in framework code, we are "always" concerned about code
re-use.  We have to fix the right problem.  I'm thinking the actual
problem is that the tooltip is a live mouse target.  The right fix might
just be to make sure the tooltips are "transparent" to the mouse.

Thoughts?
-Alex

On 7/11/17, 1:02 AM, "Harbs"  wrote:

>I can’t make up my mind… ;-)
>
>I’m not sure why the MDN article says the mouseenter can have more CPU
>problems. It seems like mouseover should be dispatched more because it
>bubbles up from all sub-elements.[2] It seems like mouseover is identical
>to mouseOver in Flash and mouseenter is identical to rollOver.
>
>That should mean that mouseenter should be the better option.
>
>[2]https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.qu
>irksmode.org%2Fjs%2Fevents_mouse.html=02%7C01%7C%7C0aa7240c28324ace7a
>9008d4c8341bfb%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C63635357351272
>7427=ypCqQo8z6cbX01npatvfaWF6cW347gOjdhtgpfqIiiw%3D=0
>ksmode.org%2Fjs%2Fevents_mouse.html=02%7C01%7C%7C0aa7240c28324ace7a90
>08d4c8341bfb%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6363535735127274
>27=ypCqQo8z6cbX01npatvfaWF6cW347gOjdhtgpfqIiiw%3D=0>
>
>> On Jul 11, 2017, at 10:48 AM, Harbs  wrote:
>> 
>> No. I’m wrong.
>> 
>> First of all, it’s mouseenter rather than rollover, and it seems like
>>it’s fired more than mouseover.[1]
>> 
>>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdevelope
>>r.mozilla.org%2Fen-US%2Fdocs%2FWeb%2FEvents%2Fmouseenter=02%7C01%7C%
>>7C0aa7240c28324ace7a9008d4c8341bfb%7Cfa7b1b5a7b34438794aed2c178decee1%7C0
>>%7C0%7C636353573512727427=PUExzeCEz0B6iWscUPz7WpebnTvI%2BNHL9VwSdUO
>>7fKU%3D=0
>>>er.mozilla.org%2Fen-US%2Fdocs%2FWeb%2FEvents%2Fmouseenter=02%7C01%7C
>>%7C0aa7240c28324ace7a9008d4c8341bfb%7Cfa7b1b5a7b34438794aed2c178decee1%7C
>>0%7C0%7C636353573512727427=PUExzeCEz0B6iWscUPz7WpebnTvI%2BNHL9VwSdU
>>O7fKU%3D=0>
>> 
>> That does beg the question though: Are the MouseEvent constants wrong
>>for Javascript?
>> 
>> 
>>> On Jul 11, 2017, at 10:38 AM, Harbs >>> wrote:
>>> 
>>> Shouldn’t the event be triggered by rollover rather than mouseover?
>>> 
>>> That seems like the issue to me…
>>> 
 On Jul 11, 2017, at 10:13 AM, Alex Harui > wrote:
 
 This seems like "just-in-case" code.  I could see that it might be
needed
 in a different bead for Express though.
 
 Without this change, is there an infinite loop somewhere?
 
 Thanks,
 -Alex
 
 On 7/10/17, 10:40 PM, "jmcl...@apache.org
" > wrote:
 
> FLEX-35338 stop cursor from spinning / CPU from spiking
> 
> 
> Project: 
> 
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wi
>p-us 
>ip-us>
> 
>.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo=02%7C01%7C%7C8e2e2d5
>b3b3
> 
>54f54848508d4c81f5768%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636
>3534
> 
>84318029070=32hEJB%2BTNsWKG8MY%2FdPr3d0RWT5Xr1tECWWpVTlM270%3D
>eser
> ved=0
> Commit: 
> 
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wi
>p-us
> 
>.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%2F549a10d8=02%7C01
>%7C%
> 
>7C8e2e2d5b3b354f54848508d4c81f5768%7Cfa7b1b5a7b34438794aed2c178decee1%
>7C0%
> 
>7C0%7C636353484318029070=dcNhAGu8WspafZBZCRxb%2FN0z7D%2Fym3tuv%2
>BAaq
> G280z0%3D=0
> Tree: 
> 

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

[piotrz]

Ok! Thanks!



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/Re-2-5-git-commit-flex-asjs-refs-heads-develop-FLEX-35338-stop-cursor-from-spinning-CPU-from-spiking-tp63061p63079.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

[Justin Mclean]

Hi,

> Even if it's working now, Harbs did research and find out that MouseEnter is
> a better for that

You do understand that it’s still using the same event as before I didn’t 
change that.

> - For what element did you use tooltip ? Does it matter ?

Probably not but I was using an image.

> - " having the tooltip smaller than the object it sits " - Did you give
> tooltip some specific size ?

No you can’t (easily) size it. I just used a biggish image and a small tool tip 
i.e. toolTip=“tiny” vs a large tool tip i.e. toolTip=“This is a longer tool tip 
that overflows what it’s positioned over”.

Thanks,
Justin

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

[piotrz]

Maybe worth to check how it is handled in MDL.

Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/Re-2-5-git-commit-flex-asjs-refs-heads-develop-FLEX-35338-stop-cursor-from-spinning-CPU-from-spiking-tp63061p63074.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

[piotrz]

Hi,

Even if it's working now, Harbs did research and find out that MouseEnter is
a better for that, so I will spent my time to test your scenario. Maybe
tomorrow. Before that couple of questions:

- For what element did you use tooltip ? Does it matter ?
- " having the tooltip smaller than the object it sits " - Did you give
tooltip some specific size ? This is what you mean ?

Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/Re-2-5-git-commit-flex-asjs-refs-heads-develop-FLEX-35338-stop-cursor-from-spinning-CPU-from-spiking-tp63061p63072.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

[Harbs]

Thanks.

I just looked at the code to see why that would not work, and I see that the 
tool tip is being added to the “PopUpHost” rather than the element.

I’m not sure whether that’s the best way to handle it.

One the one hand, being that the tool tip is a higher level element, we’re 
getting unnecessary mouse events when mousing in and out of the tool tip. On 
the other hand, placing it inside the target element might effect layout and 
the like. It’s possible that this can be solved using absolute/fixed 
positioning and zindex.

Thoughts?
Harbs

> On Jul 11, 2017, at 11:16 AM, Justin Mclean  wrote:
> 
> Hi,
> 
>> Did you try mouseenter? (See my other responses)
> 
> Yes and no it didn’t but perhaps you can get it to work that way. Feel free 
> to do so.
> 
> If you do make any changes suggested test cases to test for include:
> - mousing over the tooltip itself
> - having the tooltip smaller than the object it sits on and mousing over it 
> and off each edge of the tooltip
> - having the tooltip expand over the (right) boundary of the item it covers 
> and moving out over the tool tip not cutting a visible edge of the item 
> underneath
> - rolling off over the top, bottom, left or right edges
> 
> The change I made works in all those situations.
> 
> Thanks,
> Justin

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

[Justin Mclean]

Hi,

> Did you try mouseenter? (See my other responses)

Yes and no it didn’t but perhaps you can get it to work that way. Feel free to 
do so.

If you do make any changes suggested test cases to test for include:
- mousing over the tooltip itself
- having the tooltip smaller than the object it sits on and mousing over it and 
off each edge of the tooltip
- having the tooltip expand over the (right) boundary of the item it covers and 
moving out over the tool tip not cutting a visible edge of the item underneath
- rolling off over the top, bottom, left or right edges

The change I made works in all those situations.

Thanks,
Justin

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

[Harbs]

No. I’m wrong.

First of all, it’s mouseenter rather than rollover, and it seems like it’s 
fired more than mouseover.[1]
https://developer.mozilla.org/en-US/docs/Web/Events/mouseenter 


That does beg the question though: Are the MouseEvent constants wrong for 
Javascript?


> On Jul 11, 2017, at 10:38 AM, Harbs  wrote:
> 
> Shouldn’t the event be triggered by rollover rather than mouseover?
> 
> That seems like the issue to me…
> 
>> On Jul 11, 2017, at 10:13 AM, Alex Harui  wrote:
>> 
>> This seems like "just-in-case" code.  I could see that it might be needed
>> in a different bead for Express though.
>> 
>> Without this change, is there an infinite loop somewhere?
>> 
>> Thanks,
>> -Alex
>> 
>> On 7/10/17, 10:40 PM, "jmcl...@apache.org"  wrote:
>> 
>>> FLEX-35338 stop cursor from spinning / CPU from spiking
>>> 
>>> 
>>> Project: 
>>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>>> .apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo=02%7C01%7C%7C8e2e2d5b3b3
>>> 54f54848508d4c81f5768%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6363534
>>> 84318029070=32hEJB%2BTNsWKG8MY%2FdPr3d0RWT5Xr1tECWWpVTlM270%3D
>>> ved=0
>>> Commit: 
>>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>>> .apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%2F549a10d8=02%7C01%7C%
>>> 7C8e2e2d5b3b354f54848508d4c81f5768%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%
>>> 7C0%7C636353484318029070=dcNhAGu8WspafZBZCRxb%2FN0z7D%2Fym3tuv%2BAaq
>>> G280z0%3D=0
>>> Tree: 
>>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>>> .apache.org%2Frepos%2Fasf%2Fflex-asjs%2Ftree%2F549a10d8=02%7C01%7C%7C
>>> 8e2e2d5b3b354f54848508d4c81f5768%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C
>>> 0%7C636353484318029070=0p89CGQLSv0Pp0yscOBNjKRJ1HUMhHrDngm4xxixalc%3
>>> D=0
>>> Diff: 
>>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>>> .apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2F549a10d8=02%7C01%7C%7C
>>> 8e2e2d5b3b354f54848508d4c81f5768%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C
>>> 0%7C636353484318029070=%2FclUp4scfr0z%2B%2FTPjBMlVw2kScADTcLPMwop5J4
>>> 7cIU%3D=0
>>> 
>>> Branch: refs/heads/develop
>>> Commit: 549a10d82da5835c61a2b1247b65f7bfbc2f9a36
>>> Parents: 3891820
>>> Author: Justin Mclean 
>>> Authored: Tue Jul 11 14:57:04 2017 +1000
>>> Committer: Justin Mclean 
>>> Committed: Tue Jul 11 14:57:04 2017 +1000
>>> 
>>> --
>>> .../main/flex/org/apache/flex/html/accessories/ToolTipBead.as   | 5 -
>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>> --
>>> 
>>> 
>>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>>> .apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2F549a10d8%2Fframeworks%2Fpro
>>> jects%2FBasic%2Fsrc%2Fmain%2Fflex%2Forg%2Fapache%2Fflex%2Fhtml%2Faccessori
>>> es%2FToolTipBead.as=02%7C01%7C%7C8e2e2d5b3b354f54848508d4c81f5768%7Cf
>>> a7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636353484318029070=hifp5T8
>>> xFlL4zov22P5qOUYtZqrYuPqTqOJg2x4X5lo%3D=0
>>> --
>>> diff --git 
>>> a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories
>>> /ToolTipBead.as 
>>> b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories
>>> /ToolTipBead.as
>>> index 03ce21e..bdf0b68 100644
>>> --- 
>>> a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories
>>> /ToolTipBead.as
>>> +++ 
>>> b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories
>>> /ToolTipBead.as
>>> @@ -100,7 +100,10 @@ package org.apache.flex.html.accessories
>>>  * @private
>>>  */
>>> protected function rollOverHandler( event:MouseEvent ):void
>>> -   {   
>>> +   {
>>> +   if (!toolTip)
>>> +   return;
>>> +
>>> 
>>> IEventDispatcher(_strand).addEventListener(MouseEvent.MOUSE_OUT,
>>> rollOutHandler, false);
>>> 
>>>   var comp:IUIBase = _strand as IUIBase
>>> 
>> 
> 

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

[Harbs]

I can’t make up my mind… ;-)

I’m not sure why the MDN article says the mouseenter can have more CPU 
problems. It seems like mouseover should be dispatched more because it bubbles 
up from all sub-elements.[2] It seems like mouseover is identical to mouseOver 
in Flash and mouseenter is identical to rollOver.

That should mean that mouseenter should be the better option.

[2]https://www.quirksmode.org/js/events_mouse.html 


> On Jul 11, 2017, at 10:48 AM, Harbs  wrote:
> 
> No. I’m wrong.
> 
> First of all, it’s mouseenter rather than rollover, and it seems like it’s 
> fired more than mouseover.[1]
> https://developer.mozilla.org/en-US/docs/Web/Events/mouseenter 
> 
> 
> That does beg the question though: Are the MouseEvent constants wrong for 
> Javascript?
> 
> 
>> On Jul 11, 2017, at 10:38 AM, Harbs > > wrote:
>> 
>> Shouldn’t the event be triggered by rollover rather than mouseover?
>> 
>> That seems like the issue to me…
>> 
>>> On Jul 11, 2017, at 10:13 AM, Alex Harui >> > wrote:
>>> 
>>> This seems like "just-in-case" code.  I could see that it might be needed
>>> in a different bead for Express though.
>>> 
>>> Without this change, is there an infinite loop somewhere?
>>> 
>>> Thanks,
>>> -Alex
>>> 
>>> On 7/10/17, 10:40 PM, "jmcl...@apache.org " 
>>> > wrote:
>>> 
 FLEX-35338 stop cursor from spinning / CPU from spiking
 
 
 Project: 
 https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us 
 
 .apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo=02%7C01%7C%7C8e2e2d5b3b3
 54f54848508d4c81f5768%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6363534
 84318029070=32hEJB%2BTNsWKG8MY%2FdPr3d0RWT5Xr1tECWWpVTlM270%3D
 ved=0
 Commit: 
 https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
 .apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%2F549a10d8=02%7C01%7C%
 7C8e2e2d5b3b354f54848508d4c81f5768%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%
 7C0%7C636353484318029070=dcNhAGu8WspafZBZCRxb%2FN0z7D%2Fym3tuv%2BAaq
 G280z0%3D=0
 Tree: 
 https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
 .apache.org%2Frepos%2Fasf%2Fflex-asjs%2Ftree%2F549a10d8=02%7C01%7C%7C
 8e2e2d5b3b354f54848508d4c81f5768%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C
 0%7C636353484318029070=0p89CGQLSv0Pp0yscOBNjKRJ1HUMhHrDngm4xxixalc%3
 D=0
 Diff: 
 https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
 .apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2F549a10d8=02%7C01%7C%7C
 8e2e2d5b3b354f54848508d4c81f5768%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C
 0%7C636353484318029070=%2FclUp4scfr0z%2B%2FTPjBMlVw2kScADTcLPMwop5J4
 7cIU%3D=0
 
 Branch: refs/heads/develop
 Commit: 549a10d82da5835c61a2b1247b65f7bfbc2f9a36
 Parents: 3891820
 Author: Justin Mclean 
 Authored: Tue Jul 11 14:57:04 2017 +1000
 Committer: Justin Mclean 
 Committed: Tue Jul 11 14:57:04 2017 +1000
 
 --
 .../main/flex/org/apache/flex/html/accessories/ToolTipBead.as   | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)
 --
 
 
 https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
 .apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2F549a10d8%2Fframeworks%2Fpro
 jects%2FBasic%2Fsrc%2Fmain%2Fflex%2Forg%2Fapache%2Fflex%2Fhtml%2Faccessori
 es%2FToolTipBead.as=02%7C01%7C%7C8e2e2d5b3b354f54848508d4c81f5768%7Cf
 a7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636353484318029070=hifp5T8
 xFlL4zov22P5qOUYtZqrYuPqTqOJg2x4X5lo%3D=0
 --
 diff --git 
 a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories
 /ToolTipBead.as 
 b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories
 /ToolTipBead.as
 index 03ce21e..bdf0b68 100644
 --- 
 a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories
 /ToolTipBead.as
 +++ 
 b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories
 /ToolTipBead.as
 @@ -100,7 +100,10 @@ package org.apache.flex.html.accessories
 * @private
 */
protected function rollOverHandler( event:MouseEvent ):void
 -  {   
 +  {
 +  if (!toolTip)
 +  

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

[Harbs]

Did you try mouseenter? (See my other responses)

It seems like that should solve the problem.

> On Jul 11, 2017, at 11:01 AM, Justin Mclean  wrote:
> 
> Hi,
> 
> I not sure how this could be consider "just in case" when previous the 
> tooltip didn’t work and had an infinite loop? Before it was incorrectly 
> destroying and recreating the tooltip endlessly when you were still inside 
> the UI element. You got a horrible flickering / strobing as it created and 
> destroyed the tooltip as fast as it possibly could when you moused over the 
> tooltip itself.
> 
> But if you have an alternative (tested) way of fixing this please do suggest 
> it and/or modify the code.
> 
> Thanks,
> Justin

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

[Justin Mclean]

Hi,

I not sure how this could be consider "just in case" when previous the tooltip 
didn’t work and had an infinite loop? Before it was incorrectly destroying and 
recreating the tooltip endlessly when you were still inside the UI element. You 
got a horrible flickering / strobing as it created and destroyed the tooltip as 
fast as it possibly could when you moused over the tooltip itself.

But if you have an alternative (tested) way of fixing this please do suggest it 
and/or modify the code.

Thanks,
Justin

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

[Harbs]

Shouldn’t the event be triggered by rollover rather than mouseover?

That seems like the issue to me…

> On Jul 11, 2017, at 10:13 AM, Alex Harui  wrote:
> 
> This seems like "just-in-case" code.  I could see that it might be needed
> in a different bead for Express though.
> 
> Without this change, is there an infinite loop somewhere?
> 
> Thanks,
> -Alex
> 
> On 7/10/17, 10:40 PM, "jmcl...@apache.org"  wrote:
> 
>> FLEX-35338 stop cursor from spinning / CPU from spiking
>> 
>> 
>> Project: 
>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>> .apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo=02%7C01%7C%7C8e2e2d5b3b3
>> 54f54848508d4c81f5768%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6363534
>> 84318029070=32hEJB%2BTNsWKG8MY%2FdPr3d0RWT5Xr1tECWWpVTlM270%3D
>> ved=0
>> Commit: 
>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>> .apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%2F549a10d8=02%7C01%7C%
>> 7C8e2e2d5b3b354f54848508d4c81f5768%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%
>> 7C0%7C636353484318029070=dcNhAGu8WspafZBZCRxb%2FN0z7D%2Fym3tuv%2BAaq
>> G280z0%3D=0
>> Tree: 
>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>> .apache.org%2Frepos%2Fasf%2Fflex-asjs%2Ftree%2F549a10d8=02%7C01%7C%7C
>> 8e2e2d5b3b354f54848508d4c81f5768%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C
>> 0%7C636353484318029070=0p89CGQLSv0Pp0yscOBNjKRJ1HUMhHrDngm4xxixalc%3
>> D=0
>> Diff: 
>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>> .apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2F549a10d8=02%7C01%7C%7C
>> 8e2e2d5b3b354f54848508d4c81f5768%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C
>> 0%7C636353484318029070=%2FclUp4scfr0z%2B%2FTPjBMlVw2kScADTcLPMwop5J4
>> 7cIU%3D=0
>> 
>> Branch: refs/heads/develop
>> Commit: 549a10d82da5835c61a2b1247b65f7bfbc2f9a36
>> Parents: 3891820
>> Author: Justin Mclean 
>> Authored: Tue Jul 11 14:57:04 2017 +1000
>> Committer: Justin Mclean 
>> Committed: Tue Jul 11 14:57:04 2017 +1000
>> 
>> --
>> .../main/flex/org/apache/flex/html/accessories/ToolTipBead.as   | 5 -
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>> --
>> 
>> 
>> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>> .apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2F549a10d8%2Fframeworks%2Fpro
>> jects%2FBasic%2Fsrc%2Fmain%2Fflex%2Forg%2Fapache%2Fflex%2Fhtml%2Faccessori
>> es%2FToolTipBead.as=02%7C01%7C%7C8e2e2d5b3b354f54848508d4c81f5768%7Cf
>> a7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636353484318029070=hifp5T8
>> xFlL4zov22P5qOUYtZqrYuPqTqOJg2x4X5lo%3D=0
>> --
>> diff --git 
>> a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories
>> /ToolTipBead.as 
>> b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories
>> /ToolTipBead.as
>> index 03ce21e..bdf0b68 100644
>> --- 
>> a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories
>> /ToolTipBead.as
>> +++ 
>> b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories
>> /ToolTipBead.as
>> @@ -100,7 +100,10 @@ package org.apache.flex.html.accessories
>>   * @private
>>   */
>>  protected function rollOverHandler( event:MouseEvent ):void
>> -{   
>> +{
>> +if (!toolTip)
>> +return;
>> +
>> 
>> IEventDispatcher(_strand).addEventListener(MouseEvent.MOUSE_OUT,
>> rollOutHandler, false);
>> 
>>var comp:IUIBase = _strand as IUIBase
>> 
> 

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

[Alex Harui]

Hi Justin,

Are you saying a rollOut is being dispatched when you haven't rolled out
of the tooltip?  WOuldn't that be a problem in the rollout logic?

-Alex

On 7/10/17, 11:14 PM, "Justin Mclean"  wrote:

>Hi,
>
>And my last check has fixed the issue so should be all good.
>
>Thanks,
>Justin

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

[Alex Harui]

This seems like "just-in-case" code.  I could see that it might be needed
in a different bead for Express though.

Without this change, is there an infinite loop somewhere?

Thanks,
-Alex

On 7/10/17, 10:40 PM, "jmcl...@apache.org"  wrote:

>FLEX-35338 stop cursor from spinning / CPU from spiking
>
>
>Project: 
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo=02%7C01%7C%7C8e2e2d5b3b3
>54f54848508d4c81f5768%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6363534
>84318029070=32hEJB%2BTNsWKG8MY%2FdPr3d0RWT5Xr1tECWWpVTlM270%3D
>ved=0
>Commit: 
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%2F549a10d8=02%7C01%7C%
>7C8e2e2d5b3b354f54848508d4c81f5768%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%
>7C0%7C636353484318029070=dcNhAGu8WspafZBZCRxb%2FN0z7D%2Fym3tuv%2BAaq
>G280z0%3D=0
>Tree: 
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Ftree%2F549a10d8=02%7C01%7C%7C
>8e2e2d5b3b354f54848508d4c81f5768%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C
>0%7C636353484318029070=0p89CGQLSv0Pp0yscOBNjKRJ1HUMhHrDngm4xxixalc%3
>D=0
>Diff: 
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2F549a10d8=02%7C01%7C%7C
>8e2e2d5b3b354f54848508d4c81f5768%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C
>0%7C636353484318029070=%2FclUp4scfr0z%2B%2FTPjBMlVw2kScADTcLPMwop5J4
>7cIU%3D=0
>
>Branch: refs/heads/develop
>Commit: 549a10d82da5835c61a2b1247b65f7bfbc2f9a36
>Parents: 3891820
>Author: Justin Mclean 
>Authored: Tue Jul 11 14:57:04 2017 +1000
>Committer: Justin Mclean 
>Committed: Tue Jul 11 14:57:04 2017 +1000
>
>--
> .../main/flex/org/apache/flex/html/accessories/ToolTipBead.as   | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>--
>
>
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2F549a10d8%2Fframeworks%2Fpro
>jects%2FBasic%2Fsrc%2Fmain%2Fflex%2Forg%2Fapache%2Fflex%2Fhtml%2Faccessori
>es%2FToolTipBead.as=02%7C01%7C%7C8e2e2d5b3b354f54848508d4c81f5768%7Cf
>a7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636353484318029070=hifp5T8
>xFlL4zov22P5qOUYtZqrYuPqTqOJg2x4X5lo%3D=0
>--
>diff --git 
>a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories
>/ToolTipBead.as 
>b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories
>/ToolTipBead.as
>index 03ce21e..bdf0b68 100644
>--- 
>a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories
>/ToolTipBead.as
>+++ 
>b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/accessories
>/ToolTipBead.as
>@@ -100,7 +100,10 @@ package org.apache.flex.html.accessories
>* @private
>*/
>   protected function rollOverHandler( event:MouseEvent ):void
>-  {   
>+  {
>+  if (!toolTip)
>+  return;
>+
> 
>IEventDispatcher(_strand).addEventListener(MouseEvent.MOUSE_OUT,
>rollOutHandler, false);
> 
> var comp:IUIBase = _strand as IUIBase
>

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

[Justin Mclean]

Hi,

And my last check has fixed the issue so should be all good.

Thanks,
Justin

Re: [2/5] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35338 stop cursor from spinning / CPU from spiking

[Justin Mclean]

Hi,

JFYI still work in progress the calculations around outside need a little bit 
more work as I’m reasonably sure it need to take into account the x, y co-ords 
and check left and top boundaries as well. I’ll get to that later today / 
tomorrow.

Thanks,
Justin