Re: git commit: [flex-asjs] [refs/heads/release0.8.0] - Fix for FLEX-35322: NumericStepper layout.

2017-06-07 Thread Harbs
Nope. Looks right to me.

> On Jun 7, 2017, at 3:03 AM, Justin Mclean  wrote:
> 
> Hi,
> 
> Not 100% sure and I probably not understanding what these methods are doing 
> but perhaps the issue is in isHeightSizedToContent / isWidthSizedToContent.
> 
> Does the last line of each function look suspect to anyone else?
> 
> return (left === undefined || right === undefined);
> 
> return (top === undefined || bottom === undefined); 
> 
> I would of expected that && be used rather than ||?
> 
> Thanks,
> Justin
> 



Re: git commit: [flex-asjs] [refs/heads/release0.8.0] - Fix for FLEX-35322: NumericStepper layout.

2017-06-06 Thread Justin Mclean
Hi,

Not 100% sure and I probably not understanding what these methods are doing but 
perhaps the issue is in isHeightSizedToContent / isWidthSizedToContent.

Does the last line of each function look suspect to anyone else?

return (left === undefined || right === undefined);

return (top === undefined || bottom === undefined); 

I would of expected that && be used rather than ||?

Thanks,
Justin