Re: git commit: [flex-asjs] [refs/heads/develop] - - Add first Material Icons beads "cancel" and "add" - Use "add' material icon bead in Buttons example - Add missing classList - Throw error Deletable

[Carlos Rovira]

As I saw is common for all, for that reason I think we could have a Base
Class with that common properties that rest off icons will inherit. If not
you will end replicating in all material icon classes ;)

2016-12-02 7:04 GMT+01:00 piotrz :

> One question - does "md-48" is something what can you put to every
> "material-icons" or it's something specific to some choosen elements?
>
> Piotr
>
>
>
> -
> Apache Flex PMC
> piotrzarzyck...@gmail.com
> --
> View this message in context: http://apache-flex-
> development.247.n4.nabble.com/Re-git-commit-flex-asjs-
> refs-heads-develop-Add-first-Material-Icons-beads-cancel-
> and-add-Use-add-mats-tp56899p56912.html
> Sent from the Apache Flex Development mailing list archive at Nabble.com.
>



-- 

Carlos Rovira
Director General
M: +34 607 22 60 05
http://www.codeoscopic.com
http://www.avant2.es

Este mensaje se dirige exclusivamente a su destinatario y puede contener
información privilegiada o confidencial. Si ha recibido este mensaje por
error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
proceda a su destrucción.

De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
S.A. La finalidad de dicho tratamiento es facilitar la prestación del
servicio o información solicitados, teniendo usted derecho de acceso,
rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
necesaria.

Re: git commit: [flex-asjs] [refs/heads/develop] - - Add first Material Icons beads "cancel" and "add" - Use "add' material icon bead in Buttons example - Add missing classList - Throw error Deletable

[piotrz]

One question - does "md-48" is something what can you put to every
"material-icons" or it's something specific to some choosen elements?

Piotr



-
Apache Flex PMC
piotrzarzyck...@gmail.com
--
View this message in context: 
http://apache-flex-development.247.n4.nabble.com/Re-git-commit-flex-asjs-refs-heads-develop-Add-first-Material-Icons-beads-cancel-and-add-Use-add-mats-tp56899p56912.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: git commit: [flex-asjs] [refs/heads/develop] - - Add first Material Icons beads "cancel" and "add" - Use "add' material icon bead in Buttons example - Add missing classList - Throw error Deletable

[Piotr Zarzycki]

Carlos,

Do you think that "MaterialIcons" class should extends "I" and implements
"IBead". Derived classes like MaterialIconCancel will apply only
MaterialIconsType.Cancel ?

Piotr

2016-12-02 0:26 GMT+01:00 :

> Repository: flex-asjs
> Updated Branches:
>   refs/heads/develop 7493febe8 -> 0b9753ef5
>
>
> - Add first Material Icons beads "cancel" and "add"
> - Use "add' material icon bead in Buttons example
> - Add missing classList
> - Throw error DeletableChip strand do not meet requirements
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/0b9753ef
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/0b9753ef
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/0b9753ef
>
> Branch: refs/heads/develop
> Commit: 0b9753ef54928628b84db0466817418efffe5c92
> Parents: 7493feb
> Author: piotrz 
> Authored: Fri Dec 2 00:26:45 2016 +0100
> Committer: piotrz 
> Committed: Fri Dec 2 00:26:45 2016 +0100
>
> --
>  .../MDLExample/src/main/flex/Buttons.mxml   |  4 +-
>  .../flex/org/apache/flex/mdl/beads/Badge.as |  3 +-
>  .../org/apache/flex/mdl/beads/DeletableChip.as  | 10 ++-
>  .../flex/org/apache/flex/mdl/beads/Restrict.as  | 12 +---
>  .../mdl/beads/materialIcons/MaterialIconAdd.as  | 74 
>  .../beads/materialIcons/MaterialIconCancel.as   | 74 
>  .../beads/materialIcons/MaterialIconsType.as| 26 +++
>  .../flex/mdl/supportClasses/MaterialIcons.as| 61 
>  .../src/main/resources/mdl-manifest.xml |  2 +
>  9 files changed, 250 insertions(+), 16 deletions(-)
> --
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/
> 0b9753ef/examples/flexjs/MDLExample/src/main/flex/Buttons.mxml
> --
> diff --git a/examples/flexjs/MDLExample/src/main/flex/Buttons.mxml
> b/examples/flexjs/MDLExample/src/main/flex/Buttons.mxml
> index d6c3853..7879fad 100644
> --- a/examples/flexjs/MDLExample/src/main/flex/Buttons.mxml
> +++ b/examples/flexjs/MDLExample/src/main/flex/Buttons.mxml
> @@ -32,7 +32,9 @@ limitations under the License.
>  
>  
>  
> -add
> +
> +
> +
>  
>  
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/
> 0b9753ef/frameworks/projects/MaterialDesignLite/src/main/
> flex/org/apache/flex/mdl/beads/Badge.as
> --
> diff --git a/frameworks/projects/MaterialDesignLite/src/main/
> flex/org/apache/flex/mdl/beads/Badge.as b/frameworks/projects/
> MaterialDesignLite/src/main/flex/org/apache/flex/mdl/beads/Badge.as
> index 4abb3ed..49feb2a 100644
> --- a/frameworks/projects/MaterialDesignLite/src/main/
> flex/org/apache/flex/mdl/beads/Badge.as
> +++ b/frameworks/projects/MaterialDesignLite/src/main/
> flex/org/apache/flex/mdl/beads/Badge.as
> @@ -147,7 +147,8 @@ package org.apache.flex.mdl.beads
> 
> host.element.classList.toggle("mdl-badge--no-background",
> _noBackground);
> 
> host.element.classList.toggle("mdl-badge--overlap",
> _overlap);
> 
> host.element.setAttribute('data-badge',
> _dataBadge.toString());
> -   } else
> +   }
> +   else
> {
> throw new Error("Host component
> must be an MDL Host for Badges.");
> }
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/
> 0b9753ef/frameworks/projects/MaterialDesignLite/src/main/
> flex/org/apache/flex/mdl/beads/DeletableChip.as
> --
> diff --git a/frameworks/projects/MaterialDesignLite/src/main/
> flex/org/apache/flex/mdl/beads/DeletableChip.as b/frameworks/projects/
> MaterialDesignLite/src/main/flex/org/apache/flex/mdl/
> beads/DeletableChip.as
> index f5a5329..bf75144 100644
> --- a/frameworks/projects/MaterialDesignLite/src/main/
> flex/org/apache/flex/mdl/beads/DeletableChip.as
> +++ b/frameworks/projects/MaterialDesignLite/src/main/
> flex/org/apache/flex/mdl/beads/DeletableChip.as
> @@ -47,12 +47,12 @@ package org.apache.flex.mdl.beads
>
>  }
>
> -private var deleteButton:Button;
> -
>  private var _strand:IStrand;
>
>  /**
>   * @flexjsignorecoercion HTMLElement
> + * @flexjsignorecoercion HTMLSpanElement
> + * @flexjsignorecoercion HTMLButtonElement
>   *
>   * @param value
>