Re: Request for contributor permission

2018-09-30 Thread Tzu-Li Chen 
Hi Gao,

Welcome to Flink community! cc Till and Stephan for you.

Best,
tison.


yungao.gy  于2018年10月1日周一 下午1:42写道：

>
> Hi all,
>
> I want to start contributing to Flink with FLINK-10469. Could someone
> grant me the contributor permission? My Jira ID is gaoyunhaii and my full
> name is Yun Gao. Thanks a lot ! :)
>
>
> Yours sincerely
>   Yun Gao

Request for contributor permission

2018-09-30 Thread yungao.gy 

Hi all,

I want to start contributing to Flink with FLINK-10469. Could someone grant me 
the contributor permission? My Jira ID is gaoyunhaii and my full name is Yun 
Gao. Thanks a lot ! :)


Yours sincerely
  Yun Gao

[jira] [Created] (FLINK-10469) FileChannel may not write the whole buffer in a single call to FileChannel.write(Buffer buffer)

2018-09-30 Thread Yun Gao (JIRA) 
Yun Gao created FLINK-10469:
---

 Summary: FileChannel may not write the whole buffer in a single 
call to FileChannel.write(Buffer buffer)
 Key: FLINK-10469
 URL: https://issues.apache.org/jira/browse/FLINK-10469
 Project: Flink
  Issue Type: Bug
  Components: Core
Affects Versions: 1.5.4, 1.6.1, 1.6.0, 1.5.3, 1.4.2, 1.4.1, 1.7.0, 1.6.2
Reporter: Yun Gao


Currently all the calls to _FileChannel.write(ByteBuffer src)_ assumes that 
this method will not return before the whole buffer is written, like the one in 
_AsynchronousFileIOChannel.write()._

 

However, this assumption may not be right for all the environments. We have 
encountered the case that only part of a buffer was written on a cluster with a 
high IO load, and the target file got messy. 

 

To fix this issue, I think we should add a utility method in the 
org.apache.flink.util.IOUtils to ensure the whole buffer is written with a 
loop，and replace all the calls to _FileChannel.write(ByteBuffer)_ with this new 
method. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (FLINK-10468) Potential missing break for PARTITION_CUSTOM in OutputEmitter ctor

2018-09-30 Thread Ted Yu (JIRA) 
Ted Yu created FLINK-10468:
--

 Summary: Potential missing break for PARTITION_CUSTOM in 
OutputEmitter ctor
 Key: FLINK-10468
 URL: https://issues.apache.org/jira/browse/FLINK-10468
 Project: Flink
  Issue Type: Bug
Reporter: Ted Yu


Here is related code:
{code}
switch (strategy) {
case PARTITION_CUSTOM:
  extractedKeys = new Object[1];
case FORWARD:
{code}
It seems a 'break' is missing prior to FORWARD case.
{code}
if (strategy == ShipStrategyType.PARTITION_CUSTOM && partitioner == null) {
  throw new NullPointerException("Partitioner must not be null when the 
ship strategy is set to custom partitioning.");
}
{code}
Since the above check is for PARTITION_CUSTOM, it seems we can place the check 
in the switch statement.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)