[jira] [Created] (FLINK-4668) Fix positive random int generation
Alexander Pivovarov created FLINK-4668:
--
Summary: Fix positive random int generation
Key: FLINK-4668
URL: https://issues.apache.org/jira/browse/FLINK-4668
Project: Flink
Issue Type: Bug
Components: Client
Reporter: Alexander Pivovarov
Priority: Trivial
According to java spec
{code}Math.abs(Integer.MIN_VALUE) == Integer.MIN_VALUE{code}
So, {code}Math.abs(rnd.nextInt()){code} might return negative value
To generate positive random int value we can use
{code}rnd.nextInt(Integer.MAX_VALUE){code}
Integer.MAX_VALUE will be excluded btw
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (FLINK-4666) Make constants final in ParameterTool
Alexander Pivovarov created FLINK-4666: -- Summary: Make constants final in ParameterTool Key: FLINK-4666 URL: https://issues.apache.org/jira/browse/FLINK-4666 Project: Flink Issue Type: Bug Components: Java API Reporter: Alexander Pivovarov Priority: Trivial NO_VALUE_KEY and DEFAULT_UNDEFINED in ParameterTool should be final -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (FLINK-4665) Remove boxing/unboxing to parse a primitive
Alexander Pivovarov created FLINK-4665: -- Summary: Remove boxing/unboxing to parse a primitive Key: FLINK-4665 URL: https://issues.apache.org/jira/browse/FLINK-4665 Project: Flink Issue Type: Bug Components: Java API Reporter: Alexander Pivovarov Priority: Trivial I found the following issues with boxing/unboxing and Integer 1. Current code doing boxing/unboxing to parse a primitive - It is more efficient to just call the static parseXXX method. 2. boxing/unboxing to do type cast 3. new Integer instead of valueOf - Using new Integer(int) is guaranteed to always result in a new object whereas Integer.valueOf(int) allows caching of values to be done by the compiler. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (FLINK-4612) Close FileWriter using try with resources
Alexander Pivovarov created FLINK-4612: -- Summary: Close FileWriter using try with resources Key: FLINK-4612 URL: https://issues.apache.org/jira/browse/FLINK-4612 Project: Flink Issue Type: Bug Components: Java API Affects Versions: 1.1.2 Reporter: Alexander Pivovarov Priority: Trivial FileWriter is not closed properly in many places in the project modules -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (FLINK-4610) Replace keySet/getValue with entrySet in UdfAnalyzerUtils
Alexander Pivovarov created FLINK-4610: -- Summary: Replace keySet/getValue with entrySet in UdfAnalyzerUtils Key: FLINK-4610 URL: https://issues.apache.org/jira/browse/FLINK-4610 Project: Flink Issue Type: Improvement Components: Java API Affects Versions: 1.1.2 Reporter: Alexander Pivovarov Priority: Minor Map.keySet + getValue combination is not very efficient It can be replaced with Map.entrySet to avoid values lookup Also MapEntry allows to modify Map values while iterating thought the map using entrySet.iterator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (FLINK-4609) Remove redundant check for null in CrossOperator
Alexander Pivovarov created FLINK-4609: -- Summary: Remove redundant check for null in CrossOperator Key: FLINK-4609 URL: https://issues.apache.org/jira/browse/FLINK-4609 Project: Flink Issue Type: Bug Components: Java API Affects Versions: 1.1.2 Reporter: Alexander Pivovarov Priority: Trivial CrossOperator checks input1 and input2 for null after they were dereferenced -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (FLINK-4608) Use short-circuit AND in Max/Min AggregationFunction
Alexander Pivovarov created FLINK-4608: -- Summary: Use short-circuit AND in Max/Min AggregationFunction Key: FLINK-4608 URL: https://issues.apache.org/jira/browse/FLINK-4608 Project: Flink Issue Type: Bug Components: Java API Affects Versions: 1.1.2 Reporter: Alexander Pivovarov Priority: Trivial -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (FLINK-4607) Close FileInputStream in ParameterTool and other
Alexander Pivovarov created FLINK-4607:
--
Summary: Close FileInputStream in ParameterTool and other
Key: FLINK-4607
URL: https://issues.apache.org/jira/browse/FLINK-4607
Project: Flink
Issue Type: Bug
Affects Versions: 1.1.2
Reporter: Alexander Pivovarov
Priority: Trivial
ParameterTool and some tests do not close FileInputStream
{code}
flink-core/src/test/java/org/apache/flink/core/fs/local/LocalFileSystemTest.java
flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
flink-java8/src/test/java/org/apache/flink/runtime/util/JarFileCreatorLambdaTest.java
flink-runtime/src/test/java/org/apache/flink/runtime/util/JarFileCreatorTest.java
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (FLINK-4601) Check for empty string properly
Alexander Pivovarov created FLINK-4601: -- Summary: Check for empty string properly Key: FLINK-4601 URL: https://issues.apache.org/jira/browse/FLINK-4601 Project: Flink Issue Type: Bug Affects Versions: 1.1.2 Reporter: Alexander Pivovarov Priority: Trivial UdfAnalyzerExamplesTest.java and UdfAnalyzerTest.java use == to check for empty string. We should use isEmpty() instead -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (FLINK-4595) Close FileOutputStream in ParameterTool
Alexander Pivovarov created FLINK-4595:
--
Summary: Close FileOutputStream in ParameterTool
Key: FLINK-4595
URL: https://issues.apache.org/jira/browse/FLINK-4595
Project: Flink
Issue Type: Bug
Components: Java API
Affects Versions: 1.1.2
Reporter: Alexander Pivovarov
Priority: Trivial
ParameterTool and ParameterToolTest do not close FileOutputStream
{code}
defaultProps.store(new FileOutputStream(file), "Default file created by Flink's
ParameterUtil.createPropertiesFile()");
{code}
{code}
props.store(new FileOutputStream(propertiesFile), "Test properties");
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
release-1.1.2 does not exist on github
Hi Everyone I noticed that release-1.1.2 does not exist on github https://github.com/apache/flink/releases Regards Alex
[jira] [Created] (FLINK-4593) Fix PageRank algorithm example
Alexander Pivovarov created FLINK-4593:
--
Summary: Fix PageRank algorithm example
Key: FLINK-4593
URL: https://issues.apache.org/jira/browse/FLINK-4593
Project: Flink
Issue Type: Bug
Components: Project Website
Reporter: Alexander Pivovarov
Priority: Minor
This page https://flink.apache.org/features.html shows the code which
implements PageRank algorithm (Batch Processing Applications).
I noticed couple bugs in the code
Page class has pageId field
Adjacency has just id
but in the code I see
{code}pages.join(adjacency).where("pageId").equalTo("pageId"){code}
Also {code}Page(page.id, 0.15 / numPages){code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (FLINK-4585) Fix broken links on flink.apache.org
Alexander Pivovarov created FLINK-4585: -- Summary: Fix broken links on flink.apache.org Key: FLINK-4585 URL: https://issues.apache.org/jira/browse/FLINK-4585 Project: Flink Issue Type: Bug Components: Project Website Reporter: Alexander Pivovarov Priority: Minor The following links are broken link: http://ci.apache.org/projects/flink/flink-docs-master/apis/batch/index.html correct link: https://ci.apache.org/projects/flink/flink-docs-master/dev/batch/index.html link: http://ci.apache.org/projects/flink/flink-docs-master/apis/batch/libs/table.html correct link: https://ci.apache.org/projects/flink/flink-docs-master/dev/table_api.html The following links show "Page 'X' Has Moved to" for 1-2 sec and then redirect to correct page link: http://ci.apache.org/projects/flink/flink-docs-master/apis/streaming/index.html redirect-to: https://ci.apache.org/projects/flink/flink-docs-master/dev/datastream_api.html link: http://ci.apache.org/projects/flink/flink-docs-master/apis/programming_guide.html redirect-to: https://ci.apache.org/projects/flink/flink-docs-master/dev/batch/index.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (FLINK-4584) Fix broken links on flink.apache.org
Alexander Pivovarov created FLINK-4584: -- Summary: Fix broken links on flink.apache.org Key: FLINK-4584 URL: https://issues.apache.org/jira/browse/FLINK-4584 Project: Flink Issue Type: Bug Components: Project Website Reporter: Alexander Pivovarov Priority: Minor The following links are broken link: http://ci.apache.org/projects/flink/flink-docs-master/apis/batch/index.html correct link: https://ci.apache.org/projects/flink/flink-docs-master/dev/batch/index.html link: http://ci.apache.org/projects/flink/flink-docs-master/apis/batch/libs/table.html correct link: https://ci.apache.org/projects/flink/flink-docs-master/dev/table_api.html The following links show "Page 'X' Has Moved to" for 1-2 sec and then redirect to correct page link: http://ci.apache.org/projects/flink/flink-docs-master/apis/streaming/index.html redirect-to: https://ci.apache.org/projects/flink/flink-docs-master/dev/datastream_api.html link: http://ci.apache.org/projects/flink/flink-docs-master/apis/programming_guide.html redirect-to: https://ci.apache.org/projects/flink/flink-docs-master/dev/batch/index.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
