Re: [VOTE] Release 1.3.2, release candidate #2

[Aljoscha Krettek]

Hi,

I think FLINK-7352 is only a testing instability. We should definitely fix that 
but I don't think it should block the release, which has quite a few critical 
fixes.

Best,
Aljoscha

> On 5. Aug 2017, at 00:05, Ted Yu  wrote:
> 
> When I ran integration tests, I bumped into:
> FLINK-7352
> 
> Should this be resolved for 1.3.2 ?
> 
> Thanks
> 
> On Sun, Jul 30, 2017 at 12:07 AM, Aljoscha Krettek 
> wrote:
> 
>> Hi everyone,
>> 
>> Please review and vote on the release candidate #2 for the version 1.3.2,
>> as follows:
>> [ ] +1, Approve the release
>> [ ] -1, Do not approve the release (please provide specific comments)
>> 
>> 
>> The complete staging area is available for your review, which includes:
>> * JIRA release notes [1],
>> * the official Apache source release and binary convenience releases to be
>> deployed to dist.apache.org [2], which is signed with the key with
>> fingerprint 0xA8F4FD97121D7293 [3],
>> * all artifacts to be deployed to the Maven Central Repository [4],
>> * source code tag "release-1.3.2-rc2" [5],
>> * website pull request listing the new release and adding announcement
>> blog post [6].
>> 
>> The vote will be open for at least 72 hours (excluding this current
>> weekend). It is adopted by majority approval, with at least 3 PMC
>> affirmative votes.
>> 
>> Please use the provided document, as discussed before, for coordinating
>> the testing efforts: [7]
>> 
>> Thanks,
>> Aljoscha
>> 
>> [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>> projectId=12315522=12340984
>> [2] http://people.apache.org/~aljoscha/flink-1.3.2-rc2/
>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>> [4] https://repository.apache.org/content/repositories/
>> orgapacheflink-1133/
>> [5] https://git-wip-us.apache.org/repos/asf?p=flink.git;a=tag;h=
>> e38825d0c8e7fe2191a4c657984d9939ed8dd0ad
>> [6] https://github.com/apache/flink-web/pull/75
>> [7] https://docs.google.com/document/d/1dN9AM9FUPizIu4hTKAXJSbbAORRdr
>> ce-BqQ8AUHlOqE/edit?usp=sharing

Re: [VOTE] Release 1.3.2, release candidate #2

[Ted Yu]

When I ran integration tests, I bumped into:
FLINK-7352

Should this be resolved for 1.3.2 ?

Thanks

On Sun, Jul 30, 2017 at 12:07 AM, Aljoscha Krettek 
wrote:

> Hi everyone,
>
> Please review and vote on the release candidate #2 for the version 1.3.2,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
>
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release and binary convenience releases to be
> deployed to dist.apache.org [2], which is signed with the key with
> fingerprint 0xA8F4FD97121D7293 [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag "release-1.3.2-rc2" [5],
> * website pull request listing the new release and adding announcement
> blog post [6].
>
> The vote will be open for at least 72 hours (excluding this current
> weekend). It is adopted by majority approval, with at least 3 PMC
> affirmative votes.
>
> Please use the provided document, as discussed before, for coordinating
> the testing efforts: [7]
>
> Thanks,
> Aljoscha
>
> [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12315522=12340984
> [2] http://people.apache.org/~aljoscha/flink-1.3.2-rc2/
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4] https://repository.apache.org/content/repositories/
> orgapacheflink-1133/
> [5] https://git-wip-us.apache.org/repos/asf?p=flink.git;a=tag;h=
> e38825d0c8e7fe2191a4c657984d9939ed8dd0ad
> [6] https://github.com/apache/flink-web/pull/75
> [7] https://docs.google.com/document/d/1dN9AM9FUPizIu4hTKAXJSbbAORRdr
> ce-BqQ8AUHlOqE/edit?usp=sharing

[CANCEL] [VOTE] Release 1.3.2, release candidate #2

[Aljoscha Krettek]

Thanks for testing everyone. Unfortunately, I have to close this vote because 
of the problem with the Gelly Examples jar. I'll immediately create another RC 
(in fact I'm already on it). I'm hoping that we can do an expedited vote on 
that new RC because the only change in that RC is going to be a fix for the 
Gelly Examples jar.

Best,
Aljoscha
> On 3. Aug 2017, at 14:10, Fabian Hueske  wrote:
> 
> +1
> 
> - checked hashes and signatures
> - checked added and modified dependencies since Flink 1.3.1
>  - io.dropwizard.metrics/metrics-core was upgraded to 3.1.5 and is ASL
>  - org.xerial.snappy/snappy-java/1.0.5 was added and is ASL
> 
> - built from source
> 
> Thanks, Fabian
> 
> 2017-08-03 11:24 GMT+02:00 Stefan Richter :
> 
>> +1
>> 
>> 1. Cluster tests
>> 
>> Tested with the stateful state machine job on the following settings:
>> - Cloud env: AWS
>> - Distributions: EMR 5.7.0
>> - Flink deployment method: YARN (Hadoop 2.7.2)
>> - HA: enabled
>> - Kerberos: disabled
>> - Kafka version: 0.10, 0.11
>> - State Backends: Heap (Sync / Async) & RocksDB (incremental / full)
>> - Filesystem: S3 and HDFS (Hadoop 2.7.2)
>> - Externalized checkpoints: enabled & disabled
>> 
>> 2. Building with Scala 2.11 works
>> 
>> 3. Building against Hadoop version works
>> 
>> 
>>> Am 30.07.2017 um 09:07 schrieb Aljoscha Krettek :
>>> 
>>> Hi everyone,
>>> 
>>> Please review and vote on the release candidate #2 for the version
>> 1.3.2, as follows:
>>> [ ] +1, Approve the release
>>> [ ] -1, Do not approve the release (please provide specific comments)
>>> 
>>> 
>>> The complete staging area is available for your review, which includes:
>>> * JIRA release notes [1],
>>> * the official Apache source release and binary convenience releases to
>> be deployed to dist.apache.org [2], which is signed with the key with
>> fingerprint 0xA8F4FD97121D7293 [3],
>>> * all artifacts to be deployed to the Maven Central Repository [4],
>>> * source code tag "release-1.3.2-rc2" [5],
>>> * website pull request listing the new release and adding announcement
>> blog post [6].
>>> 
>>> The vote will be open for at least 72 hours (excluding this current
>> weekend). It is adopted by majority approval, with at least 3 PMC
>> affirmative votes.
>>> 
>>> Please use the provided document, as discussed before, for coordinating
>> the testing efforts: [7]
>>> 
>>> Thanks,
>>> Aljoscha
>>> 
>>> [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>> projectId=12315522=12340984
>>> [2] http://people.apache.org/~aljoscha/flink-1.3.2-rc2/
>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
>>> [4] https://repository.apache.org/content/repositories/
>> orgapacheflink-1133/
>>> [5] https://git-wip-us.apache.org/repos/asf?p=flink.git;a=tag;h=
>> e38825d0c8e7fe2191a4c657984d9939ed8dd0ad
>>> [6] https://github.com/apache/flink-web/pull/75
>>> [7] https://docs.google.com/document/d/1dN9AM9FUPizIu4hTKAXJSbbAORRdr
>> ce-BqQ8AUHlOqE/edit?usp=sharing
>> 
>> 

Re: [VOTE] Release 1.3.2, release candidate #2

[Fabian Hueske]

+1

- checked hashes and signatures
- checked added and modified dependencies since Flink 1.3.1
  - io.dropwizard.metrics/metrics-core was upgraded to 3.1.5 and is ASL
  - org.xerial.snappy/snappy-java/1.0.5 was added and is ASL

- built from source

Thanks, Fabian

2017-08-03 11:24 GMT+02:00 Stefan Richter :

> +1
>
> 1. Cluster tests
>
> Tested with the stateful state machine job on the following settings:
> - Cloud env: AWS
> - Distributions: EMR 5.7.0
> - Flink deployment method: YARN (Hadoop 2.7.2)
> - HA: enabled
> - Kerberos: disabled
> - Kafka version: 0.10, 0.11
> - State Backends: Heap (Sync / Async) & RocksDB (incremental / full)
> - Filesystem: S3 and HDFS (Hadoop 2.7.2)
> - Externalized checkpoints: enabled & disabled
>
> 2. Building with Scala 2.11 works
>
> 3. Building against Hadoop version works
>
>
> > Am 30.07.2017 um 09:07 schrieb Aljoscha Krettek :
> >
> > Hi everyone,
> >
> > Please review and vote on the release candidate #2 for the version
> 1.3.2, as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> >
> > The complete staging area is available for your review, which includes:
> > * JIRA release notes [1],
> > * the official Apache source release and binary convenience releases to
> be deployed to dist.apache.org [2], which is signed with the key with
> fingerprint 0xA8F4FD97121D7293 [3],
> > * all artifacts to be deployed to the Maven Central Repository [4],
> > * source code tag "release-1.3.2-rc2" [5],
> > * website pull request listing the new release and adding announcement
> blog post [6].
> >
> > The vote will be open for at least 72 hours (excluding this current
> weekend). It is adopted by majority approval, with at least 3 PMC
> affirmative votes.
> >
> > Please use the provided document, as discussed before, for coordinating
> the testing efforts: [7]
> >
> > Thanks,
> > Aljoscha
> >
> > [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12315522=12340984
> > [2] http://people.apache.org/~aljoscha/flink-1.3.2-rc2/
> > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > [4] https://repository.apache.org/content/repositories/
> orgapacheflink-1133/
> > [5] https://git-wip-us.apache.org/repos/asf?p=flink.git;a=tag;h=
> e38825d0c8e7fe2191a4c657984d9939ed8dd0ad
> > [6] https://github.com/apache/flink-web/pull/75
> > [7] https://docs.google.com/document/d/1dN9AM9FUPizIu4hTKAXJSbbAORRdr
> ce-BqQ8AUHlOqE/edit?usp=sharing
>
>

Re: [VOTE] Release 1.3.2, release candidate #2

[Stefan Richter]

+1

1. Cluster tests

Tested with the stateful state machine job on the following settings:
- Cloud env: AWS
- Distributions: EMR 5.7.0
- Flink deployment method: YARN (Hadoop 2.7.2)
- HA: enabled
- Kerberos: disabled
- Kafka version: 0.10, 0.11
- State Backends: Heap (Sync / Async) & RocksDB (incremental / full)
- Filesystem: S3 and HDFS (Hadoop 2.7.2)
- Externalized checkpoints: enabled & disabled

2. Building with Scala 2.11 works

3. Building against Hadoop version works


> Am 30.07.2017 um 09:07 schrieb Aljoscha Krettek :
> 
> Hi everyone,
> 
> Please review and vote on the release candidate #2 for the version 1.3.2, as 
> follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
> 
> 
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release and binary convenience releases to be 
> deployed to dist.apache.org [2], which is signed with the key with 
> fingerprint 0xA8F4FD97121D7293 [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag "release-1.3.2-rc2" [5],
> * website pull request listing the new release and adding announcement blog 
> post [6]. 
> 
> The vote will be open for at least 72 hours (excluding this current weekend). 
> It is adopted by majority approval, with at least 3 PMC affirmative votes.
> 
> Please use the provided document, as discussed before, for coordinating the 
> testing efforts: [7]
> 
> Thanks,
> Aljoscha
> 
> [1] 
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12340984
> [2] http://people.apache.org/~aljoscha/flink-1.3.2-rc2/
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4] https://repository.apache.org/content/repositories/orgapacheflink-1133/
> [5] 
> https://git-wip-us.apache.org/repos/asf?p=flink.git;a=tag;h=e38825d0c8e7fe2191a4c657984d9939ed8dd0ad
> [6] https://github.com/apache/flink-web/pull/75
> [7] 
> https://docs.google.com/document/d/1dN9AM9FUPizIu4hTKAXJSbbAORRdrce-BqQ8AUHlOqE/edit?usp=sharing

Re: [VOTE] Release 1.3.2, release candidate #2

[Greg Hogan]

-1

The Gelly examples jar is not included in the Scala 2.11 convenience binaries 
since change-scala-version.sh is not switching the hard-coded Scala version 
from 2.10 to 2.11 in ./flink-dist/src/main/assemblies/bin.xml. The simplest fix 
may be to revert FLINK-7211 and simply exclude the corresponding javadoc jar 
(this is only an issue in the 1.3 branch, the FLINK-7211 should be working on 
master). I don’t think I’ll have time to submit this tomorrow.

I would like to look into adding an end-to-end test for Gelly for the next 
release.

Greg

> On Jul 30, 2017, at 3:07 AM, Aljoscha Krettek  wrote:
> 
> Hi everyone,
> 
> Please review and vote on the release candidate #2 for the version 1.3.2, as 
> follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
> 
> 
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release and binary convenience releases to be 
> deployed to dist.apache.org [2], which is signed with the key with 
> fingerprint 0xA8F4FD97121D7293 [3],
> * all artifacts to be deployed to the Maven Central Repository [4],
> * source code tag "release-1.3.2-rc2" [5],
> * website pull request listing the new release and adding announcement blog 
> post [6]. 
> 
> The vote will be open for at least 72 hours (excluding this current weekend). 
> It is adopted by majority approval, with at least 3 PMC affirmative votes.
> 
> Please use the provided document, as discussed before, for coordinating the 
> testing efforts: [7]
> 
> Thanks,
> Aljoscha
> 
> [1] 
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12340984
> [2] http://people.apache.org/~aljoscha/flink-1.3.2-rc2/
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4] https://repository.apache.org/content/repositories/orgapacheflink-1133/
> [5] 
> https://git-wip-us.apache.org/repos/asf?p=flink.git;a=tag;h=e38825d0c8e7fe2191a4c657984d9939ed8dd0ad
> [6] https://github.com/apache/flink-web/pull/75
> [7] 
> https://docs.google.com/document/d/1dN9AM9FUPizIu4hTKAXJSbbAORRdrce-BqQ8AUHlOqE/edit?usp=sharing

Re: [VOTE] Release 1.3.2, release candidate #2

[Nico Kruber]

+-1 (non-binding)

L.1 Check if checksums and GPG files match the corresponding release files
- found an issue with a malformed flink-1.3.2-src.tgz.md5 that gnu coreutils 
8.27 was not accepting - already fixed by now

L.3 Check if the source release is building properly (mvn clean verify)
- found these NON-BLOCKING issues: FLINK-6738, FLINK-7351, FLINK-7352
- also found FLINK-7354 which I could NOT get passed by (or only very rarely) 
on Debian 9 without fixing: an instable unit test (may be BLOCKING when 
happening this much?)

L.4 Verify the LICENSE and NOTICE files for the binary and source releases
OK

F.1 Run the start-local.sh, start-cluster.sh
OK

F.2 Examine the *.out files and the log files
OK

F.10 Run manual Tests in "flink-tests" module
(actually I looked for any ignored test in any module)
- NON-BLOCKING-ISSUE: FLINK-7355
- NON-BLOCKING-ISSUE: ChaosMonkeyITCase does not work (but removed in master)


Nico

On Sunday, 30 July 2017 09:07:03 CEST Aljoscha Krettek wrote:
> Hi everyone,
> 
> Please review and vote on the release candidate #2 for the version 1.3.2, as
> follows: [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
> 
> 
> The complete staging area is available for your review, which includes:
> * JIRA release notes [1],
> * the official Apache source release and binary convenience releases to be
> deployed to dist.apache.org [2], which is signed with the key with
> fingerprint 0xA8F4FD97121D7293 [3], * all artifacts to be deployed to the
> Maven Central Repository [4], * source code tag "release-1.3.2-rc2" [5],
> * website pull request listing the new release and adding announcement blog
> post [6].
> 
> The vote will be open for at least 72 hours (excluding this current
> weekend). It is adopted by majority approval, with at least 3 PMC
> affirmative votes.
> 
> Please use the provided document, as discussed before, for coordinating the
> testing efforts: [7]
> 
> Thanks,
> Aljoscha
> 
> [1]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522
> ersion=12340984 [2] http://people.apache.org/~aljoscha/flink-1.3.2-rc2/
> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> [4] https://repository.apache.org/content/repositories/orgapacheflink-1133/
> [5]
> https://git-wip-us.apache.org/repos/asf?p=flink.git;a=tag;h=e38825d0c8e7fe2
> 191a4c657984d9939ed8dd0ad [6] https://github.com/apache/flink-web/pull/75
> [7]
> https://docs.google.com/document/d/1dN9AM9FUPizIu4hTKAXJSbbAORRdrce-BqQ8AUH
> lOqE/edit?usp=sharing



signature.asc
Description: This is a digitally signed message part.

Re: [VOTE] Release 1.3.2, release candidate #2

[Tzu-Li (Gordon) Tai]

+1

1. Cluster tests
Tested with the stateful state machine job, using the following settings and 
variations:
- Cloud env: GCE
- Distributions: CDH 5.9.0
- Flink deployment method: YARN per-job (Hadoop 2.6.0)
- HA: both enabled & disabled
- Kerberos: enabled, keytab mode
- Kafka version: 0.9.0.1
- State Backends: Heap (Sync / Async) & RocksDB (incremental / full)
- Filesystem: HDFS (Hadoop 2.6.0)
- Externalized checkpoints: enabled & disabled

Logs also seem to be hygiene. All tests pass (state machine job processes 
records and does not fail).
Also verified that the job fails when using 1.3.1, with Kafka brokers 
deliberately shutdown on job restore due to FLINK-7195.

2. Build with Scala 2.10 successful

3. Minor new Kafka consumer commitsFailed and commitsSuccessful metric
Works nicely and can be queried in the REST API / web UI.

4. Checked README.md, LICENSE, NOTICE
Ok, but we need to remember to bring README.md up-to-date with the recent new 
important features (see FLINK-7353)

5. Website release announcement
Left comments on the PR, can be addressed independent of the vote.

Cheers,
Gordon

On 30 July 2017 at 3:07:08 PM, Aljoscha Krettek (aljos...@apache.org) wrote:

Hi everyone,  

Please review and vote on the release candidate #2 for the version 1.3.2, as 
follows:  
[ ] +1, Approve the release  
[ ] -1, Do not approve the release (please provide specific comments)  


The complete staging area is available for your review, which includes:  
* JIRA release notes [1],  
* the official Apache source release and binary convenience releases to be 
deployed to dist.apache.org [2], which is signed with the key with fingerprint 
0xA8F4FD97121D7293 [3],  
* all artifacts to be deployed to the Maven Central Repository [4],  
* source code tag "release-1.3.2-rc2" [5],  
* website pull request listing the new release and adding announcement blog 
post [6].  

The vote will be open for at least 72 hours (excluding this current weekend). 
It is adopted by majority approval, with at least 3 PMC affirmative votes.  

Please use the provided document, as discussed before, for coordinating the 
testing efforts: [7]  

Thanks,  
Aljoscha  

[1] 
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12340984
  
[2] http://people.apache.org/~aljoscha/flink-1.3.2-rc2/  
[3] https://dist.apache.org/repos/dist/release/flink/KEYS  
[4] https://repository.apache.org/content/repositories/orgapacheflink-1133/  
[5] 
https://git-wip-us.apache.org/repos/asf?p=flink.git;a=tag;h=e38825d0c8e7fe2191a4c657984d9939ed8dd0ad
  
[6] https://github.com/apache/flink-web/pull/75  
[7] 
https://docs.google.com/document/d/1dN9AM9FUPizIu4hTKAXJSbbAORRdrce-BqQ8AUHlOqE/edit?usp=sharing

[VOTE] Release 1.3.2, release candidate #2

[Aljoscha Krettek]

Hi everyone,

Please review and vote on the release candidate #2 for the version 1.3.2, as 
follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)


The complete staging area is available for your review, which includes:
* JIRA release notes [1],
* the official Apache source release and binary convenience releases to be 
deployed to dist.apache.org [2], which is signed with the key with fingerprint 
0xA8F4FD97121D7293 [3],
* all artifacts to be deployed to the Maven Central Repository [4],
* source code tag "release-1.3.2-rc2" [5],
* website pull request listing the new release and adding announcement blog 
post [6]. 

The vote will be open for at least 72 hours (excluding this current weekend). 
It is adopted by majority approval, with at least 3 PMC affirmative votes.

Please use the provided document, as discussed before, for coordinating the 
testing efforts: [7]

Thanks,
Aljoscha

[1] 
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522=12340984
[2] http://people.apache.org/~aljoscha/flink-1.3.2-rc2/
[3] https://dist.apache.org/repos/dist/release/flink/KEYS
[4] https://repository.apache.org/content/repositories/orgapacheflink-1133/
[5] 
https://git-wip-us.apache.org/repos/asf?p=flink.git;a=tag;h=e38825d0c8e7fe2191a4c657984d9939ed8dd0ad
[6] https://github.com/apache/flink-web/pull/75
[7] 
https://docs.google.com/document/d/1dN9AM9FUPizIu4hTKAXJSbbAORRdrce-BqQ8AUHlOqE/edit?usp=sharing