[jira] [Updated] (FLUME-2988) Kafka Sink metrics missing eventDrainAttemptCount
[
https://issues.apache.org/jira/browse/FLUME-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Udai Kiran Potluri updated FLUME-2988:
--
Attachment: FLUME-2988.1.patch
Attaching a patch with a simple fix that I think is right. Please review
[~jholoman] and [~sati]
> Kafka Sink metrics missing eventDrainAttemptCount
> -
>
> Key: FLUME-2988
> URL: https://issues.apache.org/jira/browse/FLUME-2988
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
>Reporter: Denes Arvay
>Assignee: Udai Kiran Potluri
>Priority: Minor
> Attachments: FLUME-2988.1.patch
>
>
> {{eventDrainAttemptCount}} doesn't get incremented in Kafka Sink, only the
> {{eventDrainSuccessCount}}
> (https://github.com/apache/flume/blob/trunk/flume-ng-sinks/flume-ng-kafka-sink/src/main/java/org/apache/flume/sink/kafka/KafkaSink.java#L210)
> resulting in misleading statistics (e.g. when calculating {{attemptCount -
> successCount}})
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLUME-2988) Kafka Sink metrics missing eventDrainAttemptCount
[
https://issues.apache.org/jira/browse/FLUME-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534380#comment-15534380
]
Udai Kiran Potluri commented on FLUME-2988:
---
[~jholoman] - Would it be ok if I take this one?
> Kafka Sink metrics missing eventDrainAttemptCount
> -
>
> Key: FLUME-2988
> URL: https://issues.apache.org/jira/browse/FLUME-2988
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
>Reporter: Denes Arvay
>Assignee: Udai Kiran Potluri
>Priority: Minor
>
> {{eventDrainAttemptCount}} doesn't get incremented in Kafka Sink, only the
> {{eventDrainSuccessCount}}
> (https://github.com/apache/flume/blob/trunk/flume-ng-sinks/flume-ng-kafka-sink/src/main/java/org/apache/flume/sink/kafka/KafkaSink.java#L210)
> resulting in misleading statistics (e.g. when calculating {{attemptCount -
> successCount}})
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (FLUME-2988) Kafka Sink metrics missing eventDrainAttemptCount
[
https://issues.apache.org/jira/browse/FLUME-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Udai Kiran Potluri reassigned FLUME-2988:
-
Assignee: Udai Kiran Potluri (was: Jeff Holoman)
> Kafka Sink metrics missing eventDrainAttemptCount
> -
>
> Key: FLUME-2988
> URL: https://issues.apache.org/jira/browse/FLUME-2988
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
>Reporter: Denes Arvay
>Assignee: Udai Kiran Potluri
>Priority: Minor
>
> {{eventDrainAttemptCount}} doesn't get incremented in Kafka Sink, only the
> {{eventDrainSuccessCount}}
> (https://github.com/apache/flume/blob/trunk/flume-ng-sinks/flume-ng-kafka-sink/src/main/java/org/apache/flume/sink/kafka/KafkaSink.java#L210)
> resulting in misleading statistics (e.g. when calculating {{attemptCount -
> successCount}})
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (FLUME-2268) Increase default transactionCapacity for MemoryChannel from 100 to 10000
[ https://issues.apache.org/jira/browse/FLUME-2268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13848389#comment-13848389 ] Udai Kiran Potluri commented on FLUME-2268: --- I will work on removing the transactionCapacity = capacity for the memoryChannel. I agree, the check seems somewhat unnecessary. Increase default transactionCapacity for MemoryChannel from 100 to 1 Key: FLUME-2268 URL: https://issues.apache.org/jira/browse/FLUME-2268 Project: Flume Issue Type: Improvement Components: Channel Affects Versions: v1.4.0 Reporter: Udai Kiran Potluri Assignee: Udai Kiran Potluri Priority: Minor Attachments: FLUME-2268-0.patch The current MemoryChannel default value is 100. Increasing it to 1 would be useful. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (FLUME-2268) Increase default transactionCapacity for MemoryChannel from 100 to 10000
[ https://issues.apache.org/jira/browse/FLUME-2268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847871#comment-13847871 ] Udai Kiran Potluri commented on FLUME-2268: --- Thanks [~mpercy] and Thanks [~paliwalashish] for further clarifications! Increase default transactionCapacity for MemoryChannel from 100 to 1 Key: FLUME-2268 URL: https://issues.apache.org/jira/browse/FLUME-2268 Project: Flume Issue Type: Improvement Components: Channel Affects Versions: v1.4.0 Reporter: Udai Kiran Potluri Assignee: Udai Kiran Potluri Priority: Minor Attachments: FLUME-2268-0.patch The current MemoryChannel default value is 100. Increasing it to 1 would be useful. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (FLUME-1860) Remove transaction capacity from Memory and File channels
[ https://issues.apache.org/jira/browse/FLUME-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846929#comment-13846929 ] Udai Kiran Potluri commented on FLUME-1860: --- @hari sreedharan - Is this ticket still relevant? Remove transaction capacity from Memory and File channels - Key: FLUME-1860 URL: https://issues.apache.org/jira/browse/FLUME-1860 Project: Flume Issue Type: Bug Reporter: Hari Shreedharan Transaction Capacity was primarily meant to be a memory safeguard. It ensures that we don't have queues which are massive and can cause OOMs. I wonder if there is a way of fixing this and making sure a malicious RpcClient cannot cause OOMs by sending batches of huge sizes -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Comment Edited] (FLUME-1860) Remove transaction capacity from Memory and File channels
[ https://issues.apache.org/jira/browse/FLUME-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846929#comment-13846929 ] Udai Kiran Potluri edited comment on FLUME-1860 at 12/12/13 11:49 PM: -- [~hshreedharan] - Is this ticket still relevant? was (Author: udai): @hari sreedharan - Is this ticket still relevant? Remove transaction capacity from Memory and File channels - Key: FLUME-1860 URL: https://issues.apache.org/jira/browse/FLUME-1860 Project: Flume Issue Type: Bug Reporter: Hari Shreedharan Transaction Capacity was primarily meant to be a memory safeguard. It ensures that we don't have queues which are massive and can cause OOMs. I wonder if there is a way of fixing this and making sure a malicious RpcClient cannot cause OOMs by sending batches of huge sizes -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Created] (FLUME-2267) Increase default transactionCapacity for FileChannel to 10000 from 1000
Udai Kiran Potluri created FLUME-2267: - Summary: Increase default transactionCapacity for FileChannel to 1 from 1000 Key: FLUME-2267 URL: https://issues.apache.org/jira/browse/FLUME-2267 Project: Flume Issue Type: Improvement Components: Channel Affects Versions: v1.4.0 Reporter: Udai Kiran Potluri Priority: Minor Default transactionCapacity for FileChannel is currently 1000, which is very low. Increasing it to 1 in default would be helpful. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Updated] (FLUME-2267) Increase default transactionCapacity for FileChannel to 10000 from 1000
[ https://issues.apache.org/jira/browse/FLUME-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Udai Kiran Potluri updated FLUME-2267: -- Attachment: FLUME-2267-0.patch Patch uploaded with transactionCapacity changed to 1 in code and UserGuide. Increase default transactionCapacity for FileChannel to 1 from 1000 --- Key: FLUME-2267 URL: https://issues.apache.org/jira/browse/FLUME-2267 Project: Flume Issue Type: Improvement Components: Channel Affects Versions: v1.4.0 Reporter: Udai Kiran Potluri Priority: Minor Attachments: FLUME-2267-0.patch Default transactionCapacity for FileChannel is currently 1000, which is very low. Increasing it to 1 in default would be helpful. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Updated] (FLUME-2268) Increase default transactionCapacity for MemoryChannel from 100 to 10000
[ https://issues.apache.org/jira/browse/FLUME-2268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Udai Kiran Potluri updated FLUME-2268: -- Attachment: FLUME-2268-0.patch Patch with fix to increase defaultTransCapacity to 1 from 100 for Memory Channel along with corresponding update to UserGuide. Increase default transactionCapacity for MemoryChannel from 100 to 1 Key: FLUME-2268 URL: https://issues.apache.org/jira/browse/FLUME-2268 Project: Flume Issue Type: Improvement Components: Channel Affects Versions: v1.4.0 Reporter: Udai Kiran Potluri Priority: Minor Attachments: FLUME-2268-0.patch The current MemoryChannel default value is 100. Increasing it to 1 would be useful. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Assigned] (FLUME-2268) Increase default transactionCapacity for MemoryChannel from 100 to 10000
[ https://issues.apache.org/jira/browse/FLUME-2268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Udai Kiran Potluri reassigned FLUME-2268: - Assignee: Udai Kiran Potluri Increase default transactionCapacity for MemoryChannel from 100 to 1 Key: FLUME-2268 URL: https://issues.apache.org/jira/browse/FLUME-2268 Project: Flume Issue Type: Improvement Components: Channel Affects Versions: v1.4.0 Reporter: Udai Kiran Potluri Assignee: Udai Kiran Potluri Priority: Minor Attachments: FLUME-2268-0.patch The current MemoryChannel default value is 100. Increasing it to 1 would be useful. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Assigned] (FLUME-2267) Increase default transactionCapacity for FileChannel to 10000 from 1000
[ https://issues.apache.org/jira/browse/FLUME-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Udai Kiran Potluri reassigned FLUME-2267: - Assignee: Udai Kiran Potluri Increase default transactionCapacity for FileChannel to 1 from 1000 --- Key: FLUME-2267 URL: https://issues.apache.org/jira/browse/FLUME-2267 Project: Flume Issue Type: Improvement Components: Channel Affects Versions: v1.4.0 Reporter: Udai Kiran Potluri Assignee: Udai Kiran Potluri Priority: Minor Attachments: FLUME-2267-0.patch Default transactionCapacity for FileChannel is currently 1000, which is very low. Increasing it to 1 in default would be helpful. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
