[jira] [Commented] (FLUME-2876) ElasticSearchSink: indexnameBuilderContext.putAll bug fixes

2016-07-23 Thread Lior Zeno (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLUME-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390616#comment-15390616
 ] 

Lior Zeno commented on FLUME-2876:
--

[~yh123555], thank you for the configuration example. Maybe I was not clear 
enough, but I meant adding another test in your patch that catches this issue, 
i.e. the test fails without the extra code in your patch, and succeeds with it.

Now that I'm looking at the jira history, maybe you don't need to do that 
because this issue has MANY instances, and a patch with a unit test has already 
been contributed. For example: FLUME-2576 (includes a unit test in the patch), 
FLUME-2884, FLUME-2391, FLUME-2435, FLUME-2424.

> ElasticSearchSink: indexnameBuilderContext.putAll bug fixes
> ---
>
> Key: FLUME-2876
> URL: https://issues.apache.org/jira/browse/FLUME-2876
> Project: Flume
>  Issue Type: Bug
>  Components: Sinks+Sources
>Affects Versions: v1.5.0, v1.6.0, v1.7.0
>Reporter: yh123555
>  Labels: unit-test-missing
> Fix For: v1.7.0
>
> Attachments: 
> 0001-ElasticSearchSink-indexnameBuilderContext.putAll-bug.patch
>
>
> ElasticSearchSink: indexnameBuilderContext.putAll bug fixes
> org.apache.flume.sink.elasticsearch.ElasticSearchSink 
> indexnameBuilderContext.putAll wrong  serializerContext.putAll



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLUME-2876) ElasticSearchSink: indexnameBuilderContext.putAll bug fixes

2016-07-20 Thread yh123555 (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLUME-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386961#comment-15386961
 ] 

yh123555 commented on FLUME-2876:
-


agent1.sinks.sink1.type = org.apache.flume.sink.elasticsearch.ElasticSearchSink
agent1.sinks.sink1.batchSize = 500
agent1.sinks.sink1.hostNames = th_log_app1_test:9300
agent1.sinks.sink1.indexName = kafka-index
agent1.sinks.sink1.indexType = kafka
agent1.sinks.sink1.ttl=1
#agent1.sinks.sink1.indexNameBuilder=org.apache.flume.sink.elasticsearch.SimpleIndexNameBuilder
agent1.sinks.sink1.indexNameBuilder=org.apache.flume.sink.elasticsearch.TimeBasedIndexNameBuilder
agent1.sinks.sink1.indexNameBuilder.dateFormat=MM

Date cannot be correctly matched.


> ElasticSearchSink: indexnameBuilderContext.putAll bug fixes
> ---
>
> Key: FLUME-2876
> URL: https://issues.apache.org/jira/browse/FLUME-2876
> Project: Flume
>  Issue Type: Bug
>  Components: Sinks+Sources
>Affects Versions: v1.5.0, v1.6.0, v1.7.0
>Reporter: yh123555
>  Labels: unit-test-missing
> Fix For: v1.7.0
>
> Attachments: 
> 0001-ElasticSearchSink-indexnameBuilderContext.putAll-bug.patch
>
>
> ElasticSearchSink: indexnameBuilderContext.putAll bug fixes
> org.apache.flume.sink.elasticsearch.ElasticSearchSink 
> indexnameBuilderContext.putAll wrong  serializerContext.putAll



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLUME-2876) ElasticSearchSink: indexnameBuilderContext.putAll bug fixes

2016-07-20 Thread Lior Zeno (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLUME-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385496#comment-15385496
 ] 

Lior Zeno commented on FLUME-2876:
--

Could you please add a test for this case? 

> ElasticSearchSink: indexnameBuilderContext.putAll bug fixes
> ---
>
> Key: FLUME-2876
> URL: https://issues.apache.org/jira/browse/FLUME-2876
> Project: Flume
>  Issue Type: Bug
>  Components: Sinks+Sources
>Affects Versions: v1.5.0, v1.6.0, v1.7.0
>Reporter: yh123555
> Fix For: v1.7.0
>
> Attachments: 
> 0001-ElasticSearchSink-indexnameBuilderContext.putAll-bug.patch
>
>
> ElasticSearchSink: indexnameBuilderContext.putAll bug fixes
> org.apache.flume.sink.elasticsearch.ElasticSearchSink 
> indexnameBuilderContext.putAll wrong  serializerContext.putAll



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLUME-2876) ElasticSearchSink: indexnameBuilderContext.putAll bug fixes

2016-07-19 Thread Alexander Alten-Lorenz (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLUME-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15384067#comment-15384067
 ] 

Alexander Alten-Lorenz commented on FLUME-2876:
---

+1 to get into 1.7

> ElasticSearchSink: indexnameBuilderContext.putAll bug fixes
> ---
>
> Key: FLUME-2876
> URL: https://issues.apache.org/jira/browse/FLUME-2876
> Project: Flume
>  Issue Type: Bug
>  Components: Sinks+Sources
>Affects Versions: v1.5.0, v1.6.0, v1.7.0
>Reporter: yh123555
> Fix For: v1.7.0
>
> Attachments: 
> 0001-ElasticSearchSink-indexnameBuilderContext.putAll-bug.patch
>
>
> ElasticSearchSink: indexnameBuilderContext.putAll bug fixes
> org.apache.flume.sink.elasticsearch.ElasticSearchSink 
> indexnameBuilderContext.putAll wrong  serializerContext.putAll



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (FLUME-2876) ElasticSearchSink: indexnameBuilderContext.putAll bug fixes

2016-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/FLUME-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129677#comment-15129677
 ] 

ASF GitHub Bot commented on FLUME-2876:
---

GitHub user githubyh opened a pull request:

https://github.com/apache/flume/pull/35

FLUME-2876 ElasticSearchSink: indexnameBuilderContext.putAll bug fixes

ElasticSearchSink: indexnameBuilderContext.putAll bug fixes
org.apache.flume.sink.elasticsearch.ElasticSearchSink 
indexnameBuilderContext.putAll wrong serializerContext.putAll
[https://issues.apache.org/jira/browse/FLUME-2876](url)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/githubyh/flume flume_es_sink_change

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flume/pull/35.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #35


commit 7818d93d0d01856d60da782cc632eb491f5eaa90
Author: githubyh 
Date:   2016-02-03T02:38:13Z

ElasticSearchSink: indexnameBuilderContext.putAll bug fixes

commit 1b33ee1692acd37e2315df8415690b74ce2d0f89
Author: githubyh 
Date:   2016-02-03T02:41:48Z

ElasticSearchSink: indexnameBuilderContext.putAll bug fixes




> ElasticSearchSink: indexnameBuilderContext.putAll bug fixes
> ---
>
> Key: FLUME-2876
> URL: https://issues.apache.org/jira/browse/FLUME-2876
> Project: Flume
>  Issue Type: Bug
>  Components: Sinks+Sources
>Affects Versions: v1.5.0, v1.6.0, v1.7.0
>Reporter: yh123555
> Fix For: v1.7.0
>
>
> ElasticSearchSink: indexnameBuilderContext.putAll bug fixes
> org.apache.flume.sink.elasticsearch.ElasticSearchSink 
> indexnameBuilderContext.putAll wrong  serializerContext.putAll



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)