[jira] [Commented] (FLUME-2883) LoadBalancingRpcClient returns wrong value for batchSize
[ https://issues.apache.org/jira/browse/FLUME-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535071#comment-15535071 ] Umesh Chaudhary commented on FLUME-2883: Hi [~agnek], Apologies as I assign this to me without asking to you. Would you want to work on this ? > LoadBalancingRpcClient returns wrong value for batchSize > > > Key: FLUME-2883 > URL: https://issues.apache.org/jira/browse/FLUME-2883 > Project: Flume > Issue Type: Bug > Components: Client SDK >Reporter: Alexey Churkin >Assignee: Umesh Chaudhary >Priority: Minor > > LoadBalancingRpcClient doesn't read batchSize property from configuration and > returns default value in getBatchSize method. > But underlying clients creates with right batchSize value read from > configuration. So LoadBalancingRpcClient should also read batch-size > configuration param and set it field batchSize according to it value. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLUME-2883) LoadBalancingRpcClient returns wrong value for batchSize
[ https://issues.apache.org/jira/browse/FLUME-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503623#comment-15503623 ] Umesh Chaudhary commented on FLUME-2883: Yes, that is a valid point. [~mpercy], please provide your inputs on this. > LoadBalancingRpcClient returns wrong value for batchSize > > > Key: FLUME-2883 > URL: https://issues.apache.org/jira/browse/FLUME-2883 > Project: Flume > Issue Type: Bug > Components: Client SDK >Reporter: Alexey Churkin >Priority: Minor > > LoadBalancingRpcClient doesn't read batchSize property from configuration and > returns default value in getBatchSize method. > But underlying clients creates with right batchSize value read from > configuration. So LoadBalancingRpcClient should also read batch-size > configuration param and set it field batchSize according to it value. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLUME-2883) LoadBalancingRpcClient returns wrong value for batchSize
[ https://issues.apache.org/jira/browse/FLUME-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483998#comment-15483998 ] Alexey Churkin commented on FLUME-2883: --- There are such method in base class - AbstractRpcClient, which returns default value (RpcClientConfigurationConstants.DEFAULT_BATCH_SIZE). But connections created in LoadBalancingRpcClient read configs from config properties - not default values. So I suppose LoadBalancingRpcClient should ovveride getBatchSize method and return batchSize of first client from clientMap. > LoadBalancingRpcClient returns wrong value for batchSize > > > Key: FLUME-2883 > URL: https://issues.apache.org/jira/browse/FLUME-2883 > Project: Flume > Issue Type: Bug > Components: Client SDK >Reporter: Alexey Churkin >Priority: Minor > > LoadBalancingRpcClient doesn't read batchSize property from configuration and > returns default value in getBatchSize method. > But underlying clients creates with right batchSize value read from > configuration. So LoadBalancingRpcClient should also read batch-size > configuration param and set it field batchSize according to it value. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FLUME-2883) LoadBalancingRpcClient returns wrong value for batchSize
[ https://issues.apache.org/jira/browse/FLUME-2883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15483941#comment-15483941 ] Umesh Chaudhary commented on FLUME-2883: [~agnek], I am sorry but I don't see any getBatchSize method in LoadBalancingRpcClient. > LoadBalancingRpcClient returns wrong value for batchSize > > > Key: FLUME-2883 > URL: https://issues.apache.org/jira/browse/FLUME-2883 > Project: Flume > Issue Type: Bug > Components: Client SDK >Reporter: Alexey Churkin >Priority: Minor > > LoadBalancingRpcClient doesn't read batchSize property from configuration and > returns default value in getBatchSize method. > But underlying clients creates with right batchSize value read from > configuration. So LoadBalancingRpcClient should also read batch-size > configuration param and set it field batchSize according to it value. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
